Re: [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-1)

[girish <girishvg@gmail.com>]

On Sep 30, 2006, at 2:06 AM, Jan Engelhardt wrote:

>>>>
>>>> -	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
>>>> +	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads +
>>>> num_children);
>>>
>>> Personally, I'd prefer the children count to be separate,  
>>> something like:
>>>
>>> buffer += sprintf(buffer, "Threads:\t%d (%d children, %d total)",
>>> num_threads, num_children, num_threads + num_children);
>>>
>>> That would be rather nice, indeed.
>
> And I would suggest three separate lines to keep it parseable!
>
>
> Jan Engelhardt
> -- 

How about this?

         buffer += sprintf(buffer, "Threads:\t%d", num_threads);
         if (num_children)
                 buffer += sprintf(buffer, " Children: %d Total: %d",  
num_children, num_threads + num_children);
         buffer += sprintf(buffer, "\n");