mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Pitcock <nenolod@atheme.org>
To: girish <girishvg@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-1)
Date: Fri, 29 Sep 2006 11:31:06 -0500	[thread overview]
Message-ID: <F2F2C98F-6AFB-4E19-BEE9-D32652E2F478@atheme.org> (raw)
In-Reply-To: <0635847A-C149-412C-92B1-A974230381F8@dts.local>


On Sep 29, 2006, at 10:18 AM, girish wrote:

>
> -	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
> +	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads +  
> num_children);

Personally, I'd prefer the children count to be separate, something  
like:

buffer += sprintf(buffer, "Threads:\t%d (%d children, %d total)",  
num_threads, num_children, num_threads + num_children);

That would be rather nice, indeed.

Also, next time, make sure that linux-kernel is CC'd, not BCC'd.

---
William Pitcock
nenolod@atheme.org
http://people.atheme.org/~nenolod/
http://nenolod.net



  reply	other threads:[~2006-09-29 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-29 15:18 girish
2006-09-29 16:31 ` William Pitcock [this message]
2006-09-29 16:51   ` girish
2006-09-29 17:06     ` Jan Engelhardt
2006-09-29 17:18       ` girish
2006-09-29 18:12         ` Jan Engelhardt
2006-09-29 18:24           ` [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-3) girish
2006-09-29 22:51             ` Eric W. Biederman
     [not found]               ` <E78297DA-5F0F-40FA-A008-89264570B313@gmail.com>
2006-09-30 17:11                 ` Jan Engelhardt
2006-10-01 11:34                   ` girish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F2F2C98F-6AFB-4E19-BEE9-D32652E2F478@atheme.org \
    --to=nenolod@atheme.org \
    --cc=girishvg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®