From: "Andrew Chew" <achew@nvidia.com>
To: "Jeff Garzik" <jgarzik@pobox.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-ide@vger.kernel.org>
Subject: RE: [PATCH 2.6.8-rc2] sata_nv.c
Date: Tue, 27 Jul 2004 13:26:20 -0700 [thread overview]
Message-ID: <DBFABB80F7FD3143A911F9E6CFD477B03F95F5@hqemmail02.nvidia.com> (raw)
Jeff Garzik wrote:
> 7) don't use host->scr_addr as a sly way to obtain your base address.
> Use host_set->mmio_base directly (casting from unsigned long
> if it's PIO
> rather than MMIO).
I noticed in libata-core.c's ata_pci_remove_one(), that the
host_set->mmio_base gets unmapped before calling
host_set->ops->host_stop(host_set). The problem is that I want to
access the registers mapped to host_set->mmio_base in my host_stop
routine (it's in my host_stop routine that I disable hotplug event
interrupts).
It looks safe to just swap the two calls, so we call
host_set->ops->host_stop(host_set) before we iounmap
host_set->mmio_base. That way, my host_stop routine can still access
host_set->mmio_base.
However, I don't want to break any architectural model you may have in
mind. Can you advise me on the proper approach I should take with this?
next reply other threads:[~2004-07-27 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 20:26 Andrew Chew [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-08-05 22:06 Andrew Chew
2004-08-05 21:31 Andrew Chew
2004-08-05 21:53 ` Jeff Garzik
2004-07-27 18:45 Andrew Chew
2004-07-27 18:55 ` Jeff Garzik
2004-07-22 21:38 Andrew Chew
2004-07-27 17:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBFABB80F7FD3143A911F9E6CFD477B03F95F5@hqemmail02.nvidia.com \
--to=achew@nvidia.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®