RE: [PATCH 2.6.8-rc2] sata_nv.c

["Andrew Chew" <achew@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

> Andrew Chew wrote:
> > A minor change to libata-core.c needs to accompany this 
> patch.  This 
> > is in regards to the function ata_pci_remove_one(), where the
> > host_set->ops->host_stop(host_set) needs to occur before the 
> > iounmap(host_set->mmio_base).  This is because sata_nv's host_stop 
> > callback needs access to the iomapped region.

Jeff Garzik wrote:
> Do you want to send a separate patch for this?  I don't see 
> that change 
> in the attached patch.

Attached patch.

[-- Attachment #2: libata-core_2-6.diff --]
[-- Type: application/octet-stream, Size: 488 bytes --]

--- linux-2.6.8-rc2/drivers/scsi/libata-core.c	2004-08-05 14:17:30.000000000 -0700
+++ linux/drivers/scsi/libata-core.c	2004-07-27 14:42:06.000000000 -0700
@@ -3251,10 +3251,10 @@
 	}
 
 	free_irq(host_set->irq, host_set);
-	if (host_set->mmio_base)
-		iounmap(host_set->mmio_base);
 	if (host_set->ops->host_stop)
 		host_set->ops->host_stop(host_set);
+	if (host_set->mmio_base)
+		iounmap(host_set->mmio_base);
 
 	for (i = 0; i < host_set->n_ports; i++) {
 		ap = host_set->ports[i];