mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Anirban Sinha" <ASinha@zeugmasystems.com>
To: <linux-kernel@vger.kernel.org>
Cc: "Ingo Molnar" <mingo@elte.hu>
Subject: futex question
Date: Tue, 29 Sep 2009 18:10:41 -0700	[thread overview]
Message-ID: <DDFD17CC94A9BD49A82147DDF7D545C501FD7F97@exchange.ZeugmaSystems.local> (raw)

Hi Folks:

We are observing something interesting regarding how task->robust_list
pointer is being handled across a sys_execve() call. If a task does a
sys_set_robust_list() with a certain head pointer and then at some point
does a execve() call to over-write it's address space, the 'robust-list'
pointer is never cleared. So in essence what happens is that during task
exit, within mm_release(), the 
if (unlikely(tsk->robust_list)) condition might still be true because
the pointer has a non-null address. However, the actual address value
may not belong to the new address space or point to something else
within the new address space. Should we not just clear the pointer (and
it's compat version) within do_execve()?

Granted, within exit_robust_list(), the fetch_robust_entry() calls will
fail and bail out of the function. So in essence, nothing bad should
happen. However, that extra code should save us from entering
exit_robust_list() in the first place.

CCing Ingo since the robust futex support was started by him.

Cheers,

Ani
 

             reply	other threads:[~2009-09-30  1:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30  1:10 Anirban Sinha [this message]
2009-10-01  9:22 ` Ingo Molnar
2009-10-01 16:54   ` Anirban Sinha
2009-10-01 23:46   ` Anirban Sinha
2009-10-02 23:38     ` Darren Hart
2009-10-03  0:36       ` Anirban Sinha
2009-10-03  4:14         ` Eric Dumazet
2009-10-04  8:44       ` Thomas Gleixner
     [not found]         ` <DDFD17CC94A9BD49A82147DDF7D545C501F457C5@exchange.ZeugmaSystems.local>
2009-10-04 16:37           ` Anirban Sinha
2009-10-04 16:59             ` Thomas Gleixner
2009-10-05 10:36               ` Peter Zijlstra
2009-10-05 10:56                 ` Thomas Gleixner
2009-10-05 11:16                   ` Peter Zijlstra
2009-10-05 11:19                     ` Ingo Molnar
2009-10-05 11:50                       ` Thomas Gleixner
2009-10-05 11:47                     ` Thomas Gleixner
2009-10-05 13:11                       ` Anirban Sinha
2009-10-05 13:28                         ` Thomas Gleixner
2009-10-05 14:03                           ` Anirban Sinha
2009-10-05 18:36                             ` Anirban Sinha
2009-10-05 11:58                 ` Peter Zijlstra
2009-10-05 11:59                   ` Thomas Gleixner
2009-10-05 12:18                     ` Peter Zijlstra
2009-10-05 12:24                       ` Ingo Molnar
2009-10-05 14:09                         ` Darren Hart
2009-10-05 18:11                 ` Anirban Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDFD17CC94A9BD49A82147DDF7D545C501FD7F97@exchange.ZeugmaSystems.local \
    --to=asinha@zeugmasystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®