From: "Anirban Sinha" <ASinha@zeugmasystems.com>
To: "Ingo Molnar" <mingo@elte.hu>, "Darren Hart" <dvhltc@us.ibm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: futex question
Date: Thu, 1 Oct 2009 16:46:16 -0700 [thread overview]
Message-ID: <DDFD17CC94A9BD49A82147DDF7D545C501FD8409@exchange.ZeugmaSystems.local> (raw)
In-Reply-To: <20091001092218.GH15345@elte.hu>
> Should we not just clear the pointer (and
>> it's compat version) within do_execve()?
In our private repository, applying the following patch resolved the
issues I mentioned. I no longer see messages like this:
[futex] ("ifconfig")(pid=2509) exit_robust_list:unable to fetch robust
entry. uaddr=0x000000002abbc4f0
from my instrumented kernel within exit_robust_list(). My
instrumentation looked something like this:
if (fetch_robust_entry(...)) {
printk(...);
return;
}
Just tossing the patch in the community in case someone is interested
...
Signed-off-by: Anirban Sinha <asinha@zeugmasystems.com>
---
fs/compat.c | 3 +++
fs/exec.c | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/compat.c b/fs/compat.c
index 6d6f98f..c3d117c 100644
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -1510,6 +1510,9 @@ int compat_do_execve(char * filename,
if (retval)
goto out_file;
+#ifdef CONFIG_FUTEX
+ current->compat_robust_list = NULL;
+#endif
bprm->argc = compat_count(argv, MAX_ARG_STRINGS);
if ((retval = bprm->argc) < 0)
goto out;
diff --git a/fs/exec.c b/fs/exec.c
index 172ceb6..e9334b8 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1323,6 +1323,9 @@ int do_execve(char * filename,
retval = bprm_mm_init(bprm);
if (retval)
goto out_file;
+#ifdef CONFIG_FUTEX
+ current->robust_list = NULL;
+#endif
bprm->argc = count(argv, MAX_ARG_STRINGS);
if ((retval = bprm->argc) < 0)
next prev parent reply other threads:[~2009-10-01 23:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 1:10 Anirban Sinha
2009-10-01 9:22 ` Ingo Molnar
2009-10-01 16:54 ` Anirban Sinha
2009-10-01 23:46 ` Anirban Sinha [this message]
2009-10-02 23:38 ` Darren Hart
2009-10-03 0:36 ` Anirban Sinha
2009-10-03 4:14 ` Eric Dumazet
2009-10-04 8:44 ` Thomas Gleixner
[not found] ` <DDFD17CC94A9BD49A82147DDF7D545C501F457C5@exchange.ZeugmaSystems.local>
2009-10-04 16:37 ` Anirban Sinha
2009-10-04 16:59 ` Thomas Gleixner
2009-10-05 10:36 ` Peter Zijlstra
2009-10-05 10:56 ` Thomas Gleixner
2009-10-05 11:16 ` Peter Zijlstra
2009-10-05 11:19 ` Ingo Molnar
2009-10-05 11:50 ` Thomas Gleixner
2009-10-05 11:47 ` Thomas Gleixner
2009-10-05 13:11 ` Anirban Sinha
2009-10-05 13:28 ` Thomas Gleixner
2009-10-05 14:03 ` Anirban Sinha
2009-10-05 18:36 ` Anirban Sinha
2009-10-05 11:58 ` Peter Zijlstra
2009-10-05 11:59 ` Thomas Gleixner
2009-10-05 12:18 ` Peter Zijlstra
2009-10-05 12:24 ` Ingo Molnar
2009-10-05 14:09 ` Darren Hart
2009-10-05 18:11 ` Anirban Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDFD17CC94A9BD49A82147DDF7D545C501FD8409@exchange.ZeugmaSystems.local \
--to=asinha@zeugmasystems.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®