* [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c
@ 2026-02-04 18:31 Rachit Dhar
2026-02-05 9:47 ` Rui Miguel Silva
0 siblings, 1 reply; 2+ messages in thread
From: Rachit Dhar @ 2026-02-04 18:31 UTC (permalink / raw)
To: Rui Miguel Silva
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel, Rachit Dhar
Added comment to mutex declarations, to resolve checkpatch.pl checks.
Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
---
drivers/staging/greybus/light.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index e509fdc715db..1f2faa6d545d 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -37,7 +37,7 @@ struct gb_channel {
bool releasing;
bool strobe_state;
bool active;
- struct mutex lock;
+ struct mutex lock; /* protects gb_channel->active */
};
struct gb_light {
@@ -59,7 +59,7 @@ struct gb_lights {
struct gb_connection *connection;
u8 lights_count;
struct gb_light *lights;
- struct mutex lights_lock;
+ struct mutex lights_lock; /* protects gb_lights->lights */
};
static void gb_lights_channel_free(struct gb_channel *channel);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c
2026-02-04 18:31 [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c Rachit Dhar
@ 2026-02-05 9:47 ` Rui Miguel Silva
0 siblings, 0 replies; 2+ messages in thread
From: Rui Miguel Silva @ 2026-02-05 9:47 UTC (permalink / raw)
To: Rachit Dhar, Rui Miguel Silva
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel
Hey Rachit,
Thanks for the patch. And the sending corrections along the path.
On Wed Feb 4, 2026 at 6:31 PM WET, Rachit Dhar wrote:
> Added comment to mutex declarations, to resolve checkpatch.pl checks.
>
> Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
> ---
> drivers/staging/greybus/light.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index e509fdc715db..1f2faa6d545d 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -37,7 +37,7 @@ struct gb_channel {
> bool releasing;
> bool strobe_state;
> bool active;
> - struct mutex lock;
> + struct mutex lock; /* protects gb_channel->active */
> };
>
> struct gb_light {
> @@ -59,7 +59,7 @@ struct gb_lights {
> struct gb_connection *connection;
> u8 lights_count;
> struct gb_light *lights;
> - struct mutex lights_lock;
> + struct mutex lights_lock; /* protects gb_lights->lights */
> };
>
This LGTM.
Acked-by: Rui Miguel Silva <rui.silva@linaro.org>
Cheers,
Rui
> static void gb_lights_channel_free(struct gb_channel *channel);
> --
> 2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-05 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-04 18:31 [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c Rachit Dhar
2026-02-05 9:47 ` Rui Miguel Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®