* [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
@ 2026-04-10 19:55 Osama Abdelkader
2026-04-14 7:28 ` Luca Ceresoli
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2026-04-10 19:55 UTC (permalink / raw)
To: luca.ceresoli, Jagan Teki, Andrzej Hajda, Neil Armstrong,
Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel
Cc: Osama Abdelkader
when chipone_dsi_host_attach fails in chipone_i2c_probe remove drm
bridge before return
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 814713c5bea9..5bee10c64265 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -760,7 +760,10 @@ static int chipone_i2c_probe(struct i2c_client *client)
drm_bridge_add(&icn->bridge);
- return chipone_dsi_host_attach(icn);
+ ret = chipone_dsi_host_attach(icn);
+ if (ret)
+ drm_bridge_remove(&icn->bridge);
+ return ret;
}
static void chipone_dsi_remove(struct mipi_dsi_device *dsi)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
2026-04-10 19:55 [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails Osama Abdelkader
@ 2026-04-14 7:28 ` Luca Ceresoli
0 siblings, 0 replies; 2+ messages in thread
From: Luca Ceresoli @ 2026-04-14 7:28 UTC (permalink / raw)
To: Osama Abdelkader, Jagan Teki, Andrzej Hajda, Neil Armstrong,
Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel
On Fri Apr 10, 2026 at 9:55 PM CEST, Osama Abdelkader wrote:
> when chipone_dsi_host_attach fails in chipone_i2c_probe remove drm
> bridge before return
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index 814713c5bea9..5bee10c64265 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -760,7 +760,10 @@ static int chipone_i2c_probe(struct i2c_client *client)
>
> drm_bridge_add(&icn->bridge);
>
> - return chipone_dsi_host_attach(icn);
> + ret = chipone_dsi_host_attach(icn);
> + if (ret)
> + drm_bridge_remove(&icn->bridge);
> + return ret;
> }
You can simply switch to devm_drm_bridge_add().
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-14 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-10 19:55 [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails Osama Abdelkader
2026-04-14 7:28 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®