mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH v4] mtd: spi-nor: micron-st: Add support for is25wx01g
Date: Wed, 18 Nov 2026 14:42:13 +0100	[thread overview]
Message-ID: <DMYDPBNBU7IY.3956HW6C59693@kernel.org> (raw)
In-Reply-To: <20261106-mtd-spi-nor-new-issi-chip-v4-1-7e2b6a361fe0@analog.com>

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

Hi,

On Fri Nov 6, 2026 at 5:33 PM CET, Nuno Sá wrote:
> Add support for the ISSI IS25WX01G, a 1 Gbit (128 MiB) octal NOR flash.
> The part is fully described by SFDP, so only the flash ID and small
> post_bfpt and post_sfdp fixups are needed.
>
> WRITE STATUS REGISTER (01h) takes a single data byte and only affects
> status register bits 7:2, so the default 16-bit Write Status assumption
> does not hold. Clear write_sr1_and_sr2 so that the single byte write_sr1
> path is taken; write_sr1 is already set to 01h by the BFPT parsing.
>
> The flash also has no Status Register 2. Configuration registers are read
> with B5h/85h and written with B1h/81h, and the 35h Read Configuration
> Register command does not exist, so clear read_sr2 as well.
>
> Software write protection is done through the block protect bits in the
> status register: BP0-BP2 at bits 4:2, BP3 at bit 6 and a Top/Bottom bit at
> bit 5, which is exactly what SPI_NOR_HAS_LOCK, SPI_NOR_4BIT_BP,
> SPI_NOR_BP3_SR_BIT6 and SPI_NOR_HAS_TB describe, so set those flags to get
> the generic locking support.
>
> The flash also supports 8D-8D-8D, but this could not be tested. Since the
> SFDP has no SCCR map, the core would select 8D-8D-8D on a capable
> controller but never switch the flash into it. Hence, drop the 8D-8D-8D
> capabilities in a post_sfdp fixup for now.

Could you please test if one (or maybe both) makes a difference
here and the fixups could possibly be dropped?

https://lore.kernel.org/r/20261023-spi-nor-fix-v5-1-bb6e0ce21169@nxp.com/
https://lore.kernel.org/r/20261013-winbond-master-spi-nor-w35t-v3-1-6dde1d513df8@bootlin.com/

Thanks,
-michael

> Note that given that the Flag Status Register (FSR) handling is the same
> as in some micron devices, we're adding the issi chip directly on the
> micron-st driver.
>
> Link: https://www.issi.com/WW/pdf/25LX-WX01GB.pdf
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

      parent reply	other threads:[~2026-11-18 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 16:33 Nuno Sá
2026-11-12  2:25 ` Takahiro.Kuwano
2026-11-12  9:29   ` Nuno Sá
2026-11-18 13:42 ` Michael Walle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYDPBNBU7IY.3956HW6C59693@kernel.org \
    --to=mwalle@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nuno.sa@analog.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=takahiro.kuwano@infineon.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®