* [PATCH 3/5] Fix pd6729.c on architectures which define NO_IRQ
@ 2005-11-21 1:14 Matthew Wilcox
2005-11-21 12:41 ` Komuro
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2005-11-21 1:14 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Matthew Wilcox, Ingo Molnar, linux-kernel, Jun Komuro
Use pci_valid_irq() instead of a custom NO_IRQ definition.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Acked-by: Ingo Molnar <mingo@elte.hu>
---
drivers/pcmcia/pd6729.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
applies-to: 26750e45f268b109d418c91b01a55e124bd879e1
fd1b59b22f926ee7daa097166d9e7ac6005b1284
diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index 20642f0..72720f2 100644
--- a/drivers/pcmcia/pd6729.c
+++ b/drivers/pcmcia/pd6729.c
@@ -39,10 +39,6 @@ MODULE_AUTHOR("Jun Komuro <komurojun-mbn
*/
#define to_cycles(ns) ((ns)/120)
-#ifndef NO_IRQ
-#define NO_IRQ ((unsigned int)(0))
-#endif
-
/*
* PARAMETERS
* irq_mode=n
@@ -733,7 +729,7 @@ static int __devinit pd6729_pci_probe(st
goto err_out_disable;
}
- if (dev->irq == NO_IRQ)
+ if (!pci_valid_irq(dev->irq))
irq_mode = 0; /* fall back to ISA interrupt mode */
mask = pd6729_isa_scan();
---
0.99.8.GIT
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/5] Fix pd6729.c on architectures which define NO_IRQ
2005-11-21 1:14 [PATCH 3/5] Fix pd6729.c on architectures which define NO_IRQ Matthew Wilcox
@ 2005-11-21 12:41 ` Komuro
0 siblings, 0 replies; 2+ messages in thread
From: Komuro @ 2005-11-21 12:41 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-kernel
Thanks for pointing this out!
I have misused the NO_IRQ definition.
Best Regards
Komuro
>
>Use pci_valid_irq() instead of a custom NO_IRQ definition.
>
>Signed-off-by: Matthew Wilcox <matthew@wil.cx>
>Acked-by: Ingo Molnar <mingo@elte.hu>
>
>---
>
> drivers/pcmcia/pd6729.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
>applies-to: 26750e45f268b109d418c91b01a55e124bd879e1
>fd1b59b22f926ee7daa097166d9e7ac6005b1284
>diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
>index 20642f0..72720f2 100644
>--- a/drivers/pcmcia/pd6729.c
>+++ b/drivers/pcmcia/pd6729.c
>@@ -39,10 +39,6 @@ MODULE_AUTHOR("Jun Komuro <komurojun-mbn
> */
> #define to_cycles(ns) ((ns)/120)
>
>-#ifndef NO_IRQ
>-#define NO_IRQ ((unsigned int)(0))
>-#endif
>-
> /*
> * PARAMETERS
> * irq_mode=n
>@@ -733,7 +729,7 @@ static int __devinit pd6729_pci_probe(st
> goto err_out_disable;
> }
>
>- if (dev->irq == NO_IRQ)
>+ if (!pci_valid_irq(dev->irq))
> irq_mode = 0; /* fall back to ISA interrupt mode */
>
> mask = pd6729_isa_scan();
>---
>0.99.8.GIT
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-21 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-21 1:14 [PATCH 3/5] Fix pd6729.c on architectures which define NO_IRQ Matthew Wilcox
2005-11-21 12:41 ` Komuro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®