mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] [m32r] __xchg() should be always_inline
@ 2007-05-15 19:37 Al Viro
  2007-05-16  1:37 ` Hirokazu Takata
  0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2007-05-15 19:37 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, takata


it depends on elimination of unreachable branches in switch (by object
size), so we must declare it always_inline

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 include/asm-m32r/system.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/asm-m32r/system.h b/include/asm-m32r/system.h
index b291b2f..8ee73d3 100644
--- a/include/asm-m32r/system.h
+++ b/include/asm-m32r/system.h
@@ -10,6 +10,7 @@
  * Copyright (C) 2004, 2006  Hirokazu Takata <takata at linux-m32r.org>
  */
 
+#include <linux/compiler.h>
 #include <asm/assembler.h>
 
 #ifdef __KERNEL__
@@ -154,7 +155,7 @@ extern void  __xchg_called_with_bad_pointer(void);
 #define DCACHE_CLEAR(reg0, reg1, addr)
 #endif	/* CONFIG_CHIP_M32700_TS1 */
 
-static inline unsigned long
+static __always_inline unsigned long
 __xchg(unsigned long x, volatile void * ptr, int size)
 {
 	unsigned long flags;
-- 
1.5.0-rc2.GIT



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [m32r] __xchg() should be always_inline
  2007-05-15 19:37 [PATCH] [m32r] __xchg() should be always_inline Al Viro
@ 2007-05-16  1:37 ` Hirokazu Takata
  0 siblings, 0 replies; 2+ messages in thread
From: Hirokazu Takata @ 2007-05-16  1:37 UTC (permalink / raw)
  To: Al Viro; +Cc: torvalds, linux-kernel, takata

Thank you.

Acked-by: Hirokazu Takata <takata@linux-m32r.org>

From: Al Viro <viro@ftp.linux.org.uk>
Subject: [PATCH] [m32r] __xchg() should be always_inline
Date: Tue, 15 May 2007 20:37:00 +0100
> 
> it depends on elimination of unreachable branches in switch (by object
> size), so we must declare it always_inline
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  include/asm-m32r/system.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/asm-m32r/system.h b/include/asm-m32r/system.h
> index b291b2f..8ee73d3 100644
> --- a/include/asm-m32r/system.h
> +++ b/include/asm-m32r/system.h
> @@ -10,6 +10,7 @@
>   * Copyright (C) 2004, 2006  Hirokazu Takata <takata at linux-m32r.org>
>   */
>  
> +#include <linux/compiler.h>
>  #include <asm/assembler.h>
>  
>  #ifdef __KERNEL__
> @@ -154,7 +155,7 @@ extern void  __xchg_called_with_bad_pointer(void);
>  #define DCACHE_CLEAR(reg0, reg1, addr)
>  #endif	/* CONFIG_CHIP_M32700_TS1 */
>  
> -static inline unsigned long
> +static __always_inline unsigned long
>  __xchg(unsigned long x, volatile void * ptr, int size)
>  {
>  	unsigned long flags;
> -- 
> 1.5.0-rc2.GIT
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-16  1:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-15 19:37 [PATCH] [m32r] __xchg() should be always_inline Al Viro
2007-05-16  1:37 ` Hirokazu Takata

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome