mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kamble, Nitin A" <nitin.a.kamble@intel.com>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: "Andrew Morton" <akpm@osdl.org>, <linux-kernel@vger.kernel.org>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>,
	"Saxena, Sunil" <sunil.saxena@intel.com>
Subject: RE: [PATCH] mxcsr patch for i386 & x86-64
Date: Tue, 4 May 2004 13:25:33 -0700	[thread overview]
Message-ID: <E305A4AFB7947540BC487567B5449BA802CA7C7C@scsmsx402.sc.intel.com> (raw)

>Ahh. Have we verified that the new semantics of that MXCSR_MASK field
>works on non-intel CPU's too?
Yes, this semantics is same for AMD and Intel. And we have verified that
it also works AMD.

>
>It would also (in my opinion) make sense to just export the
>"common_mxcsr_mask" (and probably just rename it as
"mxcsr_feature_mask"
>or something - where does that "common" come from? Is it just to imply
>that it's the bits that all CPU's support "in common", or what?

Yes, The "common" word is for the common set of bit-mask between all the
SMP processors, in case they are not same. Renaming the
mxcsr_common_mask to mxcsr_feature_mask is ok.

>
>Right now you export a function that does just a simple mask operation,
>and quite frankly, that just seems to make it less clear what the code
is
>doing. So who not get rid of that "set_fpu_mxcsr()" function, and just
>replace all the "0xffbf" uses with "mxcsr_feature_mask"?
>
>Hmm?
I agree that it will be cleaner to read. The idea of the set_fpu_mxcsr()
was to export access to the static mxcsr_common_mask variable. We can
get rid of the function by making the mask a global variable, or through
a new function exporting the static variable.
>
>		Linus

             reply	other threads:[~2004-05-04 20:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-04 20:25 Kamble, Nitin A [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-07  1:40 Kamble, Nitin A
2004-05-06 21:00 Kamble, Nitin A
2004-05-07 14:23 ` Pavel Machek
2004-05-04 21:47 Nakajima, Jun
2004-05-04 21:06 Kamble, Nitin A
2004-05-04 18:50 Kamble, Nitin A
2004-05-04 19:10 ` Linus Torvalds
2004-05-04 19:26   ` Linus Torvalds
2004-05-04 20:24     ` Linus Torvalds
2004-05-04 21:07       ` Jeff Garzik
2004-05-05 13:51       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E305A4AFB7947540BC487567B5449BA802CA7C7C@scsmsx402.sc.intel.com \
    --to=nitin.a.kamble@intel.com \
    --cc=akpm@osdl.org \
    --cc=asit.k.mallick@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunil.saxena@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®