* [PATCH] drm/appletbdrm: Fix incorrect error message on encoder attach failure
@ 2026-09-26 13:18 Adam Azuddin via B4 Relay
2026-09-28 8:34 ` Aditya Garg
0 siblings, 1 reply; 2+ messages in thread
From: Adam Azuddin via B4 Relay @ 2026-09-26 13:18 UTC (permalink / raw)
To: Aun-Ali Zaidi, Aditya Garg, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Atharva Tiwari,
Kerem Karabay
Cc: dri-devel, linux-kernel, Adam Azuddin
From: Adam Azuddin <azuddinadam@gmail.com>
drm_connector_attach_encoder() replaced an earlier call to
drm_simple_display_pipe_init() during review, but the error message
logged on failure was not updated to match and still refers to the
old call.
Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
Signed-off-by: Adam Azuddin <azuddinadam@gmail.com>
---
drivers/gpu/drm/tiny/appletbdrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
index 4297d9c1125e..91a51b513911 100644
--- a/drivers/gpu/drm/tiny/appletbdrm.c
+++ b/drivers/gpu/drm/tiny/appletbdrm.c
@@ -724,7 +724,7 @@ static int appletbdrm_setup_mode_config(struct appletbdrm_device *adev)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret) {
- drm_err(drm, "Failed to initialize simple display pipe\n");
+ drm_err(drm, "Failed to attach connector to encoder\n");
return ret;
}
---
base-commit: 98c7fc4219b93f953ee85c07fb6c8256046aba73
change-id: 20260926-fix-err-msg-appletbdrm-63865f293290
Best regards,
--
Adam Azuddin <azuddinadam@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/appletbdrm: Fix incorrect error message on encoder attach failure
2026-09-26 13:18 [PATCH] drm/appletbdrm: Fix incorrect error message on encoder attach failure Adam Azuddin via B4 Relay
@ 2026-09-28 8:34 ` Aditya Garg
0 siblings, 0 replies; 2+ messages in thread
From: Aditya Garg @ 2026-09-28 8:34 UTC (permalink / raw)
To: azuddinadam
Cc: Aun-Ali Zaidi, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Atharva Tiwari,
Kerem Karabay, dri-devel, linux-kernel, Adam Azuddin
> On 26 Sep 2026, at 6:49 PM, Adam Azuddin via B4 Relay <devnull+azuddinadam.gmail.com@kernel.org> wrote:
>
> From: Adam Azuddin <azuddinadam@gmail.com>
>
> drm_connector_attach_encoder() replaced an earlier call to
> drm_simple_display_pipe_init() during review, but the error message
> logged on failure was not updated to match and still refers to the
> old call.
>
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Signed-off-by: Adam Azuddin <azuddinadam@gmail.com>
Reviewed-by: Aditya Garg <aditya.garg@linux.dev>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-28 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-26 13:18 [PATCH] drm/appletbdrm: Fix incorrect error message on encoder attach failure Adam Azuddin via B4 Relay
2026-09-28 8:34 ` Aditya Garg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®