From: "Matteo Sasso" <icemaze@tiscalinet.it>
To: "Linux Kernel ML" <linux-kernel@vger.kernel.org>
Cc: <torvalds@transmeta.com>
Subject: Tiny cosmetic patch
Date: Wed, 28 Nov 2001 12:42:35 +0100 [thread overview]
Message-ID: <GAELJDOEMJGDLHEONDIOKECJCBAA.icemaze@tiscalinet.it> (raw)
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
I noticed that lots of printk() have no loglevel tag on them, bringing them
down to loglevel 4. This results in many spurious messages when a loglevel
below 7 is selected.
Here's a tiny patch for a couple of "PCI: Enabling device" messages, which I
chose because there IS one of them with a KERN_INFO tag:
###
linux-2.5.16/arch/sh/kernel/pcibios.c:97: printk(KERN_INFO "PCI: Enabling
device %s (%04x -> %04x)\n", dev->name, old_cmd, cmd);
###
so - I thought - why others shouldn't have it? They ARE informational
messages! So here's the patch against 2.4.16. If it will be included, I will
fix up some others...
--
icemaze@tiscalinet.it
[-- Attachment #2: console-loglevel-patch --]
[-- Type: application/octet-stream, Size: 2480 bytes --]
diff -Nru linux-2.4.16/arch/i386/kernel/pci-i386.c linux/arch/i386/kernel/pci-i386.c
--- linux-2.4.16/arch/i386/kernel/pci-i386.c Wed Nov 28 10:24:33 2001
+++ linux/arch/i386/kernel/pci-i386.c Wed Nov 28 10:31:40 2001
@@ -325,7 +325,7 @@
if (dev->resource[PCI_ROM_RESOURCE].start)
cmd |= PCI_COMMAND_MEMORY;
if (cmd != old_cmd) {
- printk("PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
+ printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
return 0;
diff -Nru linux-2.4.16/arch/mips/ddb5476/pci.c linux/arch/mips/ddb5476/pci.c
--- linux-2.4.16/arch/mips/ddb5476/pci.c Sun Sep 9 19:43:01 2001
+++ linux/arch/mips/ddb5476/pci.c Wed Nov 28 10:36:24 2001
@@ -426,7 +426,7 @@
cmd |= PCI_COMMAND_MEMORY;
}
if (cmd != old_cmd) {
- printk("PCI: Enabling device %s (%04x -> %04x)\n",
+ printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
dev->slot_name, old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
diff -Nru linux-2.4.16/arch/mips/ddb5074/pci.c linux/arch/mips/ddb5074/pci.c
--- linux-2.4.16/arch/mips/ddb5074/pci.c Sun Sep 9 19:43:01 2001
+++ linux/arch/mips/ddb5074/pci.c Wed Nov 28 10:36:51 2001
@@ -352,7 +352,7 @@
cmd |= PCI_COMMAND_MEMORY;
}
if (cmd != old_cmd) {
- printk("PCI: Enabling device %s (%04x -> %04x)\n",
+ printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
dev->slot_name, old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
diff -Nru linux-2.4.16/arch/ppc/kernel/pci.c linux/arch/ppc/kernel/pci.c
--- linux-2.4.16/arch/ppc/kernel/pci.c Wed Nov 28 10:20:44 2001
+++ linux/arch/ppc/kernel/pci.c Wed Nov 28 10:37:09 2001
@@ -410,7 +410,7 @@
if (dev->resource[PCI_ROM_RESOURCE].start)
cmd |= PCI_COMMAND_MEMORY;
if (cmd != old_cmd) {
- printk("PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
+ printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
return 0;
@@ -873,7 +873,7 @@
cmd |= PCI_COMMAND_MEMORY;
}
if (cmd != old_cmd) {
- printk("PCI: Enabling device %s (%04x -> %04x)\n",
+ printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
dev->slot_name, old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
reply other threads:[~2001-11-28 11:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GAELJDOEMJGDLHEONDIOKECJCBAA.icemaze@tiscalinet.it \
--to=icemaze@tiscalinet.it \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®