mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Tiny cosmetic patch
@ 2001-11-28 11:42 Matteo Sasso
  0 siblings, 0 replies; only message in thread
From: Matteo Sasso @ 2001-11-28 11:42 UTC (permalink / raw)
  To: Linux Kernel ML; +Cc: torvalds

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

I noticed that lots of printk() have no loglevel tag on them, bringing them
down to loglevel 4. This results in many spurious messages when a loglevel
below 7 is selected.

Here's a tiny patch for a couple of "PCI: Enabling device" messages, which I
chose because there IS one of them with a KERN_INFO tag:
###
linux-2.5.16/arch/sh/kernel/pcibios.c:97:	printk(KERN_INFO "PCI: Enabling
device %s (%04x -> %04x)\n", dev->name, old_cmd, cmd);
###
so - I thought - why others shouldn't have it? They ARE informational
messages! So here's the patch against 2.4.16. If it will be included, I will
fix up some others...
--
icemaze@tiscalinet.it

[-- Attachment #2: console-loglevel-patch --]
[-- Type: application/octet-stream, Size: 2480 bytes --]

diff -Nru linux-2.4.16/arch/i386/kernel/pci-i386.c linux/arch/i386/kernel/pci-i386.c
--- linux-2.4.16/arch/i386/kernel/pci-i386.c	Wed Nov 28 10:24:33 2001
+++ linux/arch/i386/kernel/pci-i386.c	Wed Nov 28 10:31:40 2001
@@ -325,7 +325,7 @@
 	if (dev->resource[PCI_ROM_RESOURCE].start)
 		cmd |= PCI_COMMAND_MEMORY;
 	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
+		printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}
 	return 0;

diff -Nru linux-2.4.16/arch/mips/ddb5476/pci.c linux/arch/mips/ddb5476/pci.c
--- linux-2.4.16/arch/mips/ddb5476/pci.c	Sun Sep  9 19:43:01 2001
+++ linux/arch/mips/ddb5476/pci.c	Wed Nov 28 10:36:24 2001
@@ -426,7 +426,7 @@
 			cmd |= PCI_COMMAND_MEMORY;
 	}
 	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n",
+		printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
 		       dev->slot_name, old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}

diff -Nru linux-2.4.16/arch/mips/ddb5074/pci.c linux/arch/mips/ddb5074/pci.c
--- linux-2.4.16/arch/mips/ddb5074/pci.c	Sun Sep  9 19:43:01 2001
+++ linux/arch/mips/ddb5074/pci.c	Wed Nov 28 10:36:51 2001
@@ -352,7 +352,7 @@
 			cmd |= PCI_COMMAND_MEMORY;
 	}
 	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n",
+		printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
 		       dev->slot_name, old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}

diff -Nru linux-2.4.16/arch/ppc/kernel/pci.c linux/arch/ppc/kernel/pci.c
--- linux-2.4.16/arch/ppc/kernel/pci.c	Wed Nov 28 10:20:44 2001
+++ linux/arch/ppc/kernel/pci.c	Wed Nov 28 10:37:09 2001
@@ -410,7 +410,7 @@
 	if (dev->resource[PCI_ROM_RESOURCE].start)
 		cmd |= PCI_COMMAND_MEMORY;
 	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
+		printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n", dev->slot_name, old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}
 	return 0;
@@ -873,7 +873,7 @@
 			cmd |= PCI_COMMAND_MEMORY;
 	}
 	if (cmd != old_cmd) {
-		printk("PCI: Enabling device %s (%04x -> %04x)\n",
+		printk(KERN_INFO "PCI: Enabling device %s (%04x -> %04x)\n",
 		       dev->slot_name, old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-11-28 11:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-28 11:42 Tiny cosmetic patch Matteo Sasso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®