mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	Patrick Mochel <mochel@digitalimplant.org>
Subject: Please open sysfs symbols to proprietary modules
Date: Wed, 2 Feb 2005 17:56:57 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.62.0502021723280.5515@localhost.localdomain> (raw)

Hello!

I'm writing a module under a proprietary license.  I decided to use sysfs 
to do the configuration.  Unfortunately, all sysfs exports are available 
to GPL modules only because they are exported by EXPORT_SYMBOL_GPL.

I have found the original e-mail where this change was proposed:
http://www.ussg.iu.edu/hypermail/linux/kernel/0409.3/0345.html

Patrick writes:

"The users of these functions are all, in most cases, other subsystems, 
which provide a layer of abstraction for the downstream users (drivers, 
etc)."

Maybe it was true in September 2004, but it's not true in February 2005. 
sysfs has become a standard way to make configurable parameters available 
to userspace, just like sysctl and ioctl.

All I want to do is to have a module that would create subdirectories for 
some network interfaces under /sys/class/net/*/, which would contain 
additional parameters for those interfaces.  I'm not creating a new 
subsystem or anything like that.  sysctl is not good because the data is 
interface specific.  ioctl on a socket would be OK, although it wouldn't 
be easily scriptable.  The restriction on sysfs symbols would just force 
me to write a proprietary userspace utility to set those parameters 
instead of using a shell script.

My understanding is that EXPORT_SYMBOL_GPL is only useful for symbols so 
specific to the kernel that the modules that use them would be effectively 
based on GPL code.  But a module providing its internal state to the 
userspace doesn't need to be based on the kernel code in any way.

Please replace every EXPORT_SYMBOL_GPL with EXPORT_SYMBOL in fs/sysfs/*.c

-- 
Regards,
Pavel Roskin

             reply	other threads:[~2005-02-02 22:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 22:56 Pavel Roskin [this message]
2005-02-02 23:07 ` Greg KH
2005-02-02 23:23 ` Patrick Mochel
2005-02-02 23:29   ` Greg KH
2005-02-03  0:07     ` Pavel Roskin
2005-02-03  0:30       ` Greg KH
2005-02-03  4:54         ` Zan Lynx
2005-02-03  5:07           ` Greg KH
2005-02-03  8:59           ` Helge Hafting
2005-02-03 15:12           ` Alan Cox
2005-02-03 17:26             ` Theodore Ts'o
2005-02-03 13:47         ` linux-os
2005-02-04 16:05       ` David Woodhouse
2005-02-03  0:09 ` Joseph Pingenot
2005-02-03  1:13   ` Pavel Roskin
2005-02-03  2:50     ` Kyle Moffett
2005-02-03  3:17       ` Jon Masters
2005-02-06  7:24       ` Lee Revell
2005-02-07 16:05         ` Chris Friesen
2005-02-07 16:55           ` linux-os
2005-02-07 18:58             ` jerome lacoste
2005-02-07 19:35               ` linux-os
2005-02-07 16:55           ` Randy.Dunlap
2005-02-08  1:40             ` Horst von Brand
2005-02-03  4:57     ` Greg KH
2005-02-03  8:41 ` Arjan van de Ven
2005-02-03 21:00 ` Ben Greear
2005-02-04  9:20 ` Andrew Morton
2005-02-04  9:40   ` Arjan van de Ven
2005-02-15  1:41   ` Alan Cox
2005-02-03  4:08 Jonathan A. George
2005-02-03  5:07 ` Kyle Moffett
2005-02-03 12:30 Jonathan A. George
2005-02-04 15:16 ` Adrian Bunk
2005-02-17 23:13 parker
2005-02-18  3:32 ` Chris Friesen
2005-02-18 13:13 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0502021723280.5515@localhost.localdomain \
    --to=proski@gnu.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®