From: Ian Kent <raven@themaw.net>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: autofs@linux.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: autofs4 looks up wrong path element when ghosting is enabled
Date: Mon, 31 Oct 2005 21:27:32 +0800 (WST) [thread overview]
Message-ID: <Pine.LNX.4.63.0510312119320.2069@donald.themaw.net> (raw)
In-Reply-To: <17254.252.746357.935671@segfault.boston.redhat.com>
On Mon, 31 Oct 2005, Jeff Moyer wrote:
> ==> Regarding Re: autofs4 looks up wrong path element when ghosting is enabled; Ian Kent <raven@themaw.net> adds:
>
> raven> So to resolve this we need to ignore negative and unhashed dentries
> raven> when checking if directory dentry is empty.
> >>
> raven> Please test this patch and let me know how you go.
> >> OK, I've finally got 'round to testing your patch. It does fix the test
> >> case I was using. My only concern is the potential for regressions.
> >> I'll try making sure all of my various maps still work as advertised.
>
> raven> I've spotted a regression with this patch. It doesn't stop autofs
> raven> from appearing to function correctly. It causes mount callbacks when
> raven> they shouldn't made. So it seems that there is a case when an autofs
> raven> directory is, as yet unhashed, but should be used.
>
> I'm not sure I follow. What do you mean it doesn't stop autofs from
> *appearing* to function correctly? Do you have a reproducer that fails?
Any pseudo direct map will produce the behaviour.
It behaves as if the ghost option was not specified even when it has.
This is because the altered test for an empty directory is always
returning true even though the directory isn't empty.
I'm still trying to understand why this happens. In theory it's just not
the expected behaviour. I must be missing something in the directory
creation. I've been here before and looked several times and I just can't
see why it happens this way.
Ian
next prev parent reply other threads:[~2005-10-31 13:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 19:02 Jeff Moyer
2005-09-21 1:25 ` Ian Kent
2005-09-22 21:09 ` Jeff Moyer
2005-09-24 8:59 ` Ian Kent
2005-09-24 20:51 ` Jeff Moyer
2005-09-25 1:25 ` Ian Kent
2005-09-26 15:14 ` Jeff Moyer
2005-09-27 4:21 ` Ian Kent
2005-09-26 20:57 ` Jeff Moyer
2005-09-27 4:34 ` Ian Kent
2005-10-08 5:43 ` Ian Kent
2005-10-08 12:50 ` Jeff Moyer
2005-10-09 4:29 ` Ian Kent
2005-10-15 12:30 ` Ian Kent
2005-10-19 20:49 ` Jeff Moyer
2005-10-20 0:50 ` Ian Kent
2005-10-29 7:42 ` Ian Kent
2005-10-31 11:33 ` Jeff Moyer
2005-10-31 13:27 ` Ian Kent [this message]
2005-11-05 9:50 ` [autofs] " Ian Kent
2005-11-10 23:51 ` Jeff Moyer
2005-11-11 14:53 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0510312119320.2069@donald.themaw.net \
--to=raven@themaw.net \
--cc=autofs@linux.kernel.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®