mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Adrian Bunk <bunk@stusta.de>,
	linux-kernel@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	torvalds@osdl.org, akpm@osdl.org
Subject: Re: RFC: cleaning up the in-kernel headers
Date: Fri, 14 Jul 2006 21:59:19 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0607142152420.9010@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <1152937109.27135.101.camel@localhost.localdomain>

On Sat, 15 Jul 2006, Steven Rostedt wrote:

> Are you talking about the page-flags.h or the vmstat.h?

Both are troublesome. I forked off vmstat.hy from page-flags.h
and all my attempts to straigthen things out results in other problems
so I finally gave up and just did the same for vmstat.h.

> The page-flags.h has a FIXME by it to remove it, but under Adrian's
> rules, it seems that it should still belong.  The rule is that if foo.h
> needs bar.h to compile, then foo.h should have bar.h in it. And just
> seeing what happens if we remove page-flags.h from mm.h, we get a
> compile error in mm.h. Which means that that page-flags.h belongs in
> mm.h since it wont compile without it.

page-flags.h also seems to be included from the arches 
for various purposes. 

grep page-flags include/asm-*/*

include/asm-ia64/cacheflush.h:#include <linux/page-flags.h>
include/asm-ia64/pgalloc.h:#include <linux/page-flags.h>
include/asm-ia64/uaccess.h:#include <linux/page-flags.h>

grep page-flags arch/*/*/*
arch/s390/appldata/appldata_base.c:#include <linux/page-flags.h>

mm.h gets too big. It would be best if we had some smaller granularity and
page-flags.h should be pretty much stand on its own.


> Now for the vmstat.h, I just tried removing that, and it seems that this
> is a candidate to be removed from mm.h since mm.h compiles fine without
> it. But vmstat.h doesn't compile without mm.h.  So it seems that we
> should add mm.h to vmstat.h, remove vmstat.h from mm.h and for those .c
> files that break, just add vmstat.h to them.

Great if you can detangle that.


  reply	other threads:[~2006-07-15  4:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-11 16:06 Adrian Bunk
2006-07-11 16:28 ` David Woodhouse
2006-07-11 17:33   ` Christoph Hellwig
2006-07-11 19:34     ` Sam Ravnborg
2006-07-11 19:41       ` Sam Ravnborg
2006-07-11 20:41         ` Randy.Dunlap
2006-07-11 21:37           ` Jörn Engel
2006-07-11 22:01             ` H. Peter Anvin
2006-07-11 22:20               ` Jörn Engel
2006-07-11 22:39               ` Linus Torvalds
2006-07-11 22:40             ` Adrian Bunk
2006-07-11 21:04     ` David Woodhouse
2006-07-11 22:24   ` Adrian Bunk
2006-07-11 17:07 ` Dave Jones
2006-07-11 17:15   ` Joshua Hudson
2006-07-11 18:19     ` Dave Jones
2006-07-11 22:27   ` Adrian Bunk
2006-07-11 19:05 ` Russell King
2006-07-11 22:19   ` Adrian Bunk
2006-07-11 20:26 ` [PATCH] Fix broken kernel headers preventing ARM build Russell King
2006-07-13 19:05 ` RFC: cleaning up the in-kernel headers Christoph Lameter
2006-07-15  4:18   ` Steven Rostedt
2006-07-15  4:59     ` Christoph Lameter [this message]
2006-07-17  0:53       ` Steven Rostedt
2006-07-20 10:56         ` Adrian Bunk
2006-07-14  0:11 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0607142152420.9010@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®