From: Roman Zippel <zippel@linux-m68k.org>
To: john stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/8] cleanup ntp.c
Date: Sat, 15 Mar 2008 04:21:34 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803150418560.1791@scrub.home> (raw)
In-Reply-To: <1205526659.6122.11.camel@localhost.localdomain>
Hi,
On Fri, 14 Mar 2008, john stultz wrote:
> Ah crud. Ingo sent very similar changes to me a few weeks ago, and I've
> been too pinched for time to test and send them out.
>
> I'll spend some time today to layer his fixes as well as my own cleanups
> on top.
What fixes?
> > +static void ntp_update_offset(long offset)
> > +{
> > + long mtemp;
>
> Could we change this to a more descriptive name?
>
> Maybe last_update_interval?
It's a local variable, so IMO temp works just fine, it's not that
difficult to figure out how it's used (e.g. it's like using loop_index
instead of i).
bye, Roman
next prev parent reply other threads:[~2008-03-15 3:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 18:40 [PATCH 0/8] NTP updates zippel
2008-03-14 18:40 ` [PATCH 1/8] cleanup ntp.c zippel
2008-03-14 20:30 ` john stultz
2008-03-15 3:21 ` Roman Zippel [this message]
2008-03-14 18:40 ` [PATCH 2/8] NTP4 user space bits update zippel
2008-03-14 20:36 ` john stultz
2008-03-15 3:29 ` Roman Zippel
2008-03-14 18:40 ` [PATCH 3/8] increase time_freq resolution zippel
2008-03-14 18:40 ` [PATCH 4/8] increase time_offset resolution zippel
2008-03-14 18:40 ` [PATCH 5/8] support for TAI zippel
2008-03-14 20:55 ` john stultz
2008-03-14 18:40 ` [PATCH 6/8] Rename TICK_LENGTH_SHIFT to NTP_SCALE_SHIFT zippel
2008-03-14 18:40 ` [PATCH 7/8] Remove current_tick_length() zippel
2008-03-15 2:41 ` john stultz
2008-03-15 3:32 ` Roman Zippel
2008-03-15 3:48 ` john stultz
2008-03-15 4:18 ` Roman Zippel
2008-03-15 16:29 ` Ray Lee
2008-03-15 17:14 ` Roman Zippel
2008-03-18 1:01 ` john stultz
2008-03-26 1:53 ` Roman Zippel
2008-03-14 18:40 ` [PATCH 8/8] handle leap second via timer zippel
2008-03-14 20:24 ` john stultz
2008-03-15 3:18 ` Roman Zippel
2008-03-17 22:18 ` Andrew Morton
2008-03-21 14:15 ` Thomas Gleixner
2008-03-14 23:03 ` [PATCH 0/8] NTP updates john stultz
2008-03-15 3:15 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803150418560.1791@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®