Re: [PATCH 2/8] NTP4 user space bits update

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Fri, 14 Mar 2008, john stultz wrote:

> > -	  /* singleshot must not be used with any other mode bits */
> > -		if (txc->modes != ADJ_OFFSET_SINGLESHOT &&
> > -					txc->modes != ADJ_OFFSET_SS_READ)
> > +		/* singleshot must not be used with any other mode bits */
> > +		if (txc->modes & ~ADJ_OFFSET_SS_READ)
> >  			return -EINVAL;
> 
> This could probably go in the cleanup patch, no?

It does more than simple code indentation and refactoring, so I didn't 
want to include it there.

> > -#if 0	/* STA_CLOCKERR is never set yet */
> > -	time_status &= ~STA_CLOCKERR;		/* reset STA_CLOCKERR */
> > -#endif
> 
> This as well is just cleanup.

Debatable, it refers to user space APIs, so I included it here.

> > +		if (txc->modes & ADJ_STATUS) {
> > +			if ((time_status & STA_PLL) &&
> > +			    !(txc->status & STA_PLL)) {
> > +				time_state = TIME_OK;
> > +				time_status = STA_UNSYNC;
> > +			}
> > +			/* only set allowed bits */
> > +			time_status &= STA_RONLY;
> > +			time_status |= txc->status & ~STA_RONLY;
> > +		}
> 
> More cleanup.

Not really.

bye, Roman