mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties
Date: Wed, 27 Sep 2023 10:18:57 +0000	[thread overview]
Message-ID: <TYWPR01MB8775B9F9F70CA75410788F83C2C2A@TYWPR01MB8775.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <ZRP+ZNXe975hcEJJ@finisterre.sirena.org.uk>

Hi Mark,

Thanks for your reply!

> From: Mark Brown <broonie@kernel.org>
> Subject: Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related
> properties
> 
> On Wed, Sep 27, 2023 at 11:44:17AM +0200, Geert Uytterhoeven wrote:
> > On Wed, Sep 27, 2023 at 11:21 AM Mark Brown <broonie@kernel.org>
> wrote:
> 
> > > I see.  Is there any control over what the chip select is when
> there is
> > > one, in which case we could just look to see if there's one
> specified?
> 
> > On RZ/V2M there isn't, as there is only a single hardware chip
> select.
> 
> > On MSIOF, there are 3 hardware chip selects, but apparently only the
> > primary one can be used in target mode.
> 
> OK, it sounds like we do need a property then.  Like I say I'd rather
> not have one that just works for _NO_CS in order to avoid confusion
> for
> people writing SPI device drivers, either something in the generic
> target binding or a device specific one.

Shall I invert the logic then? What I mean is I could drop property
"renesas,csi-ss" and add property "renesas,csi-no-ss" instead, therefore
without "renesas,csi-no-ss" pin SS will be used, with "renesas,csi-no-ss"
pin SS won't be used.
What do you think?

Also, I could drop "renesas,csi-ss-high" and use "spi-cs-high" instead?

Geert, any thoughts on the above?

Thanks,
Fab

  reply	other threads:[~2023-09-27 10:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 21:08 [PATCH 0/2] Add RZ/V2M CSI slave support Fabrizio Castro
2023-09-26 21:08 ` [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties Fabrizio Castro
2023-09-27  7:59   ` Geert Uytterhoeven
2023-09-27  9:00     ` Mark Brown
2023-09-27  9:10       ` Geert Uytterhoeven
2023-09-27  9:21         ` Mark Brown
2023-09-27  9:44           ` Geert Uytterhoeven
2023-09-27 10:05             ` Mark Brown
2023-09-27 10:18               ` Fabrizio Castro [this message]
2023-09-27 10:22                 ` Mark Brown
2023-09-27  9:43         ` Fabrizio Castro
2023-09-27  9:36     ` Fabrizio Castro
2023-09-27  8:56   ` Mark Brown
2023-09-27  9:40     ` Fabrizio Castro
2023-09-26 21:08 ` [PATCH 2/2] spi: rzv2m-csi: Add Slave mode support Fabrizio Castro
2023-09-27  9:02   ` Mark Brown
2023-09-27  9:12     ` Geert Uytterhoeven
2023-09-27  9:15       ` Mark Brown
2023-09-27  9:51   ` Geert Uytterhoeven
2023-09-27 10:05     ` Fabrizio Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYWPR01MB8775B9F9F70CA75410788F83C2C2A@TYWPR01MB8775.jpnprd01.prod.outlook.com \
    --to=fabrizio.castro.jz@renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®