From: Mark Brown <broonie@kernel.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties
Date: Wed, 27 Sep 2023 12:22:59 +0200 [thread overview]
Message-ID: <ZRQCg6Xf/wYfC2PD@finisterre.sirena.org.uk> (raw)
In-Reply-To: <TYWPR01MB8775B9F9F70CA75410788F83C2C2A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Wed, Sep 27, 2023 at 10:18:57AM +0000, Fabrizio Castro wrote:
> > From: Mark Brown <broonie@kernel.org>
> > OK, it sounds like we do need a property then. Like I say I'd rather
> > not have one that just works for _NO_CS in order to avoid confusion
> > for
> > people writing SPI device drivers, either something in the generic
> > target binding or a device specific one.
> Shall I invert the logic then? What I mean is I could drop property
> "renesas,csi-ss" and add property "renesas,csi-no-ss" instead, therefore
> without "renesas,csi-no-ss" pin SS will be used, with "renesas,csi-no-ss"
> pin SS won't be used.
> What do you think?
That sounds fine for me, I guess we could add a further property if some
new IP allows multiple options for the chip select in target mode.
> Also, I could drop "renesas,csi-ss-high" and use "spi-cs-high" instead?
I think that's OK but I looked less at that bit.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-27 10:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 21:08 [PATCH 0/2] Add RZ/V2M CSI slave support Fabrizio Castro
2023-09-26 21:08 ` [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties Fabrizio Castro
2023-09-27 7:59 ` Geert Uytterhoeven
2023-09-27 9:00 ` Mark Brown
2023-09-27 9:10 ` Geert Uytterhoeven
2023-09-27 9:21 ` Mark Brown
2023-09-27 9:44 ` Geert Uytterhoeven
2023-09-27 10:05 ` Mark Brown
2023-09-27 10:18 ` Fabrizio Castro
2023-09-27 10:22 ` Mark Brown [this message]
2023-09-27 9:43 ` Fabrizio Castro
2023-09-27 9:36 ` Fabrizio Castro
2023-09-27 8:56 ` Mark Brown
2023-09-27 9:40 ` Fabrizio Castro
2023-09-26 21:08 ` [PATCH 2/2] spi: rzv2m-csi: Add Slave mode support Fabrizio Castro
2023-09-27 9:02 ` Mark Brown
2023-09-27 9:12 ` Geert Uytterhoeven
2023-09-27 9:15 ` Mark Brown
2023-09-27 9:51 ` Geert Uytterhoeven
2023-09-27 10:05 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRQCg6Xf/wYfC2PD@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®