mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties
Date: Wed, 27 Sep 2023 10:56:42 +0200	[thread overview]
Message-ID: <ZRPuSidGd5zO6pXf@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20230926210818.197356-2-fabrizio.castro.jz@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

On Tue, Sep 26, 2023 at 10:08:17PM +0100, Fabrizio Castro wrote:
> The CSI IP found inside the Renesas RZ/V2M SoC can also work
> in SPI slave mode.
> When working in slave mode, the IP can make use of the SS
> (Slave Select) pin, with "low" as default active level.
> The active level of SS can be changed to "high" upon configuration.
> This patch adds two new properties, one to make use of the
> SS pin when in slave mode, and one to make the SS pin active high.

Please avoid the use of outdated terminology like this, prefer "device
mode" or similar.

> +  renesas,csi-ss:
> +    type: boolean
> +    description:
> +      Use CSI Slave Selection (SS) pin to enable transmission and reception when
> +      in slave mode.

When would this ever not be true when in device mode?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2023-09-27  8:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 21:08 [PATCH 0/2] Add RZ/V2M CSI slave support Fabrizio Castro
2023-09-26 21:08 ` [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties Fabrizio Castro
2023-09-27  7:59   ` Geert Uytterhoeven
2023-09-27  9:00     ` Mark Brown
2023-09-27  9:10       ` Geert Uytterhoeven
2023-09-27  9:21         ` Mark Brown
2023-09-27  9:44           ` Geert Uytterhoeven
2023-09-27 10:05             ` Mark Brown
2023-09-27 10:18               ` Fabrizio Castro
2023-09-27 10:22                 ` Mark Brown
2023-09-27  9:43         ` Fabrizio Castro
2023-09-27  9:36     ` Fabrizio Castro
2023-09-27  8:56   ` Mark Brown [this message]
2023-09-27  9:40     ` Fabrizio Castro
2023-09-26 21:08 ` [PATCH 2/2] spi: rzv2m-csi: Add Slave mode support Fabrizio Castro
2023-09-27  9:02   ` Mark Brown
2023-09-27  9:12     ` Geert Uytterhoeven
2023-09-27  9:15       ` Mark Brown
2023-09-27  9:51   ` Geert Uytterhoeven
2023-09-27 10:05     ` Fabrizio Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRPuSidGd5zO6pXf@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®