From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Wolfram Sang <wsa@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Cai Huoqing <cai.huoqing@linux.dev>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Gerhard Sittig <gsi@denx.de>, Anatolij Gustschin <agust@denx.de>,
Mark Brown <broonie@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe
Date: Mon, 24 Oct 2022 15:00:28 +0300 [thread overview]
Message-ID: <Y1Z+XHdOozjBFBzF@smile.fi.intel.com> (raw)
In-Reply-To: <20221024114810.732168-1-dzm91@hust.edu.cn>
On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
> The commit 1149108e2fbf ("can: mscan: improve clock API use
> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
Strange indentation. Why the '")' part can't be on the previous line?
> put_clock in the error handling code.
>
> Fix this bug by adding put_clock in the error handling code.
--
With Best Regards,
Andy Shevchenko
next parent reply other threads:[~2022-10-24 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221024114810.732168-1-dzm91@hust.edu.cn>
2022-10-24 12:00 ` Andy Shevchenko [this message]
2022-10-25 2:29 ` Dongliang Mu
2022-10-25 7:12 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Z+XHdOozjBFBzF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agust@denx.de \
--cc=broonie@kernel.org \
--cc=cai.huoqing@linux.dev \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=christophe.leroy@csgroup.eu \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=dzm91@hust.edu.cn \
--cc=edumazet@google.com \
--cc=gsi@denx.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wg@grandegger.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®