* Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe [not found] <20221024114810.732168-1-dzm91@hust.edu.cn> @ 2022-10-24 12:00 ` Andy Shevchenko 2022-10-25 2:29 ` Dongliang Mu 0 siblings, 1 reply; 3+ messages in thread From: Andy Shevchenko @ 2022-10-24 12:00 UTC (permalink / raw) To: Dongliang Mu Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Chris Packham, Damien Le Moal, Wolfram Sang, Michael Ellerman, Cai Huoqing, Christophe Leroy, Gerhard Sittig, Anatolij Gustschin, Mark Brown, linux-can, netdev, linux-kernel On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote: > The commit 1149108e2fbf ("can: mscan: improve clock API use > ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add Strange indentation. Why the '")' part can't be on the previous line? > put_clock in the error handling code. > > Fix this bug by adding put_clock in the error handling code. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe 2022-10-24 12:00 ` [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe Andy Shevchenko @ 2022-10-25 2:29 ` Dongliang Mu 2022-10-25 7:12 ` Marc Kleine-Budde 0 siblings, 1 reply; 3+ messages in thread From: Dongliang Mu @ 2022-10-25 2:29 UTC (permalink / raw) To: Andy Shevchenko Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Chris Packham, Damien Le Moal, Wolfram Sang, Michael Ellerman, Cai Huoqing, Christophe Leroy, Gerhard Sittig, Anatolij Gustschin, Mark Brown, linux-can, netdev, linux-kernel > On Oct 24, 2022, at 20:00, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote: >> The commit 1149108e2fbf ("can: mscan: improve clock API use >> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add > > Strange indentation. Why the '")' part can't be on the previous line? :/ it is automatically done by vim in `git commit -a -s -e`. I can adjust this part in v2 patch. > >> put_clock in the error handling code. >> >> Fix this bug by adding put_clock in the error handling code. > > -- > With Best Regards, > Andy Shevchenko > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe 2022-10-25 2:29 ` Dongliang Mu @ 2022-10-25 7:12 ` Marc Kleine-Budde 0 siblings, 0 replies; 3+ messages in thread From: Marc Kleine-Budde @ 2022-10-25 7:12 UTC (permalink / raw) To: Dongliang Mu Cc: Andy Shevchenko, Wolfgang Grandegger, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Chris Packham, Damien Le Moal, Wolfram Sang, Michael Ellerman, Cai Huoqing, Christophe Leroy, Gerhard Sittig, Anatolij Gustschin, Mark Brown, linux-can, netdev, linux-kernel [-- Attachment #1: Type: text/plain, Size: 873 bytes --] On 25.10.2022 10:29:50, Dongliang Mu wrote: > > > > On Oct 24, 2022, at 20:00, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > > On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote: > >> The commit 1149108e2fbf ("can: mscan: improve clock API use > >> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add > > > > Strange indentation. Why the '")' part can't be on the previous line? > > :/ it is automatically done by vim in `git commit -a -s -e`. I can > adjust this part in v2 patch. Fixed while applying the patch. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-25 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221024114810.732168-1-dzm91@hust.edu.cn>
2022-10-24 12:00 ` [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe Andy Shevchenko
2022-10-25 2:29 ` Dongliang Mu
2022-10-25 7:12 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®