From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"LH.Kuo" <lhjeff911@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"dvorkin@tibbo.com" <dvorkin@tibbo.com>,
"qinjian@cqplus1.com" <qinjian@cqplus1.com>,
"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: Re: [PATCH v3 1/2] SPI: Add SPI driver for Sunplus SP7021
Date: Fri, 26 Nov 2021 13:03:25 +0000 [thread overview]
Message-ID: <YaDbHe+COa3pke+s@sirena.org.uk> (raw)
In-Reply-To: <63a467164c985cadce0e28e50508363a8d2f6622.camel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Fri, Nov 26, 2021 at 11:36:29AM +0100, Philipp Zabel wrote:
> > pm_runtime_disable(&pdev->dev);
> I'm not sure if the SPI framework requires the spi_controller to be
> unregistered before hardware is powered off, maybe it is enough to call
> spi_controller_suspend() in the right place?
It would *probably* do the right thing but the expectation really is
that you'll unregister before making the controller stop working, that
should be much more robust..
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-26 13:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 6:18 [PATCH 0/2] Add SPI control driver for Sunplus SP7021 SoC LH.Kuo
2021-11-01 6:18 ` [PATCH 1/2] SPI: Add SPI driver for Sunplus SP7021 LH.Kuo
2021-11-01 18:36 ` Mark Brown
[not found] ` <1c5b8e435d614772a5c0af8d5c633941@sphcmbx02.sunplus.com.tw>
2021-11-05 13:29 ` Mark Brown
2021-11-10 16:46 ` Andy Shevchenko
2021-11-02 14:31 ` Philipp Zabel
2021-11-14 8:02 ` Lukas Wunner
2021-11-01 6:18 ` [PATCH 2/2] devicetree bindings SPI Add bindings doc " LH.Kuo
2021-11-09 9:01 ` [PATCH v2 0/2] Add SPI control driver for Sunplus SP7021 SoC LH.Kuo
2021-11-09 9:01 ` [PATCH v2 1/2] SPI: Add SPI driver for Sunplus SP7021 LH.Kuo
2021-11-09 14:56 ` Mark Brown
[not found] ` <f98b5548cf564093af1d10ba1239507d@sphcmbx02.sunplus.com.tw>
2021-11-10 16:22 ` Mark Brown
[not found] ` <70a9c10ef34e46c2a51f134829abdd08@sphcmbx02.sunplus.com.tw>
2021-11-11 13:41 ` Mark Brown
[not found] ` <083dc70e20964ec8b74f71f6817be55e@sphcmbx02.sunplus.com.tw>
2021-11-18 13:38 ` Mark Brown
[not found] ` <e98c0bc4dc99415099197688a8dd3ef5@sphcmbx02.sunplus.com.tw>
2021-11-19 13:06 ` Mark Brown
2021-11-09 16:55 ` Randy Dunlap
[not found] ` <de7535b134fb4247b5275c04fa21debf@sphcmbx02.sunplus.com.tw>
2021-11-10 5:41 ` Randy Dunlap
2021-11-09 9:01 ` [PATCH v2 2/2] devicetree bindings SPI Add bindings doc " LH.Kuo
2021-11-09 14:57 ` Mark Brown
[not found] ` <2eeae9b780e94ac9810ffffe249098f2@sphcmbx02.sunplus.com.tw>
2021-11-10 14:11 ` Mark Brown
2021-11-22 2:33 ` [PATCH v3 0/2] Add SPI control driver for Sunplus SP7021 SoC LH.Kuo
2021-11-22 2:33 ` [PATCH v3 1/2] SPI: Add SPI driver for Sunplus SP7021 LH.Kuo
2021-11-22 22:09 ` Andy Shevchenko
2021-11-23 14:03 ` Mark Brown
2021-11-23 17:11 ` Andy Shevchenko
[not found] ` <6eb68a8153ba46c48862d00f7aa6e0fe@sphcmbx02.sunplus.com.tw>
2021-11-25 10:06 ` Andy Shevchenko
[not found] ` <33d50e94059b4734939db60b5c531bc9@sphcmbx02.sunplus.com.tw>
2021-11-26 10:33 ` Andy Shevchenko
2021-11-26 10:36 ` Philipp Zabel
2021-11-26 13:03 ` Mark Brown [this message]
[not found] ` <d33a3a4f3b8248a78fae572a7f88050a@sphcmbx02.sunplus.com.tw>
2021-11-29 13:10 ` Andy Shevchenko
[not found] ` <3d792085d6fc4be19253f5200c181041@sphcmbx02.sunplus.com.tw>
2021-12-01 19:28 ` Andy Shevchenko
2021-11-23 12:48 ` Lukas Wunner
2021-11-22 2:33 ` [PATCH v3 2/2] devicetree: bindings SPI Add bindings doc " LH.Kuo
2021-11-29 0:35 ` Rob Herring
2021-11-23 14:36 ` [PATCH v3 0/2] Add SPI control driver for Sunplus SP7021 SoC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaDbHe+COa3pke+s@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dvorkin@tibbo.com \
--cc=lh.Kuo@sunplus.com \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®