mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Tim Murray <timmurray@google.com>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
	Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH] f2fs: move f2fs to use reader-unfair rwsems
Date: Mon, 10 Jan 2022 16:02:33 +0100	[thread overview]
Message-ID: <YdxKiVHBUYvVP7W2@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YdvoxkAAquI17UbX@infradead.org>

On Mon, Jan 10, 2022 at 12:05:26AM -0800, Christoph Hellwig wrote:
> Adding the locking primitive maintainers to this patch adding open coded
> locking primitives..
> 
> On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim wrote:
> > From: Tim Murray <timmurray@google.com>
> > 
> > f2fs rw_semaphores work better if writers can starve readers,
> > especially for the checkpoint thread, because writers are strictly
> > more important than reader threads. This prevents significant priority
> > inversion between low-priority readers that blocked while trying to
> > acquire the read lock and a second acquisition of the write lock that
> > might be blocking high priority work.

*groan*... that's nowhere near enough Changelog to justify any of this.
Because next is a whole series of patches making things even worse
because lockdep no longers works as expected on this custom thing.

Can we start by describing the actual problem?

  reply	other threads:[~2022-01-10 15:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-08 16:46 Jaegeuk Kim
2022-01-10  8:05 ` Christoph Hellwig
2022-01-10 15:02   ` Peter Zijlstra [this message]
2022-01-10 16:18   ` Waiman Long
2022-01-10 18:45     ` Peter Zijlstra
2022-01-10 18:55       ` Waiman Long
2022-01-10 19:41     ` Tim Murray
2022-01-11  4:15       ` Waiman Long
2022-01-11  6:53         ` Tim Murray
2022-01-11 15:04           ` Waiman Long
2022-01-11 17:07             ` Jaegeuk Kim
2022-01-11 22:01               ` Waiman Long
2022-01-12  0:25                 ` Jaegeuk Kim
2022-01-12 15:08                   ` Waiman Long
2022-01-12 14:06       ` Peter Zijlstra
2022-01-12 22:06         ` Tim Murray
2022-02-23  7:42         ` Christoph Hellwig
2022-02-23 17:48           ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdxKiVHBUYvVP7W2@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=boqun.feng@gmail.com \
    --cc=hch@infradead.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=timmurray@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome