From: Petr Mladek <pmladek@suse.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] panic: Add panic_in_progress helper
Date: Tue, 25 Jan 2022 12:48:22 +0100 [thread overview]
Message-ID: <Ye/jhjBaN35L76BF@alley> (raw)
In-Reply-To: <20220121190222.572694-2-stephen.s.brennan@oracle.com>
On Fri 2022-01-21 11:02:19, Stephen Brennan wrote:
Please, add explanation why the new helper is added. It will be
used in printk code to reduce risk of deadlocks during panic().
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
> ---
> We cannot define a static inline without including linux/atomic.h, so
> I just added a macro for convenience in later patches. Since macros were
> the only option, I didn't include a helper for
> panic_in_progress_different_cpu().
What is the exact problem with including atomic.h and using static
inline, please?
IMHO, the define is not a real solution. The macro won't be usable
without including atomic.h. So, it would work only by chance.
But it is possible that I miss something.
Best Regards,
Petr
next prev parent reply other threads:[~2022-01-25 11:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 19:02 [PATCH 0/4] printk: reduce deadlocks during panic Stephen Brennan
2022-01-21 19:02 ` [PATCH 1/4] panic: Add panic_in_progress helper Stephen Brennan
2022-01-25 11:48 ` Petr Mladek [this message]
2022-01-26 17:37 ` Stephen Brennan
2022-01-21 19:02 ` [PATCH 2/4] printk: disable optimistic spin during panic Stephen Brennan
2022-01-25 12:42 ` Petr Mladek
2022-01-26 9:18 ` Sergey Senozhatsky
2022-01-26 9:45 ` John Ogness
2022-01-26 10:06 ` Sergey Senozhatsky
2022-01-26 18:15 ` Stephen Brennan
2022-01-27 7:11 ` Sergey Senozhatsky
2022-01-27 9:09 ` John Ogness
2022-01-27 11:38 ` Petr Mladek
2022-01-27 12:43 ` John Ogness
2022-01-27 14:25 ` Petr Mladek
2022-01-21 19:02 ` [PATCH 3/4] printk: Avoid livelock with heavy printk " Stephen Brennan
2022-01-25 14:25 ` Petr Mladek
2022-01-21 19:02 ` [PATCH 4/4] printk: Drop console_sem " Stephen Brennan
2022-01-24 16:12 ` John Ogness
2022-01-24 16:26 ` John Ogness
2022-01-25 15:04 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye/jhjBaN35L76BF@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®