[PATCH] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

[PATCH] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

[Jiri Kosina]

From: Jiri Kosina <jkosina@suse.cz>

The 'Do you have a strange power saving mode enabled?' hint when unknown 
NMI happens dates back to i386 stone age, and isn't currently really 
helpful.

Unknown NMIs are coming for many different reasons (broken firmware, 
faulty hardware, ...) and rarely have anything to do with 'strange power 
saving mode' (whatever that even is).

Just remove it as it's largerly misleading.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 arch/x86/kernel/nmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 4bce802d25fb..e73f7df362f5 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
 	pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
 		 reason, smp_processor_id());
 
-	pr_emerg("Do you have a strange power saving mode enabled?\n");
 	if (unknown_nmi_panic || panic_on_unrecovered_nmi)
 		nmi_panic(regs, "NMI: Not continuing");
 
-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

[Peter Zijlstra]

On Mon, Mar 14, 2022 at 09:25:18AM +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> The 'Do you have a strange power saving mode enabled?' hint when unknown 
> NMI happens dates back to i386 stone age, and isn't currently really 
> helpful.
> 
> Unknown NMIs are coming for many different reasons (broken firmware, 
> faulty hardware, ...) and rarely have anything to do with 'strange power 
> saving mode' (whatever that even is).
> 
> Just remove it as it's largerly misleading.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Fair enough,

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

> ---
>  arch/x86/kernel/nmi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
> index 4bce802d25fb..e73f7df362f5 100644
> --- a/arch/x86/kernel/nmi.c
> +++ b/arch/x86/kernel/nmi.c
> @@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
>  	pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
>  		 reason, smp_processor_id());
>  
> -	pr_emerg("Do you have a strange power saving mode enabled?\n");
>  	if (unknown_nmi_panic || panic_on_unrecovered_nmi)
>  		nmi_panic(regs, "NMI: Not continuing");
>  
> -- 
> Jiri Kosina
> SUSE Labs
> 

[tip: x86/cleanups] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

[tip-bot2 for Jiri Kosina]

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     d4c9df20a37d128f6acb3c6286db7e694554a51b
Gitweb:        https://git.kernel.org/tip/d4c9df20a37d128f6acb3c6286db7e694554a51b
Author:        Jiri Kosina <jkosina@suse.cz>
AuthorDate:    Mon, 14 Mar 2022 09:25:18 +01:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Wed, 16 Mar 2022 11:02:41 +01:00

x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

The

  Do you have a strange power saving mode enabled?

hint when unknown NMI happens dates back to i386 stone age, and isn't
currently really helpful.

Unknown NMIs are coming for many different reasons (broken firmware,
faulty hardware, ...) and rarely have anything to do with 'strange power
saving mode' (whatever that even is).

Just remove it as it's largerly misleading.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/nycvar.YFH.7.76.2203140924120.24795@cbobk.fhfr.pm
---
 arch/x86/kernel/nmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 4bce802..e73f7df 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
 	pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
 		 reason, smp_processor_id());
 
-	pr_emerg("Do you have a strange power saving mode enabled?\n");
 	if (unknown_nmi_panic || panic_on_unrecovered_nmi)
 		nmi_panic(regs, "NMI: Not continuing");