From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: xiubli@redhat.com, idryomov@gmail.com, jlayton@kernel.org,
marc.dionne@auristor.com, keescook@chromium.org,
kirill.shutemov@linux.intel.com, william.kucharski@oracle.com,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-cachefs@redhat.com,
vshankar@redhat.com
Subject: Re: [PATCH v4] netfs: do not unlock and put the folio twice
Date: Thu, 7 Jul 2022 14:26:33 +0100 [thread overview]
Message-ID: <YsbfCcNvjMVcT2yx@casper.infradead.org> (raw)
In-Reply-To: <2520851.1657200105@warthog.procyon.org.uk>
On Thu, Jul 07, 2022 at 02:21:45PM +0100, David Howells wrote:
> - struct folio *folio, void **_fsdata);
> + struct folio **_folio, void **_fsdata);
The usual convention is that _foo means "Don't touch". This should
probably be named "foliop" (ie pointer to a thing that would normally
be called folio).
next prev parent reply other threads:[~2022-07-07 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 4:51 [PATCH v3 0/2] netfs: fix the crash when unlocking the folio xiubli
2022-07-07 4:51 ` [PATCH v3 1/2] netfs: do not unlock and put the folio twice xiubli
2022-07-07 4:51 ` [PATCH v3 2/2] afs: unlock the folio when vnode is marked deleted xiubli
2022-07-07 10:56 ` Jeff Layton
2022-07-07 12:52 ` David Howells
2022-07-07 12:32 ` [PATCH v3 1/2] netfs: do not unlock and put the folio twice David Howells
2022-07-08 0:34 ` Xiubo Li
2022-07-07 12:53 ` David Howells
2022-07-07 13:21 ` [PATCH v4] " David Howells
2022-07-07 13:26 ` Matthew Wilcox [this message]
2022-07-11 4:19 ` Xiubo Li
2022-07-09 0:27 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsbfCcNvjMVcT2yx@casper.infradead.org \
--to=willy@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=vshankar@redhat.com \
--cc=william.kucharski@oracle.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®