From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
John Ogness <john.ogness@linutronix.de>,
Mike Galbraith <efault@gmx.de>, Petr Mladek <pmladek@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Theodore Ts'o <tytso@mit.edu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from __ptr_to_hashval().
Date: Mon, 1 Aug 2022 14:41:43 +0200 [thread overview]
Message-ID: <YufKBytKQOoXgFae@linutronix.de> (raw)
In-Reply-To: <YufC9XCej2qmcH8p@zx2c4.com>
On 2022-08-01 14:11:33 [+0200], Jason A. Donenfeld wrote:
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -750,12 +750,7 @@ static int __init debug_boot_weak_hash_e
> > }
> > early_param("debug_boot_weak_hash", debug_boot_weak_hash_enable);
> >
> > -static DEFINE_STATIC_KEY_FALSE(filled_random_ptr_key);
> > -
> > -static void enable_ptr_key_workfn(struct work_struct *work)
> > -{
> > - static_branch_enable(&filled_random_ptr_key);
> > -}
> > +static bool filled_random_ptr_key;
>
> This should be __read_mostly, right? Just like ptr_key.
could be, yes.
> Jason
Sebastian
next prev parent reply other threads:[~2022-08-01 12:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 15:47 [PATCH 0/2 v2] Init the hashed pointer from a worker Sebastian Andrzej Siewior
2022-07-29 15:47 ` [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from __ptr_to_hashval() Sebastian Andrzej Siewior
2022-08-01 12:11 ` Jason A. Donenfeld
2022-08-01 12:41 ` Sebastian Andrzej Siewior [this message]
2022-08-01 12:13 ` Jason A. Donenfeld
2022-08-01 12:42 ` Sebastian Andrzej Siewior
2022-07-29 15:47 ` [PATCH 2/2 v2] lib/vsprintf: Initialize vsprintf's pointer hash once the random core is ready Sebastian Andrzej Siewior
2022-07-29 23:29 ` Jason A. Donenfeld
2022-08-01 7:32 ` Sebastian Andrzej Siewior
2022-08-01 9:34 ` [PATCH 2/2 v3] " Sebastian Andrzej Siewior
2022-08-01 12:36 ` Jason A. Donenfeld
2022-08-01 12:39 ` [PATCH v4] lib/vsprintf: defer filling siphash key on RT Jason A. Donenfeld
2022-08-01 12:46 ` Sebastian Andrzej Siewior
2022-08-01 13:36 ` Jason A. Donenfeld
2022-08-01 13:44 ` Jason A. Donenfeld
2022-08-01 14:25 ` Sebastian Andrzej Siewior
2022-08-01 14:30 ` Jason A. Donenfeld
2022-08-01 13:47 ` Sebastian Andrzej Siewior
2022-08-01 13:55 ` Jason A. Donenfeld
2022-08-01 14:12 ` [PATCH v5] " Jason A. Donenfeld
2022-08-01 14:26 ` Sebastian Andrzej Siewior
2022-08-01 12:41 ` [PATCH 2/2 v3] lib/vsprintf: Initialize vsprintf's pointer hash once the random core is ready Sebastian Andrzej Siewior
2022-09-20 15:01 ` Jason A. Donenfeld
2022-09-23 10:36 ` Petr Mladek
2022-09-23 15:28 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YufKBytKQOoXgFae@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=efault@gmx.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome