* [PATCH v1 1/1] pref/x86/rapl: Remove unused function
@ 2024-12-02 18:28 Andy Shevchenko
2024-12-04 23:56 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-12-02 18:28 UTC (permalink / raw)
To: linux-perf-users, linux-kernel, llvm
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan, Thomas Gleixner,
Borislav Petkov, Dave Hansen, x86, H. Peter Anvin,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Andy Shevchenko
get_rapl_pmu_cpumask() is unused, it prevents kernel builds
with clang, `make W=1` and CONFIG_WERROR=y:
arch/x86/events/rapl.c:165:37: error: unused function 'get_rapl_pmu_cpumask' [-Werror,-Wunused-function]
Fix this by removing unused function.
See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
inline functions for W=1 build").
Fixes: 9e9af8bbb5f9 ("perf/x86/rapl: Clean up cpumask and hotplug")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/events/rapl.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
index a8defc813c36..3ed5ea2aa867 100644
--- a/arch/x86/events/rapl.c
+++ b/arch/x86/events/rapl.c
@@ -162,12 +162,6 @@ static inline unsigned int get_rapl_pmu_idx(int cpu)
topology_logical_die_id(cpu);
}
-static inline const struct cpumask *get_rapl_pmu_cpumask(int cpu)
-{
- return rapl_pmu_is_pkg_scope() ? topology_core_cpumask(cpu) :
- topology_die_cpumask(cpu);
-}
-
static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu)
{
unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu);
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pref/x86/rapl: Remove unused function
2024-12-02 18:28 [PATCH v1 1/1] pref/x86/rapl: Remove unused function Andy Shevchenko
@ 2024-12-04 23:56 ` Ian Rogers
2024-12-05 7:44 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2024-12-04 23:56 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-perf-users, linux-kernel, llvm, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Liang, Kan, Thomas Gleixner, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt
On Mon, Dec 2, 2024 at 10:28 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> get_rapl_pmu_cpumask() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> arch/x86/events/rapl.c:165:37: error: unused function 'get_rapl_pmu_cpumask' [-Werror,-Wunused-function]
>
> Fix this by removing unused function.
>
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
>
> Fixes: 9e9af8bbb5f9 ("perf/x86/rapl: Clean up cpumask and hotplug")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
nit: s/pref/perf/ in the commit message title
Thanks,
Ian
> ---
> arch/x86/events/rapl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
> index a8defc813c36..3ed5ea2aa867 100644
> --- a/arch/x86/events/rapl.c
> +++ b/arch/x86/events/rapl.c
> @@ -162,12 +162,6 @@ static inline unsigned int get_rapl_pmu_idx(int cpu)
> topology_logical_die_id(cpu);
> }
>
> -static inline const struct cpumask *get_rapl_pmu_cpumask(int cpu)
> -{
> - return rapl_pmu_is_pkg_scope() ? topology_core_cpumask(cpu) :
> - topology_die_cpumask(cpu);
> -}
> -
> static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu)
> {
> unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu);
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pref/x86/rapl: Remove unused function
2024-12-04 23:56 ` Ian Rogers
@ 2024-12-05 7:44 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-12-05 7:44 UTC (permalink / raw)
To: Ian Rogers
Cc: linux-perf-users, linux-kernel, llvm, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Liang, Kan, Thomas Gleixner, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt
On Wed, Dec 04, 2024 at 03:56:03PM -0800, Ian Rogers wrote:
> On Mon, Dec 2, 2024 at 10:28 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > get_rapl_pmu_cpumask() is unused, it prevents kernel builds
> > with clang, `make W=1` and CONFIG_WERROR=y:
> >
> > arch/x86/events/rapl.c:165:37: error: unused function 'get_rapl_pmu_cpumask' [-Werror,-Wunused-function]
> >
> > Fix this by removing unused function.
> >
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
> >
> > Fixes: 9e9af8bbb5f9 ("perf/x86/rapl: Clean up cpumask and hotplug")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
>
> nit: s/pref/perf/ in the commit message title
Thanks, the analogue change is already in the perf tree. Just hadn't made the
rc1.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-05 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-02 18:28 [PATCH v1 1/1] pref/x86/rapl: Remove unused function Andy Shevchenko
2024-12-04 23:56 ` Ian Rogers
2024-12-05 7:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®