* [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT"
@ 2024-12-23 9:20 Xi Ruoyao
2025-01-11 10:09 ` Jiaxun Yang
2025-01-11 12:02 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Xi Ruoyao @ 2024-12-23 9:20 UTC (permalink / raw)
To: Jiaxun Yang, Thomas Bogendoerfer
Cc: linux-mips, linux-kernel, Xi Ruoyao, stable, Icenowy Zheng
This reverts commit 426fa8e4fe7bb914b5977cbce453a9926bf5b2e6.
The commit has caused two issues on Loongson 3A4000:
1. The timestamp in dmesg become erratic, like:
[3.736957] amdgpu 0000:04:00.0: ... ...
[3.748895] [drm] Initialized amdgpu ... ...
[18446744073.381141] amdgpu 0000:04:00:0: ... ...
[1.613326] igb 0000:03:00.0 enp3s0: ... ...
2. More seriously, some workloads (for example, the test
stdlib/test-cxa_atexit2 in the Glibc test suite) triggers an RCU
stall and hang the system with a high probably (4 hangs out of 5
tests).
Revert this commit to use jiffie on Loongson MIPS systems and fix these
issues for now. The root cause may need more investigation.
Cc: stable@vger.kernel.org # 6.11+
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Icenowy Zheng <icenowy@aosc.io>
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 467b10f4361a..5078ebf071ec 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1084,7 +1084,6 @@ config CSRC_IOASIC
config CSRC_R4K
select CLOCKSOURCE_WATCHDOG if CPU_FREQ
- select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT
bool
config CSRC_SB1250
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT"
2024-12-23 9:20 [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT" Xi Ruoyao
@ 2025-01-11 10:09 ` Jiaxun Yang
2025-01-11 12:02 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Jiaxun Yang @ 2025-01-11 10:09 UTC (permalink / raw)
To: Xi Ruoyao, Thomas Bogendoerfer
Cc: linux-mips, linux-kernel, stable, Icenowy Zheng
在2024年12月23日十二月 上午9:20，Xi Ruoyao写道：
> This reverts commit 426fa8e4fe7bb914b5977cbce453a9926bf5b2e6.
>
> The commit has caused two issues on Loongson 3A4000:
>
> 1. The timestamp in dmesg become erratic, like:
>
> [3.736957] amdgpu 0000:04:00.0: ... ...
> [3.748895] [drm] Initialized amdgpu ... ...
> [18446744073.381141] amdgpu 0000:04:00:0: ... ...
> [1.613326] igb 0000:03:00.0 enp3s0: ... ...
>
> 2. More seriously, some workloads (for example, the test
> stdlib/test-cxa_atexit2 in the Glibc test suite) triggers an RCU
> stall and hang the system with a high probably (4 hangs out of 5
> tests).
>
> Revert this commit to use jiffie on Loongson MIPS systems and fix these
> issues for now. The root cause may need more investigation.
>
> Cc: stable@vger.kernel.org # 6.11+
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: Icenowy Zheng <icenowy@aosc.io>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
It's indeed problematic in some scenarios.
Let's revert for now.
Thanks
- Jiaxun
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 467b10f4361a..5078ebf071ec 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1084,7 +1084,6 @@ config CSRC_IOASIC
>
> config CSRC_R4K
> select CLOCKSOURCE_WATCHDOG if CPU_FREQ
> - select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT
> bool
>
> config CSRC_SB1250
> --
> 2.47.1
--
- Jiaxun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT"
2024-12-23 9:20 [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT" Xi Ruoyao
2025-01-11 10:09 ` Jiaxun Yang
@ 2025-01-11 12:02 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2025-01-11 12:02 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: Jiaxun Yang, linux-mips, linux-kernel, stable, Icenowy Zheng
On Mon, Dec 23, 2024 at 05:20:41PM +0800, Xi Ruoyao wrote:
> This reverts commit 426fa8e4fe7bb914b5977cbce453a9926bf5b2e6.
>
> The commit has caused two issues on Loongson 3A4000:
>
> 1. The timestamp in dmesg become erratic, like:
>
> [3.736957] amdgpu 0000:04:00.0: ... ...
> [3.748895] [drm] Initialized amdgpu ... ...
> [18446744073.381141] amdgpu 0000:04:00:0: ... ...
> [1.613326] igb 0000:03:00.0 enp3s0: ... ...
>
> 2. More seriously, some workloads (for example, the test
> stdlib/test-cxa_atexit2 in the Glibc test suite) triggers an RCU
> stall and hang the system with a high probably (4 hangs out of 5
> tests).
>
> Revert this commit to use jiffie on Loongson MIPS systems and fix these
> issues for now. The root cause may need more investigation.
>
> Cc: stable@vger.kernel.org # 6.11+
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: Icenowy Zheng <icenowy@aosc.io>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 467b10f4361a..5078ebf071ec 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1084,7 +1084,6 @@ config CSRC_IOASIC
>
> config CSRC_R4K
> select CLOCKSOURCE_WATCHDOG if CPU_FREQ
> - select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT
> bool
>
> config CSRC_SB1250
> --
> 2.47.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-11 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-23 9:20 [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT" Xi Ruoyao
2025-01-11 10:09 ` Jiaxun Yang
2025-01-11 12:02 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®