[PATCH] init: Unnecessary braces around single line statment.

[PATCH] init: Unnecessary braces around single line statment.

[deaner92]

From: Jeremy Clifton <deaner92@yahoo.com>

Warning found with checkpatch.pl script. Removed unnecessary braces.

Signed-off-by: Jeremy Clifton <deaner92@yahoo.com>
---
 init/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/init/main.c b/init/main.c
index 00fac1170294..64034fce4c9e 100644
--- a/init/main.c
+++ b/init/main.c
@@ -398,9 +398,8 @@ static char * __init xbc_make_cmdline(const char *key)
 static int __init bootconfig_params(char *param, char *val,
 				    const char *unused, void *arg)
 {
-	if (strcmp(param, "bootconfig") == 0) {
+	if (strcmp(param, "bootconfig") == 0)
 		bootconfig_found = true;
-	}
 	return 0;
 }
 
-- 
2.43.0

Re: [PATCH] init: Unnecessary braces around single line statment.

[Markus Elfring]

> Warning found with checkpatch.pl script. Removed unnecessary braces.

1. An imperative wording can be more desirable for an improved change description.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94

2. Please avoid a typo in the summary phrase.

3. It is probably helpful to specify selected email addresses also in the message field “To”.


Regards,
Markus

Re: init: Unnecessary braces around single line statment.

[Markus Elfring]

>> 2. Please avoid a typo in the summary phrase.
>>
> I will need to resubmit another patch to the mailing list.

Yes, please.


> How do I close this one?

It will probably be noticed that you sent a subsequent patch version.


> Should I reference this in the new post with  'Fixes?'

Unlikely.

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n310

Regards,
Markus

Re: init: Unnecessary braces around single line statement

[Markus Elfring]

> So ask yourself whether such a change is really worth it.
Some change combinations can occasionally become more worthwhile,
can't they?

Regards,
Markus

Re: init: Unnecessary braces around single line statement

[Christophe Leroy]

Le 28/01/2025 à 09:45, Markus Elfring a écrit :
>> So ask yourself whether such a change is really worth it.
> Some change combinations can occasionally become more worthwhile,
> can't they?

Sure that change would be perfect as part of a series which modifies 
bootconfig_params(), but as a standalone change I can't see the benefit.

Re: init: Unnecessary braces around single line statement

[Petr Mladek]

On Tue 2025-01-28 09:59:08, Christophe Leroy wrote:
> 
> 
> Le 28/01/2025 à 09:45, Markus Elfring a écrit :
> > > So ask yourself whether such a change is really worth it.
> > Some change combinations can occasionally become more worthwhile,
> > can't they?
> 
> Sure that change would be perfect as part of a series which modifies
> bootconfig_params(), but as a standalone change I can't see the benefit.

I agree here:

1. Cosmetic changes just complicate merging branches with really
   useful changes. They are complicate backporting fixes to
   stable kernels.

2. Cosmetic changes are material for bikeshedding. Some people might
   prefer the original code because it is better readable for them...

3. The authors of cosmetic changes will not learn much by this.
   Also it will also not help much to gain any reputation.

Best Regards,
Petr

Re: init: Unnecessary braces around single line statement

[Markus Elfring]

…
> 3. The authors of cosmetic changes will not learn much by this.…

Would any contributors wonder how many efforts may be invested in coding style improvements
for selected software components?

Regards,
Markus