mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	emilio.lopez@collabora.co.uk,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Shuah Khan <shuah@kernel.org>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftest: sync: improve assert() failure message
Date: Tue, 13 Dec 2016 07:33:47 -0700	[thread overview]
Message-ID: <a0af9595-4322-7f72-8d14-d6bd7abcf0f2@kernel.org> (raw)
In-Reply-To: <1481636929-25738-1-git-send-email-gustavo@padovan.org>

On 12/13/2016 06:48 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> Print "ERROR" on all messages instead of using the not well defined terms
> like "BAD".
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> ---
>  tools/testing/selftests/sync/synctest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
> index 4e0e59f..e7d1d57 100644
> --- a/tools/testing/selftests/sync/synctest.h
> +++ b/tools/testing/selftests/sync/synctest.h
> @@ -32,7 +32,7 @@
>  
>  #define ASSERT(cond, msg) do { \
>  	if (!(cond)) { \
> -		printf("[BAD]\t%s", (msg)); \
> +		printf("[ERROR]\t%s", (msg)); \
>  		return 1; \
>  	} \
>  } while (0)
> 

Thanks, Applied to linux-kselftest next for 4.10-rc1

-- Shuah

      reply	other threads:[~2016-12-13 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 13:48 Gustavo Padovan
2016-12-13 14:33 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0af9595-4322-7f72-8d14-d6bd7abcf0f2@kernel.org \
    --to=shuah@kernel.org \
    --cc=emilio.lopez@collabora.co.uk \
    --cc=gustavo.padovan@collabora.com \
    --cc=gustavo@padovan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®