* [PATCH] selftest: sync: improve assert() failure message
@ 2016-12-13 13:48 Gustavo Padovan
2016-12-13 14:33 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Padovan @ 2016-12-13 13:48 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kernel, linux-kselftest, emilio.lopez, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.com>
Print "ERROR" on all messages instead of using the not well defined terms
like "BAD".
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
tools/testing/selftests/sync/synctest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
index 4e0e59f..e7d1d57 100644
--- a/tools/testing/selftests/sync/synctest.h
+++ b/tools/testing/selftests/sync/synctest.h
@@ -32,7 +32,7 @@
#define ASSERT(cond, msg) do { \
if (!(cond)) { \
- printf("[BAD]\t%s", (msg)); \
+ printf("[ERROR]\t%s", (msg)); \
return 1; \
} \
} while (0)
--
2.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] selftest: sync: improve assert() failure message
2016-12-13 13:48 [PATCH] selftest: sync: improve assert() failure message Gustavo Padovan
@ 2016-12-13 14:33 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2016-12-13 14:33 UTC (permalink / raw)
To: Gustavo Padovan
Cc: linux-kernel, linux-kselftest, emilio.lopez, Gustavo Padovan,
Shuah Khan, Shuah Khan
On 12/13/2016 06:48 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
>
> Print "ERROR" on all messages instead of using the not well defined terms
> like "BAD".
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> ---
> tools/testing/selftests/sync/synctest.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
> index 4e0e59f..e7d1d57 100644
> --- a/tools/testing/selftests/sync/synctest.h
> +++ b/tools/testing/selftests/sync/synctest.h
> @@ -32,7 +32,7 @@
>
> #define ASSERT(cond, msg) do { \
> if (!(cond)) { \
> - printf("[BAD]\t%s", (msg)); \
> + printf("[ERROR]\t%s", (msg)); \
> return 1; \
> } \
> } while (0)
>
Thanks, Applied to linux-kselftest next for 4.10-rc1
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-13 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-13 13:48 [PATCH] selftest: sync: improve assert() failure message Gustavo Padovan
2016-12-13 14:33 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®