From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 01/16] staging: rtl8723bs: Remove function pointer EFUSEGetEfuseDefinition
Date: Wed, 6 Nov 2024 19:33:30 +0100 [thread overview]
Message-ID: <a203a6b2558ea0af5811d8c5841b10b7bbf2e9ff.1730916582.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730916582.git.philipp.g.hortmann@gmail.com>
Remove function pointer EFUSEGetEfuseDefinition and use
Hal_GetEfuseDefinition directly to increase readability.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +--
drivers/staging/rtl8723bs/include/hal_intf.h | 3 ++-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index b6c655e6747e..b8023e9d7631 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -171,7 +171,7 @@ EFUSE_GetEfuseDefinition(
bool bPseudoTest
)
{
- padapter->HalFunc.EFUSEGetEfuseDefinition(padapter, efuseType, type, pOut, bPseudoTest);
+ Hal_GetEfuseDefinition(padapter, efuseType, type, pOut, bPseudoTest);
}
/*-----------------------------------------------------------------------------
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 2d2de56d5df7..8a4ebe645786 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -490,7 +490,7 @@ static u8 hal_EfuseSwitchToBank(
return bRet;
}
-static void Hal_GetEfuseDefinition(
+void Hal_GetEfuseDefinition(
struct adapter *padapter,
u8 efuseType,
u8 type,
@@ -1745,7 +1745,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
{
/* Efuse related function */
- pHalFunc->EFUSEGetEfuseDefinition = &Hal_GetEfuseDefinition;
pHalFunc->EfuseGetCurrentSize = &Hal_EfuseGetCurrentSize;
pHalFunc->Efuse_PgPacketRead = &Hal_EfusePgPacketRead;
pHalFunc->Efuse_PgPacketWrite = &Hal_EfusePgPacketWrite;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 2285e82ab7b2..a513721e763b 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -164,7 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
struct hal_ops {
void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
- void (*EFUSEGetEfuseDefinition)(struct adapter *padapter, u8 efuseType, u8 type, void *pOut, bool bPseudoTest);
u16 (*EfuseGetCurrentSize)(struct adapter *padapter, u8 efuseType, bool bPseudoTest);
int (*Efuse_PgPacketRead)(struct adapter *padapter, u8 offset, u8 *data, bool bPseudoTest);
int (*Efuse_PgPacketWrite)(struct adapter *padapter, u8 offset, u8 word_en, u8 *data, bool bPseudoTest);
@@ -290,4 +289,6 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset,
u16 _size_byte, u8 *pbuf, bool bPseudoTest);
+void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 type,
+ void *pOut, bool bPseudoTest);
#endif /* __HAL_INTF_H__ */
--
2.43.0
next prev parent reply other threads:[~2024-11-06 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 18:33 [PATCH 00/16] staging: rtl8723bs: Replace function pointers starting with EFUSEGetEfuseDefinition Philipp Hortmann
2024-11-06 18:33 ` Philipp Hortmann [this message]
2024-11-06 18:33 ` [PATCH 02/16] staging: rtl8723bs: Remove function pointer EfuseGetCurrentSize Philipp Hortmann
2024-11-06 18:33 ` [PATCH 03/16] staging: rtl8723bs: Remove unused function Efuse_PgPacketRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 04/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 05/16] staging: rtl8723bs: Remove unused function Efuse_PgPacketWrite Philipp Hortmann
2024-11-06 18:33 ` [PATCH 06/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketWrite Philipp Hortmann
2024-11-06 18:33 ` [PATCH 07/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketWrite_BT Philipp Hortmann
2024-11-06 18:33 ` [PATCH 08/16] staging: rtl8723bs: Remove unused function hal_EfusePgPacketWriteData Philipp Hortmann
2024-11-06 18:33 ` [PATCH 09/16] staging: rtl8723bs: Remove unused function hal_EfusePgPacketWriteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 10/16] staging: rtl8723bs: Remove unused function hal_EfusePartialWriteCheck Philipp Hortmann
2024-11-06 18:33 ` [PATCH 11/16] staging: rtl8723bs: Remove unused function hal_EfuseConstructPGPkt Philipp Hortmann
2024-11-06 18:33 ` [PATCH 12/16] staging: rtl8723bs: Remove unused function hal_EfusePgCheckAvailableAddr Philipp Hortmann
2024-11-06 18:33 ` [PATCH 13/16] staging: rtl8723bs: Remove function hal_EfusePgPacketWrite2ByteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 14/16] staging: rtl8723bs: Remove function hal_EfusePgPacketWrite1ByteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 15/16] staging: rtl8723bs: Remove unused function efuse_WordEnableDataRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 16/16] staging: rtl8723bs: Remove unused function Efuse_GetCurrentSize Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a203a6b2558ea0af5811d8c5841b10b7bbf2e9ff.1730916582.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®