mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 06/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketWrite
Date: Wed,  6 Nov 2024 19:33:35 +0100	[thread overview]
Message-ID: <e2d4cfd440651ed08952afccbb3e927c26927c77.1730916582.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730916582.git.philipp.g.hortmann@gmail.com>

Remove unused function pointer Efuse_PgPacketWrite and unused function
Hal_EfusePgPacketWrite.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 30 -------------------
 drivers/staging/rtl8723bs/include/hal_intf.h  |  1 -
 2 files changed, 31 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 13fe77f84cc9..432c2c0aa259 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1365,35 +1365,6 @@ static u8 hal_EfusePgPacketWriteData(
 	return true;
 }
 
-static s32 Hal_EfusePgPacketWrite(
-	struct adapter *padapter,
-	u8 offset,
-	u8 word_en,
-	u8 *pData,
-	bool bPseudoTest
-)
-{
-	struct pgpkt_struct targetPkt;
-	u16 startAddr = 0;
-	u8 efuseType = EFUSE_WIFI;
-
-	if (!hal_EfusePgCheckAvailableAddr(padapter, efuseType, bPseudoTest))
-		return false;
-
-	hal_EfuseConstructPGPkt(offset, word_en, pData, &targetPkt);
-
-	if (!hal_EfusePartialWriteCheck(padapter, efuseType, &startAddr, &targetPkt, bPseudoTest))
-		return false;
-
-	if (!hal_EfusePgPacketWriteHeader(padapter, efuseType, &startAddr, &targetPkt, bPseudoTest))
-		return false;
-
-	if (!hal_EfusePgPacketWriteData(padapter, efuseType, &startAddr, &targetPkt, bPseudoTest))
-		return false;
-
-	return true;
-}
-
 static bool Hal_EfusePgPacketWrite_BT(
 	struct adapter *padapter,
 	u8 offset,
@@ -1673,7 +1644,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
 {
 	/*  Efuse related function */
-	pHalFunc->Efuse_PgPacketWrite = &Hal_EfusePgPacketWrite;
 	pHalFunc->Efuse_WordEnableDataWrite = &Hal_EfuseWordEnableDataWrite;
 	pHalFunc->Efuse_PgPacketWrite_BT = &Hal_EfusePgPacketWrite_BT;
 
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index c320795f3fd4..34cd13e49d8f 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -164,7 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 struct hal_ops {
 	void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
 
-	int	(*Efuse_PgPacketWrite)(struct adapter *padapter, u8 offset, u8 word_en, u8 *data, bool bPseudoTest);
 	u8 (*Efuse_WordEnableDataWrite)(struct adapter *padapter, u16 efuse_addr, u8 word_en, u8 *data, bool bPseudoTest);
 	bool	(*Efuse_PgPacketWrite_BT)(struct adapter *padapter, u8 offset, u8 word_en, u8 *data, bool bPseudoTest);
 
-- 
2.43.0


  parent reply	other threads:[~2024-11-06 18:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 18:33 [PATCH 00/16] staging: rtl8723bs: Replace function pointers starting with EFUSEGetEfuseDefinition Philipp Hortmann
2024-11-06 18:33 ` [PATCH 01/16] staging: rtl8723bs: Remove function pointer EFUSEGetEfuseDefinition Philipp Hortmann
2024-11-06 18:33 ` [PATCH 02/16] staging: rtl8723bs: Remove function pointer EfuseGetCurrentSize Philipp Hortmann
2024-11-06 18:33 ` [PATCH 03/16] staging: rtl8723bs: Remove unused function Efuse_PgPacketRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 04/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 05/16] staging: rtl8723bs: Remove unused function Efuse_PgPacketWrite Philipp Hortmann
2024-11-06 18:33 ` Philipp Hortmann [this message]
2024-11-06 18:33 ` [PATCH 07/16] staging: rtl8723bs: Remove unused function Hal_EfusePgPacketWrite_BT Philipp Hortmann
2024-11-06 18:33 ` [PATCH 08/16] staging: rtl8723bs: Remove unused function hal_EfusePgPacketWriteData Philipp Hortmann
2024-11-06 18:33 ` [PATCH 09/16] staging: rtl8723bs: Remove unused function hal_EfusePgPacketWriteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 10/16] staging: rtl8723bs: Remove unused function hal_EfusePartialWriteCheck Philipp Hortmann
2024-11-06 18:33 ` [PATCH 11/16] staging: rtl8723bs: Remove unused function hal_EfuseConstructPGPkt Philipp Hortmann
2024-11-06 18:33 ` [PATCH 12/16] staging: rtl8723bs: Remove unused function hal_EfusePgCheckAvailableAddr Philipp Hortmann
2024-11-06 18:33 ` [PATCH 13/16] staging: rtl8723bs: Remove function hal_EfusePgPacketWrite2ByteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 14/16] staging: rtl8723bs: Remove function hal_EfusePgPacketWrite1ByteHeader Philipp Hortmann
2024-11-06 18:33 ` [PATCH 15/16] staging: rtl8723bs: Remove unused function efuse_WordEnableDataRead Philipp Hortmann
2024-11-06 18:33 ` [PATCH 16/16] staging: rtl8723bs: Remove unused function Efuse_GetCurrentSize Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2d4cfd440651ed08952afccbb3e927c26927c77.1730916582.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®