* [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
@ 2026-10-12 17:35 ` Adrian Ambrozewicz
2026-10-13 6:09 ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C Adrian Ambrozewicz
` (9 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:35 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, linux-gpio, devicetree, linux-kernel,
Greg Kroah-Hartman
Add the binding for a GPIO channel of an NVIDIA LSTP USB adapter. The
node is a child of the adapter's USB device or interface node, matched
to a channel the device reports by reg (the channel ID) and compatible
(the channel type).
The device firmware reports the number of lines and their names and
directions; the node adds line names, hogs and interrupt consumers. Pins
the firmware reports as LEDs are LEDs, not GPIO lines, and an optional
leds child node describes them.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
.../bindings/gpio/nvidia,lstp-gpio.yaml | 276 ++++++++++++++++++
MAINTAINERS | 7 +
2 files changed, 283 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
new file mode 100644
index 000000000000..4ca5081e509d
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
@@ -0,0 +1,276 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/nvidia,lstp-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA LSTP GPIO Channel
+
+maintainers:
+ - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+ - Donald Shannon <donalds@nvidia.com>
+
+description: |
+ GPIO controller channel on an NVIDIA LSTP USB device.
+
+ The number of GPIO lines and their default names and directions are
+ reported by the device firmware.
+
+ gpio-line-names overrides the firmware-reported pin names. The
+ gpio-controller and #gpio-cells properties let consumers (e.g.
+ gpio-leds, gpio-keys) reference the lines by phandle.
+
+ The channel is also an interrupt controller. A consumer may reference
+ a line through a *-gpios property and use it as an interrupt, or
+ reference it through interrupts-extended, or interrupt-parent and
+ interrupts, using the interrupt-controller and #interrupt-cells
+ properties. An interrupt line must be an input; the firmware-reported
+ pin direction is authoritative and is not changed at runtime.
+
+ GPIO hog child nodes are supported for boot-time pin configuration.
+
+ Pins the device firmware reports as LEDs are not GPIO lines; each is
+ an LED instead, named after the firmware pin name. An optional leds
+ child node describes some of them: their names, initial state, default
+ trigger, and a pattern the device plays on its own.
+
+ Because the controller sits behind USB, every line access is a USB
+ transaction that blocks until it completes. Consumers that need
+ non-blocking line access cannot use this controller.
+
+properties:
+ compatible:
+ const: nvidia,lstp-gpio
+
+ reg:
+ description: Channel ID reported by the device firmware.
+ maxItems: 1
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+ description: |
+ Two cells: pin number and flags.
+ Cell 0: GPIO pin offset (0-based).
+ Cell 1: GPIO flags (e.g. GPIO_ACTIVE_LOW).
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+ description: |
+ Two cells: GPIO line offset and trigger flags.
+ Cell 0: GPIO line offset (0-based), same numbering as #gpio-cells.
+ Cell 1: Trigger flags (see <dt-bindings/interrupt-controller/irq.h>).
+
+ gpio-line-names:
+ description: |
+ Optional list of human-readable names for each GPIO line.
+ Overrides the firmware-reported pin names. The number of entries
+ must not exceed the number of GPIO lines reported by firmware.
+ minItems: 1
+ maxItems: 255
+
+ leds:
+ type: object
+ description: |
+ LED pins of the channel. A pin the device firmware reports as an
+ LED is an LED whether or not it has a node here, and a node for a
+ pin the firmware does not report as an LED is ignored.
+
+ properties:
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ patternProperties:
+ "^led@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/leds/common.yaml#
+ unevaluatedProperties: false
+ description: |
+ One LED pin. The LED takes its name from label, or from color,
+ function and function-enumerator, instead of the firmware pin
+ name.
+
+ properties:
+ reg:
+ description: Pin number, in the channel's own pin numbering.
+ maxItems: 1
+
+ default-state:
+ description: |
+ Written to the device once, when the LED is set up, and "off"
+ when absent, as in leds/common.yaml. "keep" leaves the LED as
+ the device firmware set it; the device cannot report its
+ current state. Not written for a node with led-pattern.
+
+ led-pattern:
+ description: |
+ A pattern the device plays in a loop once the LED is set up.
+ Each entry is <brightness duration>: brightness from 0 to
+ 255, held or faded towards for duration milliseconds,
+ depending on the pin's firmware-reported LED mode. The
+ pattern is sent to the device once and played there without
+ further USB traffic. It must fit in a single request, which
+ for a device with 64-byte USB endpoints is ten entries; a
+ longer pattern is not sent.
+ minItems: 1
+ maxItems: 255
+ items:
+ items:
+ - description: Brightness
+ maximum: 255
+ - description: Duration in milliseconds
+
+ active-low: false
+ flash-max-microamp: false
+ flash-max-timeout-us: false
+ inactive-high-impedance: false
+ led-max-microamp: false
+ led-sources: false
+ max-brightness: false
+ panic-indicator: false
+ retain-state-shutdown: false
+ retain-state-suspended: false
+
+ required:
+ - reg
+
+ anyOf:
+ - required: [label]
+ - required: [function]
+
+ dependentSchemas:
+ led-pattern:
+ properties:
+ default-state: false
+ linux,default-trigger: false
+
+ required:
+ - "#address-cells"
+ - "#size-cells"
+
+ additionalProperties: false
+
+patternProperties:
+ "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
+ type: object
+ required:
+ - gpio-hog
+
+dependentRequired:
+ interrupt-controller: ["#interrupt-cells"]
+ "#interrupt-cells": [interrupt-controller]
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ /* Minimal: let firmware define pin count and names */
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio@3 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <3>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ };
+ - |
+ /* Override pin names and add a hog */
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio_ch: gpio@3 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <3>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names = "STATUS_LED", "ALERT_INT";
+
+ led-hog {
+ gpio-hog;
+ gpios = <0 0>;
+ output-high;
+ line-name = "status-led-hog";
+ };
+ };
+ };
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ /* Act as an interrupt controller for a consumer via interrupts-extended */
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio_irq_ch: gpio@3 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <3>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ key-alert {
+ label = "alert";
+ linux,code = <143>; /* KEY_WAKEUP */
+ /* Line 1 as a falling-edge interrupt source */
+ interrupts-extended = <&gpio_irq_ch 1 IRQ_TYPE_EDGE_FALLING>;
+ };
+ };
+ - |
+ #include <dt-bindings/leds/common.h>
+
+ /* Name two firmware-reported LED pins; one plays a pattern on its own */
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio@3 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <3>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@4 {
+ reg = <4>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_POWER;
+ default-state = "on";
+ };
+
+ led@5 {
+ reg = <5>;
+ color = <LED_COLOR_ID_AMBER>;
+ function = LED_FUNCTION_STATUS;
+ /* Two short flashes, then a pause */
+ led-pattern = <255 100>, <0 100>, <255 100>, <0 700>;
+ };
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 65e8a4b5c90b..284000589694 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19565,6 +19565,13 @@ L: linux-acpi@vger.kernel.org
S: Maintained
F: drivers/acpi/apei/ghes-nvidia.c
+NVIDIA LSTP USB ADAPTER DRIVERS
+M: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+M: Donald Shannon <donalds@nvidia.com>
+L: linux-usb@vger.kernel.org
+S: Supported
+F: Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
+
NVIDIA VRS RTC DRIVER
M: Shubhi Garg <shgarg@nvidia.com>
L: linux-tegra@vger.kernel.org
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO
2026-10-12 17:35 ` [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO Adrian Ambrozewicz
@ 2026-10-13 6:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 6:09 UTC (permalink / raw)
To: Adrian Ambrozewicz, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, linux-gpio, devicetree, linux-kernel,
Greg Kroah-Hartman
On 12/10/2026 19:35, Adrian Ambrozewicz wrote:
> Add the binding for a GPIO channel of an NVIDIA LSTP USB adapter. The
> node is a child of the adapter's USB device or interface node, matched
> to a channel the device reports by reg (the channel ID) and compatible
> (the channel type).
>
> The device firmware reports the number of lines and their names and
> directions; the node adds line names, hogs and interrupt consumers. Pins
> the firmware reports as LEDs are LEDs, not GPIO lines, and an optional
> leds child node describes them.
>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> .../bindings/gpio/nvidia,lstp-gpio.yaml | 276 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 283 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
> new file mode 100644
> index 000000000000..4ca5081e509d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
> @@ -0,0 +1,276 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/nvidia,lstp-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA LSTP GPIO Channel
> +
> +maintainers:
> + - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> + - Donald Shannon <donalds@nvidia.com>
> +
> +description: |
> + GPIO controller channel on an NVIDIA LSTP USB device.
What is LSTP?
> +
> + The number of GPIO lines and their default names and directions are
> + reported by the device firmware.
> +
> + gpio-line-names overrides the firmware-reported pin names. The
> + gpio-controller and #gpio-cells properties let consumers (e.g.
> + gpio-leds, gpio-keys) reference the lines by phandle.
Why are you describing the binding? This is pointless. Describe the
hardware.
> +
> + The channel is also an interrupt controller. A consumer may reference
> + a line through a *-gpios property and use it as an interrupt, or
What? Please read other bindings to understand what is here.
> + reference it through interrupts-extended, or interrupt-parent and
> + interrupts, using the interrupt-controller and #interrupt-cells
> + properties. An interrupt line must be an input; the firmware-reported
> + pin direction is authoritative and is not changed at runtime.
> +
> + GPIO hog child nodes are supported for boot-time pin configuration.
> +
> + Pins the device firmware reports as LEDs are not GPIO lines; each is
> + an LED instead, named after the firmware pin name. An optional leds
> + child node describes some of them: their names, initial state, default
> + trigger, and a pattern the device plays on its own.
> +
> + Because the controller sits behind USB, every line access is a USB
> + transaction that blocks until it completes. Consumers that need
> + non-blocking line access cannot use this controller.
> +
> +properties:
> + compatible:
> + const: nvidia,lstp-gpio
What is lstp?
> +
> + reg:
> + description: Channel ID reported by the device firmware.
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> + description: |
> + Two cells: pin number and flags.
> + Cell 0: GPIO pin offset (0-based).
> + Cell 1: GPIO flags (e.g. GPIO_ACTIVE_LOW).
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> + description: |
> + Two cells: GPIO line offset and trigger flags.
> + Cell 0: GPIO line offset (0-based), same numbering as #gpio-cells.
> + Cell 1: Trigger flags (see <dt-bindings/interrupt-controller/irq.h>).
> +
> + gpio-line-names:
> + description: |
> + Optional list of human-readable names for each GPIO line.
> + Overrides the firmware-reported pin names. The number of entries
> + must not exceed the number of GPIO lines reported by firmware.
> + minItems: 1
> + maxItems: 255
> +
> + leds:
> + type: object
> + description: |
> + LED pins of the channel. A pin the device firmware reports as an
> + LED is an LED whether or not it has a node here, and a node for a
> + pin the firmware does not report as an LED is ignored.
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^led@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/leds/common.yaml#
> + unevaluatedProperties: false
> + description: |
> + One LED pin. The LED takes its name from label, or from color,
> + function and function-enumerator, instead of the firmware pin
> + name.
> +
> + properties:
> + reg:
> + description: Pin number, in the channel's own pin numbering.
> + maxItems: 1
> +
> + default-state:
> + description: |
> + Written to the device once, when the LED is set up, and "off"
> + when absent, as in leds/common.yaml. "keep" leaves the LED as
> + the device firmware set it; the device cannot report its
> + current state. Not written for a node with led-pattern.
> +
> + led-pattern:
> + description: |
> + A pattern the device plays in a loop once the LED is set up.
> + Each entry is <brightness duration>: brightness from 0 to
> + 255, held or faded towards for duration milliseconds,
> + depending on the pin's firmware-reported LED mode. The
> + pattern is sent to the device once and played there without
> + further USB traffic. It must fit in a single request, which
> + for a device with 64-byte USB endpoints is ten entries; a
> + longer pattern is not sent.
> + minItems: 1
> + maxItems: 255
> + items:
> + items:
> + - description: Brightness
> + maximum: 255
> + - description: Duration in milliseconds
> +
> + active-low: false
> + flash-max-microamp: false
> + flash-max-timeout-us: false
> + inactive-high-impedance: false
> + led-max-microamp: false
> + led-sources: false
> + max-brightness: false
> + panic-indicator: false
> + retain-state-shutdown: false
> + retain-state-suspended: false
Why are you repeating all standard properties? Drop.
> +
> + required:
> + - reg
> +
> + anyOf:
> + - required: [label]
> + - required: [function]
I don't get why simple binding is made so complicated.
> +
> + dependentSchemas:
> + led-pattern:
> + properties:
> + default-state: false
> + linux,default-trigger: false
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> +
> + additionalProperties: false
> +
> +patternProperties:
> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> + type: object
> + required:
> + - gpio-hog
> +
> +dependentRequired:
> + interrupt-controller: ["#interrupt-cells"]
> + "#interrupt-cells": [interrupt-controller]
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + /* Minimal: let firmware define pin count and names */
> + interface {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio@3 {
> + compatible = "nvidia,lstp-gpio";
> + reg = <3>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
> + - |
> + /* Override pin names and add a hog */
> + interface {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio_ch: gpio@3 {
> + compatible = "nvidia,lstp-gpio";
> + reg = <3>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-line-names = "STATUS_LED", "ALERT_INT";
> +
> + led-hog {
> + gpio-hog;
> + gpios = <0 0>;
> + output-high;
> + line-name = "status-led-hog";
> + };
> + };
> + };
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + /* Act as an interrupt controller for a consumer via interrupts-extended */
> + interface {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio_irq_ch: gpio@3 {
> + compatible = "nvidia,lstp-gpio";
> + reg = <3>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + key-alert {
> + label = "alert";
> + linux,code = <143>; /* KEY_WAKEUP */
> + /* Line 1 as a falling-edge interrupt source */
> + interrupts-extended = <&gpio_irq_ch 1 IRQ_TYPE_EDGE_FALLING>;
> + };
> + };
Drop irrelevant. Keep only one complete example. Two if they are different.
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + /* Name two firmware-reported LED pins; one plays a pattern on its own */
> + interface {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio@3 {
> + compatible = "nvidia,lstp-gpio";
> + reg = <3>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@4 {
> + reg = <4>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_POWER;
> + default-state = "on";
> + };
> +
> + led@5 {
> + reg = <5>;
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_STATUS;
> + /* Two short flashes, then a pause */
> + led-pattern = <255 100>, <0 100>, <255 100>, <0 700>;
> + };
> + };
> + };
So that's the only example you should keep.
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
2026-10-12 17:35 ` [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-13 6:11 ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI Adrian Ambrozewicz
` (8 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, linux-i2c, devicetree, linux-kernel,
Greg Kroah-Hartman
Add the binding for an I2C controller channel of an NVIDIA LSTP USB
adapter. Peripherals on the bus are child nodes, as for any I2C
controller. The device sets the bus speed and the protocol cannot
change it, so clock-frequency is not supported.
nvidia,retries sets how many times the host re-issues a transfer that
failed on arbitration loss or a busy bus (default 3). The generic I2C
controller schema has no property for this. A device that reports its
own arbitration retries handles both cases itself, and the property is
ignored for it.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
.../bindings/i2c/nvidia,lstp-i2c.yaml | 71 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
new file mode 100644
index 000000000000..eacabed52cd1
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/nvidia,lstp-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA LSTP I2C Channel
+
+maintainers:
+ - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+ - Donald Shannon <donalds@nvidia.com>
+
+description: |
+ I2C controller channel on an NVIDIA LSTP USB device.
+
+ Peripherals on the bus are described as child nodes. An i2c alias
+ gives the bus a fixed number.
+
+ The bus speed is set by the device. The LSTP protocol has no way to
+ change it, so clock-frequency is not supported and is ignored.
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ const: nvidia,lstp-i2c
+
+ reg:
+ description: Channel ID reported by the device firmware.
+ maxItems: 1
+
+ nvidia,retries:
+ description: |
+ Number of times the host re-issues a transfer that fails on
+ arbitration loss or a busy bus before giving up.
+
+ Ignored when the channel config reports non-zero bus arbitration
+ retries. Such a device is expected to retry both arbitration loss and
+ a busy bus itself before reporting failure, so the host adds no
+ attempts on top.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 255
+ default: 3
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c@2 {
+ compatible = "nvidia,lstp-i2c";
+ reg = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ nvidia,retries = <5>;
+
+ temperature-sensor@48 {
+ compatible = "ti,tmp102";
+ reg = <0x48>;
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 284000589694..d8092f6d91b2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19571,6 +19571,7 @@ M: Donald Shannon <donalds@nvidia.com>
L: linux-usb@vger.kernel.org
S: Supported
F: Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
+F: Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
NVIDIA VRS RTC DRIVER
M: Shubhi Garg <shgarg@nvidia.com>
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C
2026-10-12 17:36 ` [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C Adrian Ambrozewicz
@ 2026-10-13 6:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 6:11 UTC (permalink / raw)
To: Adrian Ambrozewicz, Andi Shyti, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Donald Shannon, linux-usb, linux-i2c, devicetree, linux-kernel,
Greg Kroah-Hartman
On 12/10/2026 19:36, Adrian Ambrozewicz wrote:
> Add the binding for an I2C controller channel of an NVIDIA LSTP USB
> adapter. Peripherals on the bus are child nodes, as for any I2C
> controller. The device sets the bus speed and the protocol cannot
> change it, so clock-frequency is not supported.
>
> nvidia,retries sets how many times the host re-issues a transfer that
> failed on arbitration loss or a busy bus (default 3). The generic I2C
> controller schema has no property for this. A device that reports its
> own arbitration retries handles both cases itself, and the property is
> ignored for it.
>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> .../bindings/i2c/nvidia,lstp-i2c.yaml | 71 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
> new file mode 100644
> index 000000000000..eacabed52cd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
We do not use that tag. Drop it everywhere.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/nvidia,lstp-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA LSTP I2C Channel
> +
> +maintainers:
> + - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> + - Donald Shannon <donalds@nvidia.com>
> +
> +description: |
> + I2C controller channel on an NVIDIA LSTP USB device.
Say something useful.
> +
> + Peripherals on the bus are described as child nodes. An i2c alias
> + gives the bus a fixed number.
What are you describing here?
> +
> + The bus speed is set by the device. The LSTP protocol has no way to
> + change it, so clock-frequency is not supported and is ignored.
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + const: nvidia,lstp-i2c
> +
> + reg:
> + description: Channel ID reported by the device firmware.
> + maxItems: 1
> +
> + nvidia,retries:
You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.
> + description: |
> + Number of times the host re-issues a transfer that fails on
> + arbitration loss or a busy bus before giving up.
> +
> + Ignored when the channel config reports non-zero bus arbitration
> + retries. Such a device is expected to retry both arbitration loss and
> + a busy bus itself before reporting failure, so the host adds no
> + attempts on top.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 255
> + default: 3
> +
> +required:
> + - compatible
> + - reg
Incomplete, where are any resources? If you do not have any, then this
should be folded into the parent node.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + interface {
> + #address-cells = <1>;
> + #size-cells = <0>;
Why do you need that wrapping node and what is "interface"?
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
2026-10-12 17:35 ` [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-13 6:11 ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter Adrian Ambrozewicz
` (7 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, linux-spi, devicetree, linux-kernel,
Greg Kroah-Hartman
Add the binding for an SPI controller channel of an NVIDIA LSTP USB
adapter. Peripherals on the bus are child nodes, as for any SPI
controller. The firmware reports the number of chip selects and the bus
speed; only chip selects 0 and 1 can be addressed.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
.../bindings/spi/nvidia,lstp-spi.yaml | 68 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 69 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
diff --git a/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml b/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
new file mode 100644
index 000000000000..5a96faab9106
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/nvidia,lstp-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA LSTP SPI Channel
+
+maintainers:
+ - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+ - Donald Shannon <donalds@nvidia.com>
+
+description: |
+ SPI controller channel on an NVIDIA LSTP USB device.
+
+ Peripherals on the bus are described as child nodes. The number of
+ chip selects and the bus speed are reported by the device firmware;
+ only chip selects 0 and 1 can be addressed.
+
+allOf:
+ - $ref: /schemas/spi/spi-controller.yaml#
+
+properties:
+ compatible:
+ const: nvidia,lstp-spi
+
+ reg:
+ description: Channel ID reported by the device firmware.
+ maxItems: 1
+
+patternProperties:
+ "@[0-9a-f]+$":
+ type: object
+
+ properties:
+ reg:
+ description: Chip select.
+ maximum: 1
+
+ spi-max-frequency:
+ description: Must not exceed the speed reported by the device firmware.
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ interface {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ spi@1 {
+ compatible = "nvidia,lstp-spi";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <18750000>;
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index d8092f6d91b2..a45adf95d36d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19572,6 +19572,7 @@ L: linux-usb@vger.kernel.org
S: Supported
F: Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
F: Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
+F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
NVIDIA VRS RTC DRIVER
M: Shubhi Garg <shgarg@nvidia.com>
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI
2026-10-12 17:36 ` [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI Adrian Ambrozewicz
@ 2026-10-13 6:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 6:11 UTC (permalink / raw)
To: Adrian Ambrozewicz, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Donald Shannon, linux-usb, linux-spi, devicetree, linux-kernel,
Greg Kroah-Hartman
On 12/10/2026 19:36, Adrian Ambrozewicz wrote:
> Add the binding for an SPI controller channel of an NVIDIA LSTP USB
> adapter. Peripherals on the bus are child nodes, as for any SPI
> controller. The firmware reports the number of chip selects and the bus
> speed; only chip selects 0 and 1 can be addressed.
>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> .../bindings/spi/nvidia,lstp-spi.yaml | 68 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml b/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
> new file mode 100644
> index 000000000000..5a96faab9106
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
All comments apply here as well.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (2 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-13 6:13 ` Krzysztof Kozlowski
2026-10-13 6:17 ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 05/11] usb: misc: Add NVIDIA LSTP USB adapter driver Adrian Ambrozewicz
` (6 subsequent siblings)
10 siblings, 2 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, devicetree, linux-kernel
Add the binding for the NVIDIA LSTP USB adapter. The device multiplexes
SPI, I2C, GPIO, IPMI and UART channels over the bulk endpoints of one
interface and reports its channels itself, so it needs no device tree
to work. A node describes what the device cannot report: peripherals on
its buses, GPIO line names and hogs, and LEDs.
Channel nodes go under the device node or under the interface node, as
usb-device.yaml lays out for the device's descriptors. The GPIO, I2C
and SPI channels reference their own schemas. The IPMI and UART channel
nodes are defined here and carry only compatible, reg and status; they
exist for status = "disabled", which keeps a channel the firmware
reports from being used.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
.../devicetree/bindings/usb/nvidia,lstp.yaml | 280 ++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 281 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
diff --git a/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
new file mode 100644
index 000000000000..62b21051ab20
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
@@ -0,0 +1,280 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/nvidia,lstp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA LSTP USB Multi-Function Device
+
+maintainers:
+ - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+ - Donald Shannon <donalds@nvidia.com>
+
+description: |
+ The NVIDIA LSTP (Low-Speed Transport Protocol) device is a USB device
+ that exposes function channels (SPI, I2C, GPIO, IPMI, UART) over one USB
+ interface. Channel traffic is multiplexed over the bulk endpoints of
+ that interface.
+
+ The device reports its channels, their types and their IDs itself, so
+ it needs no device tree to work. A node adds only what the device
+ cannot report: peripherals on its SPI and I2C buses, GPIO line names
+ and hogs, and LEDs. As for any USB device, a node is matched to the
+ device by position alone, each level by the port number in reg, so a
+ node suits only an LSTP device hard-wired on the board.
+
+ Each channel node is matched to a firmware-reported channel by reg (the
+ channel ID) and compatible (the channel type). A channel without a node
+ is still usable. A channel whose node has status = "disabled" is not
+ used at all.
+
+ Where the channel nodes go follows the rules for USB device and
+ interface nodes in usb-device.yaml, which depend on the device's
+ descriptors and not on its compatible:
+
+ - A device of class 0 with one configuration and one interface has a
+ combined node. The channels go directly under the device node, which
+ has #address-cells = <1>.
+ - Any other device has an interface node for the LSTP interface,
+ interface@N with reg = <N C> (interface number, configuration value).
+ The channels go under it, and the device node has
+ #address-cells = <2>.
+
+ For interface 2, in configuration 1, of a device on port 3 of a hub on
+ root port 1, the path from the host controller node is hub@1, then the
+ device node with reg = <3>, then interface@2 with reg = <2 1>.
+
+ The reg of a node on a root-hub port, hub@1 here, is the host
+ controller's port number, which is not always the port number in the
+ USB path. On an xHCI controller it is the one-based index of the
+ port's register set, and the USB 2 and USB 3 ports share that one
+ numbering. A node on a port of an external hub uses the hub's port
+ number, as the USB path shows it.
+
+allOf:
+ - $ref: /schemas/usb/usb-device.yaml#
+ - $ref: "#/$defs/channels"
+ - if:
+ properties:
+ "#address-cells":
+ const: 1
+ then:
+ patternProperties:
+ "^interface@": false
+ else:
+ patternProperties:
+ "^(spi|i2c|gpio|serial|ipmi)@": false
+
+properties:
+ compatible:
+ enum:
+ - usb955,cf11
+ - usb424,4940
+ - usb174c,2214
+
+ reg:
+ description: Port number on the parent hub or host controller.
+ maxItems: 1
+
+ "#address-cells":
+ enum: [1, 2]
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^interface@[0-9a-f]{1,2}(,[0-9a-f]{1,2})?$":
+ type: object
+ description: |
+ Interface node for the interface that carries the LSTP channels. The
+ configuration component of the unit address is omitted for
+ configuration 1.
+
+ status = "disabled" disables the interface, and with it every
+ channel below it.
+
+ $ref: "#/$defs/channels"
+
+ properties:
+ compatible:
+ pattern: "^usbif[0-9a-f]{1,4},[0-9a-f]{1,4}\\.config[0-9a-f]{1,2}\\.[0-9a-f]{1,2}$"
+
+ reg:
+ description: Interface number, then configuration value.
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ required:
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+ unevaluatedProperties: false
+
+$defs:
+ channels:
+ patternProperties:
+ "^spi@[0-9a-f]+$":
+ $ref: /schemas/spi/nvidia,lstp-spi.yaml#
+
+ "^i2c@[0-9a-f]+$":
+ $ref: /schemas/i2c/nvidia,lstp-i2c.yaml#
+
+ "^gpio@[0-9a-f]+$":
+ $ref: /schemas/gpio/nvidia,lstp-gpio.yaml#
+
+ "^serial@[0-9a-f]+$":
+ type: object
+ description: |
+ UART channel.
+
+ The device firmware sets the baud rate, framing, parity and flow
+ control and reports them to the host; the host cannot change them.
+
+ properties:
+ compatible:
+ const: nvidia,lstp-uart
+
+ reg:
+ description: Channel ID reported by the device firmware.
+ maxItems: 1
+
+ required:
+ - compatible
+ - reg
+
+ additionalProperties: false
+
+ "^ipmi@[0-9a-f]+$":
+ type: object
+ description: |
+ IPMI message channel, on a device attached to a BMC. The device
+ firmware terminates the managed host's IPMI transport, passes each
+ request to the BMC over this channel and returns the BMC's response.
+
+ properties:
+ compatible:
+ const: nvidia,lstp-ipmi
+
+ reg:
+ description: Channel ID reported by the device firmware.
+ maxItems: 1
+
+ required:
+ - compatible
+ - reg
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Three interfaces; the LSTP channels are on interface 2. */
+ device@3 {
+ compatible = "usb955,cf11";
+ reg = <3>;
+ #address-cells = <2>;
+ #size-cells = <0>;
+
+ interface@2 {
+ compatible = "usbif955,cf11.config1.2";
+ reg = <2 1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ spi@1 {
+ compatible = "nvidia,lstp-spi";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <18750000>;
+ };
+ };
+
+ i2c@2 {
+ compatible = "nvidia,lstp-i2c";
+ reg = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ temperature-sensor@48 {
+ compatible = "ti,tmp102";
+ reg = <0x48>;
+ };
+ };
+
+ gpio@3 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <3>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names = "LED", "INT";
+ };
+
+ ipmi@4 {
+ compatible = "nvidia,lstp-ipmi";
+ reg = <4>;
+ };
+
+ serial@5 {
+ compatible = "nvidia,lstp-uart";
+ reg = <5>;
+ };
+ };
+ };
+ };
+ };
+
+ - |
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Class 0, one interface: a combined node carries the channels. */
+ device@2 {
+ compatible = "usb424,4940";
+ reg = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c@1 {
+ compatible = "nvidia,lstp-i2c";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ gpio@2 {
+ compatible = "nvidia,lstp-gpio";
+ reg = <2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index a45adf95d36d..3eaae7388a69 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19573,6 +19573,7 @@ S: Supported
F: Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
F: Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
+F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
NVIDIA VRS RTC DRIVER
M: Shubhi Garg <shgarg@nvidia.com>
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter
2026-10-12 17:36 ` [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter Adrian Ambrozewicz
@ 2026-10-13 6:13 ` Krzysztof Kozlowski
2026-10-13 6:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 6:13 UTC (permalink / raw)
To: Adrian Ambrozewicz, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, devicetree, linux-kernel
On 12/10/2026 19:36, Adrian Ambrozewicz wrote:
> Add the binding for the NVIDIA LSTP USB adapter. The device multiplexes
> SPI, I2C, GPIO, IPMI and UART channels over the bulk endpoints of one
> interface and reports its channels itself, so it needs no device tree
> to work. A node describes what the device cannot report: peripherals on
> its buses, GPIO line names and hogs, and LEDs.
>
> Channel nodes go under the device node or under the interface node, as
> usb-device.yaml lays out for the device's descriptors. The GPIO, I2C
> and SPI channels reference their own schemas. The IPMI and UART channel
> nodes are defined here and carry only compatible, reg and status; they
> exist for status = "disabled", which keeps a channel the firmware
> reports from being used.
>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> .../devicetree/bindings/usb/nvidia,lstp.yaml | 280 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 281 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
> new file mode 100644
> index 000000000000..62b21051ab20
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
> @@ -0,0 +1,280 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/nvidia,lstp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA LSTP USB Multi-Function Device
> +
> +maintainers:
> + - Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> + - Donald Shannon <donalds@nvidia.com>
> +
> +description: |
> + The NVIDIA LSTP (Low-Speed Transport Protocol) device is a USB device
> + that exposes function channels (SPI, I2C, GPIO, IPMI, UART) over one USB
> + interface. Channel traffic is multiplexed over the bulk endpoints of
> + that interface.
> +
> + The device reports its channels, their types and their IDs itself, so
> + it needs no device tree to work. A node adds only what the device
> + cannot report: peripherals on its SPI and I2C buses, GPIO line names
> + and hogs, and LEDs. As for any USB device, a node is matched to the
> + device by position alone, each level by the port number in reg, so a
> + node suits only an LSTP device hard-wired on the board.
> +
> + Each channel node is matched to a firmware-reported channel by reg (the
> + channel ID) and compatible (the channel type). A channel without a node
> + is still usable. A channel whose node has status = "disabled" is not
> + used at all.
> +
> + Where the channel nodes go follows the rules for USB device and
> + interface nodes in usb-device.yaml, which depend on the device's
> + descriptors and not on its compatible:
You again explain bindings. Description explains hardware, not repeats
schema.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter
2026-10-12 17:36 ` [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter Adrian Ambrozewicz
2026-10-13 6:13 ` Krzysztof Kozlowski
@ 2026-10-13 6:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 6:17 UTC (permalink / raw)
To: Adrian Ambrozewicz, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Donald Shannon, linux-usb, devicetree, linux-kernel
On 12/10/2026 19:36, Adrian Ambrozewicz wrote:
> + - $ref: /schemas/usb/usb-device.yaml#
> + - $ref: "#/$defs/channels"
> + - if:
> + properties:
> + "#address-cells":
> + const: 1
> + then:
> + patternProperties:
> + "^interface@": false
> + else:
> + patternProperties:
> + "^(spi|i2c|gpio|serial|ipmi)@": false
No, compatible, not presence of properties defines whether device has
SPI or not.
Also, allOf is placed after required, see other schemas or example-schema.
> +
> +properties:
> + compatible:
> + enum:
> + - usb955,cf11
> + - usb424,4940
> + - usb174c,2214
> +
> + reg:
> + description: Port number on the parent hub or host controller.
> + maxItems: 1
> +
> + "#address-cells":
> + enum: [1, 2]
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^interface@[0-9a-f]{1,2}(,[0-9a-f]{1,2})?$":
> + type: object
Your example is either incomplete or this is unnecessary. Assuming your
example is complete, then you have one interface, thus this node is
pointless. What's more, your top level compatible EXACTLY defines all
this, thus none of your properties are needed as they are implied by the
top-level compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 05/11] usb: misc: Add NVIDIA LSTP USB adapter driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (3 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 06/11] gpio: Add NVIDIA LSTP GPIO driver Adrian Ambrozewicz
` (5 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Donald Shannon, Jonathan Corbet, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Len Brown, Kees Cook, Gustavo A. R. Silva,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Hans de Goede, linux-usb, linux-kernel, linux-doc, linux-acpi,
linux-hardening, llvm, Sakari Ailus, Lixu Zhang,
Danilo Krummrich, driver-core
LSTP (Low-Speed Transport Protocol) is a vendor-specific USB interface
that multiplexes SPI, I2C, GPIO, UART, IPMI and MMIO channels over one
pair of bulk endpoints. The endpoint is an MCU, an FPGA or an ASIC; the
firmware decides which channels a device has, so the same VID:PID
carries different channels on different boards.
The core driver binds the interface, reads the channel table from
channel 0 and creates each channel as an auxiliary device,
lstp.<type>.<id>, for the function drivers that follow in this series.
It owns the URBs, packet framing, request/response matching and the
event path, and exports a small request API in the "LSTP" namespace
through include/linux/usb/lstp.h.
Responses carry no tag, so the first response after a request is its
answer. A response that arrives with no request waiting, or after the
waiting request already has its answer, is dropped and counted in the
channel's rx_late statistic, so it cannot overwrite a response the
waiter is still reading.
Before adding a channel, the core attaches its firmware node, if there
is one: a child of the interface's device tree node, or on ACPI a
Device() under the interface's Device(), which is a child of the port
companion. Channels match on their address (reg, or _ADR on ACPI) and
compatible. A _DSD data node, which has no _ADR, never matches.
Document the sysfs attributes, the driver API and the ACPI description,
and add a MAINTAINERS entry.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
.../ABI/testing/sysfs-bus-usb-devices-lstp | 331 ++
Documentation/driver-api/usb/index.rst | 1 +
Documentation/driver-api/usb/lstp.rst | 276 ++
Documentation/firmware-guide/acpi/index.rst | 1 +
Documentation/firmware-guide/acpi/lstp.rst | 419 +++
MAINTAINERS | 5 +
drivers/usb/misc/Kconfig | 15 +
drivers/usb/misc/Makefile | 1 +
drivers/usb/misc/lstp.c | 2983 +++++++++++++++++
include/linux/usb/lstp.h | 219 ++
10 files changed, 4251 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-bus-usb-devices-lstp
create mode 100644 Documentation/driver-api/usb/lstp.rst
create mode 100644 Documentation/firmware-guide/acpi/lstp.rst
create mode 100644 drivers/usb/misc/lstp.c
create mode 100644 include/linux/usb/lstp.h
diff --git a/Documentation/ABI/testing/sysfs-bus-usb-devices-lstp b/Documentation/ABI/testing/sysfs-bus-usb-devices-lstp
new file mode 100644
index 000000000000..6003ee77a866
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-bus-usb-devices-lstp
@@ -0,0 +1,331 @@
+What: /sys/bus/usb/devices/<intf>/lstp/name
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Name the device reported for this LSTP interface during
+ channel discovery. <intf> is the USB interface directory,
+ for example 1-1.2.2:1.2.
+
+What: /sys/bus/usb/devices/<intf>/lstp.<type>.<instance>/
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ A channel's auxiliary device, as seen from its parent USB
+ interface. This is the canonical location for a channel;
+ the same device is reachable on the auxiliary bus as
+ /sys/bus/auxiliary/devices/lstp.<type>.<instance>.
+
+ <type> is the channel's subsystem: spi, i2c, gpio, ipmi,
+ uart or mmio. <instance> is an auxiliary-bus instance number
+ drawn in channel-discovery order from a module-global pool
+ shared by every LSTP device in the system. It is fixed for
+ the life of the channel, including across an unbind and
+ rebind of its driver, and is drawn again when the interface
+ is probed afresh. It is not the firmware channel id <N> and
+ must not be parsed to obtain one: read the channel attribute
+ instead.
+
+ A firmware channel whose type the lstp core does not support
+ gets no auxiliary device, so a gap in the instance numbers
+ carries no meaning.
+
+ The directory exists for every channel of a supported type,
+ whether or not a driver ever bound to it, so its presence
+ is not a liveness signal. Read the driver symlink, or look
+ for the nested subsystem device, to tell a bound channel
+ from an offered one.
+
+What: /sys/bus/usb/devices/<intf>/lstp.<type>.<instance>/<subsys-device>
+What: /sys/bus/usb/devices/<intf>/lstp.<type>.<instance>/<class>/<subsys-device>
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ The Linux device the channel's driver created -- an SPI
+ controller, I2C adapter, GPIO chip, tty or misc device --
+ nested beneath the channel that owns it, either directly or
+ inside its class directory. This is the way to reach a
+ channel's underlying node.
+
+ Present only while a driver is bound to the channel, because
+ the bound driver is what creates the device. Treat its
+ absence as "not currently bound" rather than as a channel
+ that does not exist: it may be waiting for its driver, its
+ driver may have failed to probe, or it may have been unbound
+ by hand.
+
+ For the channel types backed by a character device the
+ class-device name is also the node name under /dev:
+ tty/ttyLSTP<line> is /dev/ttyLSTP<line> and misc/ipmi-lstp<n>
+ is /dev/ipmi-lstp<n>. A label property in an IPMI channel's
+ firmware node does not change the name.
+ LEDs are one level further down; see lstp.led.<instance>
+ below.
+
+ None of these numbers is the firmware channel id, and none
+ is stable. i2c-<busnr>, spi_master/spi<busnr> and
+ gpiochip<chipnr> are assigned by the subsystem core from its
+ own pool, and <line> and the <n> of the misc names by the
+ driver from its own, lowest free number first, each time the
+ driver binds. An unbind releases the number, or, if a file
+ descriptor is still open on the node, the last close does,
+ so a rebind takes another number while the old node is held
+ or once another channel has taken it. Use a device-tree i2c
+ or spi alias to pin an I2C or SPI bus number and a udev
+ symlink to pin any other name, or resolve it at runtime
+ through the channel.
+
+ The class device's own device link, and every walk up out of
+ it, resolves through the channel: /sys/class/<class>/<dev>/device
+ is the channel's auxiliary device (for LEDs see
+ lstp.led.<instance> below), and its parent is the USB
+ interface.
+
+What: /sys/bus/usb/devices/<intf>/lstp.gpio.<instance>/lstp.led.<instance>
+What: /sys/bus/usb/devices/<intf>/lstp.gpio.<instance>/lstp.led.<instance>/leds/<ledname>
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ The LED pins of a GPIO channel, on an auxiliary device the
+ GPIO channel's driver creates for the LED driver when the
+ device firmware reports any. <instance> is the GPIO channel's
+ own. It is present while a driver is bound to the GPIO
+ channel. It is also listed on the auxiliary bus, as
+ /sys/bus/auxiliary/devices/lstp.led.<instance>, but led is
+ not a channel <type>: the device has none of the channel
+ attributes.
+
+ Each pin registers one LED class device, leds/<ledname>, with
+ /sys/class/leds/<ledname> linking to it. <ledname> is the
+ firmware node's label, or its color and function, when a
+ leds node under the channel's firmware node describes the pin,
+ and the firmware pin name otherwise. The LED core adds a
+ numbered suffix to a name that is already taken.
+ /sys/class/leds/<ledname>/device is this auxiliary device, and
+ its parent is the GPIO channel.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/name
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Name of the channel, built from the interface name and the
+ channel name the device reported. This is the stable
+ identifier for a channel; the Linux device names underneath
+ it are not stable across boots or hotplug.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/channel
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Firmware channel index of this channel, the <N> the device
+ itself uses. Read it to recover a channel's firmware index
+ when starting from the auxiliary device directory, whose
+ <instance> suffix is unrelated to <N>.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/enable
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Whether the device has this channel enabled. Reading
+ queries the device; writing 0 or 1 asks the device to
+ disable or enable the channel. A channel that is disabled
+ does not carry traffic. The setting is part of the device's
+ stored channel configuration and may persist across resets
+ and power cycles. Either direction exchanges packets on
+ control channel 0, so polling this attribute advances the
+ interface counters under lstp/statistics/.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Directories of read-only counters. Every counter starts at
+ zero when the interface is probed and only increases; there
+ is no way to reset one, so a rate is obtained by sampling
+ twice and subtracting. The counters under lstp/statistics/
+ describe the USB bulk endpoints, which all channels share,
+ while those under a channel describe that channel's LSTP
+ request and response exchanges.
+
+ The two levels do not add up. An interface counter covers
+ every packet on the endpoint, including traffic on the
+ control channel 0, which has no directory of its own, and
+ packets that no channel accepted. Expect the interface
+ totals to exceed the sum of the per-channel ones.
+
+ The driver takes no action of its own based on any counter.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_packets
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of packets received successfully on the bulk endpoint
+ shared by every channel of this interface.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_errors
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of received packets discarded as malformed, because
+ the length or channel field did not describe a usable LSTP
+ packet. A device whose firmware disagrees with the driver
+ about the wire format shows up here.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_no_channel
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of well-formed packets discarded because they named a
+ channel that is not registered. This indicates the device
+ and the driver disagree about which channels exist, rather
+ than a problem with the transfer itself.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_urb_errors
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of receive transfers that completed with an error,
+ excluding the errors expected while the device is being
+ disconnected. Sustained growth points at the USB link rather
+ than at any one channel.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_stalls
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of times the receive endpoint was found halted and
+ the driver attempted to clear the halt before receiving
+ again. Counted when the halt is detected, so an attempt
+ that fails to clear it still counts and is logged.
+
+What: /sys/bus/usb/devices/<intf>/lstp/statistics/rx_retries
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of attempts made to resubmit the receive transfer
+ after a failure. Because retries are spaced by a growing
+ backoff, a large value alongside a small rx_packets means
+ the interface is spending its time recovering rather than
+ carrying traffic.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/tx_packets
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of requests this channel handed to the host
+ controller, both request/response exchanges and one-way
+ sends. Responses the driver returns for device-initiated
+ events are not requests and are not counted. Serves as the
+ denominator for timeouts and errors, which apply only to
+ exchanges that expect a response.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/rx_packets
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of responses this channel received and accepted,
+ meaning the response reported success and was long enough to
+ satisfy the request that asked for it. Only counts replies to
+ requests the driver sent; traffic the device originates is
+ counted by rx_events instead.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/rx_events
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of unsolicited packets the device sent on this channel
+ that were delivered to the subsystem, as opposed to answering
+ a request from the host. Channels whose inbound data arrives
+ this way, such as UART receive or a GPIO interrupt event,
+ show their traffic here and not in rx_packets. Stays at zero
+ for a channel that the device never originates traffic on.
+
+ This is the denominator for the unsolicited share of
+ rx_dropped: comparing the two tells whether losses are
+ occasional or routine.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/timeouts
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of requests that reached the wire but drew no
+ response before the driver stopped waiting. Together with
+ errors this separates a device that has gone quiet from one
+ that is answering and reporting failures. Requests abandoned
+ because the interface is being torn down or the channel's
+ driver is unbinding are not counted here.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/errors
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of responses rejected because the device reported a
+ failure status, or because the response was too short to
+ satisfy the request. The device is reachable in both cases;
+ see the driver logs to tell the two apart.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/tx_errors
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of requests that did not reach the device, because
+ the host controller refused the submission or a one-way
+ send failed to complete. These requests never had a
+ response to wait for, so they are not counted in timeouts
+ or errors. Requests abandoned because the interface is
+ being torn down are not counted here either.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/rx_dropped
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of packets addressed to this channel that it could
+ not accept: an unsolicited request arrived while the previous
+ one was still being handled, no driver was bound to the
+ channel to receive it, or the channel does not handle the
+ kind of packet that arrived. Read it against rx_events to
+ judge how much of the device's unsolicited traffic is being
+ lost. A channel deliberately left unbound accumulates drops
+ here with nothing wrong.
+
+What: /sys/bus/auxiliary/devices/lstp.<type>.<instance>/statistics/rx_late
+Date: October 2026
+KernelVersion: 7.5
+Contact: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
+Description:
+ Number of responses that arrived after the request waiting
+ for them had already timed out, and found no other request
+ waiting, or that arrived while a request was waiting but
+ after it already had its answer. Growth here alongside
+ timeouts means the device is answering more slowly than the
+ driver waits, rather than not answering at all. Growth
+ without timeouts points at surplus responses: a device that
+ answers a request twice, or a response left over from
+ before the driver was bound.
+
+ A lower bound, not a count of every late response. Nothing
+ on the wire ties a response to the request that asked for
+ it, so a late response that arrives while a subsequent
+ request is outstanding is delivered to that request instead
+ and is not counted here.
diff --git a/Documentation/driver-api/usb/index.rst b/Documentation/driver-api/usb/index.rst
index a32819963b99..5a0bbeacbc7f 100644
--- a/Documentation/driver-api/usb/index.rst
+++ b/Documentation/driver-api/usb/index.rst
@@ -22,3 +22,4 @@ Linux USB API
typec
typec_bus
usb3-debug-port
+ lstp
diff --git a/Documentation/driver-api/usb/lstp.rst b/Documentation/driver-api/usb/lstp.rst
new file mode 100644
index 000000000000..f192e2ccfa7a
--- /dev/null
+++ b/Documentation/driver-api/usb/lstp.rst
@@ -0,0 +1,276 @@
+.. SPDX-License-Identifier: GPL-2.0-only
+.. SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+
+==================================
+NVIDIA LSTP USB channel framework
+==================================
+
+The LSTP core driver binds the USB interface of an LSTP device, reads the
+channel descriptors through channel 0, and offers each channel of a supported
+type to the auxiliary bus. A subsystem driver (GPIO, I2C, SPI, UART, ...)
+binds that auxiliary device and does its I/O through the helpers declared in
+``include/linux/usb/lstp.h``.
+
+The core is the ``lstp`` module. Each subsystem driver is a module of its own
+on the auxiliary bus: ``gpio-lstp``, ``i2c-lstp``, ``spi-lstp``, ``lstp_tty``
+and ``ipmi-lstp`` bind the ``lstp.<type>.<n>`` devices the core adds. A GPIO
+channel's LED pins are a sub-device, ``lstp.led.<n>``, which ``gpio-lstp``
+adds and owns below its own device and ``leds-lstp`` binds. Each module loads
+on demand from its devices' modaliases.
+
+This document describes three rules those drivers rely on and the code
+comments point to: how long a channel lives, when its I/O is refused, and how
+it gets a firmware node. It ends with the limits of the packet handling.
+
+
+Channel lifetime and pins
+=========================
+
+Each channel of a supported type lives in a private container,
+``struct lstp_channel_priv``, that embeds the channel's auxiliary device. The
+reference count of that device owns the container, which
+``lstp_channel_dev_release()`` frees on the last put. Channel 0 and channels
+of a type the driver does not implement never get an initialised auxiliary
+device (``LSTP_AUXDEV_RAW``); they are freed when the USB interface is
+unbound.
+
+A subsystem whose state can outlive the bind behind a userspace handle (an
+open file descriptor, a queued tty) pins the channel with
+lstp_channel_get() when it creates that state, and drops the pin with
+lstp_channel_put() when it frees it, from its own code. While a pin is held
+the container, and with it the fence the I/O helpers test, stays valid after
+the USB device is gone and the subsystem driver has been unbound: the channel
+can still be inspected, and every lstp_send() and lstp_request*() on it fails
+with ``-ENODEV`` rather than touching freed state.
+
+A pin does not keep I/O refused. An unbind raises the fence only until the
+next bind lowers it, so state that outlives its bind refuses I/O through a
+per-bind flag of its own, raised at teardown and never cleared. That state is
+reached through the handle, never through ``lstp_channel.priv``, which the
+core clears when the driver unbinds.
+
+Only a channel offered to a subsystem can be pinned: lstp_channel_get()
+returns ``NULL`` for a ``LSTP_AUXDEV_RAW`` channel, whose embedded device was
+never initialised, and lstp_channel_put() ignores one the same way; both
+warn once.
+
+
+The I/O fence
+=============
+
+A channel is fenced while either of two flags in its container is set;
+lstp_channel_disconnected() reports it. A fenced channel refuses lstp_send()
+and lstp_request*() with ``-ENODEV`` under the channel's TX mutex, wakes
+response waiters with ``-ENODEV``, and refuses a bind in ``lstp_aux_probe()``.
+The fence frees nothing: a pinned container stays valid.
+
+``gone``
+ The permanent half: the device is not coming back. Raised by
+ ``lstp_channel_mark_gone()``, from the teardown path and from RX completion
+ (atomic) once the URB reports the device or HCD away. Never cleared.
+
+``unbound``
+ The half a bind clears, so an unbind and rebind resume I/O on a device still
+ present. Raised by ``lstp_channel_mark_unbound()``, from the channel's
+ devres unwind, or from the bus notifier's BIND arm when it could not book
+ that unwind. Cleared by the BIND arm, the edge before ``.probe()``, so a
+ probe can reach its own channel. False from creation until the first bind,
+ which keeps channel 0 usable for discovery config reads: channel 0 is never
+ offered to the bus, so it never binds.
+
+The two are separate so that a bind edge cannot un-fence a channel whose
+device has already departed. Both are stored with ``smp_store_release()``;
+lstp_channel_disconnected() reads them with the paired ``smp_load_acquire()``.
+
+Unbind
+------
+
+The BIND arm books ``lstp_channel_quiesce_unbound()`` as devres on the
+channel's auxiliary device before ``.probe()``, so it lands at the tail of the
+driver's own unwind on every edge. No notifier arm can do it: the driver core
+reports ``BUS_NOTIFY_DRIVER_NOT_BOUND`` before ``device_unbind_cleanup()`` and
+``BUS_NOTIFY_UNBOUND_DRIVER`` after it, so a failed probe would be fenced
+mid-release, and a release that does LSTP I/O, as led_classdev_unregister()
+does when it writes ``LED_OFF``, would get ``-ENODEV``.
+
+``lstp_channel_quiesce_unbound()`` raises ``unbound``, takes the TX mutex so
+that a request that passed the fence finishes, and kills both TX URBs under
+it. If ``gone`` is already up it kills nothing and leaves the URBs to
+interface teardown, which frees them without the channel device's lock: an
+unbind on the auxiliary bus does not take the USB interface's lock, so the
+two can run at once. The TX mutex orders the two sides, because teardown
+raises ``gone`` before it takes each channel's TX mutex and frees the URBs
+only after that. The TX mutex covers only the request URB as a submitter.
+The IRQ response URB has two submitters: the ``irq_packet`` upcall, which
+cannot run by then (UNBIND retracted dispatch, BOUND never published it, or
+interface teardown poisoned RX), and the core's ``LSTP_NACK`` from the RX
+completion, which can. A NACK that meets the kill fails, and one sent after
+it completes on its own; the URB and its buffer are interface devres, so
+teardown kills the URB before freeing either. The URBs are killed and not
+poisoned: poison rejects submissions for the life of the URB and would leave
+the channel dead across a rebind.
+
+A request the device sends while no driver takes it (none bound yet, or
+dispatch retracted) is dropped. On a UART channel the device waits for the
+answer to each such write, so the core answers it with ``LSTP_NACK`` and the
+device retries; it does so only once the channel's auxiliary device has been
+added, when its response slot exists, and not once the USB device is gone.
+GPIO and IPMI events take no response. So while no driver is bound to a UART
+channel (before ``lstp_tty`` loads, or after it is removed or unbound), every
+write the device sends is NACKed and counted in the channel's ``rx_dropped``.
+The device's retry pacing, which the specification leaves open, sets the
+rate.
+
+Two teardowns are not reported by the bus:
+
+- Under ``CONFIG_DEBUG_TEST_DRIVER_REMOVE``, ``really_probe()`` runs
+ ``.remove()`` and ``device_unbind_cleanup()`` after a successful probe and
+ then re-probes, emitting no BOUND, UNBIND or UNBOUND. The devres fence fires
+ in that unwind and the second BIND lifts it.
+
+- Interface teardown unregisters the notifier before the channel that
+ registered it is deleted, so that channel's delete reports nothing. RX is
+ already poisoned, and nothing reads the channel's ``priv`` after the delete.
+
+Disconnect
+----------
+
+``lstp_teardown()`` runs on USB disconnect and on the probe error path, since
+the USB core does not call ``.disconnect()`` after a failed probe. It stops RX
+before any channel driver's ``.remove()`` can run, raises ``gone`` on every
+channel, takes and drops each channel's TX mutex so that a caller
+mid-submission finishes, and poisons the TX URBs.
+
+That drain only covers callers already inside the framework. Subsystem
+teardown runs later, against a channel whose framework buffers are already
+freed: they are interface devres nodes registered after
+``lstp_channel_destroy_action()``, so they unwind first. What keeps a
+teardown-time write off a freed buffer is the fence raised here, which the
+public I/O helpers test under the TX mutex and refuse on. A teardown step that
+reaches channel state without them has no such protection.
+
+The TX URB of a fenced request
+------------------------------
+
+Outside the fence, every request retires its TX URB before returning, even on
+success. Nothing on the wire ties a response to its request, so a response
+left over from a request that already timed out is taken for this one's
+answer, and it can arrive before this request's own transfer completes, since
+the device has not seen it yet. The next request reuses the URB and refills
+the TX buffer, so the URB has to retire first: otherwise ``usb_submit_urb()``
+refuses it as still active, and the refill rewrites a buffer still on the
+wire.
+
+On a fenced channel the URB is deliberately left queued, whether the request
+timed out or completed: ``usb_kill_urb()`` blocks until the URB retires and
+can be reached holding a lock teardown waits on (gpiolib's SRCU section),
+which wedges teardown under load. ``lstp_channel_quiesce_unbound()`` reclaims
+it at unbind, and once ``gone`` is up it yields to interface teardown, where
+``lstp_stop_tx()`` and the devres release of the URB reclaim it. The test is
+the fence and not whether the USB device is gone: the fence is also what
+stops the next request from resubmitting the URB, and the device already
+reads as gone before ``.disconnect()`` raises the fence.
+
+
+Firmware nodes
+==============
+
+A channel's firmware node is optional. Channels are discovered from the
+device at probe time; a node only attaches properties to a channel or
+describes devices behind it. Channel nodes are children of a per-interface
+node, which ``lstp_find_intf_fwnode()`` resolves once per probe;
+``lstp_init_channel_fwnode()`` then matches each channel among its children
+on its address (the channel ID) and ``compatible``. The address is ``reg`` on
+device tree and software nodes and ``_ADR`` on ACPI
+(``lstp_fwnode_read_address()``). The fwnode property accessors read device
+tree, ACPI and software nodes alike. A channel that firmware does not
+describe gets no node and comes up with no firmware properties.
+
+The bindings are in ``Documentation/devicetree/bindings/usb/nvidia,lstp.yaml``; the ACPI
+spelling is in ``Documentation/firmware-guide/acpi/lstp.rst``.
+
+The interface node
+------------------
+
+Device tree
+ The node the USB core attached to the interface in
+ ``usb_set_configuration()``: an ``interface@N`` node with a two-cell
+ ``reg``, or the device node itself on a device with a combined node. It is
+ taken as the core resolved it rather than re-matched, so the driver sees
+ exactly what every other consumer of the interface's ``of_node`` sees.
+
+ Two layouts leave every channel of the interface silently undescribed, and
+ ``lstp_check_of_layout()`` warns about both. An interface node with a
+ one-cell ``reg``: ``usb_of_get_interface_node()`` reads two cells, so the
+ core attaches nothing to the interface. And channels wrapped in an interface
+ node on a device with a combined node (``usb_of_has_combined_node()``): the
+ core hands the interface the device node itself, so channel nodes belong
+ directly under it.
+
+ACPI and software nodes
+ The interface has no companion of its own, since the core hands it the
+ device's (for ACPI, the port object), so the interface node is the child of
+ that node whose address is ``bInterfaceNumber``.
+
+ On ACPI the address is the full 64-bit ``_ADR`` of a ``Device()``, read
+ with ``acpi_get_local_u64_address()`` and compared with the interface
+ number or channel ID as it is; ``reg`` is not read. A ``_DSD`` data node
+ has no ``_ADR`` and never matches. ``lstp_check_acpi_data_node()`` warns
+ once per probe about each data node among the interface object's children,
+ and among the port object's children when no interface object matched.
+
+Channel nodes
+-------------
+
+On device tree every child is considered, disabled or not, so that a channel
+whose node is marked ``status = "disabled"`` is found and then not created.
+``fwnode_for_each_child_node()`` would skip it
+(``of_get_next_available_child()``), and the channel would come up
+undescribed instead. A disabled node means the channel is not created at all,
+as for an MFD cell or a USB interface. This is logged at info level, as the
+USB core logs a disabled interface, because the channel is otherwise simply
+absent.
+
+Everywhere else the generic fwnode iterator walks ACPI and software nodes.
+On ACPI it returns ``_DSD`` data nodes as well as ``Device()`` objects, and
+a data node never matches. Where the ACPI walk is
+``acpi_get_next_present_subnode()``, it also skips a ``Device()`` whose
+``_STA`` reports it absent.
+
+No match is both the ordinary answer and what a wrong address or a misspelled
+``compatible`` produce (and, where the ACPI walk filters on ``_STA``, an
+absent device), so the outcome is only logged at debug level.
+
+A ``_DSD`` data node could not stand in for a channel even if it matched: it
+has no ACPI companion, so ACPI-enumerated children and ACPI references to the
+channel would never resolve.
+
+Reference ownership
+-------------------
+
+The match is stored in ``lstp_channel.fwnode``, which the core hands to the
+channel's auxiliary device with ``device_set_node()`` before adding it. That
+takes no reference of its own: the channel owns the single reference and
+drops it in ``lstp_channel_free()``. A subsystem that points another device
+at the node must not put it.
+
+
+Limitations
+===========
+
+LSTP Specification 1.0 lets a device pack several LSTP packets into one USB
+transfer, spread one packet over several, and describe more than 255 GPIOs
+with further config blocks. The drivers support none of these. The core takes
+one packet from each transfer and ignores the bytes after its payload, and
+rejects a packet that claims more payload than one transfer holds;
+``gpio-lstp`` reads a channel's first config block only, so at most 255 GPIOs.
+The host's own requests are sized so that each response fits one transfer.
+
+
+Subsystem driver API
+====================
+
+.. kernel-doc:: include/linux/usb/lstp.h
+
+.. kernel-doc:: drivers/usb/misc/lstp.c
+ :export:
diff --git a/Documentation/firmware-guide/acpi/index.rst b/Documentation/firmware-guide/acpi/index.rst
index db9eb7229948..f82759d02092 100644
--- a/Documentation/firmware-guide/acpi/index.rst
+++ b/Documentation/firmware-guide/acpi/index.rst
@@ -30,3 +30,4 @@ ACPI Support
extcon-intel-int3496
intel-pmc-mux
chromeos-acpi-device
+ lstp
diff --git a/Documentation/firmware-guide/acpi/lstp.rst b/Documentation/firmware-guide/acpi/lstp.rst
new file mode 100644
index 000000000000..536e22fcada2
--- /dev/null
+++ b/Documentation/firmware-guide/acpi/lstp.rst
@@ -0,0 +1,419 @@
+.. SPDX-License-Identifier: GPL-2.0-only
+.. SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+
+==========================================
+NVIDIA LSTP USB Multi-Function Device ACPI
+==========================================
+
+This is the ACPI spelling of the description in
+``Documentation/devicetree/bindings/usb/nvidia,lstp.yaml``. The driver reads both through
+the same fwnode property accessors, so the properties, their names and
+their meanings are identical. What differs is the syntax, the placement
+in the namespace, and the address of an interface or channel, which ACPI
+gives as ``_ADR`` where device tree has ``reg``. Read the device tree
+binding for what the properties mean, and this document for how to write
+them in ASL.
+
+Static description is optional. Channels are discovered from firmware at
+probe time and work with no ACPI or device tree description at all. It is
+needed only to attach properties to a channel (GPIO line names, LED names)
+or to declare devices sitting behind an I2C or SPI channel.
+
+
+Where the objects go
+====================
+
+An LSTP channel object is found by walking down from the USB device's ACPI
+companion. For a USB device on a port, that companion is the *port*
+object, not an object of its own: ``usb_acpi_find_companion_for_device()``
+in ``drivers/usb/core/usb-acpi.c`` returns the companion of the port the
+device is attached to, which ``acpi_find_child_by_adr()`` matches by
+``_ADR``.
+
+So the interface objects are children of the port object. This is the
+namespace for a device at ``1-1.3:1.2`` -- interface 2 of the device on
+port 3 of a hub attached to root-hub port 1, the same device the device
+tree binding example uses::
+
+ Device (XHCI) // host controller
+ Device (RHUB) // root hub, _ADR = 0
+ Device (PRT1) // root-hub port 1, _ADR = raw port
+ Device (PRT3) // hub port 3, _ADR = 3
+ Device (IFC2) // interface, _ADR = 2
+ Device (CHN1) // channel, _ADR = 1
+ Device (CHN2) // channel, _ADR = 2
+
+Interface and channel objects are identified by ``_ADR``, as the port
+objects above them are: an interface object's ``_ADR`` is its
+``bInterfaceNumber``, and a channel object's is its channel ID. Do not use
+``_HID`` instead -- that would advertise the object for driver binding,
+which is not what these are.
+
+Earlier versions of this driver ignored ``_ADR`` on these objects and
+matched them on a ``reg`` property in their ``_DSD`` instead, with
+``_ADR`` set to the same value only so the table compiles. Tables
+written to that rule keep working unchanged, since their ``_ADR`` is the
+address. The driver does not read ``reg`` on an ACPI object, so a table
+that also has to work with those earlier versions may keep it, set to the
+same value as ``_ADR``. An object whose ``_ADR`` and ``reg`` differ was
+matched on ``reg`` by those versions and is matched on ``_ADR`` now.
+
+An LSTP device plugged straight into a root-hub port has one level less:
+the interface objects hang off that port object directly. The nesting
+above exists because the device is behind an external hub, and each hub
+level gets a port object of its own.
+
+This is the one structural difference from device tree, where the USB
+device has a node of its own between the hub and the interface node. The
+device-level ``compatible = "usb955,cf11"`` has no ACPI counterpart
+because nothing in the match path reads it; the device is identified by
+USB descriptors either way. For the same reason the device tree's
+combined node does not apply here: a device with a single interface still
+gets an interface object, with ``_ADR`` = 0.
+
+Object names (``IFC2``, ``CHN1``) are arbitrary. Only ``_ADR`` and the
+``_DSD`` properties below take part in matching.
+
+
+Properties
+==========
+
+Interface object
+ ``_ADR``
+ ``bInterfaceNumber`` of the USB interface carrying LSTP traffic.
+ Required.
+
+Channel object
+ ``_ADR``
+ Firmware-reported channel ID, as ``reg`` is in the device tree
+ binding. This is the channel ID the device reports, which is not the
+ auxiliary device instance suffix. Required.
+
+ ``compatible``, in ``_DSD``
+ One of ``nvidia,lstp-spi``, ``nvidia,lstp-i2c``, ``nvidia,lstp-gpio``,
+ ``nvidia,lstp-ipmi``, ``nvidia,lstp-uart``. Required; a channel
+ object is matched on ``_ADR`` and ``compatible`` together, so a
+ mismatched ``compatible`` leaves the channel with no firmware node
+ rather than binding it to the wrong driver.
+
+ Per-channel properties are named exactly as in the device tree binding
+ -- ``gpio-line-names`` and so on.
+
+``_DSD`` properties use the device-properties UUID
+``daffd814-6eba-4d8c-8a91-bc9bbf4aa301``. An interface object needs no
+``_DSD`` at all.
+
+A single ``_DSD`` string satisfies a ``compatible`` match: reading a
+string property as an array returns a count of one for a lone string
+(``acpi_data_prop_read_single()``, ``drivers/acpi/property.c``), so there
+is no need to wrap it in a package.
+
+
+Use Device objects, not _DSD data nodes
+=======================================
+
+Interfaces and channels must be real ``Device()`` objects. ACPI also
+allows a hierarchy of *data* nodes under a single ``_DSD``, and the
+driver's walk returns those too: it goes through the
+``get_next_child_node`` operation, which for ACPI is
+``acpi_get_next_subnode()``, or on newer kernels
+``acpi_get_next_present_subnode()``, and returns child ``Device()``
+objects and data nodes alike. A data node has no ``_ADR``, so it never
+matches an interface or a channel, whatever properties it carries. The
+driver warns at probe about each data node among the interface object's
+children, and among the port object's children when no interface object
+matches, so that the table's mistake is visible rather than inferred from
+an undescribed channel. Earlier versions of this driver matched data
+nodes on their ``reg``.
+
+The walk is worth knowing for a second reason. On kernels whose walk is
+``acpi_get_next_present_subnode()``, any child ``Device()`` whose ``_STA``
+reports the device absent is skipped silently, so a channel can also go
+missing because its object is present in the table but evaluates as not
+present. On older kernels such an object is matched like any other.
+
+Even matched, a data node could not work, because it is not a device and
+so has no ACPI companion, and the cores that enumerate on this driver's
+behalf all gate on having one:
+
+- ``i2c_acpi_register_devices()`` returns early unless
+ ``has_acpi_companion(&adap->dev)``, which is just
+ ``is_acpi_device_node(dev->fwnode)``.
+- ``acpi_register_spi_devices()`` returns early unless
+ ``ACPI_HANDLE(ctlr->dev.parent)`` is set.
+- ``acpi_gpiochip_add()`` returns early unless
+ ``ACPI_COMPANION(chip->parent)`` is set, so the chip is never registered
+ with the ACPI GPIO layer. A consumer that names this controller then
+ gets ``-EPROBE_DEFER`` from ``acpi_get_gpiod()`` -- which is meant for a
+ controller that has not probed yet, so here it never resolves and the
+ consumer defers forever.
+
+Nothing would be enumerated, and none of the three cores would report an
+error.
+
+
+Devices behind a channel
+========================
+
+The I2C and SPI cores enumerate by walking the namespace from the root and
+matching each candidate's connection resource against this controller,
+rather than by reading children of the channel object. A device on the
+bus may therefore live anywhere in the namespace; putting it under its
+channel is convention, not a requirement.
+
+I2C
+ Give each device its own ``Device()`` with an ``I2cSerialBus()`` resource
+ whose ``ResourceSource`` is the full path of the channel object.
+
+SPI
+ Give each device its own ``Device()`` with a ``SpiSerialBus()`` resource
+ whose ``ResourceSource`` is the full path of the channel object. The
+ channel object is what the SPI core looks at, because the controller's
+ parent is the channel's auxiliary device and carries that node.
+
+GPIO
+ There is nothing to enumerate, but the relationship runs the other way:
+ a consumer elsewhere in the namespace names this channel as its GPIO
+ provider, so the channel object still has to be resolvable. Reference it
+ by path from the consumer's ``_CRS``::
+
+ Device (LEDX)
+ {
+ Name (_HID, "PRP0001")
+ Name (_CRS, ResourceTemplate ()
+ {
+ GpioIo (Exclusive, PullNone, 0, 0, IoRestrictionOutputOnly,
+ "\\_SB.PCI0.XHCI.RHUB.PRT1.PRT3.IFC2.CHN3", 0,
+ ResourceConsumer, ,)
+ { 0 } // pin, controller-relative
+ })
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package () { Package () { "compatible", "gpio-leds" } }
+ })
+ }
+
+ The pin number is controller-relative, matching the channel's own pin
+ numbering. ``PRP0001`` only enumerates a device whose ``_DSD`` carries a
+ ``compatible``; without one the object is scanned, matched and then does
+ nothing. A consumer with a real ``_HID`` needs no ``_DSD`` -- only the
+ ``_CRS`` reference matters here.
+
+ The ACPI GPIO layer does not link a consumer to the controller it
+ resolved. When the LSTP device is unbound, reset or re-enumerated, a
+ consumer that is bound at that moment keeps its lines on the removed
+ controller: its GPIO accesses no longer reach the device (reads fail
+ with ``-ENODEV``, or return 0 on older kernels, and writes are dropped),
+ it is not probed again when the channel comes back, and it keeps the
+ gpio-lstp module in use. On older kernels, unbinding the consumer also logs
+ a warning for each line it held. Unbind and bind the consumer again
+ once the LSTP device is back, for example from a udev rule on the
+ channel's auxiliary device.
+
+ Pins the device firmware reports as LEDs take their LED properties from
+ a ``leds`` child with one ``led@N`` child per pin, as in the device tree
+ binding. These are only read, never enumerated, so here ``_DSD`` data
+ nodes are the right spelling, as in
+ ``Documentation/firmware-guide/acpi/dsd/leds.rst``::
+
+ Device (CHN3)
+ {
+ Name (_ADR, 3)
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-gpio" }
+ },
+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
+ Package () { Package () { "leds", LEDS } }
+ })
+ Name (LEDS, Package ()
+ {
+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
+ Package () { Package () { "led@4", LED4 } }
+ })
+ Name (LED4, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "reg", 4 },
+ Package () { "label", "amber:status" },
+ Package () { "default-state", "on" }
+ }
+ })
+ }
+
+IPMI, UART
+ Nothing to enumerate, nothing to reference, and no properties beyond
+ ``compatible``. An object for one of these channels
+ describes it but changes nothing about how it comes up.
+
+
+Example
+=======
+
+The device at ``1-1.3:1.2`` -- interface 2 of an LSTP device on port 3 of a
+hub attached to root-hub port 1 -- with five channels, an I2C temperature
+sensor on channel 2 and a SPI device on channel 1::
+
+ Scope (\_SB.PCI0.XHCI.RHUB.PRT1) // root-hub port 1, _ADR = raw port
+ {
+ Device (PRT3)
+ {
+ Name (_ADR, 3) // port on the external hub
+
+ Device (IFC2)
+ {
+ Name (_ADR, 2) // bInterfaceNumber
+
+ Device (CHN1) // SPI channel
+ {
+ Name (_ADR, 1) // channel ID
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-spi" }
+ }
+ })
+
+ Device (FLS0) // flash on chip select 0
+ {
+ Name (_HID, "PRP0001")
+ Name (_CRS, ResourceTemplate ()
+ {
+ SpiSerialBus (0, // chip select
+ PolarityLow, FourWireMode, 8,
+ ControllerInitiated, 24000000,
+ ClockPolarityLow, ClockPhaseFirst,
+ "\\_SB.PCI0.XHCI.RHUB.PRT1.PRT3.IFC2.CHN1")
+ })
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "jedec,spi-nor" }
+ }
+ })
+ }
+ }
+
+ Device (CHN2) // I2C channel
+ {
+ Name (_ADR, 2) // channel ID
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-i2c" }
+ }
+ })
+
+ Device (TMP0) // sensor at 0x48
+ {
+ Name (_HID, "PRP0001")
+ Name (_CRS, ResourceTemplate ()
+ {
+ I2cSerialBus (0x0048, ControllerInitiated,
+ 400000, AddressingMode7Bit,
+ "\\_SB.PCI0.XHCI.RHUB.PRT1.PRT3.IFC2.CHN2",
+ 0x00, ResourceConsumer,,)
+ })
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "ti,tmp102" }
+ }
+ })
+ }
+ }
+
+ Device (CHN3) // GPIO channel
+ {
+ Name (_ADR, 3) // channel ID
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-gpio" },
+ Package () { "gpio-line-names",
+ Package () { "LED", "INT" } }
+ }
+ })
+ }
+
+ Device (CHN4) // IPMI channel
+ {
+ Name (_ADR, 4) // channel ID
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-ipmi" }
+ }
+ })
+ }
+
+ Device (CHN5) // UART channel
+ {
+ Name (_ADR, 5) // channel ID
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "compatible", "nvidia,lstp-uart" }
+ }
+ })
+ }
+ }
+ }
+ }
+
+``_HID`` of ``PRP0001`` with a ``compatible`` property is the generic way
+to bind an ACPI device to a driver that has only a device tree match
+table; use the device's own ``_HID`` instead where it has one.
+
+
+Locating the port object
+========================
+
+Each hub level in the sysfs path gets a port object. For the device at
+``1-1.3:1.2`` used above:
+
+============== ===================================== ==================
+sysfs segment ACPI object ``_ADR``
+============== ===================================== ==================
+``1-`` host controller platform's own
+``1-`` root hub, child of the controller 0
+``1-1`` root-hub port 1 raw port number
+``1-1.3`` port 3 on the hub at port 1 3
+``1-1.3:1.2`` interface 2 2
+============== ===================================== ==================
+
+The two port rows are matched differently, which matters when writing the
+table. A port on an external hub uses the port number as sysfs shows it.
+A **root-hub** port does not: ``usb_acpi_get_companion_for_port()`` passes
+the port through ``usb_hcd_find_raw_port_number()`` first, and on xHCI that
+resolves to the controller's hardware port number
+(``rhub->ports[port1 - 1]->hw_portnum + 1``), which is generally not the
+sysfs number because the USB2 and USB3 root hubs are numbered separately
+over one shared hardware port array. Controllers that do not implement
+``find_raw_port_number`` leave the number unchanged. Read the hardware
+port number out of the platform's own table rather than counting sysfs
+segments.
+
+The interface row is no port at all: its ``_ADR`` is the
+``bInterfaceNumber``, which the USB core does not look up. This driver
+matches it among the children of the device's port object.
diff --git a/MAINTAINERS b/MAINTAINERS
index 3eaae7388a69..e18d45bd7da5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19570,10 +19570,15 @@ M: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
M: Donald Shannon <donalds@nvidia.com>
L: linux-usb@vger.kernel.org
S: Supported
+F: Documentation/ABI/testing/sysfs-bus-usb-devices-lstp
F: Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
F: Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
+F: Documentation/driver-api/usb/lstp.rst
+F: Documentation/firmware-guide/acpi/lstp.rst
+F: drivers/usb/misc/lstp.c
+F: include/linux/usb/lstp.h
NVIDIA VRS RTC DRIVER
M: Shubhi Garg <shgarg@nvidia.com>
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 91b62acb537b..9cfb43b2a927 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -194,6 +194,21 @@ config USB_USBIO
This driver can also be built as a module. If so, the module
will be called usbio.
+config USB_LSTP
+ tristate "NVIDIA LSTP USB adapter support"
+ depends on USB
+ select AUXILIARY_BUS
+ help
+ Say Y here to support NVIDIA LSTP (Low-Speed Transport Protocol)
+ USB adapters. An LSTP adapter exposes firmware-configured I2C,
+ SPI, GPIO, UART and IPMI channels over a single USB interface.
+ This core driver discovers the channels and offers each one as an
+ auxiliary device; enable GPIO_LSTP, LEDS_LSTP, I2C_LSTP, SPI_LSTP,
+ LSTP_TTY and LSTP_IPMI_BMC for the channel types you need.
+
+ This driver can also be built as a module. If so, the module
+ will be called lstp.
+
source "drivers/usb/misc/sisusbvga/Kconfig"
config USB_LD
diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
index 494ab0377f35..5133075e5739 100644
--- a/drivers/usb/misc/Makefile
+++ b/drivers/usb/misc/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_USB_EZUSB_FX2) += ezusb.o
obj-$(CONFIG_APPLE_MFI_FASTCHARGE) += apple-mfi-fastcharge.o
obj-$(CONFIG_USB_LJCA) += usb-ljca.o
obj-$(CONFIG_USB_USBIO) += usbio.o
+obj-$(CONFIG_USB_LSTP) += lstp.o
obj-$(CONFIG_USB_IDMOUSE) += idmouse.o
obj-$(CONFIG_USB_IOWARRIOR) += iowarrior.o
obj-$(CONFIG_USB_ISIGHTFW) += isight_firmware.o
diff --git a/drivers/usb/misc/lstp.c b/drivers/usb/misc/lstp.c
new file mode 100644
index 000000000000..768c267c7354
--- /dev/null
+++ b/drivers/usb/misc/lstp.c
@@ -0,0 +1,2983 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * LSTP USB interface driver.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/acpi.h>
+#include <linux/atomic.h>
+#include <linux/bitfield.h>
+#include <linux/bits.h>
+#include <linux/build_bug.h>
+#include <linux/cleanup.h>
+#include <linux/delay.h>
+#include <linux/idr.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/mutex.h>
+#include <linux/notifier.h>
+#include <linux/of.h>
+#include <linux/overflow.h>
+#include <linux/property.h>
+#include <linux/spinlock.h>
+#include <linux/uio.h>
+#include <linux/usb.h>
+#include <linux/wait_bit.h>
+#include <linux/workqueue.h>
+
+#include <linux/usb/lstp.h>
+
+#define LSTP_VERSION 1
+#define LSTP_USB_REQUEST_TIMEOUT_MS 1000
+#define LSTP_USB_EP_MAX_SIZE 512
+#define LSTP_MAX_CHANNELS 256 /* Includes channel 0 */
+#define LSTP_ANY_RX_LEN 0 /* "no minimum" -- callers without a known min payload length */
+#define LSTP_READ_CONFIG_MAX U16_MAX /* sentinel: max ch_config bytes per USB RX packet */
+#define LSTP_INTF_NAME_LEN (LSTP_CH_NAME_LEN + 1) /* ch0_name + '\0' */
+
+#define LSTP_CH_FLAG_ENABLE BIT(0)
+
+#define LSTP_BUFFER_LOCK_BIT 0 /* resp_buffer_lock, irq_buffer_lock, irq_resp_buffer_lock */
+
+/* Fields of lstp_header.cmd and lstp_header.status */
+#define LSTP_HDR_CODE GENMASK(6, 0)
+#define LSTP_HDR_RESPONSE BIT(7)
+
+enum lstp_channel_type {
+ LSTP_CHANNEL_TYPE_MGMT = 0x00,
+ LSTP_CHANNEL_TYPE_SPI = 0x01,
+ LSTP_CHANNEL_TYPE_GPIO = 0x02,
+ LSTP_CHANNEL_TYPE_I2C = 0x03,
+ LSTP_CHANNEL_TYPE_UART = 0x04,
+ LSTP_CHANNEL_TYPE_IPMI = 0x05,
+ LSTP_CHANNEL_TYPE_MMIO = 0x06,
+ LSTP_CHANNEL_TYPE_MAX, /* sentinel, not a wire value; keep last */
+};
+
+struct lstp_ch0_read_req {
+ u8 ch_id;
+ __le16 offset;
+ __le16 length;
+} __packed;
+
+struct lstp_ch0_write_req {
+ u8 ch_id;
+ __le16 offset;
+ struct lstp_ch_desc desc;
+ u8 ch_config[];
+} __packed;
+
+/* Process-context resubmit path for RX completions whose usb_submit_urb() failed. */
+struct lstp_rx_retry {
+ struct delayed_work work;
+ int last_err;
+ unsigned int failures;
+};
+
+/**
+ * struct lstp_usb_stats - Shared bulk-in endpoint counters, ``lstp/statistics/``.
+ * @rx_packets: Packets completed successfully on the endpoint.
+ * @rx_errors: Completions rejected by lstp_validate_rx_pkt().
+ * @rx_no_channel: Well-formed packets naming an unregistered channel.
+ * @rx_urb_errors: Error completions other than the teardown codes.
+ * @rx_stalls: Endpoint halts cleared by lstp_rx_retry_work().
+ * @rx_retries: Resubmit attempts made by lstp_rx_retry_work().
+ */
+struct lstp_usb_stats {
+ atomic64_t rx_packets;
+ atomic64_t rx_errors;
+ atomic64_t rx_no_channel;
+ atomic64_t rx_urb_errors;
+ atomic64_t rx_stalls;
+ atomic64_t rx_retries;
+};
+
+struct lstp_usb {
+ struct usb_device *udev;
+ struct usb_interface *intf;
+ u8 bulk_in_ep;
+ u8 bulk_out_ep;
+ struct urb *bulk_rx_urb;
+ struct lstp_rx_retry bulk_rx_retry;
+ u8 *rx_buf;
+ size_t bulk_tx_size;
+ size_t bulk_rx_size;
+ u8 lstp_version;
+ char lstp_intf_name[LSTP_INTF_NAME_LEN];
+ u8 max_ch_id;
+ /*
+ * Published with smp_store_release() by lstp_create_channel(); the RX
+ * completion and the disconnect fence smp_load_acquire() before they
+ * dereference. Plain loads only where the read is already so ordered.
+ */
+ struct lstp_channel *channels[LSTP_MAX_CHANNELS];
+ /* Node the channel nodes hang off, or NULL; see lstp_find_intf_fwnode() */
+ struct fwnode_handle *intf_fwnode;
+ struct lstp_usb_stats stats;
+ struct notifier_block aux_nb; /* auxiliary-bus bind/unbind hook (one per device) */
+ const struct bus_type *aux_bus; /* bus @aux_nb is registered on */
+};
+
+static DEFINE_IDA(lstp_auxdev_ida);
+
+/*
+ * Channel containers and lstp/ kobjects not yet released. Their release runs
+ * this module's code and can come after disconnect, so module exit waits until
+ * none remain.
+ */
+static atomic_t lstp_live_objects = ATOMIC_INIT(0);
+
+enum lstp_ch0_cmd {
+ LSTP_CH0_CMD_READ_CONFIG = 0x08,
+ LSTP_CH0_CMD_WRITE_CONFIG = 0x09,
+ LSTP_CH0_CMD_LOCK = 0x0A,
+};
+
+struct lstp_ch0_config {
+ u8 lstp_version;
+ u8 num_channels; /* does not include ch0 */
+} __packed;
+
+/**
+ * struct lstp_channel_stats - Counters for one channel's LSTP exchanges.
+ * @tx_packets: Requests handed to the host controller.
+ * @rx_packets: Responses accepted by lstp_validate_resp().
+ * @rx_events: Unsolicited requests delivered to the bound driver.
+ * @timeouts: Requests unanswered within LSTP_USB_RESPONSE_TIMEOUT_MS.
+ * @errors: Responses rejected by lstp_validate_resp().
+ * @tx_errors: Requests that failed to submit.
+ * @rx_dropped: Inbound packets the channel could not accept.
+ * @rx_late: Responses that arrived with no waiter, or after the waiter's
+ * answer. A lower bound: nothing on the wire ties a response to
+ * its request.
+ *
+ * Monotonic; published read-only in the channel's ``statistics`` sysfs group.
+ */
+struct lstp_channel_stats {
+ atomic64_t tx_packets;
+ atomic64_t rx_packets;
+ atomic64_t rx_events;
+ atomic64_t timeouts;
+ atomic64_t errors;
+ atomic64_t tx_errors;
+ atomic64_t rx_dropped;
+ atomic64_t rx_late;
+};
+
+/**
+ * enum lstp_auxdev_state - Lifecycle state of a channel's embedded auxdev.
+ * @LSTP_AUXDEV_RAW: Never auxiliary_device_init'd, owns no instance id: ch0,
+ * an unsupported channel type, or a failure before init.
+ * @LSTP_AUXDEV_INITED: auxiliary_device_init() done; not yet on the bus.
+ * @LSTP_AUXDEV_ADDED: auxiliary_device_add() done; live on the auxiliary bus.
+ */
+enum lstp_auxdev_state {
+ LSTP_AUXDEV_RAW = 0,
+ LSTP_AUXDEV_INITED,
+ LSTP_AUXDEV_ADDED,
+};
+
+/**
+ * struct lstp_channel_type_info - What the core needs to know of a channel type.
+ * @name: Auxdev name; the channel's auxdev is "lstp.<name>.<id>".
+ * @compatible: "compatible" of the channel's firmware node, or NULL if the
+ * type has none.
+ * @irq_needs_resp: The device waits for a response to each request it sends,
+ * so the core NACKs one no driver takes.
+ *
+ * Kept in the core: channels are created and matched to firmware nodes
+ * whether or not their driver is loaded.
+ */
+struct lstp_channel_type_info {
+ const char *name;
+ const char *compatible;
+ bool irq_needs_resp;
+};
+
+/**
+ * struct lstp_channel_priv - Framework-private extension of struct lstp_channel.
+ * @pub: Public, subsystem-visible part. Must be first.
+ * @auxdev: Per-channel auxiliary_device; its refcount owns this
+ * container, see lstp_channel_dev_release().
+ * @auxdev_state: Lifecycle state of @auxdev.
+ * @ch_type: LSTP channel type.
+ * @type: @ch_type's entry in lstp_channel_types[], or NULL
+ * for ch0 and for a channel that was skipped.
+ * @usb: Back-pointer to the LSTP USB device.
+ * @tx_mutex: Serializes outbound requests, one per channel.
+ * @cfg_lock: Serializes ch0 descriptor read-modify-write.
+ * @resp_buffer_lock: Bit lock guarding @resp_buf.
+ * @irq_buffer_lock: Bit lock guarding @irq_buf.
+ * @irq_resp_buffer_lock: Bit lock guarding the IRQ response slot.
+ * @rx_ready: Set when a solicited response is in @resp_buf.
+ * @gone: Fence: the device has gone. Never cleared.
+ * @unbound: Fence: raised at unbind, cleared at the next bind.
+ * @started: Gates dispatch of unsolicited packets.
+ * @irq_cb_lock: Guards @irq_ops against the atomic RX dispatch reader.
+ * @irq_ops: Ops of the bound driver, NULL while unbound.
+ * @tx_buf: Bulk-out scratch buffer for requests.
+ * @tx_resp_buf: Bulk-out scratch buffer for IRQ responses.
+ * @resp_buf: Buffer for solicited responses, or NULL.
+ * @irq_buf: Buffer for unsolicited requests, or NULL.
+ * @bulk_tx_urb: URB for outbound requests.
+ * @bulk_tx_resp_urb: URB for IRQ responses.
+ * @rx_wq: Wait queue for solicited-response readers.
+ * @stats: Per-channel exchange counters.
+ *
+ * @gone and @unbound together are the channel's I/O fence; see
+ * Documentation/driver-api/usb/lstp.rst.
+ */
+struct lstp_channel_priv {
+ struct lstp_channel pub;
+ struct auxiliary_device auxdev;
+ enum lstp_auxdev_state auxdev_state;
+
+ u8 ch_type;
+ const struct lstp_channel_type_info *type;
+ struct lstp_usb *usb;
+ struct mutex tx_mutex; /* serializes outbound requests */
+ struct mutex cfg_lock; /* serializes ch0 descriptor read-modify-write */
+ unsigned long resp_buffer_lock;
+ unsigned long irq_buffer_lock;
+ unsigned long irq_resp_buffer_lock;
+ bool rx_ready;
+ bool gone;
+ bool unbound;
+ bool started;
+ spinlock_t irq_cb_lock; /* guards @irq_ops vs atomic RX dispatch */
+ const struct lstp_ops *irq_ops;
+ u8 *tx_buf;
+ u8 *tx_resp_buf;
+ u8 *resp_buf;
+ u8 *irq_buf;
+ struct urb *bulk_tx_urb;
+ struct urb *bulk_tx_resp_urb;
+ wait_queue_head_t rx_wq;
+ struct lstp_channel_stats stats;
+};
+
+#define to_lstp_priv(ch) container_of((ch), struct lstp_channel_priv, pub)
+
+static_assert(offsetof(struct lstp_channel_priv, pub) == 0,
+ "struct lstp_channel must be the first member of struct lstp_channel_priv");
+
+static inline struct lstp_channel_priv *to_lstp_priv_from_auxdev(struct auxiliary_device *auxdev)
+{
+ return container_of(auxdev, struct lstp_channel_priv, auxdev);
+}
+
+/* Valid only for drivers registered through lstp_auxiliary_driver_register(). */
+static inline const struct lstp_auxiliary_driver *to_lstp_aux_drv(struct device_driver *drv)
+{
+ return container_of(to_auxiliary_drv(drv), struct lstp_auxiliary_driver, adrv);
+}
+
+/**
+ * lstp_channel_from_auxdev() - Recover the channel handle from its auxdev.
+ * @auxdev: Auxiliary device the framework registered for the channel.
+ *
+ * Context: Any context.
+ * Return: The channel handle, or %NULL if @auxdev was %NULL.
+ */
+struct lstp_channel *lstp_channel_from_auxdev(struct auxiliary_device *auxdev)
+{
+ if (!auxdev)
+ return NULL;
+
+ return &to_lstp_priv_from_auxdev(auxdev)->pub;
+}
+EXPORT_SYMBOL_NS_GPL(lstp_channel_from_auxdev, "LSTP");
+
+/*
+ * True once usb_disconnect() has marked the device USB_STATE_NOTATTACHED, read
+ * locklessly as usb_submit_urb() does, or once a channel that outlived its
+ * interface has dropped @usb. Unlike the channel fence, false for an unbind
+ * while the device is still attached.
+ */
+static inline bool lstp_usb_gone(const struct lstp_usb *usb)
+{
+ return !usb || !usb->udev || usb->udev->state == USB_STATE_NOTATTACHED;
+}
+
+/**
+ * lstp_channel_get() - Pin a channel so it outlives USB disconnect.
+ * @ch: LSTP channel to pin, or %NULL.
+ *
+ * Takes a reference on the channel's auxiliary_device, which owns the private
+ * container; see Documentation/driver-api/usb/lstp.rst for when a subsystem
+ * must pin. Only a channel offered to a subsystem can be pinned; ch0 and
+ * unsupported channel types stay LSTP_AUXDEV_RAW.
+ *
+ * Context: Any context.
+ * Return: @ch, or %NULL if @ch was %NULL or is not pinnable.
+ */
+struct lstp_channel *lstp_channel_get(struct lstp_channel *ch)
+{
+ if (!ch)
+ return NULL;
+
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (WARN_ON_ONCE(priv->auxdev_state == LSTP_AUXDEV_RAW))
+ return NULL;
+
+ get_device(&priv->auxdev.dev);
+ return ch;
+}
+EXPORT_SYMBOL_NS_GPL(lstp_channel_get, "LSTP");
+
+/**
+ * lstp_channel_put() - Drop a pin taken by lstp_channel_get().
+ * @ch: LSTP channel to release, or %NULL.
+ *
+ * The last reference frees the container. Refuses what lstp_channel_get()
+ * refuses, so a pin that was never taken is never dropped.
+ *
+ * Context: Process context. May sleep.
+ */
+void lstp_channel_put(struct lstp_channel *ch)
+{
+ if (!ch)
+ return;
+
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (WARN_ON_ONCE(priv->auxdev_state == LSTP_AUXDEV_RAW))
+ return;
+
+ put_device(&priv->auxdev.dev);
+}
+EXPORT_SYMBOL_NS_GPL(lstp_channel_put, "LSTP");
+
+static void lstp_usb_rx_callback(struct urb *urb);
+static void lstp_rx_retry_work(struct work_struct *work);
+static void lstp_teardown(struct lstp_usb *dev);
+static void lstp_kobj_release(struct kobject *kobj);
+static ssize_t lstp_name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf);
+
+/*
+ * /sys/.../lstp. Allocated on its own because a kobject's memory must last
+ * until its release, which can come after struct lstp_usb (devres) is gone.
+ * @dev is only dereferenced by attribute callbacks, and kobject_del() waits
+ * for those to finish before the devres teardown goes on.
+ */
+struct lstp_kobj {
+ struct kobject kobj;
+ struct lstp_usb *dev;
+};
+
+static struct lstp_usb *lstp_kobj_to_usb(struct kobject *kobj)
+{
+ return container_of(kobj, struct lstp_kobj, kobj)->dev;
+}
+
+/*
+ * One lstp_request*() or lstp_send() is one LSTP exchange. Not exported:
+ * subsystems serialise multi-exchange sequences at their own layer.
+ */
+DEFINE_GUARD(lstp_channel, struct lstp_channel *, mutex_lock(&to_lstp_priv(_T)->tx_mutex),
+ mutex_unlock(&to_lstp_priv(_T)->tx_mutex))
+
+static struct kobj_attribute lstp_name_attr = __ATTR(name, 0444, lstp_name_show, NULL);
+
+/* A named group's files get the owning kobject, so lstp_kobj_to_usb() applies. */
+/* clang-format off */
+#define LSTP_STAT_ATTR(field) \
+ static ssize_t lstp_stat_##field##_show(struct kobject *kobj, \
+ struct kobj_attribute *attr, \
+ char *buf) \
+ { \
+ struct lstp_usb *lstp = lstp_kobj_to_usb(kobj); \
+ \
+ return sysfs_emit(buf, "%lld\n", \
+ atomic64_read(&lstp->stats.field)); \
+ } \
+ static struct kobj_attribute lstp_stat_##field##_attr = \
+ __ATTR(field, 0444, lstp_stat_##field##_show, NULL)
+/* clang-format on */
+
+LSTP_STAT_ATTR(rx_packets);
+LSTP_STAT_ATTR(rx_errors);
+LSTP_STAT_ATTR(rx_no_channel);
+LSTP_STAT_ATTR(rx_urb_errors);
+LSTP_STAT_ATTR(rx_stalls);
+LSTP_STAT_ATTR(rx_retries);
+
+static struct attribute *lstp_attrs[] = {
+ &lstp_name_attr.attr,
+ NULL,
+};
+
+static struct attribute *lstp_stat_attrs[] = {
+ &lstp_stat_rx_packets_attr.attr,
+ &lstp_stat_rx_errors_attr.attr,
+ &lstp_stat_rx_no_channel_attr.attr,
+ &lstp_stat_rx_urb_errors_attr.attr,
+ &lstp_stat_rx_stalls_attr.attr,
+ &lstp_stat_rx_retries_attr.attr,
+ NULL,
+};
+
+static const struct attribute_group lstp_group = {
+ .attrs = lstp_attrs,
+};
+
+static const struct attribute_group lstp_stat_group = {
+ .name = "statistics",
+ .attrs = lstp_stat_attrs,
+};
+
+static const struct attribute_group *lstp_groups[] = {
+ &lstp_group,
+ &lstp_stat_group,
+ NULL,
+};
+
+static const struct kobj_type lstp_ktype = {
+ .release = lstp_kobj_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+ .default_groups = lstp_groups,
+};
+
+/* clang-format off */
+static const int lstp_errno_map[] = {
+ [LSTP_SUCCESS] = 0,
+ [LSTP_ERROR] = -EIO,
+ [LSTP_TIMEOUT] = -ETIMEDOUT,
+ [LSTP_BUSY] = -EBUSY,
+ [LSTP_NACK] = -ENXIO,
+ [LSTP_ARB_LOST] = -EAGAIN,
+ [LSTP_NOT_SUPP] = -EOPNOTSUPP,
+ [LSTP_TOO_LARGE] = -EFBIG,
+}; /* clang-format on */
+
+/*
+ * Unmapped statuses are -EIO. A gap in the designated-initializer table reads
+ * back as 0, so only LSTP_SUCCESS may return 0.
+ */
+static int lstp_status_to_errno(u8 status)
+{
+ if (status == LSTP_SUCCESS)
+ return 0;
+
+ if (status < ARRAY_SIZE(lstp_errno_map) && lstp_errno_map[status])
+ return lstp_errno_map[status];
+
+ return -EIO;
+}
+
+static int lstp_validate_rx_pkt(struct lstp_usb *dev, struct lstp_packet *rx_pkt,
+ size_t actual_length)
+{
+ struct lstp_header *rx_hdr = &rx_pkt->hdr;
+
+ if (actual_length < sizeof(struct lstp_header)) {
+ dev_err_ratelimited(&dev->intf->dev,
+ "%s: Packet without header (got %zu, need >=%zu)\n", __func__,
+ actual_length, sizeof(struct lstp_header));
+ return -EIO;
+ }
+
+ u8 ch_id = rx_hdr->ch_id;
+
+ if (ch_id > dev->max_ch_id) {
+ dev_err_ratelimited(&dev->intf->dev, "%s: Invalid channel ID (got %u, max %u)\n",
+ __func__, ch_id, dev->max_ch_id);
+ return -EIO;
+ }
+
+ size_t claimed_payload_len = le16_to_cpu(rx_hdr->length);
+ size_t max_payload_len = dev->bulk_rx_size - sizeof(struct lstp_header);
+ /* Payloads are limited to one packet. */
+ if (claimed_payload_len > max_payload_len) {
+ dev_err_ratelimited(&dev->intf->dev,
+ "%s: ch_%u: Payload too large (claims %zu, max %zu)\n",
+ __func__, ch_id, claimed_payload_len, max_payload_len);
+ return -EIO;
+ }
+
+ if (sizeof(struct lstp_header) + claimed_payload_len > actual_length) {
+ dev_err_ratelimited(&dev->intf->dev,
+ "%s: ch_%u: Payload too short (claims %zu, got %zu)\n",
+ __func__, ch_id, claimed_payload_len,
+ actual_length - sizeof(struct lstp_header));
+ return -EIO;
+ }
+
+ return 0;
+}
+
+/*
+ * Validate a packet already accepted by lstp_validate_rx_pkt(): LSTP status
+ * first, then payload against @min_payload_len (LSTP_ANY_RX_LEN for none).
+ * Longer payloads pass; see lstp_request() for the length modes. @lstp_status,
+ * when given, is set only if the returned errno came from the status byte.
+ */
+static int lstp_validate_resp(struct lstp_usb *dev, struct lstp_packet *rx_pkt,
+ size_t min_payload_len, int *lstp_status)
+{
+ struct lstp_header *rx_hdr = &rx_pkt->hdr;
+ u8 ch_id = rx_hdr->ch_id;
+ u8 status = FIELD_GET(LSTP_HDR_CODE, rx_hdr->status);
+
+ int ret = lstp_status_to_errno(status);
+
+ if (ret) {
+ if (lstp_status)
+ *lstp_status = status;
+ dev_dbg(&dev->intf->dev, "%s: ch_%u: LSTP error status %d (errno=%d)\n", __func__,
+ ch_id, status, ret);
+ return ret;
+ }
+
+ size_t payload_len = le16_to_cpu(rx_hdr->length);
+
+ if (payload_len < min_payload_len) {
+ dev_err_ratelimited(&dev->intf->dev,
+ "%s: ch_%u: Payload too short (need at least %zu, got %zu)\n",
+ __func__, ch_id, min_payload_len, payload_len);
+ return -EIO;
+ }
+
+ if (min_payload_len && payload_len > min_payload_len)
+ dev_dbg(&dev->intf->dev,
+ "%s: ch_%u: Payload longer than minimum (got %zu, min %zu) -- forward-compat extension?\n",
+ __func__, ch_id, payload_len, min_payload_len);
+
+ return 0;
+}
+
+/*
+ * Bytes of ch_config[] one READ_CONFIG reply can carry, or 0 if ch0 is
+ * unreachable. Every config read is served by ch0, so the window follows ch0's
+ * RX payload rather than the target channel's: 42 with the 64-byte bulk
+ * endpoint Full Speed mandates, 490 with a 512-byte one.
+ */
+static size_t lstp_usb_config_window(const struct lstp_usb *usb)
+{
+ /* Probe enforces bulk_rx_size >= LSTP_USB_EP_MIN_SIZE; anchor a nonzero window. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(struct lstp_ch0_read_resp) >=
+ LSTP_USB_EP_MIN_SIZE);
+
+ if (!usb || !usb->channels[0])
+ return 0;
+
+ return usb->channels[0]->max_rx_payload - offsetof(struct lstp_ch0_read_resp, ch_config);
+}
+
+static size_t lstp_ch0_config_window(struct lstp_channel *ch)
+{
+ return lstp_usb_config_window(to_lstp_priv(ch)->usb);
+}
+
+/* lstp_ch0_read_config() by channel id, for discovery, before the channel exists. */
+static int __lstp_ch0_read_config(struct lstp_usb *usb, u8 ch_id, u16 offset, u16 length,
+ struct lstp_ch0_read_resp **resp_out, size_t *len_out)
+{
+ struct lstp_ch0_read_resp *resp __free(kfree) = NULL;
+
+ if (!usb || !usb->channels[0])
+ return -ENODEV;
+ if (!resp_out || !len_out)
+ return -EINVAL;
+
+ struct lstp_channel *ch0 = usb->channels[0];
+ size_t max_payload_len = ch0->max_rx_payload;
+ u16 max_config_len = lstp_usb_config_window(usb);
+ u16 config_len = length;
+
+ if (length == LSTP_READ_CONFIG_MAX)
+ config_len = max_config_len;
+ else if (length > max_config_len)
+ return -EINVAL;
+
+ resp = kzalloc(max_payload_len, GFP_KERNEL);
+ if (!resp)
+ return -ENOMEM;
+
+ /* Probe enforces bulk_tx_size >= LSTP_USB_EP_MIN_SIZE; anchor the fixed request here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(struct lstp_ch0_read_req) >
+ LSTP_USB_EP_MIN_SIZE);
+
+ struct lstp_ch0_read_req req = {
+ .ch_id = ch_id,
+ .offset = cpu_to_le16(offset),
+ .length = cpu_to_le16(config_len),
+ };
+
+ size_t actual;
+ int ret = lstp_request(ch0, LSTP_CH0_CMD_READ_CONFIG, &req, sizeof(req), resp,
+ max_payload_len, &actual, NULL);
+ if (ret) {
+ dev_dbg(&usb->intf->dev, "%s: ch_%u: READ_CONFIG failed (%pe)\n", __func__, ch_id,
+ ERR_PTR(ret));
+ return ret;
+ }
+
+ size_t need = sizeof(*resp);
+
+ if (length != LSTP_READ_CONFIG_MAX)
+ need += length;
+ if (actual < need) {
+ dev_dbg(&usb->intf->dev, "%s: ch_%u: READ_CONFIG short reply: %zu < %zu\n",
+ __func__, ch_id, actual, need);
+ return -EIO;
+ }
+
+ *resp_out = no_free_ptr(resp);
+ *len_out = actual;
+ return 0;
+}
+
+/**
+ * lstp_ch0_read_config() - Read a config slice via ch0 READ_CONFIG.
+ * @ch: Target LSTP channel to read config from
+ * @offset: Byte offset starting at ch_config[0]
+ * @length: Bytes of ch_config[] to read, at most what one reply can carry
+ * @resp_out: On success, the kmalloc'd on-wire response (descriptor head plus
+ * config bytes); the caller owns it and must kfree() it
+ * @len_out: On success, response bytes in *@resp_out: at least the head plus
+ * @length config bytes
+ *
+ * Valid only while a driver is bound to @ch; does not honour a pin past
+ * disconnect.
+ *
+ * Context: Process context. Performs blocking USB I/O.
+ * Return: 0 on success, negative errno on failure.
+ */
+int lstp_ch0_read_config(struct lstp_channel *ch, u16 offset, u16 length,
+ struct lstp_ch0_read_resp **resp_out, size_t *len_out)
+{
+ if (!ch)
+ return -ENODEV;
+
+ return __lstp_ch0_read_config(to_lstp_priv(ch)->usb, ch->ch_id, offset, length, resp_out,
+ len_out);
+}
+EXPORT_SYMBOL_NS_GPL(lstp_ch0_read_config, "LSTP");
+
+/**
+ * lstp_ch0_read_config_bytes() - Read a byte range of ch_config[], reassembling packets.
+ * @ch: Target LSTP channel to read config from
+ * @offset: Byte offset starting at ch_config[0]
+ * @buf: Destination buffer of at least @len bytes
+ * @len: Bytes to read
+ *
+ * Splits @len into reads of at most lstp_ch0_config_window() bytes each.
+ *
+ * Context: Process context. Performs blocking USB I/O, once per packet.
+ * Return: 0 on success, negative errno on failure.
+ */
+static int lstp_ch0_read_config_bytes(struct lstp_channel *ch, u16 offset, void *buf, size_t len)
+{
+ if (!ch)
+ return -ENODEV;
+ if (!buf)
+ return -EINVAL;
+
+ size_t avail = lstp_ch0_config_window(ch);
+ size_t end;
+
+ if (!avail)
+ return -ENODEV;
+ if (check_add_overflow((size_t)offset, len, &end) || end > U16_MAX)
+ return -EINVAL;
+
+ for (size_t done = 0; done < len;) {
+ struct lstp_ch0_read_resp *resp __free(kfree) = NULL;
+ u16 length = min(len - done, avail);
+ size_t resp_len;
+ int ret = lstp_ch0_read_config(ch, offset + done, length, &resp, &resp_len);
+
+ if (ret)
+ return ret;
+
+ /* lstp_ch0_read_config() rejects a reply short of @length config bytes. */
+ memcpy(buf + done, resp->ch_config, length);
+ done += length;
+ }
+ return 0;
+}
+
+/**
+ * lstp_read_config_table() - Walk a channel's variable-length config entry array.
+ * @ch: Target LSTP channel to read config from
+ * @config_head_size: Bytes before the entry array starts (sizeof the fixed config head)
+ * @config_entry_size: Size of one wire config entry
+ * @total_entries: Number of entries to walk
+ * @entry_fn: Per-entry callback; @entry points into a scratch buffer
+ * and is valid only for the duration of the call
+ * @entry_ctx: Opaque context passed to @entry_fn
+ *
+ * The array is read as a byte stream; an entry straddling two responses is
+ * carried across reads. Valid only while a driver is bound to @ch; does not
+ * honour a pin past disconnect.
+ *
+ * Context: Process context. Performs blocking USB I/O; @entry_fn runs in the
+ * same context.
+ * Return: 0 on success or for an empty table, %-ENODEV for a %NULL @ch or
+ * unreachable ch0, %-EINVAL for a bad argument, else the first read
+ * or @entry_fn errno.
+ */
+int lstp_read_config_table(struct lstp_channel *ch, size_t config_head_size,
+ size_t config_entry_size, unsigned int total_entries,
+ lstp_config_entry_fn entry_fn, void *entry_ctx)
+{
+ if (!total_entries)
+ return 0;
+ if (!ch)
+ return -ENODEV;
+ if (!entry_fn || !config_entry_size)
+ return -EINVAL;
+
+ size_t avail = lstp_ch0_config_window(ch);
+ size_t table_bytes;
+ size_t table_end;
+
+ if (!avail)
+ return -ENODEV;
+ if (check_mul_overflow((size_t)total_entries, config_entry_size, &table_bytes) ||
+ check_add_overflow(config_head_size, table_bytes, &table_end) || table_end > U16_MAX)
+ return -EINVAL;
+
+ /* One full window plus the largest partial entry that can carry over. */
+ u8 *buf __free(kfree) = kmalloc(config_entry_size + avail, GFP_KERNEL);
+
+ if (!buf)
+ return -ENOMEM;
+
+ unsigned int next_entry = 0;
+ size_t carried = 0;
+
+ for (size_t done = 0; done < table_bytes;) {
+ size_t length = min(table_bytes - done, avail);
+ int ret = lstp_ch0_read_config_bytes(ch, config_head_size + done, buf + carried,
+ length);
+
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: config read for entry %u failed (%pe)\n",
+ __func__, ch->ch_id, next_entry, ERR_PTR(ret));
+ return ret;
+ }
+ done += length;
+ carried += length;
+
+ size_t consumed = 0;
+
+ while (carried - consumed >= config_entry_size) {
+ ret = entry_fn(ch, next_entry++, buf + consumed, entry_ctx);
+ if (ret)
+ return ret;
+ consumed += config_entry_size;
+ }
+
+ carried -= consumed;
+ memmove(buf, buf + consumed, carried);
+ }
+ return 0;
+}
+EXPORT_SYMBOL_NS_GPL(lstp_read_config_table, "LSTP");
+
+/*
+ * Read @ch's descriptor head via ch0 READ_CONFIG. Read-modify-write callers
+ * hold priv->cfg_lock across this and the write; see __lstp_ch0_write_config().
+ */
+static int lstp_ch0_read_desc(struct lstp_channel *ch, struct lstp_ch_desc *desc)
+{
+ if (!ch)
+ return -ENODEV;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ struct lstp_usb *usb = priv->usb;
+
+ if (!usb || !usb->channels[0])
+ return -ENODEV;
+ struct lstp_channel *ch0 = usb->channels[0];
+
+ struct lstp_ch0_read_req req = {
+ .ch_id = ch->ch_id,
+ .offset = cpu_to_le16(0),
+ .length = cpu_to_le16(0),
+ };
+
+ /* Fixed-length read (see lstp_request()); firmware may append a config trailer. */
+ int ret = lstp_request(ch0, LSTP_CH0_CMD_READ_CONFIG, &req, sizeof(req), desc,
+ sizeof(*desc), NULL, NULL);
+ if (ret)
+ dev_err(ch->dev, "%s: ch_%d: READ_CONFIG failed (%pe)\n", __func__, ch->ch_id,
+ ERR_PTR(ret));
+ return ret;
+}
+
+/*
+ * Raw WRITE_CONFIG sender: @desc goes on the wire verbatim, @config_len bytes
+ * of @config land at @offset in ch_config[] (@config is NULL exactly when
+ * @config_len is 0).
+ * Every WRITE_CONFIG re-sends the descriptor head, so a caller that changes
+ * the descriptor must hold priv->cfg_lock across a re-read of @desc from the
+ * device and this write, or it writes back a stale type/flags/name.
+ */
+static int __lstp_ch0_write_config(struct lstp_channel *ch, u16 offset,
+ const struct lstp_ch_desc *desc, const void *config,
+ u16 config_len)
+{
+ if (!ch || !desc)
+ return -ENODEV;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ struct lstp_usb *usb = priv->usb;
+
+ if (!usb || !usb->channels[0])
+ return -ENODEV;
+ if (config_len && !config)
+ return -EINVAL;
+
+ struct lstp_channel *ch0 = usb->channels[0];
+ size_t req_len;
+
+ /* Probe enforces bulk_tx_size >= LSTP_USB_EP_MIN_SIZE; anchor the fixed head here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + offsetof(struct lstp_ch0_write_req, ch_config) >
+ LSTP_USB_EP_MIN_SIZE);
+
+ if (check_add_overflow(offsetof(struct lstp_ch0_write_req, ch_config), config_len,
+ &req_len))
+ return -EINVAL;
+
+ struct lstp_ch0_write_req *req __free(kfree) = kmalloc(req_len, GFP_KERNEL);
+ if (!req)
+ return -ENOMEM;
+
+ req->ch_id = ch->ch_id;
+ req->offset = cpu_to_le16(offset);
+ req->desc = *desc;
+ if (config_len)
+ memcpy(req->ch_config, config, config_len);
+
+ int ret = lstp_request(ch0, LSTP_CH0_CMD_WRITE_CONFIG, req, req_len, NULL, 0, NULL, NULL);
+
+ if (ret)
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: WRITE_CONFIG failed (%pe). Config locked?\n",
+ __func__, ch->ch_id, ERR_PTR(ret));
+
+ return ret;
+}
+
+static int lstp_ch0_set_enable(struct lstp_channel *ch, bool enable)
+{
+ struct lstp_ch_desc desc;
+
+ if (!ch)
+ return -ENODEV;
+
+ guard(mutex)(&to_lstp_priv(ch)->cfg_lock);
+
+ int ret = lstp_ch0_read_desc(ch, &desc);
+
+ if (ret)
+ return ret;
+
+ if (enable)
+ desc.ch_flags |= LSTP_CH_FLAG_ENABLE;
+ else
+ desc.ch_flags &= ~LSTP_CH_FLAG_ENABLE;
+
+ return __lstp_ch0_write_config(ch, 0, &desc, NULL, 0);
+}
+
+static void lstp_put_usb_dev(void *data)
+{
+ usb_put_dev((struct usb_device *)data);
+}
+
+/*
+ * Devres action: kill and free the URB in *(struct urb **)@data and NULL the
+ * slot. @data must live at least as long as the devres node.
+ */
+static void lstp_release_urb_slot(void *data)
+{
+ struct urb **slot = data;
+
+ usb_kill_urb(*slot);
+ usb_free_urb(*slot);
+ *slot = NULL;
+}
+
+static void lstp_kobj_del_put(void *data)
+{
+ struct kobject *kobj = data;
+
+ kobject_del(kobj);
+ kobject_put(kobj);
+}
+
+static void lstp_kobj_release(struct kobject *kobj)
+{
+ kfree(container_of(kobj, struct lstp_kobj, kobj));
+ if (atomic_dec_and_test(&lstp_live_objects))
+ wake_up_var(&lstp_live_objects);
+}
+
+static ssize_t lstp_name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
+{
+ struct lstp_usb *lstp = lstp_kobj_to_usb(kobj);
+
+ return sysfs_emit(buf, "%s\n", lstp->lstp_intf_name);
+}
+
+/* <auxdev>/enable: LSTP_CH_FLAG_ENABLE, read back from the device. */
+static ssize_t enable_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(to_auxiliary_dev(dev));
+ struct lstp_ch_desc desc;
+ int ret = lstp_ch0_read_desc(ch, &desc);
+
+ if (ret)
+ return ret;
+
+ u8 enable_bit = (desc.ch_flags & LSTP_CH_FLAG_ENABLE) ? 1 : 0;
+
+ return sysfs_emit(buf, "%u\n", enable_bit);
+}
+
+static ssize_t enable_store(struct device *dev, struct device_attribute *attr, const char *buf,
+ size_t count)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(to_auxiliary_dev(dev));
+ unsigned int enable;
+ int ret = kstrtouint(buf, 0, &enable);
+
+ if (ret)
+ return ret;
+
+ if (enable > 1)
+ return -EINVAL;
+
+ ret = lstp_ch0_set_enable(ch, enable != 0);
+ if (ret)
+ return ret;
+
+ return count;
+}
+
+static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(to_auxiliary_dev(dev));
+
+ return sysfs_emit(buf, "%s\n", ch->display_name);
+}
+
+/* <auxdev>/channel: ch_id, which the auxdev instance suffix does not track. */
+static ssize_t channel_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(to_auxiliary_dev(dev));
+
+ return sysfs_emit(buf, "%u\n", ch->ch_id);
+}
+
+/* clang-format off */
+#define LSTP_CHANNEL_STAT_ATTR(field) \
+ static ssize_t field##_show(struct device *dev, \
+ struct device_attribute *attr, char *buf) \
+ { \
+ struct lstp_channel_priv *priv = \
+ to_lstp_priv_from_auxdev(to_auxiliary_dev(dev)); \
+ \
+ return sysfs_emit(buf, "%lld\n", \
+ atomic64_read(&priv->stats.field)); \
+ } \
+ static DEVICE_ATTR_RO(field)
+/* clang-format on */
+
+LSTP_CHANNEL_STAT_ATTR(tx_packets);
+LSTP_CHANNEL_STAT_ATTR(rx_packets);
+LSTP_CHANNEL_STAT_ATTR(rx_events);
+LSTP_CHANNEL_STAT_ATTR(timeouts);
+LSTP_CHANNEL_STAT_ATTR(errors);
+LSTP_CHANNEL_STAT_ATTR(tx_errors);
+LSTP_CHANNEL_STAT_ATTR(rx_dropped);
+LSTP_CHANNEL_STAT_ATTR(rx_late);
+
+static DEVICE_ATTR_RO(name);
+static DEVICE_ATTR_RO(channel);
+static DEVICE_ATTR_RW(enable);
+
+static struct attribute *lstp_channel_attrs[] = {
+ &dev_attr_name.attr,
+ &dev_attr_channel.attr,
+ &dev_attr_enable.attr,
+ NULL,
+};
+
+/* clang-format off */
+static struct attribute *lstp_channel_stat_attrs[] = {
+ &dev_attr_tx_packets.attr,
+ &dev_attr_rx_packets.attr,
+ &dev_attr_rx_events.attr,
+ &dev_attr_timeouts.attr,
+ &dev_attr_errors.attr,
+ &dev_attr_tx_errors.attr,
+ &dev_attr_rx_dropped.attr,
+ &dev_attr_rx_late.attr,
+ NULL,
+}; /* clang-format on */
+
+static const struct attribute_group lstp_channel_group = {
+ .attrs = lstp_channel_attrs,
+};
+
+static const struct attribute_group lstp_channel_stat_group = {
+ .name = "statistics",
+ .attrs = lstp_channel_stat_attrs,
+};
+
+static const struct attribute_group *lstp_channel_groups[] = {
+ &lstp_channel_group,
+ &lstp_channel_stat_group,
+ NULL,
+};
+
+static int lstp_create_sysfs_hierarchy(struct lstp_usb *dev)
+{
+ struct device *parent_dev = &dev->intf->dev;
+ struct lstp_kobj *lk = kzalloc_obj(*lk);
+ int ret;
+
+ if (!lk)
+ return -ENOMEM;
+ atomic_inc(&lstp_live_objects);
+ lk->dev = dev;
+
+ ret = kobject_init_and_add(&lk->kobj, &lstp_ktype, &parent_dev->kobj, "lstp");
+ if (ret) {
+ kobject_put(&lk->kobj);
+ return ret;
+ }
+
+ return devm_add_action_or_reset(parent_dev, lstp_kobj_del_put, &lk->kobj);
+}
+
+/*
+ * Warn about an interface node with a one-cell "reg", and about an interface
+ * node under a combined device node. The USB core attaches neither, so every
+ * channel of the interface would come up undescribed.
+ */
+static void lstp_check_of_layout(struct lstp_usb *dev)
+{
+ struct device_node *udev_np = dev->udev->dev.of_node;
+ struct device_node *intf_np = dev->intf->dev.of_node;
+ u8 ifnum = dev->intf->cur_altsetting->desc.bInterfaceNumber;
+ struct device_node *np;
+ u32 reg;
+
+ if (intf_np == udev_np) {
+ for_each_child_of_node(udev_np, np) {
+ if (!of_node_name_eq(np, "interface"))
+ continue;
+ dev_warn(&dev->intf->dev,
+ "%s: %pOF is a combined device and interface node; channel nodes go directly under it, not under %pOFP\n",
+ __func__, udev_np, np);
+ of_node_put(np);
+ break;
+ }
+ return;
+ }
+
+ if (intf_np)
+ return;
+
+ for_each_child_of_node(udev_np, np) {
+ if (of_property_count_u32_elems(np, "reg") != 1 ||
+ of_property_read_u32(np, "reg", ®) || reg != ifnum)
+ continue;
+ dev_warn(&dev->intf->dev,
+ "%s: %pOF has a one-cell reg; the USB core attaches an interface node only for a two-cell reg = <interface configuration>, so no channel of this interface is described\n",
+ __func__, np);
+ of_node_put(np);
+ break;
+ }
+}
+
+#ifdef CONFIG_ACPI
+/* The full 64-bit _ADR of an ACPI Device(); -ENODATA for any other node. */
+static int lstp_acpi_read_adr(struct fwnode_handle *node, u64 *adr)
+{
+ if (!is_acpi_device_node(node))
+ return -ENODATA;
+
+ return acpi_get_local_u64_address(ACPI_HANDLE_FWNODE(node), adr);
+}
+#else
+static int lstp_acpi_read_adr(struct fwnode_handle *node, u64 *adr)
+{
+ return -ENODATA;
+}
+#endif
+
+/*
+ * The address of an interface or channel node: on ACPI the _ADR of a Device(),
+ * compared in full, so a value above the interface number or channel ID range
+ * never matches; elsewhere its "reg". A _DSD data node has no address.
+ */
+static int lstp_fwnode_read_address(struct fwnode_handle *node, u64 *addr)
+{
+ u32 reg;
+ int ret;
+
+ if (is_acpi_node(node))
+ return lstp_acpi_read_adr(node, addr);
+
+ ret = fwnode_property_read_u32(node, "reg", ®);
+ if (!ret)
+ *addr = reg;
+ return ret;
+}
+
+/*
+ * A _DSD data node has no _ADR, so it never matches an interface or channel;
+ * warn rather than leave the table's mistake silent.
+ */
+static void lstp_check_acpi_data_node(struct lstp_usb *dev, struct fwnode_handle *node)
+{
+ if (is_acpi_data_node(node))
+ dev_warn(&dev->intf->dev,
+ "%s: %pfw: ACPI _DSD data node, not a Device(); interface and channel objects must be Device() objects with _ADR\n",
+ __func__, node);
+}
+
+/*
+ * The node the channel nodes hang off, with a reference, or NULL; see
+ * Documentation/driver-api/usb/lstp.rst.
+ */
+static struct fwnode_handle *lstp_find_intf_fwnode(struct lstp_usb *dev)
+{
+ struct fwnode_handle *udev_node = dev_fwnode(&dev->udev->dev);
+ u8 ifnum = dev->intf->cur_altsetting->desc.bInterfaceNumber;
+ struct fwnode_handle *child;
+ u64 addr;
+
+ if (!udev_node)
+ return NULL;
+
+ if (is_of_node(udev_node)) {
+ lstp_check_of_layout(dev);
+ return fwnode_handle_get(dev_fwnode(&dev->intf->dev));
+ }
+
+ fwnode_for_each_child_node(udev_node, child) {
+ if (!lstp_fwnode_read_address(child, &addr) && addr == ifnum)
+ return child;
+ }
+
+ /* Only once nothing matched: other children may describe other interfaces. */
+ fwnode_for_each_child_node(udev_node, child)
+ lstp_check_acpi_data_node(dev, child);
+
+ return NULL;
+}
+
+static void lstp_put_fwnode(void *data)
+{
+ fwnode_handle_put(data);
+}
+
+static int lstp_init_intf_fwnode(struct lstp_usb *dev)
+{
+ struct fwnode_handle *child;
+
+ dev->intf_fwnode = lstp_find_intf_fwnode(dev);
+ if (!dev->intf_fwnode)
+ return 0;
+
+ if (is_acpi_node(dev->intf_fwnode)) {
+ fwnode_for_each_child_node(dev->intf_fwnode, child)
+ lstp_check_acpi_data_node(dev, child);
+ }
+
+ return devm_add_action_or_reset(&dev->intf->dev, lstp_put_fwnode, dev->intf_fwnode);
+}
+
+static bool lstp_channel_fwnode_matches(struct fwnode_handle *node, u8 channel_id,
+ const char *compatible)
+{
+ u64 addr;
+
+ return !lstp_fwnode_read_address(node, &addr) && addr == channel_id &&
+ fwnode_property_match_string(node, "compatible", compatible) >= 0;
+}
+
+/*
+ * The child of @parent matching @channel_id and @compatible, with a reference,
+ * or NULL. Disabled OF nodes are matched too, so that they remove the channel;
+ * see Documentation/driver-api/usb/lstp.rst for the iterator choice.
+ */
+static struct fwnode_handle *lstp_find_channel_fwnode(struct fwnode_handle *parent, u8 channel_id,
+ const char *compatible)
+{
+ struct fwnode_handle *ch_node;
+
+ if (is_of_node(parent)) {
+ for_each_child_of_node_scoped(to_of_node(parent), np) {
+ if (lstp_channel_fwnode_matches(of_fwnode_handle(np), channel_id,
+ compatible))
+ return of_fwnode_handle(of_node_get(np));
+ }
+ return NULL;
+ }
+
+ fwnode_for_each_child_node(parent, ch_node) {
+ if (lstp_channel_fwnode_matches(ch_node, channel_id, compatible))
+ return ch_node;
+ }
+
+ return NULL;
+}
+
+/*
+ * Store @ch's firmware node, if any, in @ch->fwnode. The channel owns the one
+ * reference and drops it in lstp_channel_free(); a subsystem that points
+ * another device at @ch->fwnode must not put it. Returns false for a disabled
+ * device tree node, whose channel is then not created. See
+ * Documentation/driver-api/usb/lstp.rst.
+ */
+static bool lstp_init_channel_fwnode(struct lstp_channel *ch, const char *compatible)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (!compatible)
+ return true;
+
+ ch->fwnode = lstp_find_channel_fwnode(priv->usb->intf_fwnode, ch->ch_id, compatible);
+
+ if (is_of_node(ch->fwnode) && !fwnode_device_is_available(ch->fwnode)) {
+ dev_info(&priv->usb->intf->dev, "%s: ch_%d: skipping disabled channel %pfw\n",
+ __func__, ch->ch_id, ch->fwnode);
+ fwnode_handle_put(ch->fwnode);
+ ch->fwnode = NULL;
+ return false;
+ }
+
+ dev_dbg(&priv->usb->intf->dev, "%s: ch_%d: %s firmware node for \"%s\"\n", __func__,
+ ch->ch_id, ch->fwnode ? "matched" : "no", compatible);
+
+ return true;
+}
+
+static int lstp_aux_notifier_register(struct lstp_usb *dev, struct auxiliary_device *auxdev);
+
+/*
+ * Allocate @resp_buf and the IRQ response slot (@tx_resp_buf,
+ * @bulk_tx_resp_urb). Devm on the USB interface, not on ch->dev, so the auxdev
+ * stays devres-clean for its driver; see lstp_channel_quiesce_unbound(). ch0
+ * allocates its own @resp_buf.
+ */
+static int lstp_alloc_channel_bufs(struct lstp_channel *ch)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+ struct device *idev = &priv->usb->intf->dev;
+
+ priv->resp_buf = devm_kzalloc(idev, priv->usb->bulk_rx_size, GFP_KERNEL);
+ if (!priv->resp_buf)
+ return -ENOMEM;
+
+ priv->tx_resp_buf = devm_kzalloc(idev, sizeof(struct lstp_header), GFP_KERNEL);
+ if (!priv->tx_resp_buf)
+ return -ENOMEM;
+
+ priv->bulk_tx_resp_urb = usb_alloc_urb(0, GFP_KERNEL);
+ if (!priv->bulk_tx_resp_urb)
+ return -ENOMEM;
+
+ return devm_add_action_or_reset(idev, lstp_release_urb_slot, &priv->bulk_tx_resp_urb);
+}
+
+/*
+ * Allocate @irq_buf at the first bind of a driver that takes unsolicited
+ * packets; a rebind reuses it. Owned by the container and freed with it, so
+ * an unbind cannot free it under lstp_usb_rx_callback(), and an interface
+ * unwind running beside a first bind cannot strand it.
+ */
+static int lstp_alloc_channel_irq_bufs(struct lstp_channel_priv *priv)
+{
+ void *irq_buf;
+
+ /* Bind paths only, serialised by device_lock, so the load is unordered. */
+ if (priv->irq_buf)
+ return 0;
+
+ irq_buf = kzalloc(priv->usb->bulk_rx_size, GFP_KERNEL);
+ if (!irq_buf)
+ return -ENOMEM;
+
+ /* Pairs with smp_load_acquire() in lstp_usb_rx_callback(): publish it zeroed. */
+ smp_store_release(&priv->irq_buf, irq_buf);
+
+ return 0;
+}
+
+/*
+ * Free the instance id, mutexes, firmware-node reference, @irq_buf,
+ * platform_data carrier and the container. Both URBs are interface devres,
+ * already gone, and RX is stopped, so nothing can still read @irq_buf.
+ */
+static void lstp_channel_free(struct lstp_channel_priv *priv)
+{
+ /* Here, not at bus removal, so a live device's id cannot be recycled. */
+ if (priv->auxdev_state != LSTP_AUXDEV_RAW)
+ ida_free(&lstp_auxdev_ida, priv->auxdev.id);
+ mutex_destroy(&priv->tx_mutex);
+ mutex_destroy(&priv->cfg_lock);
+ fwnode_handle_put(priv->pub.fwnode);
+ kfree(priv->irq_buf);
+ kfree(priv->auxdev.dev.platform_data);
+ kfree(priv);
+ if (atomic_dec_and_test(&lstp_live_objects))
+ wake_up_var(&lstp_live_objects);
+}
+
+/* Sole free site for an init'd container, on its auxdev's last put. */
+static void lstp_channel_dev_release(struct device *dev)
+{
+ lstp_channel_free(to_lstp_priv_from_auxdev(to_auxiliary_dev(dev)));
+}
+
+static void lstp_channel_destroy_action(void *data)
+{
+ struct lstp_channel_priv *priv = data;
+
+ switch (priv->auxdev_state) {
+ case LSTP_AUXDEV_ADDED:
+ auxiliary_device_delete(&priv->auxdev);
+ priv->usb = NULL;
+ fallthrough;
+ case LSTP_AUXDEV_INITED:
+ /* Drops the init ref; release -> lstp_channel_dev_release(). */
+ auxiliary_device_uninit(&priv->auxdev);
+ break;
+ case LSTP_AUXDEV_RAW:
+ lstp_channel_free(priv);
+ break;
+ }
+}
+
+/*
+ * Allocate a channel container and publish it in dev->channels[]. Its auxdev
+ * is set up once the channel type is known. Returns NULL on failure.
+ */
+static struct lstp_channel *lstp_create_channel(struct lstp_usb *dev, u8 ch_id)
+{
+ struct lstp_channel_priv *priv = kzalloc_obj(*priv);
+
+ if (!priv)
+ return NULL;
+ atomic_inc(&lstp_live_objects);
+ struct lstp_channel *ch = &priv->pub;
+
+ priv->usb = dev;
+ priv->auxdev_state = LSTP_AUXDEV_RAW;
+ mutex_init(&priv->tx_mutex);
+ mutex_init(&priv->cfg_lock);
+ spin_lock_init(&priv->irq_cb_lock);
+ init_waitqueue_head(&priv->rx_wq);
+
+ /* Registered first so it unwinds last, after actions that use @priv. */
+ if (devm_add_action_or_reset(&dev->intf->dev, lstp_channel_destroy_action, priv))
+ return NULL;
+
+ priv->tx_buf = devm_kzalloc(&dev->intf->dev, dev->bulk_tx_size, GFP_KERNEL);
+ if (!priv->tx_buf)
+ return NULL;
+
+ priv->bulk_tx_urb = usb_alloc_urb(0, GFP_KERNEL);
+ if (!priv->bulk_tx_urb)
+ return NULL;
+ if (devm_add_action_or_reset(&dev->intf->dev, lstp_release_urb_slot, &priv->bulk_tx_urb))
+ return NULL;
+
+ ch->ch_id = ch_id;
+ ch->dev = &dev->intf->dev;
+ ch->max_tx_payload = dev->bulk_tx_size - sizeof(struct lstp_header);
+ ch->max_rx_payload = dev->bulk_rx_size - sizeof(struct lstp_header);
+ /* Pairs with smp_load_acquire() in lstp_usb_rx_callback(). */
+ smp_store_release(&dev->channels[ch_id], ch);
+ return ch;
+}
+
+static int lstp_ch0_init(struct lstp_usb *dev)
+{
+ struct lstp_channel *ch0 = lstp_create_channel(dev, 0);
+
+ if (!ch0) {
+ dev_err(&dev->intf->dev, "%s: Could not allocate channel 0\n", __func__);
+ return -ENOMEM;
+ }
+ struct lstp_channel_priv *priv0 = to_lstp_priv(ch0);
+
+ priv0->ch_type = LSTP_CHANNEL_TYPE_MGMT;
+ priv0->resp_buf = devm_kzalloc(&dev->intf->dev, dev->bulk_rx_size, GFP_KERNEL);
+ if (!priv0->resp_buf)
+ return -ENOMEM;
+ return 0;
+}
+
+/* Each discovery pass thrown away costs at least one response timeout. */
+#define LSTP_DISCOVERY_PASSES 3
+
+/* Every channel's READ_CONFIG reply from one pass, read before any is offered. */
+struct lstp_discovery {
+ struct lstp_ch0_read_resp *resp[LSTP_MAX_CHANNELS];
+ size_t resp_len[LSTP_MAX_CHANNELS];
+ int err[LSTP_MAX_CHANNELS];
+};
+
+static void lstp_discovery_reset(struct lstp_discovery *d)
+{
+ for (int i = 0; i < LSTP_MAX_CHANNELS; i++)
+ kfree(d->resp[i]);
+ memset(d, 0, sizeof(*d));
+}
+
+static void lstp_discovery_free(struct lstp_discovery *d)
+{
+ if (d)
+ lstp_discovery_reset(d);
+ kfree(d);
+}
+
+DEFINE_FREE(lstp_discovery, struct lstp_discovery *, lstp_discovery_free(_T))
+
+/* A reply that cannot answer its read (see lstp_discover()); positive, unlike an errno. */
+static int lstp_discovery_stale(struct lstp_usb *dev, u8 ch_id, const char *why)
+{
+ dev_warn(&dev->intf->dev, "%s: ch_%u: Stale reply during discovery (%s), resynchronizing\n",
+ __func__, ch_id, why);
+ return 1;
+}
+
+/* Drops while only ch0 exists: ch0 replies in its rx_late, others in rx_no_channel. */
+static s64 lstp_discovery_dropped(struct lstp_usb *dev)
+{
+ struct lstp_channel_priv *priv0 = to_lstp_priv(dev->channels[0]);
+
+ return atomic64_read(&priv0->stats.rx_late) + atomic64_read(&dev->stats.rx_no_channel);
+}
+
+/*
+ * Let the replies to requests an earlier binding abandoned arrive and be
+ * dropped. Returns once a whole response timeout passes without one, after
+ * LSTP_DISCOVERY_PASSES timeouts, or when the device is gone.
+ */
+static void lstp_discovery_drain(struct lstp_usb *dev)
+{
+ for (int i = 0; i < LSTP_DISCOVERY_PASSES && !lstp_usb_gone(dev); i++) {
+ s64 seen = lstp_discovery_dropped(dev);
+
+ msleep(LSTP_USB_RESPONSE_TIMEOUT_MS);
+ if (lstp_discovery_dropped(dev) == seen)
+ return;
+ }
+}
+
+/*
+ * Read ch0's descriptor into @dev. Returns 0, 1 for a stale reply unless this
+ * is the @last pass, or a negative errno.
+ */
+static int lstp_discover_ch0(struct lstp_usb *dev, bool last)
+{
+ struct lstp_ch0_read_resp *resp __free(kfree) = NULL;
+ struct lstp_channel *ch0 = dev->channels[0];
+ size_t need = sizeof(*resp) + sizeof(struct lstp_ch0_config);
+ const char *stale = NULL;
+ size_t actual;
+ int ret = __lstp_ch0_read_config(dev, 0, 0, LSTP_READ_CONFIG_MAX, &resp, &actual);
+
+ if (ret == -ETIMEDOUT)
+ stale = "no reply";
+ else if (!ret && actual < need)
+ stale = "short reply";
+ else if (!ret && resp->desc.ch_type != LSTP_CHANNEL_TYPE_MGMT)
+ stale = "not the management channel";
+ if (stale && !last)
+ return lstp_discovery_stale(dev, 0, stale);
+ if (ret)
+ return ret;
+
+ if (actual < need) {
+ dev_err(&dev->intf->dev, "%s: ch_0: READ_CONFIG short reply: %zu < %zu\n", __func__,
+ actual, need);
+ return -EIO;
+ }
+ const struct lstp_ch0_config *config = (const struct lstp_ch0_config *)resp->ch_config;
+
+ if (resp->desc.ch_type != LSTP_CHANNEL_TYPE_MGMT) {
+ dev_err(&dev->intf->dev, "%s: ch_0: Received wrong channel 0 type (got %d)\n",
+ __func__, resp->desc.ch_type);
+ return -EINVAL;
+ }
+
+ if (resp->desc.ch_name[0] == '\0') {
+ dev_warn(&dev->intf->dev,
+ "%s: ch_0: Empty LSTP interface name, consider fixing it! Using default 'LSTP'\n",
+ __func__);
+ strscpy(dev->lstp_intf_name, "LSTP", sizeof(dev->lstp_intf_name));
+ } else {
+ snprintf(dev->lstp_intf_name, sizeof(dev->lstp_intf_name), "%.*s", LSTP_CH_NAME_LEN,
+ resp->desc.ch_name);
+ }
+ strscpy(ch0->display_name, dev->lstp_intf_name, sizeof(ch0->display_name));
+
+ if (config->lstp_version != LSTP_VERSION) {
+ dev_err(&dev->intf->dev, "%s: ch_0: Invalid LSTP version\n", __func__);
+ return -EINVAL;
+ }
+ dev->lstp_version = config->lstp_version;
+
+ BUILD_BUG_ON(type_max(typeof_member(struct lstp_ch0_config, num_channels)) >=
+ LSTP_MAX_CHANNELS);
+ if (config->num_channels == 0) {
+ dev_err(&dev->intf->dev, "%s: ch_0: Invalid channel count %d (min 1, max %d)\n",
+ __func__, config->num_channels, LSTP_MAX_CHANNELS - 1);
+ return -EINVAL;
+ }
+ dev->max_ch_id = config->num_channels;
+ return 0;
+}
+
+/*
+ * Read channels 1..max_ch_id into @d. A failed read is kept in @d->err and its
+ * channel skipped; 1 for a stale reply as for lstp_discover_ch0().
+ */
+static int lstp_discover_channels(struct lstp_usb *dev, struct lstp_discovery *d, bool last)
+{
+ for (int ch_id = 1; ch_id <= dev->max_ch_id; ch_id++) {
+ const char *stale = NULL;
+ int ret = __lstp_ch0_read_config(dev, ch_id, 0, LSTP_READ_CONFIG_MAX,
+ &d->resp[ch_id], &d->resp_len[ch_id]);
+
+ if (ret == -ETIMEDOUT)
+ stale = "no reply";
+ else if (!ret && d->resp[ch_id]->desc.ch_type == LSTP_CHANNEL_TYPE_MGMT)
+ stale = "management channel descriptor";
+ if (stale && last) {
+ dev_err(&dev->intf->dev,
+ "%s: ch_%u: Stale reply on the last discovery pass (%s)\n",
+ __func__, ch_id, stale);
+ return ret ?: -EIO;
+ }
+ if (stale)
+ return lstp_discovery_stale(dev, ch_id, stale);
+ d->err[ch_id] = ret;
+ }
+ return 0;
+}
+
+/*
+ * Read every channel descriptor, resynchronizing first if a reply is stale.
+ *
+ * The device still answers requests an earlier binding abandoned, and no
+ * reply names its request (see struct lstp_header). ch0 answers in order, so
+ * a pass is thrown away, the stale replies drained and discovery restarted
+ * from ch0 when a reply cannot be its read's own or a read gets none. No
+ * channel is created before a pass completes. The last pass fails instead.
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+static int lstp_discover(struct lstp_usb *dev, struct lstp_discovery *d)
+{
+ for (int pass = 1;; pass++) {
+ bool last = pass == LSTP_DISCOVERY_PASSES;
+ int ret = lstp_discover_ch0(dev, last);
+
+ if (!ret)
+ ret = lstp_discover_channels(dev, d, last);
+ if (ret <= 0)
+ return ret;
+ lstp_discovery_reset(d);
+ lstp_discovery_drain(dev);
+ }
+}
+
+/* clang-format off */
+static const char * const lstp_ch_type_tags[] = {
+ [LSTP_CHANNEL_TYPE_SPI] = "SPI",
+ [LSTP_CHANNEL_TYPE_GPIO] = "GPIO",
+ [LSTP_CHANNEL_TYPE_I2C] = "I2C",
+ [LSTP_CHANNEL_TYPE_UART] = "UART",
+ [LSTP_CHANNEL_TYPE_IPMI] = "IPMI",
+ [LSTP_CHANNEL_TYPE_MMIO] = "MMIO",
+}; /* clang-format on */
+
+/*
+ * Set ch->display_name from the firmware @ch_name (not NUL-terminated), or the
+ * userspace-visible fallback "<intf_name>_<TYPE>_CH<id>". Needs ch_id, ch_type.
+ */
+static void lstp_set_display_name(struct lstp_channel *ch, const char *ch_name, size_t ch_name_len)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+ size_t name_len = strnlen(ch_name, ch_name_len);
+
+ if (name_len) {
+ snprintf(ch->display_name, sizeof(ch->display_name), "%s_%.*s",
+ priv->usb->lstp_intf_name, (int)name_len, ch_name);
+ return;
+ }
+
+ const char *tag = (priv->ch_type < ARRAY_SIZE(lstp_ch_type_tags)) ?
+ lstp_ch_type_tags[priv->ch_type] :
+ NULL;
+ if (!tag)
+ tag = "UNKNOWN";
+
+ snprintf(ch->display_name, sizeof(ch->display_name), "%s_%s_CH%u",
+ priv->usb->lstp_intf_name, tag, ch->ch_id);
+ dev_warn(ch->dev, "%s: ch_%d: Empty channel name, consider fixing it! Using default '%s'\n",
+ __func__, ch->ch_id, ch->display_name);
+}
+
+/*
+ * Set up the channel's auxdev and take its instance id (LSTP_AUXDEV_INITED).
+ * @config is copied into a container-owned platform_data carrier, so it
+ * outlives the discovery scratch and every rebind.
+ */
+static int lstp_init_channel_auxdev(struct lstp_channel_priv *priv, const void *config,
+ size_t config_len)
+{
+ struct lstp_channel_init_info *info;
+ void *blob;
+ int ret;
+
+ priv->auxdev.dev.parent = &priv->usb->intf->dev;
+ priv->auxdev.dev.release = lstp_channel_dev_release;
+ priv->auxdev.dev.groups = lstp_channel_groups;
+ priv->auxdev.name = priv->type->name;
+
+ /* Carrier and blob in one allocation, freed with the container. */
+ info = kzalloc(size_add(sizeof(*info), config_len), GFP_KERNEL);
+ if (!info)
+ return -ENOMEM;
+ blob = info + 1;
+ memcpy(blob, config, config_len);
+ info->config = blob;
+ info->config_len = config_len;
+ priv->auxdev.dev.platform_data = info;
+
+ ret = ida_alloc(&lstp_auxdev_ida, GFP_KERNEL);
+ if (ret < 0)
+ return ret;
+ priv->auxdev.id = ret;
+
+ ret = auxiliary_device_init(&priv->auxdev);
+ if (ret) {
+ ida_free(&lstp_auxdev_ida, priv->auxdev.id);
+ return ret;
+ }
+ /* lstp_nack_undelivered() reads it locklessly once the channel is published. */
+ WRITE_ONCE(priv->auxdev_state, LSTP_AUXDEV_INITED);
+
+ return 0;
+}
+
+static const struct lstp_channel_type_info lstp_channel_types[LSTP_CHANNEL_TYPE_MAX] = {
+ [LSTP_CHANNEL_TYPE_SPI] = {
+ .name = "spi",
+ .compatible = "nvidia,lstp-spi",
+ },
+ [LSTP_CHANNEL_TYPE_GPIO] = {
+ .name = "gpio",
+ .compatible = "nvidia,lstp-gpio",
+ },
+ [LSTP_CHANNEL_TYPE_I2C] = {
+ .name = "i2c",
+ .compatible = "nvidia,lstp-i2c",
+ },
+ [LSTP_CHANNEL_TYPE_UART] = {
+ .name = "uart",
+ .compatible = "nvidia,lstp-uart",
+ .irq_needs_resp = true,
+ },
+ [LSTP_CHANNEL_TYPE_IPMI] = {
+ .name = "ipmi",
+ .compatible = "nvidia,lstp-ipmi",
+ },
+ /* No compatible: a miscdevice has no firmware children or consumers. */
+ [LSTP_CHANNEL_TYPE_MMIO] = {
+ .name = "mmio",
+ },
+};
+
+/* @ch_type is firmware-reported; NULL for ch0's type and any type not listed. */
+static const struct lstp_channel_type_info *lstp_channel_type_lookup(u8 ch_type)
+{
+ if (ch_type >= ARRAY_SIZE(lstp_channel_types) || !lstp_channel_types[ch_type].name)
+ return NULL;
+
+ return &lstp_channel_types[ch_type];
+}
+
+/**
+ * lstp_init_subsys_channel() - Bring up a single subsystem channel (1..N).
+ * @dev: LSTP USB device
+ * @ch_id: Channel id to initialise
+ * @resp: The channel's READ_CONFIG reply, from lstp_discover()
+ * @resp_len: Bytes in @resp
+ *
+ * Creates the channel and offers its auxiliary device to the bus. An
+ * unimplemented channel type, or a disabled device tree node, is skipped.
+ *
+ * Return: 1 if offered to the bus, 0 if skipped, negative errno.
+ */
+static int lstp_init_subsys_channel(struct lstp_usb *dev, u8 ch_id,
+ const struct lstp_ch0_read_resp *resp, size_t resp_len)
+{
+ struct lstp_channel *ch = lstp_create_channel(dev, ch_id);
+
+ if (!ch)
+ return -ENOMEM;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+ int ret;
+
+ priv->ch_type = resp->desc.ch_type;
+ lstp_set_display_name(ch, resp->desc.ch_name, LSTP_CH_NAME_LEN);
+
+ priv->type = lstp_channel_type_lookup(priv->ch_type);
+ if (!priv->type) {
+ dev_warn(&dev->intf->dev, "%s: ch_%d: Unsupported channel type %d\n", __func__,
+ ch->ch_id, priv->ch_type);
+ return 0;
+ }
+
+ /* Before the auxdev takes an instance id, so a skipped channel holds none. */
+ if (!lstp_init_channel_fwnode(ch, priv->type->compatible)) {
+ priv->type = NULL;
+ return 0;
+ }
+
+ ret = lstp_init_channel_auxdev(priv, resp->ch_config, resp_len - sizeof(*resp));
+ if (ret)
+ goto err_clear_type;
+
+ /* The bus exists once an auxdev is init'd; hook it before the first add. */
+ ret = lstp_aux_notifier_register(dev, &priv->auxdev);
+ if (ret)
+ goto err_clear_type;
+
+ /* From here ch->dev is the auxdev; framework I/O stays on the interface. */
+ ch->dev = &priv->auxdev.dev;
+ device_set_node(&priv->auxdev.dev, ch->fwnode);
+
+ ret = lstp_alloc_channel_bufs(ch);
+ if (ret)
+ goto err_clear_type;
+
+ ret = auxiliary_device_add(&priv->auxdev);
+ if (ret)
+ goto err_clear_type;
+ /* Pairs with smp_load_acquire() in lstp_nack_undelivered(): @type and bufs. */
+ smp_store_release(&priv->auxdev_state, LSTP_AUXDEV_ADDED);
+
+ /* Not an error: the driver may be a module not yet loaded, or deferred. */
+ if (!priv->auxdev.dev.driver)
+ dev_dbg(ch->dev, "%s: ch_%d: No %s driver bound yet\n", __func__, ch->ch_id,
+ priv->type->name);
+
+ return 1;
+
+err_clear_type:
+ priv->type = NULL;
+ return ret;
+}
+
+/*
+ * Discover the device and offer channels 1..max_ch_id to the auxiliary bus.
+ * Returns 0, or a negative errno if ch0 fails; a failed channel is skipped.
+ */
+static int lstp_init_channels(struct lstp_usb *dev)
+{
+ struct lstp_discovery *d __free(lstp_discovery) = kzalloc_obj(*d);
+
+ if (!d)
+ return -ENOMEM;
+
+ int ret = lstp_ch0_init(dev);
+
+ if (ret)
+ return ret;
+ ret = lstp_discover(dev, d);
+ if (ret)
+ return ret;
+
+ dev_info(&dev->intf->dev, "%s: LSTP v%d: device %s discovered with %d channels\n", __func__,
+ dev->lstp_version, dev->lstp_intf_name, dev->max_ch_id);
+
+ unsigned int offered = 0;
+
+ for (int ch_id = 1; ch_id <= dev->max_ch_id; ch_id++) {
+ ret = d->err[ch_id];
+ if (!ret)
+ ret = lstp_init_subsys_channel(dev, ch_id, d->resp[ch_id],
+ d->resp_len[ch_id]);
+ if (ret < 0) {
+ dev_err(&dev->intf->dev,
+ "%s: ch_%d: Channel initialization failed. (%pe)\n", __func__,
+ ch_id, ERR_PTR(ret));
+ continue;
+ }
+ offered += ret;
+ }
+
+ dev_info(&dev->intf->dev, "%s: offered %u of %u advertised channels to the bus\n", __func__,
+ offered, dev->max_ch_id);
+
+ return 0;
+}
+
+/**
+ * lstp_probe() - USB driver probe function.
+ * @intf: USB interface being probed
+ * @id: USB device ID that matched
+ *
+ * Creates lstp/ before discovery, so a consumer reacting to a new channel
+ * finds lstp/name. Succeeds with no channel bound.
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+static int lstp_probe(struct usb_interface *intf, const struct usb_device_id *id)
+{
+ struct usb_device *udev = usb_get_dev(interface_to_usbdev(intf));
+ struct lstp_usb *dev = devm_kzalloc(&intf->dev, sizeof(*dev), GFP_KERNEL);
+ struct usb_endpoint_descriptor *ep_in, *ep_out;
+
+ if (!dev) {
+ usb_put_dev(udev);
+ return -ENOMEM;
+ }
+
+ int ret = devm_add_action_or_reset(&intf->dev, lstp_put_usb_dev, udev);
+
+ if (ret)
+ return ret;
+
+ ret = usb_find_common_endpoints(intf->cur_altsetting, &ep_in, &ep_out, NULL, NULL);
+ if (ret) {
+ dev_err(&intf->dev, "%s: Could not find bulk endpoints\n", __func__);
+ return ret;
+ }
+
+ dev->udev = udev;
+ dev->intf = intf;
+ dev->max_ch_id = 255; /* Maximum possible before device discovery */
+ dev->bulk_in_ep = ep_in->bEndpointAddress;
+ dev->bulk_out_ep = ep_out->bEndpointAddress;
+ dev->bulk_tx_size = min_t(size_t, usb_endpoint_maxp(ep_out), LSTP_USB_EP_MAX_SIZE);
+ dev->bulk_rx_size = min_t(size_t, usb_endpoint_maxp(ep_in), LSTP_USB_EP_MAX_SIZE);
+
+ if (dev->bulk_tx_size < LSTP_USB_EP_MIN_SIZE || dev->bulk_rx_size < LSTP_USB_EP_MIN_SIZE) {
+ dev_err(&intf->dev, "%s: Invalid endpoint sizes (tx=%zu, rx=%zu, min=%u)\n",
+ __func__, dev->bulk_tx_size, dev->bulk_rx_size, LSTP_USB_EP_MIN_SIZE);
+ return -EINVAL;
+ }
+
+ ret = lstp_init_intf_fwnode(dev);
+ if (ret)
+ return ret;
+
+ dev->rx_buf = devm_kzalloc(&intf->dev, dev->bulk_rx_size, GFP_KERNEL);
+ if (!dev->rx_buf)
+ return -ENOMEM;
+
+ dev->bulk_rx_urb = usb_alloc_urb(0, GFP_KERNEL);
+ if (!dev->bulk_rx_urb)
+ return -ENOMEM;
+ ret = devm_add_action_or_reset(&intf->dev, lstp_release_urb_slot, &dev->bulk_rx_urb);
+ if (ret)
+ return ret;
+
+ usb_set_intfdata(intf, dev);
+
+ INIT_DELAYED_WORK(&dev->bulk_rx_retry.work, lstp_rx_retry_work);
+
+ usb_fill_bulk_urb(dev->bulk_rx_urb, dev->udev, usb_rcvbulkpipe(dev->udev, dev->bulk_in_ep),
+ dev->rx_buf, dev->bulk_rx_size, lstp_usb_rx_callback, dev);
+ ret = usb_submit_urb(dev->bulk_rx_urb, GFP_KERNEL);
+ if (ret) {
+ dev_err(&intf->dev, "%s: Could not submit bulk RX URB (%pe)\n", __func__,
+ ERR_PTR(ret));
+ return ret;
+ }
+
+ ret = lstp_create_sysfs_hierarchy(dev);
+ if (ret) {
+ dev_err(&intf->dev, "%s: Failed to create sysfs hierarchy (%pe)\n", __func__,
+ ERR_PTR(ret));
+ goto err_teardown;
+ }
+
+ ret = lstp_init_channels(dev);
+ if (ret)
+ goto err_teardown;
+
+ dev_info(&intf->dev, "%s: LSTP device initialized successfully\n", __func__);
+ return 0;
+
+err_teardown:
+ dev_err(&intf->dev, "%s: Probe failed (%pe)\n", __func__, ERR_PTR(ret));
+ lstp_teardown(dev);
+ return ret;
+}
+
+/* Raise the permanent half of the I/O fence; nothing ever clears it. */
+static void lstp_channel_mark_gone(struct lstp_channel *ch)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ /* Release; pairs with smp_load_acquire() in lstp_channel_disconnected(). */
+ smp_store_release(&priv->gone, true);
+ wake_up_all(&priv->rx_wq);
+}
+
+/* Raise the half of the I/O fence that the next bind clears; see @unbound. */
+static void lstp_channel_mark_unbound(struct lstp_channel *ch)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ /* Pairs with smp_load_acquire() in lstp_channel_disconnected(). */
+ smp_store_release(&priv->unbound, true);
+ wake_up_all(&priv->rx_wq);
+}
+
+static void lstp_signal_disconnect(struct lstp_usb *dev)
+{
+ for (int i = 0; i < LSTP_MAX_CHANNELS; i++) {
+ /* Pairs with smp_store_release() in lstp_create_channel(). */
+ struct lstp_channel *ch = smp_load_acquire(&dev->channels[i]);
+
+ if (ch)
+ lstp_channel_mark_gone(ch);
+ }
+}
+
+/* @aux_nb.notifier_call doubles as the "already registered" flag; clear it. */
+static void lstp_aux_notifier_unregister(void *data)
+{
+ struct lstp_usb *dev = data;
+
+ bus_unregister_notifier(dev->aux_bus, &dev->aux_nb);
+ dev->aux_nb.notifier_call = NULL;
+ dev->aux_bus = NULL;
+}
+
+static const struct lstp_ops *lstp_bound_driver_ops(struct device_driver *drv);
+
+/*
+ * Fence a channel and reclaim its TX URBs, at the tail of the driver's own
+ * unwind: the BIND arm books this as devres on the channel auxdev. Killed,
+ * not poisoned, so a rebind can submit again. Once @gone is up the URBs
+ * belong to interface teardown, which frees them without this auxdev's lock.
+ * See Documentation/driver-api/usb/lstp.rst.
+ */
+static void lstp_channel_quiesce_unbound(void *data)
+{
+ struct lstp_channel_priv *priv = data;
+
+ lstp_channel_mark_unbound(&priv->pub);
+
+ /* A request that passed the fence finishes and drops tx_mutex here. */
+ guard(mutex)(&priv->tx_mutex);
+ /* lstp_drain_inflight() takes tx_mutex after raising @gone. */
+ if (smp_load_acquire(&priv->gone))
+ return;
+
+ usb_kill_urb(priv->bulk_tx_urb);
+ usb_kill_urb(priv->bulk_tx_resp_urb);
+}
+
+/**
+ * lstp_aux_bus_notify() - One auxiliary-bus notifier per lstp_usb.
+ * @nb: The @aux_nb embedded in the owning lstp_usb.
+ * @action: The BUS_NOTIFY_* edge the driver core is reporting.
+ * @data: The struct device the edge is about.
+ *
+ * Handles every bind/unbind edge of this device's channels. The edges the bus
+ * does not report are listed in Documentation/driver-api/usb/lstp.rst.
+ *
+ * Context: Process context, with the notified device's device_lock held by the
+ * driver core.
+ * Return: %NOTIFY_DONE always; this notifier observes, it does not veto.
+ */
+static int lstp_aux_bus_notify(struct notifier_block *nb, unsigned long action, void *data)
+{
+ struct lstp_usb *dev = container_of(nb, struct lstp_usb, aux_nb);
+ struct device *cdev = data;
+ struct lstp_channel_priv *priv;
+ const struct lstp_ops *ops;
+
+ if (cdev->release != lstp_channel_dev_release)
+ return NOTIFY_DONE;
+ priv = to_lstp_priv_from_auxdev(to_auxiliary_dev(cdev));
+ if (priv->usb != dev)
+ return NOTIFY_DONE;
+
+ switch (action) {
+ case BUS_NOTIFY_BIND_DRIVER:
+ /*
+ * Before .probe(): book the re-fence. Devres is LIFO, so it
+ * fires after everything the driver goes on to register.
+ */
+ if (devm_add_action(cdev, lstp_channel_quiesce_unbound, priv)) {
+ /* lstp_aux_probe() fails the bind on the raised fence. */
+ lstp_channel_mark_unbound(&priv->pub);
+ dev_warn(cdev, "%s: ch_%d: Could not book the unbind fence\n", __func__,
+ priv->pub.ch_id);
+ break;
+ }
+ /* Lift the fence before .probe(); @gone is not touched. */
+ smp_store_release(&priv->unbound, false);
+ break;
+ case BUS_NOTIFY_BOUND_DRIVER:
+ /* After .probe(): publish the dispatch handle. */
+ ops = lstp_bound_driver_ops(cdev->driver);
+ scoped_guard(spinlock_irqsave, &priv->irq_cb_lock)
+ priv->irq_ops = ops;
+ /* Open RX dispatch; lstp_usb_rx_callback() load-acquires. */
+ smp_store_release(&priv->started, true);
+ break;
+ case BUS_NOTIFY_UNBIND_DRIVER:
+ /*
+ * Before .remove(): retract dispatch, so no IRQ reaches what
+ * .remove() frees. The fence stays down for .remove() and the
+ * driver's devres unwind.
+ */
+ smp_store_release(&priv->started, false);
+ scoped_guard(spinlock_irqsave, &priv->irq_cb_lock)
+ priv->irq_ops = NULL;
+ break;
+ case BUS_NOTIFY_DRIVER_NOT_BOUND:
+ case BUS_NOTIFY_UNBOUND_DRIVER:
+ /*
+ * UNBOUND follows .remove() and the auxdev's devres; NOT_BOUND
+ * precedes a failed probe's devres unwind, which must therefore
+ * not reach the bind's state through @priv.
+ */
+ priv->pub.priv = NULL;
+ break;
+ }
+ return NOTIFY_DONE;
+}
+
+/*
+ * Register the per-device aux-bus notifier once, before the first
+ * auxiliary_device_add(), so an already-registered driver's first BOUND is
+ * seen. The bus comes from the auxdev: auxiliary_bus_type is not exported.
+ */
+static int lstp_aux_notifier_register(struct lstp_usb *dev, struct auxiliary_device *auxdev)
+{
+ int ret;
+
+ if (dev->aux_nb.notifier_call)
+ return 0;
+ dev->aux_bus = auxdev->dev.bus;
+ dev->aux_nb.notifier_call = lstp_aux_bus_notify;
+ ret = bus_register_notifier(dev->aux_bus, &dev->aux_nb);
+ if (ret) {
+ dev->aux_nb.notifier_call = NULL;
+ dev->aux_bus = NULL;
+ return ret;
+ }
+ return devm_add_action_or_reset(&dev->intf->dev, lstp_aux_notifier_unregister, dev);
+}
+
+static void lstp_ch_signal_response(struct lstp_channel *ch)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ /* Pairs with smp_load_acquire() in lstp_ch_got_response(): @resp_buf first. */
+ smp_store_release(&priv->rx_ready, true);
+ wake_up_all(&priv->rx_wq);
+}
+
+static inline bool lstp_ch_got_response(struct lstp_channel *ch)
+{
+ /* Acquire pairs with the smp_store_release() in lstp_ch_signal_response(). */
+ return smp_load_acquire(&to_lstp_priv(ch)->rx_ready);
+}
+
+static inline bool lstp_ch_should_wake(struct lstp_channel *ch)
+{
+ return lstp_ch_got_response(ch) || lstp_channel_disconnected(ch);
+}
+
+/*
+ * Poison first: a resubmit racing in from the RX completion or the retry
+ * worker then takes -EPERM, which lstp_rx_handle_err() routes to the
+ * disconnect arm without rescheduling, so the cancel below cannot lose a
+ * self-requeue.
+ */
+static void lstp_stop_rx(struct lstp_usb *dev)
+{
+ usb_poison_urb(dev->bulk_rx_urb);
+ cancel_delayed_work_sync(&dev->bulk_rx_retry.work);
+}
+
+/* Poison every channel's TX URBs, so a racing usb_submit_urb() gets -EPERM. */
+static void lstp_stop_tx(struct lstp_usb *dev)
+{
+ for (int i = 0; i < LSTP_MAX_CHANNELS; i++) {
+ struct lstp_channel *ch = dev->channels[i];
+
+ if (!ch)
+ continue;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ usb_poison_urb(priv->bulk_tx_urb);
+ usb_poison_urb(priv->bulk_tx_resp_urb);
+ }
+}
+
+/*
+ * Wait out in-flight channel I/O. The fence is already raised, so a caller
+ * mid-submission finishes and drops tx_mutex, and every later one sees the
+ * fence under it. Nothing then touches @tx_buf or @resp_buf when devres frees
+ * them.
+ */
+static void lstp_drain_inflight(struct lstp_usb *dev)
+{
+ for (int i = 0; i < LSTP_MAX_CHANNELS; i++) {
+ struct lstp_channel *ch = dev->channels[i];
+
+ if (!ch)
+ continue;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ mutex_lock(&priv->tx_mutex);
+ mutex_unlock(&priv->tx_mutex);
+ }
+}
+
+/**
+ * lstp_teardown() - Ordered driver-level teardown of the LSTP device.
+ * @dev: LSTP USB device structure
+ *
+ * Shared with the lstp_probe() error path, since USB core does not call
+ * .disconnect() on probe failure. Subsystem teardown runs later, against freed
+ * framework buffers; the fence raised here, not the drain, keeps it off them.
+ * See Documentation/driver-api/usb/lstp.rst.
+ */
+static void lstp_teardown(struct lstp_usb *dev)
+{
+ /* RX must stop before aux_driver .remove() runs, or dispatch can race it. */
+ lstp_stop_rx(dev);
+
+ lstp_signal_disconnect(dev);
+ lstp_drain_inflight(dev);
+ lstp_stop_tx(dev);
+}
+
+/* USB .disconnect(); the rest unwinds via devres on interface unbind. */
+static void lstp_disconnect(struct usb_interface *intf)
+{
+ struct lstp_usb *dev = usb_get_intfdata(intf);
+
+ dev_info(&intf->dev, "%s: LSTP device disconnected\n", __func__);
+
+ if (!dev)
+ return;
+
+ lstp_teardown(dev);
+}
+
+static void lstp_usb_tx_callback(struct urb *urb)
+{
+ struct lstp_channel *ch = urb->context;
+
+ if (urb->status != 0 && urb->status != -ENOENT && urb->status != -ECONNRESET &&
+ urb->status != -ESHUTDOWN) {
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: TX URB error (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(urb->status));
+ }
+}
+
+/*
+ * Completion for @bulk_tx_resp_urb. Clears @irq_resp_buffer_lock on every
+ * path, kills included, so the bit cannot stay set across a re-probe.
+ */
+static void lstp_usb_resp_tx_callback(struct urb *urb)
+{
+ struct lstp_channel *ch = urb->context;
+
+ if (urb->status != 0 && urb->status != -ENOENT && urb->status != -ECONNRESET &&
+ urb->status != -ESHUTDOWN) {
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: RX response TX URB error (%pe)\n",
+ __func__, ch->ch_id, ERR_PTR(urb->status));
+ }
+
+ clear_bit(LSTP_BUFFER_LOCK_BIT, &to_lstp_priv(ch)->irq_resp_buffer_lock);
+}
+
+/**
+ * lstp_send_irq_resp() - Post a zero-payload response for an unsolicited RX packet.
+ * @ch: LSTP channel that received the IRQ packet
+ * @status: Status byte to return to firmware (bit 7 is forced to 1 = response)
+ *
+ * Failures are logged and swallowed. A response posted while the previous one
+ * is in flight is dropped; firmware keeps one request in flight, so that
+ * should not happen.
+ *
+ * Context: Atomic, from an ops->irq_packet handler on the USB RX completion
+ * path, or from the core's RX completion.
+ */
+void lstp_send_irq_resp(struct lstp_channel *ch, u8 status)
+{
+ if (!ch)
+ return;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (!priv->usb || !priv->usb->udev)
+ return;
+
+ /*
+ * NULL during interface unwind, and before the channel is offered,
+ * when lstp_nack_undelivered() does not call; see
+ * lstp_alloc_channel_bufs().
+ */
+ if (!priv->tx_resp_buf || !priv->bulk_tx_resp_urb)
+ return;
+
+ if (test_and_set_bit(LSTP_BUFFER_LOCK_BIT, &priv->irq_resp_buffer_lock)) {
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Dropping response - prior URB in flight\n",
+ __func__, ch->ch_id);
+ return;
+ }
+
+ struct lstp_packet *tx_pkt = (struct lstp_packet *)priv->tx_resp_buf;
+
+ tx_pkt->hdr.ch_id = ch->ch_id;
+ tx_pkt->hdr.length = cpu_to_le16(0);
+ tx_pkt->hdr.status = LSTP_HDR_RESPONSE | FIELD_PREP(LSTP_HDR_CODE, status);
+
+ usb_fill_bulk_urb(priv->bulk_tx_resp_urb, priv->usb->udev,
+ usb_sndbulkpipe(priv->usb->udev, priv->usb->bulk_out_ep), tx_pkt,
+ sizeof(struct lstp_header), lstp_usb_resp_tx_callback, ch);
+
+ int ret = usb_submit_urb(priv->bulk_tx_resp_urb, GFP_ATOMIC);
+
+ if (ret) {
+ clear_bit(LSTP_BUFFER_LOCK_BIT, &priv->irq_resp_buffer_lock);
+ /* Unbind kill, unplug or shutdown: expected, not an error. */
+ if (ret == -EPERM || ret == -ENODEV || ret == -ESHUTDOWN)
+ dev_dbg_ratelimited(ch->dev, "%s: ch_%d: Failed to submit TX URB (%pe)\n",
+ __func__, ch->ch_id, ERR_PTR(ret));
+ else
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Failed to submit TX URB (%pe)\n",
+ __func__, ch->ch_id, ERR_PTR(ret));
+ }
+}
+EXPORT_SYMBOL_NS_GPL(lstp_send_irq_resp, "LSTP");
+
+/*
+ * RX resubmits retry forever with bounded exponential backoff: an attempt
+ * budget would kill RX for good on a transient -ENOMEM. BASE_DELAY also
+ * throttles completion errors from a babbling device, and stays well under
+ * LSTP_USB_RESPONSE_TIMEOUT_MS.
+ */
+#define LSTP_RX_RETRY_BASE_DELAY_MS 50
+#define LSTP_RX_RETRY_MAX_DELAY_MS 1000
+#define LSTP_RX_RETRY_MAX_BACKOFF_SHIFT 5U
+
+static unsigned long lstp_rx_retry_backoff_ms(unsigned int failures)
+{
+ unsigned int shift = failures ? min(failures - 1, LSTP_RX_RETRY_MAX_BACKOFF_SHIFT) : 0;
+ unsigned long ms = (unsigned long)LSTP_RX_RETRY_BASE_DELAY_MS << shift;
+
+ return min_t(unsigned long, ms, LSTP_RX_RETRY_MAX_DELAY_MS);
+}
+
+/*
+ * Record @ret for lstp_rx_retry_work() and schedule it after @delay_ms, or
+ * signal disconnect on a terminal errno.
+ */
+static void lstp_rx_handle_err(struct lstp_usb *dev, int ret, unsigned long delay_ms)
+{
+ struct lstp_rx_retry *rxr = &dev->bulk_rx_retry;
+
+ WRITE_ONCE(rxr->last_err, ret);
+
+ /*
+ * lstp_stop_rx()'s poison (-EPERM), or the device or HCD gone: the
+ * expected disconnect, already logged by lstp_disconnect().
+ */
+ if (ret == -ENODEV || ret == -ESHUTDOWN || ret == -EPERM) {
+ lstp_signal_disconnect(dev);
+ return;
+ }
+
+ /* Wire-side errors can fire back-to-back; submit-side ones are rare. */
+ if (ret == -EPROTO || ret == -EOVERFLOW || ret == -EILSEQ)
+ dev_warn_ratelimited(&dev->intf->dev,
+ "%s: RX URB transient error (%pe), retry in %lums\n", __func__,
+ ERR_PTR(ret), delay_ms);
+ else
+ dev_warn(&dev->intf->dev, "%s: RX URB transient error (%pe), retry in %lums\n",
+ __func__, ERR_PTR(ret), delay_ms);
+
+ schedule_delayed_work(&rxr->work, msecs_to_jiffies(delay_ms));
+}
+
+/* Process context: clears an endpoint halt and resubmits with GFP_KERNEL. */
+static void lstp_rx_retry_work(struct work_struct *work)
+{
+ struct lstp_rx_retry *rxr = container_of(to_delayed_work(work), struct lstp_rx_retry, work);
+ struct lstp_usb *dev = container_of(rxr, struct lstp_usb, bulk_rx_retry);
+ int last_err = READ_ONCE(rxr->last_err);
+
+ if (last_err == -EPIPE) {
+ atomic64_inc(&dev->stats.rx_stalls);
+
+ int ret = usb_clear_halt(dev->udev, usb_rcvbulkpipe(dev->udev, dev->bulk_in_ep));
+
+ if (ret)
+ dev_warn(&dev->intf->dev, "%s: usb_clear_halt failed (%pe)\n", __func__,
+ ERR_PTR(ret));
+ }
+
+ atomic64_inc(&dev->stats.rx_retries);
+
+ int ret = usb_submit_urb(dev->bulk_rx_urb, GFP_KERNEL);
+
+ if (ret == 0) {
+ if (rxr->failures)
+ dev_info(&dev->intf->dev, "%s: RX URB resubmitted after %u failure(s)\n",
+ __func__, rxr->failures);
+ rxr->failures = 0;
+ return;
+ }
+
+ rxr->failures++;
+ lstp_rx_handle_err(dev, ret, lstp_rx_retry_backoff_ms(rxr->failures));
+}
+
+/**
+ * lstp_dispatch_irq_packet() - Deliver an unsolicited packet to the bound driver.
+ * @ch: Channel that received the unsolicited request.
+ * @pkt: Validated packet, valid only for this call.
+ *
+ * The only path from the RX completion into a subsystem. Reads @irq_ops under
+ * @irq_cb_lock, under which the notifier publishes and retracts it, so an
+ * unbind cannot free driver state under the upcall. The lock is held with IRQs
+ * off across ops->irq_packet.
+ *
+ * Context: Atomic, USB RX completion.
+ * Return: true if a handler ran; false if none did, and the caller books a drop.
+ */
+static bool lstp_dispatch_irq_packet(struct lstp_channel *ch, struct lstp_packet *pkt)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ guard(spinlock_irqsave)(&priv->irq_cb_lock);
+ if (!priv->irq_ops || !priv->irq_ops->irq_packet)
+ return false;
+
+ priv->irq_ops->irq_packet(ch, pkt);
+ return true;
+}
+
+/*
+ * NACK a device-initiated request that no driver took, on a channel type
+ * whose device waits for the response, so it retries instead of stalling
+ * the channel. Context: Atomic, USB RX completion.
+ */
+static void lstp_nack_undelivered(struct lstp_channel_priv *priv)
+{
+ /*
+ * Pairs with smp_store_release() in lstp_init_subsys_channel(): once
+ * ADDED, @type is set for good and the response slot is in place.
+ */
+ if (smp_load_acquire(&priv->auxdev_state) != LSTP_AUXDEV_ADDED)
+ return;
+ if (lstp_usb_gone(priv->usb))
+ return;
+ if (priv->type->irq_needs_resp)
+ lstp_send_irq_resp(&priv->pub, LSTP_NACK);
+}
+
+/* RX completion: requests (bit7=0) go to lstp_dispatch_irq_packet(), responses wake waiters. */
+static void lstp_usb_rx_callback(struct urb *urb)
+{
+ struct lstp_usb *dev = urb->context;
+ int ret;
+
+ if (urb->status == -ENOENT || urb->status == -ECONNRESET || urb->status == -ESHUTDOWN) {
+ lstp_signal_disconnect(dev);
+ return;
+ }
+
+ if (urb->status) {
+ atomic64_inc(&dev->stats.rx_urb_errors);
+ lstp_rx_handle_err(dev, urb->status, LSTP_RX_RETRY_BASE_DELAY_MS);
+ return;
+ }
+
+ atomic64_inc(&dev->stats.rx_packets);
+
+ struct lstp_packet *rx_pkt = (struct lstp_packet *)dev->rx_buf;
+
+ if (lstp_validate_rx_pkt(dev, rx_pkt, urb->actual_length)) {
+ atomic64_inc(&dev->stats.rx_errors);
+ goto resubmit;
+ }
+
+ /* ch_id range-checked by lstp_validate_rx_pkt(). */
+ u8 ch_id = rx_pkt->hdr.ch_id;
+ /* Pairs with smp_store_release() in lstp_create_channel(). */
+ struct lstp_channel *ch = smp_load_acquire(&dev->channels[ch_id]);
+
+ if (!ch) {
+ atomic64_inc(&dev->stats.rx_no_channel);
+ dev_err_ratelimited(&dev->intf->dev, "%s: ch_%d: Channel not registered\n",
+ __func__, ch_id);
+ goto resubmit;
+ }
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ /* Pairs with smp_store_release() in the BOUND arm of lstp_aux_bus_notify(). */
+ bool in_service = smp_load_acquire(&priv->started);
+
+ /* Pairs with smp_store_release() in lstp_alloc_channel_irq_bufs(). */
+ void *irq_buf = smp_load_acquire(&priv->irq_buf);
+
+ if (in_service && !FIELD_GET(LSTP_HDR_RESPONSE, rx_pkt->hdr.status) && irq_buf) {
+ if (test_and_set_bit(LSTP_BUFFER_LOCK_BIT, &priv->irq_buffer_lock)) {
+ atomic64_inc(&priv->stats.rx_dropped);
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Dropping request - irq buffer busy\n",
+ __func__, ch_id);
+ lstp_nack_undelivered(priv);
+ } else {
+ struct lstp_packet *irq_pkt = (struct lstp_packet *)irq_buf;
+ bool delivered;
+
+ dev_dbg(ch->dev, "%s: ch_%d: Received unsolicited request (IRQ event)\n",
+ __func__, ch_id);
+ memcpy(irq_buf, dev->rx_buf, urb->actual_length);
+ delivered = lstp_dispatch_irq_packet(ch, irq_pkt);
+ clear_bit(LSTP_BUFFER_LOCK_BIT, &priv->irq_buffer_lock);
+
+ /* rx_events counts delivery, not arrival. */
+ if (delivered) {
+ atomic64_inc(&priv->stats.rx_events);
+ } else {
+ atomic64_inc(&priv->stats.rx_dropped);
+ lstp_nack_undelivered(priv);
+ }
+ }
+ } else if (FIELD_GET(LSTP_HDR_RESPONSE, rx_pkt->hdr.status) && priv->resp_buf) {
+ /*
+ * The first reply after a request answers it; the waiter may still
+ * be reading @resp_buf, so a second one must not overwrite it.
+ */
+ if (!test_bit(LSTP_BUFFER_LOCK_BIT, &priv->resp_buffer_lock) ||
+ lstp_ch_got_response(ch)) {
+ atomic64_inc(&priv->stats.rx_late);
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Dropping response - no one waiting\n",
+ __func__, ch_id);
+ } else {
+ memcpy(priv->resp_buf, dev->rx_buf, urb->actual_length);
+ lstp_ch_signal_response(ch);
+ }
+ } else if (!in_service && priv->type) {
+ /*
+ * Implemented but unclaimed: the driver may not be loaded yet.
+ * @type keeps ch0 and failed channels in the warn arm below.
+ */
+ atomic64_inc(&priv->stats.rx_dropped);
+ dev_dbg_ratelimited(ch->dev, "%s: ch_%d: Dropping packet - no driver bound\n",
+ __func__, ch_id);
+ if (!FIELD_GET(LSTP_HDR_RESPONSE, rx_pkt->hdr.status))
+ lstp_nack_undelivered(priv);
+ } else {
+ atomic64_inc(&priv->stats.rx_dropped);
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: Dropping packet - no handler for it\n",
+ __func__, ch_id);
+ if (!FIELD_GET(LSTP_HDR_RESPONSE, rx_pkt->hdr.status))
+ lstp_nack_undelivered(priv);
+ }
+
+resubmit:
+ ret = usb_submit_urb(urb, GFP_ATOMIC);
+ if (ret)
+ lstp_rx_handle_err(dev, ret, LSTP_RX_RETRY_BASE_DELAY_MS);
+}
+
+/**
+ * lstp_channel_disconnected() - Check whether the channel can carry traffic.
+ * @ch: LSTP channel to check; a NULL @ch counts as unable.
+ *
+ * Context: Any context.
+ * Return: true if the channel is fenced (see
+ * Documentation/driver-api/usb/lstp.rst). lstp_send(), lstp_request() and
+ * lstp_requestv() on it then fail with -ENODEV, so the caller must stop
+ * issuing traffic and unwind.
+ */
+bool lstp_channel_disconnected(const struct lstp_channel *ch)
+{
+ if (!ch)
+ return true;
+
+ const struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ /* Pairs with smp_store_release() in the two mark helpers. */
+ return smp_load_acquire(&priv->gone) || smp_load_acquire(&priv->unbound);
+}
+EXPORT_SYMBOL_NS_GPL(lstp_channel_disconnected, "LSTP");
+
+/**
+ * lstp_send() - Send a one-way LSTP packet on the bulk-out endpoint.
+ * @ch: LSTP channel to send on
+ * @cmd: LSTP command byte. Bit 7 is forced to 0 (request direction)
+ * @payload: Payload bytes to copy into the channel's TX buffer; may be NULL
+ * if @len == 0
+ * @len: Payload length in bytes
+ *
+ * Fire-and-forget: no response is read. The TX mutex covers the fence test and
+ * the submission, which lstp_drain_inflight() relies on.
+ *
+ * Context: Process context. May sleep.
+ *
+ * Return: 0 on success; -ENODEV if @ch is NULL, not initialized for I/O, or
+ * fenced; -EINVAL if @payload is NULL with @len > 0; -EMSGSIZE if
+ * @len exceeds the channel's TX payload limit; otherwise the errno
+ * from usb_bulk_msg().
+ */
+int lstp_send(struct lstp_channel *ch, u8 cmd, const void *payload, size_t len)
+{
+ size_t total;
+
+ if (!ch)
+ return -ENODEV;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (!priv->usb || !priv->tx_buf)
+ return -ENODEV;
+
+ if (len && !payload)
+ return -EINVAL;
+
+ if (len > ch->max_tx_payload || check_add_overflow(sizeof(struct lstp_header), len, &total))
+ return -EMSGSIZE;
+
+ guard(lstp_channel)(ch);
+ if (lstp_channel_disconnected(ch))
+ return -ENODEV;
+
+ struct lstp_packet *tx_pkt = (struct lstp_packet *)priv->tx_buf;
+
+ tx_pkt->hdr.ch_id = ch->ch_id;
+ tx_pkt->hdr.cmd = FIELD_PREP(LSTP_HDR_CODE, cmd); /* request: LSTP_HDR_RESPONSE clear */
+ tx_pkt->hdr.length = cpu_to_le16(len);
+ if (len)
+ memcpy(tx_pkt->payload, payload, len);
+
+ int ret = usb_bulk_msg(priv->usb->udev,
+ usb_sndbulkpipe(priv->usb->udev, priv->usb->bulk_out_ep),
+ priv->tx_buf, total, NULL, LSTP_USB_REQUEST_TIMEOUT_MS);
+
+ /* -EPERM/-ESHUTDOWN/-ENODEV are disconnect outcomes, not failures. */
+ if (!ret)
+ atomic64_inc(&priv->stats.tx_packets);
+ else if (ret != -EPERM && ret != -ESHUTDOWN && ret != -ENODEV)
+ atomic64_inc(&priv->stats.tx_errors);
+
+ return ret;
+}
+EXPORT_SYMBOL_NS_GPL(lstp_send, "LSTP");
+
+/*
+ * One request/response exchange on @ch, the request already in priv->tx_buf;
+ * see lstp_request() for the modes. The caller holds priv->tx_mutex and has
+ * tested the fence under it, so a TX URB a fenced timeout left queued is not
+ * resubmitted. Holding priv->resp_buffer_lock is what tells
+ * lstp_usb_rx_callback() a waiter exists.
+ */
+static int lstp_request_xfer(struct lstp_channel *ch, u8 cmd, u16 req_len, void *resp,
+ size_t resp_cap, size_t *resp_len, int *lstp_status)
+{
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+ struct lstp_packet *tx_pkt = (struct lstp_packet *)priv->tx_buf;
+ struct lstp_packet *rx_pkt = (struct lstp_packet *)priv->resp_buf;
+ /* Strict mode makes @resp_cap the wire floor; variable mode has none. */
+ u16 wire_min = resp_len ? LSTP_ANY_RX_LEN : (u16)resp_cap;
+ size_t to_copy = 0;
+
+ if (test_and_set_bit(LSTP_BUFFER_LOCK_BIT, &priv->resp_buffer_lock)) {
+ dev_err(ch->dev, "%s: ch_%d: BUG - rx buffer already in use\n", __func__,
+ ch->ch_id);
+ return -EBUSY;
+ }
+
+ tx_pkt->hdr.ch_id = ch->ch_id;
+ tx_pkt->hdr.cmd = FIELD_PREP(LSTP_HDR_CODE, cmd); /* request: LSTP_HDR_RESPONSE clear */
+ tx_pkt->hdr.length = cpu_to_le16(req_len);
+
+ if (req_len > 0)
+ dev_dbg(ch->dev, "%s: ch_%d: TX cmd=0x%02x, tx_len=%u, rx_min=%u, payload=0x%*ph\n",
+ __func__, ch->ch_id, cmd, req_len, wire_min, req_len, tx_pkt->payload);
+ else
+ dev_dbg(ch->dev, "%s: ch_%d: TX cmd=0x%02x, tx_len=0, rx_min=%u\n", __func__,
+ ch->ch_id, cmd, wire_min);
+
+ usb_fill_bulk_urb(priv->bulk_tx_urb, priv->usb->udev,
+ usb_sndbulkpipe(priv->usb->udev, priv->usb->bulk_out_ep), priv->tx_buf,
+ sizeof(struct lstp_header) + req_len, lstp_usb_tx_callback, ch);
+
+ /* Plain store: the usb_submit_urb() below orders it before any response. */
+ WRITE_ONCE(priv->rx_ready, false);
+
+ int ret = usb_submit_urb(priv->bulk_tx_urb, GFP_KERNEL);
+
+ if (ret) {
+ /* Teardown raced the submit; report a disconnect, not -EPERM. */
+ if (ret == -EPERM || ret == -ESHUTDOWN)
+ ret = -ENODEV;
+
+ /* -ENODEV here is a disconnect outcome, not a failure. */
+ if (ret != -ENODEV)
+ atomic64_inc(&priv->stats.tx_errors);
+ goto out_release;
+ }
+
+ atomic64_inc(&priv->stats.tx_packets);
+
+ wait_event_timeout(priv->rx_wq, lstp_ch_should_wake(ch),
+ msecs_to_jiffies(LSTP_USB_RESPONSE_TIMEOUT_MS));
+
+ if (!lstp_ch_got_response(ch)) {
+ if (lstp_channel_disconnected(ch)) {
+ /*
+ * Fenced: the queued URB is left to teardown, see
+ * out_release. The fence, not lstp_usb_gone(), is
+ * what stops the next request from resubmitting it.
+ */
+ ret = -ENODEV;
+ } else {
+ atomic64_inc(&priv->stats.timeouts);
+ /* Removed device: -ENODEV, not a retryable timeout. */
+ ret = lstp_usb_gone(priv->usb) ? -ENODEV : -ETIMEDOUT;
+ }
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: No response (%pe)\n", __func__, ch->ch_id,
+ ERR_PTR(ret));
+ goto out_release;
+ }
+
+ ret = lstp_validate_resp(priv->usb, rx_pkt, wire_min, lstp_status);
+ if (ret) {
+ atomic64_inc(&priv->stats.errors);
+ goto out_release;
+ }
+
+ atomic64_inc(&priv->stats.rx_packets);
+
+ size_t actual = le16_to_cpu(rx_pkt->hdr.length);
+
+ dev_dbg(ch->dev, "%s: ch_%d: RX rx_len=%zu\n", __func__, ch->ch_id, actual);
+
+ if (resp_len) {
+ if (actual > resp_cap) {
+ ret = -EMSGSIZE;
+ goto out_release;
+ }
+ to_copy = actual;
+ *resp_len = actual;
+ } else {
+ /* Fixed mode: a longer reply is truncated to @resp_cap. */
+ to_copy = resp_cap;
+ }
+
+ if (resp && to_copy)
+ memcpy(resp, rx_pkt->payload, to_copy);
+
+ if (lstp_status)
+ *lstp_status = LSTP_SUCCESS;
+
+out_release:
+ /*
+ * Retire the TX URB before returning, even on success: a stale reply
+ * (see struct lstp_header) can answer this request before its transfer
+ * completes, and the next request reuses the URB and @tx_buf. Cheap once
+ * retired, and @tx_mutex keeps any submit off the @reject this raises.
+ * Skipped when fenced; see Documentation/driver-api/usb/lstp.rst.
+ */
+ if (!lstp_channel_disconnected(ch))
+ usb_kill_urb(priv->bulk_tx_urb);
+
+ clear_bit(LSTP_BUFFER_LOCK_BIT, &priv->resp_buffer_lock);
+ return ret;
+}
+
+/**
+ * lstp_request() - Issue an LSTP request/response exchange.
+ * @ch: LSTP channel
+ * @cmd: LSTP command byte. Bit 7 is forced to 0 (request direction)
+ * @req: Request payload to copy into the channel's TX buffer; may be
+ * NULL if @req_len == 0
+ * @req_len: Request payload length in bytes
+ * @resp: Caller buffer that receives the response payload; may be NULL
+ * if @resp_cap == 0, or when @resp_len is non-NULL to discard
+ * the response payload
+ * @resp_cap: Capacity of @resp in bytes. The exact expected response length
+ * in fixed mode; an upper bound on the device-reported length in
+ * variable mode
+ * @resp_len: Out-param for the on-wire response length, or NULL. The pointer
+ * doubles as the mode selector:
+ *
+ * * NULL (fixed): the device must reply with at least @resp_cap
+ * bytes or the call fails with -EIO. Longer replies are
+ * accepted for forward compatibility and only the first
+ * @resp_cap bytes are copied into @resp
+ *
+ * * non-NULL (variable): no lower bound. A reply longer than
+ * @resp_cap fails with -EMSGSIZE; otherwise the reported length
+ * is stored in *@resp_len and that many bytes are copied into
+ * @resp
+ * @lstp_status: Optional out-param for the raw LSTP response status. Set to
+ * the device status when the exchange succeeds or when the
+ * returned errno is derived from that status, and to
+ * LSTP_NO_RESPONSE_STATUS otherwise. Unmodified if NULL
+ *
+ * One exchange per call, under the channel TX mutex, so at most one request is
+ * in flight per channel. Use lstp_requestv() for a payload spread over several
+ * buffers.
+ *
+ * Context: Process context. May sleep.
+ *
+ * Return: 0 on success; -ENODEV if @ch is NULL, not initialized for I/O, or
+ * fenced; -EINVAL for a NULL @req or fixed-mode @resp with a non-zero
+ * length; -EMSGSIZE if a length exceeds the channel's payload limits
+ * or a variable-mode reply exceeds @resp_cap; -EIO if a fixed-mode
+ * reply is short; -ETIMEDOUT if the device does not answer; otherwise
+ * the errno from the LSTP status or the USB I/O.
+ */
+int lstp_request(struct lstp_channel *ch, u8 cmd, const void *req, size_t req_len, void *resp,
+ size_t resp_cap, size_t *resp_len, int *lstp_status)
+{
+ return lstp_requestv(ch, cmd,
+ &(const struct kvec){
+ .iov_base = (void *)req,
+ .iov_len = req_len,
+ },
+ 1, resp, resp_cap, resp_len, lstp_status);
+}
+EXPORT_SYMBOL_NS_GPL(lstp_request, "LSTP");
+
+/**
+ * lstp_requestv() - Vectored variant of lstp_request().
+ * @ch: LSTP channel
+ * @cmd: LSTP command byte; see lstp_request()
+ * @vecs: Input kvec vector, concatenated into the TX payload in order.
+ * An entry's @iov_base may be NULL only when its @iov_len is 0.
+ * May be NULL if @nvecs is 0
+ * @nvecs: Number of entries in @vecs; may be 0 for an empty request
+ * @resp: see lstp_request()
+ * @resp_cap: see lstp_request()
+ * @resp_len: see lstp_request()
+ * @lstp_status: see lstp_request()
+ *
+ * As lstp_request(), with the request payload gathered from @vecs.
+ *
+ * Context: Process context. May sleep.
+ *
+ * Return: see lstp_request().
+ */
+int lstp_requestv(struct lstp_channel *ch, u8 cmd, const struct kvec *vecs, size_t nvecs,
+ void *resp, size_t resp_cap, size_t *resp_len, int *lstp_status)
+{
+ size_t req_total = 0;
+
+ /* Fail-safe default: only the xfer/validation publish a real status. */
+ if (lstp_status)
+ *lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ if (!ch)
+ return -ENODEV;
+ struct lstp_channel_priv *priv = to_lstp_priv(ch);
+
+ if (!priv->usb || !priv->tx_buf || !priv->resp_buf)
+ return -ENODEV;
+
+ if (nvecs && !vecs)
+ return -EINVAL;
+ if (!resp_len && resp_cap && !resp)
+ return -EINVAL;
+
+ for (size_t i = 0; i < nvecs; i++) {
+ if (vecs[i].iov_len && !vecs[i].iov_base)
+ return -EINVAL;
+ if (check_add_overflow(req_total, vecs[i].iov_len, &req_total))
+ return -EMSGSIZE;
+ }
+
+ if (req_total > ch->max_tx_payload || resp_cap > ch->max_rx_payload)
+ return -EMSGSIZE;
+
+ guard(lstp_channel)(ch);
+ /* Fence first: on a channel pinned past disconnect, tx_buf is freed. */
+ if (lstp_channel_disconnected(ch))
+ return -ENODEV;
+
+ struct lstp_packet *tx_pkt = (struct lstp_packet *)priv->tx_buf;
+ size_t off = 0;
+
+ for (size_t i = 0; i < nvecs; i++) {
+ if (vecs[i].iov_len) {
+ memcpy(tx_pkt->payload + off, vecs[i].iov_base, vecs[i].iov_len);
+ off += vecs[i].iov_len;
+ }
+ }
+
+ return lstp_request_xfer(ch, cmd, (u16)req_total, resp, resp_cap, resp_len, lstp_status);
+}
+EXPORT_SYMBOL_NS_GPL(lstp_requestv, "LSTP");
+
+#define LSTP_USB_VID_NVIDIA 0x0955
+#define LSTP_USB_VID_MICROCHIP 0x0424
+#define LSTP_USB_VID_ASMEDIA 0x174c
+
+#define LSTP_USB_SUBCLASS 0x3f
+
+#define LSTP_USB_DEVICE(vid, pid) \
+ USB_DEVICE_AND_INTERFACE_INFO(vid, pid, USB_CLASS_VENDOR_SPEC, LSTP_USB_SUBCLASS, \
+ LSTP_VERSION)
+
+static const struct usb_device_id lstp_id_table[] = {
+ { LSTP_USB_DEVICE(LSTP_USB_VID_NVIDIA, 0xcf11) },
+ { LSTP_USB_DEVICE(LSTP_USB_VID_MICROCHIP, 0x4940) },
+ { LSTP_USB_DEVICE(LSTP_USB_VID_ASMEDIA, 0x2214) },
+ {}
+};
+MODULE_DEVICE_TABLE(usb, lstp_id_table);
+
+static struct usb_driver lstp_usb_driver = {
+ .name = "lstp",
+ .probe = lstp_probe,
+ .disconnect = lstp_disconnect,
+ .id_table = lstp_id_table,
+};
+
+/*
+ * Interposed ahead of the subsystem's .probe(): set up what the matched driver
+ * needs, then delegate. A notifier cannot refuse a bind; this can.
+ */
+static int lstp_aux_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ const struct lstp_auxiliary_driver *drv = to_lstp_aux_drv(auxdev->dev.driver);
+ struct lstp_channel_priv *priv = to_lstp_priv_from_auxdev(auxdev);
+ int ret;
+
+ /*
+ * Refuse a fenced channel: its device is gone and the interface's
+ * devres, which holds the channel's framework buffers, may be
+ * unwinding. Also refuses a bind whose BIND arm could not book its
+ * unwind. Nothing below is booked on the interface.
+ */
+ if (lstp_channel_disconnected(&priv->pub))
+ return -ENODEV;
+
+ if (drv->ops && drv->ops->irq_packet) {
+ ret = lstp_alloc_channel_irq_bufs(priv);
+ if (ret)
+ return ret;
+ }
+
+ return drv->subsys_probe(auxdev, id);
+}
+
+/*
+ * The LSTP ops of a driver we registered, or NULL. The bus matches on the
+ * device-name prefix, so a foreign driver can bind our channel, and
+ * container_of() on it would be type confusion reached from URB completion.
+ * Only our drivers carry lstp_aux_probe() as .probe(): that is the test.
+ */
+static const struct lstp_ops *lstp_bound_driver_ops(struct device_driver *drv)
+{
+ if (!drv || to_auxiliary_drv(drv)->probe != lstp_aux_probe)
+ return NULL;
+
+ return to_lstp_aux_drv(drv)->ops;
+}
+
+/**
+ * __lstp_auxiliary_driver_register() - Register an LSTP subsystem aux_driver.
+ * @drv: LSTP auxiliary driver to register.
+ * @owner: Module owning @drv.
+ * @modname: Name of that module.
+ *
+ * Interposes lstp_aux_probe() ahead of the subsystem's .probe(), then
+ * registers the embedded adrv. Call it through lstp_auxiliary_driver_register().
+ *
+ * Context: Process context. May sleep.
+ * Return: 0 on success, negative errno on failure.
+ */
+int __lstp_auxiliary_driver_register(struct lstp_auxiliary_driver *drv, struct module *owner,
+ const char *modname)
+{
+ if (WARN_ON(!drv->adrv.probe))
+ return -EINVAL;
+
+ /* Idempotent: an unregister/register cycle must not chain the wrapper. */
+ if (drv->adrv.probe != lstp_aux_probe) {
+ drv->subsys_probe = drv->adrv.probe;
+ drv->adrv.probe = lstp_aux_probe;
+ }
+
+ int ret = __auxiliary_driver_register(&drv->adrv, owner, modname);
+
+ /* A driver that failed to register is never unregistered: undo it here. */
+ if (ret && drv->subsys_probe) {
+ drv->adrv.probe = drv->subsys_probe;
+ drv->subsys_probe = NULL;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL_NS_GPL(__lstp_auxiliary_driver_register, "LSTP");
+
+/**
+ * lstp_auxiliary_driver_unregister() - Unregister an LSTP subsystem aux_driver.
+ * @drv: LSTP auxiliary driver to unregister.
+ *
+ * Restores the subsystem's own .probe(), so the interposed wrapper does not
+ * outlive its registration in a struct owned by the child module.
+ *
+ * Context: Process context. May sleep.
+ */
+void lstp_auxiliary_driver_unregister(struct lstp_auxiliary_driver *drv)
+{
+ auxiliary_driver_unregister(&drv->adrv);
+
+ if (drv->subsys_probe) {
+ drv->adrv.probe = drv->subsys_probe;
+ drv->subsys_probe = NULL;
+ }
+}
+EXPORT_SYMBOL_NS_GPL(lstp_auxiliary_driver_unregister, "LSTP");
+
+static int __init lstp_module_init(void)
+{
+ return usb_register(&lstp_usb_driver);
+}
+
+static void __exit lstp_module_exit(void)
+{
+ usb_deregister(&lstp_usb_driver);
+ /* Before ida_destroy() and unload: these releases run module code, free ids. */
+ wait_var_event(&lstp_live_objects, !atomic_read(&lstp_live_objects));
+
+ ida_destroy(&lstp_auxdev_ida);
+}
+
+module_init(lstp_module_init);
+module_exit(lstp_module_exit);
+
+MODULE_DESCRIPTION("LSTP USB device driver");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/usb/lstp.h b/include/linux/usb/lstp.h
new file mode 100644
index 000000000000..ecdcee64932f
--- /dev/null
+++ b/include/linux/usb/lstp.h
@@ -0,0 +1,219 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * LSTP channel interface for the subsystem drivers.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#ifndef __LINUX_USB_LSTP_H
+#define __LINUX_USB_LSTP_H
+
+#include <linux/auxiliary_bus.h>
+#include <linux/types.h>
+
+struct fwnode_handle;
+struct kvec;
+struct module;
+
+#define LSTP_USB_RESPONSE_TIMEOUT_MS 1000
+#define LSTP_USB_EP_MIN_SIZE 64
+#define LSTP_CH_NAME_LEN 16
+#define LSTP_DISPLAY_NAME_LEN (LSTP_CH_NAME_LEN * 2 + 2) /* intf_name + '_' + ch_name + '\0' */
+
+enum lstp_status {
+ LSTP_SUCCESS = 0x00,
+ LSTP_ERROR = 0x01,
+ LSTP_TIMEOUT = 0x02,
+ LSTP_BUSY = 0x03,
+ LSTP_NACK = 0x04,
+ LSTP_ARB_LOST = 0x05,
+ LSTP_NOT_SUPP = 0x06,
+ LSTP_TOO_LARGE = 0x07,
+};
+
+/* lstp_status out-param: no response status applies. Outside 0x00..0x7f. */
+#define LSTP_NO_RESPONSE_STATUS (-1)
+
+/*
+ * Firmware-controlled (type, flags, name) triple heading both ch0 config
+ * packets, split out so callers can stack-allocate it without a flex array.
+ */
+struct lstp_ch_desc {
+ u8 ch_type;
+ u8 ch_flags;
+ char ch_name[LSTP_CH_NAME_LEN];
+} __packed;
+
+struct lstp_ch0_read_resp {
+ struct lstp_ch_desc desc;
+ u8 ch_config[];
+} __packed;
+
+/*
+ * Carries no sequence number: a response is matched only to the channel's
+ * single outstanding request.
+ */
+struct lstp_header {
+ u8 ch_id;
+ union { /* [0:6] cmd/status, [7] 0=request/1=response */
+ u8 cmd;
+ u8 status;
+ };
+ __le16 length;
+} __packed;
+
+struct lstp_packet {
+ struct lstp_header hdr;
+ u8 payload[];
+} __packed;
+
+/**
+ * struct lstp_channel - Per-channel state visible to LSTP subsystems.
+ * @ch_id: Device-assigned channel id; ch0 is management.
+ * @display_name: NUL-terminated framework-built name, valid for the channel's lifetime.
+ * @fwnode: Firmware node for this channel, or NULL if none matched.
+ * @dev: Device for dev_*() / devm_*(): the auxdev, or for ch0 the
+ * USB interface device.
+ * @max_tx_payload: Largest request payload, header excluded, in one bulk-out URB.
+ * @max_rx_payload: Largest response payload, header excluded, in one bulk-in URB.
+ * @priv: Subsystem-owned data for the current bind, opaque to the
+ * framework, which clears it at unbind. State that an open
+ * handle keeps past the unbind is reached through the handle,
+ * never through @priv, and freed by the subsystem.
+ */
+struct lstp_channel {
+ u8 ch_id;
+ char display_name[LSTP_DISPLAY_NAME_LEN];
+ struct fwnode_handle *fwnode;
+ struct device *dev;
+ size_t max_tx_payload;
+ size_t max_rx_payload;
+ void *priv;
+};
+
+/**
+ * struct lstp_channel_init_info - A channel's firmware config, as seen by its subsystem.
+ * @config: Subsystem-specific config blob, unvalidated by the framework.
+ * @config_len: On-wire blob length in bytes; may be 0.
+ *
+ * The auxdev's platform_data, valid only for the call that receives it: copy
+ * to retain. A short blob is legal: pad and warn where every absent field has
+ * a safe default, reject -EINVAL where one does not.
+ */
+struct lstp_channel_init_info {
+ const void *config;
+ size_t config_len;
+};
+
+/**
+ * struct lstp_ops - Framework-to-driver upcalls for an LSTP aux_driver.
+ * @irq_packet: Handle an unsolicited request packet; NULL if the subsystem
+ * never receives one. Runs in atomic context from the USB RX
+ * completion and must not sleep. @pkt and its payload are valid
+ * only for the call, and any answer goes out inline with
+ * lstp_send_irq_resp(), never from a work item. Called only
+ * between a successful .probe() and the start of .remove(); a
+ * call in progress completes before .remove() runs.
+ */
+struct lstp_ops {
+ void (*irq_packet)(struct lstp_channel *ch, struct lstp_packet *pkt);
+};
+
+/**
+ * struct lstp_auxiliary_driver - LSTP subclass of struct auxiliary_driver.
+ * @adrv: The embedded auxiliary_driver registered on the bus.
+ * @ops: LSTP framework-to-driver upcalls, or NULL.
+ * @subsys_probe: Subsystem .probe(), saved when the framework interposes its
+ * own. Framework-owned; a subsystem sets @adrv.probe only.
+ *
+ * The auxiliary bus matches on a device-name prefix, so a driver not
+ * registered through lstp_auxiliary_driver_register() can bind an LSTP
+ * channel device; the core never uses the @ops of such a driver.
+ */
+struct lstp_auxiliary_driver {
+ struct auxiliary_driver adrv;
+ const struct lstp_ops *ops;
+ int (*subsys_probe)(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id);
+};
+
+int __lstp_auxiliary_driver_register(struct lstp_auxiliary_driver *drv, struct module *owner,
+ const char *modname);
+
+/* The bus takes the driver's name and module ref from these; expand in the caller. */
+#define lstp_auxiliary_driver_register(drv) \
+ __lstp_auxiliary_driver_register(drv, THIS_MODULE, KBUILD_MODNAME)
+void lstp_auxiliary_driver_unregister(struct lstp_auxiliary_driver *drv);
+
+/**
+ * module_lstp_auxiliary_driver() - Register an LSTP aux_driver as its module.
+ * @__lstp_auxiliary_driver: The struct lstp_auxiliary_driver to register.
+ *
+ * For a module whose init and exit do nothing but register and unregister
+ * the driver; replaces module_init() and module_exit().
+ */
+#define module_lstp_auxiliary_driver(__lstp_auxiliary_driver) \
+ module_driver(__lstp_auxiliary_driver, lstp_auxiliary_driver_register, \
+ lstp_auxiliary_driver_unregister)
+
+struct lstp_channel *lstp_channel_from_auxdev(struct auxiliary_device *auxdev);
+
+bool lstp_channel_disconnected(const struct lstp_channel *ch);
+
+/* Pin a channel past disconnect; see lstp_channel_get(). */
+struct lstp_channel *lstp_channel_get(struct lstp_channel *ch);
+void lstp_channel_put(struct lstp_channel *ch);
+
+/* USB I/O helpers; lstp_request() documents the fixed and variable response modes. */
+int lstp_send(struct lstp_channel *ch, u8 cmd, const void *payload, size_t len);
+
+int lstp_request(struct lstp_channel *ch, u8 cmd, const void *req, size_t req_len, void *resp,
+ size_t resp_cap, size_t *resp_len, int *lstp_status);
+
+int lstp_requestv(struct lstp_channel *ch, u8 cmd, const struct kvec *vecs, size_t nvecs,
+ void *resp, size_t resp_cap, size_t *resp_len, int *lstp_status);
+
+/* Unsolicited-request response (atomic context, called from ops->irq_packet) */
+void lstp_send_irq_resp(struct lstp_channel *ch, u8 status);
+
+/* ch0 READ_CONFIG helpers; process context, may sleep. */
+int lstp_ch0_read_config(struct lstp_channel *ch, u16 offset, u16 length,
+ struct lstp_ch0_read_resp **resp_out, size_t *len_out);
+
+typedef int (*lstp_config_entry_fn)(struct lstp_channel *ch, unsigned int entry_idx,
+ const void *entry, void *entry_ctx);
+int lstp_read_config_table(struct lstp_channel *ch, size_t config_head_size,
+ size_t config_entry_size, unsigned int total_entries,
+ lstp_config_entry_fn entry_fn, void *entry_ctx);
+
+#define LSTP_GPIO_PIN_NAME_LEN 32 /* wire: pin name field, not NUL-terminated */
+
+/**
+ * struct lstp_led_pin - One LED pin of a GPIO channel.
+ * @pin: Pin number in the channel's own numbering.
+ * @name: Firmware pin name, NUL-terminated.
+ */
+struct lstp_led_pin {
+ u16 pin;
+ char name[LSTP_GPIO_PIN_NAME_LEN + 1];
+};
+
+/**
+ * struct lstp_leds - The LED pins a GPIO channel hands to the LED driver.
+ * @auxdev: "lstp.led.<id>", <id> the GPIO channel's auxdev instance, parented
+ * to that auxdev; this struct is freed on its release.
+ * @ch: The GPIO channel the LED requests go out on; valid while a driver is
+ * bound to @auxdev, which the GPIO driver deletes before its unbind.
+ * @npins: Number of entries in @pins.
+ * @pins: The LED pins, in pin order.
+ */
+struct lstp_leds {
+ struct auxiliary_device auxdev;
+ struct lstp_channel *ch;
+ u16 npins;
+ struct lstp_led_pin pins[] __counted_by(npins);
+};
+
+/* Not KBUILD_MODNAME: the name must not follow the module the GPIO driver is in. */
+#define LSTP_LEDS_AUXDEV_MODNAME "lstp"
+
+#endif /* __LINUX_USB_LSTP_H */
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 06/11] gpio: Add NVIDIA LSTP GPIO driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (4 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 05/11] usb: misc: Add NVIDIA LSTP USB adapter driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 07/11] leds: Add NVIDIA LSTP LED driver Adrian Ambrozewicz
` (4 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Donald Shannon, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-kernel, linux-gpio, linux-usb,
llvm, Greg Kroah-Hartman
Add a driver for the GPIO channels of NVIDIA LSTP USB adapters. Each
channel is registered as a GPIO chip with an interrupt controller for
its pins; every line access is a USB transaction, so the chip can
sleep. Pins the firmware reports as LEDs are not GPIO lines: the driver
hands them to the LED driver as an auxiliary device.
At probe the driver reads each pin's interrupt configuration from the
device. A reply that misses the response timeout can answer a later
request and shift every following pin's state by one, so a single read
cannot simply be retried. After a timeout the driver reads all pins
again, alternating ascending and descending order, until two
consecutive passes without a timeout agree: at most five passes, ending
within 10 s of the first timeout, after which the probe fails as
before. The probe runs in the context that added the device, often the
hub's worker, hence the bound.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/gpio/Kconfig | 14 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-lstp.c | 1194 ++++++++++++++++++++++++++++++++++++++
4 files changed, 1210 insertions(+)
create mode 100644 drivers/gpio/gpio-lstp.c
diff --git a/MAINTAINERS b/MAINTAINERS
index e18d45bd7da5..639cd7b6b146 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19577,6 +19577,7 @@ F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
F: Documentation/driver-api/usb/lstp.rst
F: Documentation/firmware-guide/acpi/lstp.rst
+F: drivers/gpio/gpio-lstp.c
F: drivers/usb/misc/lstp.c
F: include/linux/usb/lstp.h
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a48586bb8edb..7ef6a9031475 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -2051,6 +2051,20 @@ config GPIO_USBIO
This driver can also be built as a module. If so, the module
will be called gpio_usbio.
+config GPIO_LSTP
+ tristate "NVIDIA LSTP GPIO support"
+ depends on USB_LSTP
+ default USB_LSTP
+ select GPIOLIB_IRQCHIP
+ help
+ Say Y or M here to support the GPIO channels of NVIDIA LSTP USB
+ adapters. Each channel is registered as a GPIO chip, together
+ with an interrupt controller for its pins. Pins the firmware
+ reports as LEDs are left to the LEDS_LSTP driver.
+
+ This driver can also be built as a module. If so, the module
+ will be called gpio-lstp.
+
endmenu
menu "Virtual GPIO drivers"
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index dc9e6d643b5b..acd0cfae2914 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -101,6 +101,7 @@ obj-$(CONFIG_GPIO_LP873X) += gpio-lp873x.o
obj-$(CONFIG_GPIO_LP87565) += gpio-lp87565.o
obj-$(CONFIG_GPIO_LPC18XX) += gpio-lpc18xx.o
obj-$(CONFIG_GPIO_LPC32XX) += gpio-lpc32xx.o
+obj-$(CONFIG_GPIO_LSTP) += gpio-lstp.o
obj-$(CONFIG_GPIO_LTC4283) += gpio-ltc4283.o
obj-$(CONFIG_GPIO_MACSMC) += gpio-macsmc.o
obj-$(CONFIG_GPIO_MADERA) += gpio-madera.o
diff --git a/drivers/gpio/gpio-lstp.c b/drivers/gpio/gpio-lstp.c
new file mode 100644
index 000000000000..cc988a09582b
--- /dev/null
+++ b/drivers/gpio/gpio-lstp.c
@@ -0,0 +1,1194 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * GPIO driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/atomic.h>
+#include <linux/bitmap.h>
+#include <linux/build_bug.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/gpio/driver.h>
+#include <linux/irq.h>
+#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/wait_bit.h>
+#include <linux/workqueue.h>
+#include <uapi/linux/gpio.h>
+
+#include <linux/usb/lstp.h>
+
+enum lstp_gpio_cmd {
+ LSTP_GPIO_CMD_GET_VALUE = 0x00,
+ LSTP_GPIO_CMD_SET_VALUE = 0x01,
+ LSTP_GPIO_CMD_GET_IRQ_CONFIG = 0x02,
+ LSTP_GPIO_CMD_SET_IRQ_CONFIG = 0x03,
+ LSTP_GPIO_CMD_IRQ_EVENT = 0x04,
+ /* 0x05, SET_LED_PATTERN, is sent by the LED driver in leds-lstp.c */
+} __packed;
+
+struct lstp_gpio_get_value_req {
+ __le16 pin;
+} __packed;
+
+struct lstp_gpio_set_value_req {
+ __le16 pin;
+ u8 value;
+} __packed;
+
+struct lstp_gpio_get_irq_config_req {
+ __le16 pin;
+} __packed;
+
+struct lstp_gpio_set_irq_config_req {
+ __le16 pin;
+ u8 irq_type;
+} __packed;
+
+struct lstp_gpio_irq_event_req {
+ __le16 pin;
+ u8 value;
+} __packed;
+
+struct lstp_gpio_get_value_resp {
+ u8 value;
+} __packed;
+
+struct lstp_gpio_get_irq_config_resp {
+ u8 irq_type;
+} __packed;
+
+enum lstp_gpio_irq_type {
+ LSTP_GPIO_IRQ_NONE = 0x00,
+ LSTP_GPIO_IRQ_RISING = 0x01,
+ LSTP_GPIO_IRQ_FALLING = 0x02,
+ LSTP_GPIO_IRQ_BOTH = 0x03,
+ LSTP_GPIO_IRQ_HIGH = 0x04,
+ LSTP_GPIO_IRQ_LOW = 0x05,
+ LSTP_GPIO_IRQ_MAX = LSTP_GPIO_IRQ_LOW,
+} __packed;
+
+struct lstp_gpio_pin_config {
+ u8 direction;
+ u8 default_output;
+ u8 output_drive_config;
+ u8 output_persist_state; /* bool */
+ u8 bias_pull_config;
+ __le16 bias_pull_strength; /* 16 ohm increments */
+ __le16 output_drive_strength; /* in mA */
+ __le16 slew_rate; /* in 100 ps (0.1 ns) increments */
+ __le16 input_debounce_time; /* in us */
+ u8 led_support;
+ u8 reserved_0xE;
+ u8 reserved_0xF;
+} __packed;
+
+struct lstp_gpio_pin {
+ char pin_name[LSTP_GPIO_PIN_NAME_LEN];
+ struct lstp_gpio_pin_config config;
+} __packed;
+
+struct lstp_gpio_config {
+ u8 npins;
+ struct lstp_gpio_pin pin_info[];
+} __packed;
+
+/* clang-format off */
+enum lstp_gpio_direction {
+ LSTP_GPIO_OUTPUT = 0x00,
+ LSTP_GPIO_INPUT = 0x01
+} __packed;
+enum lstp_gpio_pin_state {
+ LSTP_GPIO_LOW = 0x00,
+ LSTP_GPIO_HIGH = 0x01
+} __packed;
+enum lstp_gpio_drive_config {
+ LSTP_GPIO_PUSH_PULL = 0x00,
+ LSTP_GPIO_OPEN_DRAIN = 0x01,
+ LSTP_GPIO_OPEN_SOURCE = 0x02
+} __packed;
+enum lstp_gpio_bias_config {
+ LSTP_GPIO_NO_PULL = 0x00,
+ LSTP_GPIO_PULL_UP = 0x01,
+ LSTP_GPIO_PULL_DOWN = 0x02
+} __packed;
+enum lstp_gpio_led_support {
+ LSTP_GPIO_NOT_LED = 0x00,
+ LSTP_GPIO_LED_MODE_HOLD = 0x01, /* pattern brightness jumps between steps */
+ LSTP_GPIO_LED_MODE_INTERPOLATE = 0x02, /* pattern brightness interpolates between steps */
+} __packed; /* clang-format on */
+
+struct lstp_gpio_priv {
+ struct lstp_channel *ch;
+ struct gpio_chip gc;
+ struct workqueue_struct *wq; /* ordered: IRQ batches run in RX order */
+ struct mutex irq_lock; /* Serializes irq_chip callbacks (irq_bus_lock/sync_unlock) */
+ u8 *shadow_irq_type; /* Pending IRQ type per pin [npins] */
+ u8 *hw_irq_type; /* Last successfully committed IRQ type per pin [npins] */
+ const char **pin_names; /* Line names [npins] */
+ unsigned long *led_pins; /* [npins] bitmap: pins handed to the LED driver */
+ u16 npins; /* Pin count from device config */
+ u16 ngpio; /* Non-LED GPIO pin count */
+ u16 nleds; /* LED pin count */
+};
+
+/* One work item per unsolicited RX batch; raw payload parsed in process context */
+struct lstp_gpio_irq_event_work {
+ struct work_struct work;
+ struct lstp_gpio_priv *priv;
+ u16 payload_len;
+ u8 payload[];
+};
+
+/* Read @pin's direction byte out of the channel config descriptor. */
+static int lstp_gpio_read_direction(struct lstp_gpio_priv *priv, unsigned int pin, u8 *direction)
+{
+ if (pin >= priv->npins)
+ return -EINVAL;
+
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_ch0_read_resp *resp __free(kfree) = NULL;
+ u16 pin_offset = sizeof(struct lstp_gpio_config) + pin * sizeof(struct lstp_gpio_pin);
+ u16 offset = pin_offset + offsetof(struct lstp_gpio_pin, config) +
+ offsetof(struct lstp_gpio_pin_config, direction);
+ size_t actual;
+ int ret = lstp_ch0_read_config(ch, offset, sizeof(*direction), &resp, &actual);
+
+ if (ret) {
+ if (ret != -ENODEV)
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Failed to read direction config for pin %u (%pe)\n",
+ __func__, ch->ch_id, pin, ERR_PTR(ret));
+ return ret;
+ }
+
+ *direction = *(const u8 *)resp->ch_config;
+ return 0;
+}
+
+static int lstp_gpio_get_value(struct gpio_chip *gc, unsigned int pin)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_get_value_req req = { .pin = cpu_to_le16(pin) };
+ struct lstp_gpio_get_value_resp resp;
+
+ int ret = lstp_request(ch, LSTP_GPIO_CMD_GET_VALUE, &req, sizeof(req), &resp, sizeof(resp),
+ NULL, NULL);
+ if (ret) {
+ if (ret != -ENODEV)
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Could not get value for pin %u (%pe)\n",
+ __func__, ch->ch_id, pin, ERR_PTR(ret));
+ return ret;
+ }
+
+ dev_dbg(ch->dev, "%s: ch_%d: pin=%u, value=%d\n", __func__, ch->ch_id, pin, resp.value);
+ return !!resp.value;
+}
+
+static int lstp_gpio_set_value(struct gpio_chip *gc, unsigned int pin, int value)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_set_value_req req = {
+ .pin = cpu_to_le16(pin),
+ .value = !!value,
+ };
+
+ int ret = lstp_request(ch, LSTP_GPIO_CMD_SET_VALUE, &req, sizeof(req), NULL, 0, NULL, NULL);
+
+ if (ret && ret != -ENODEV)
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Could not set value %d for pin %u (%pe)\n",
+ __func__, ch->ch_id, value, pin, ERR_PTR(ret));
+ else if (!ret)
+ dev_dbg(ch->dev, "%s: ch_%d: pin=%u, value=%d\n", __func__, ch->ch_id, pin, value);
+ return ret;
+}
+
+/*
+ * Chunked across packets when the pin count does not fit one request, one
+ * lstp_request() each, so a concurrent access may observe state from between
+ * two chunks.
+ */
+static int lstp_gpio_get_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_get_value_req *req = NULL;
+ struct lstp_gpio_get_value_resp *resp = NULL;
+ int max_pins_per_tx = ch->max_tx_payload / sizeof(*req);
+ int max_pins_per_rx = ch->max_rx_payload / sizeof(*resp);
+ int max_pins_per_pkt = min(max_pins_per_tx, max_pins_per_rx);
+ int total_pins = bitmap_weight(mask, gc->ngpio);
+ unsigned int bit_off = 0;
+ int pins_sent = 0;
+ int ret;
+
+ /* Probe enforces bulk_*_size >= LSTP_USB_EP_MIN_SIZE; anchor it here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(*req) > LSTP_USB_EP_MIN_SIZE);
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(*resp) > LSTP_USB_EP_MIN_SIZE);
+
+ if (total_pins == 0)
+ return 0;
+
+ req = kmalloc_objs(*req, max_pins_per_pkt);
+ if (!req) {
+ ret = -ENOMEM;
+ goto out_free;
+ }
+ resp = kmalloc_objs(*resp, max_pins_per_pkt);
+ if (!resp) {
+ ret = -ENOMEM;
+ goto out_free;
+ }
+
+ bitmap_zero(bits, gc->ngpio);
+
+ while (pins_sent < total_pins) {
+ int pins_in_pkt = min(max_pins_per_pkt, total_pins - pins_sent);
+
+ for (int i = 0; i < pins_in_pkt; i++) {
+ bit_off = find_next_bit(mask, gc->ngpio, bit_off);
+ req[i].pin = cpu_to_le16(bit_off);
+ bit_off++;
+ }
+
+ ret = lstp_request(ch, LSTP_GPIO_CMD_GET_VALUE, req, pins_in_pkt * sizeof(*req),
+ resp, pins_in_pkt * sizeof(*resp), NULL, NULL);
+ if (ret) {
+ if (ret != -ENODEV)
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Could not get values for %d pins (%pe)\n",
+ __func__, ch->ch_id, pins_in_pkt, ERR_PTR(ret));
+ goto out_free;
+ }
+
+ for (int i = 0; i < pins_in_pkt; i++) {
+ if (resp[i].value)
+ __set_bit(le16_to_cpu(req[i].pin), bits);
+ }
+ pins_sent += pins_in_pkt;
+ }
+
+ dev_dbg(ch->dev, "%s: ch_%d: Get %d pins, mask=%*pb, bits=%*pb\n", __func__, ch->ch_id,
+ total_pins, gc->ngpio, mask, gc->ngpio, bits);
+ ret = 0;
+
+out_free:
+ kfree(resp);
+ kfree(req);
+ return ret;
+}
+
+/* Chunked like lstp_gpio_get_multiple(); same cross-chunk visibility caveat. */
+static int lstp_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_set_value_req *req = NULL;
+ int max_pins_per_pkt = ch->max_tx_payload / sizeof(*req);
+ int total_pins = bitmap_weight(mask, gc->ngpio);
+ unsigned int bit_off = 0;
+ int pins_sent = 0;
+ int ret = 0;
+
+ /* Probe enforces bulk_tx_size >= LSTP_USB_EP_MIN_SIZE; anchor it here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(*req) > LSTP_USB_EP_MIN_SIZE);
+
+ if (total_pins == 0)
+ goto done;
+
+ req = kmalloc_objs(*req, max_pins_per_pkt);
+ if (!req) {
+ ret = -ENOMEM;
+ goto done;
+ }
+
+ while (pins_sent < total_pins) {
+ int pins_in_pkt = min(max_pins_per_pkt, total_pins - pins_sent);
+
+ for (int i = 0; i < pins_in_pkt; i++) {
+ bit_off = find_next_bit(mask, gc->ngpio, bit_off);
+ req[i].pin = cpu_to_le16(bit_off);
+ req[i].value = test_bit(bit_off, bits) ? 1 : 0;
+ bit_off++;
+ }
+
+ ret = lstp_request(ch, LSTP_GPIO_CMD_SET_VALUE, req, pins_in_pkt * sizeof(*req),
+ NULL, 0, NULL, NULL);
+ if (ret) {
+ if (ret != -ENODEV)
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Could not set values for pins (mask=%*pb) (%pe)\n",
+ __func__, ch->ch_id, gc->ngpio, mask,
+ ERR_PTR(ret));
+ goto out_free;
+ }
+ pins_sent += pins_in_pkt;
+ }
+
+ dev_dbg(ch->dev, "%s: ch_%d: Set %d pins, mask=%*pb, bits=%*pb\n", __func__, ch->ch_id,
+ total_pins, gc->ngpio, mask, gc->ngpio, bits);
+
+out_free:
+ kfree(req);
+done:
+ return ret;
+}
+
+/* Read @pin's IRQ type from the device; returns LSTP_GPIO_IRQ_* or -errno. */
+static int lstp_gpio_get_irq_config(struct lstp_gpio_priv *priv, u16 pin)
+{
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_get_irq_config_req req = { .pin = cpu_to_le16(pin) };
+ struct lstp_gpio_get_irq_config_resp resp;
+
+ int ret = lstp_request(ch, LSTP_GPIO_CMD_GET_IRQ_CONFIG, &req, sizeof(req), &resp,
+ sizeof(resp), NULL, NULL);
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: GET_IRQ_CONFIG failed for pin %u (%pe)\n", __func__,
+ ch->ch_id, pin, ERR_PTR(ret));
+ return ret;
+ }
+
+ return resp.irq_type;
+}
+
+static int lstp_gpio_set_irq_config(struct lstp_gpio_priv *priv, u16 pin, u8 irq_type)
+{
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_gpio_set_irq_config_req req = {
+ .pin = cpu_to_le16(pin),
+ .irq_type = irq_type,
+ };
+
+ int ret = lstp_request(ch, LSTP_GPIO_CMD_SET_IRQ_CONFIG, &req, sizeof(req), NULL, 0, NULL,
+ NULL);
+ if (ret && ret != -ENODEV)
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: SET_IRQ_CONFIG failed for pin %u (%pe)\n",
+ __func__, ch->ch_id, pin, ERR_PTR(ret));
+ return ret;
+}
+
+/*
+ * 0 if @pin's device-side direction matches @direction, else -EOPNOTSUPP: the
+ * device owns pin direction and the driver never changes it.
+ */
+static int lstp_gpio_require_direction(struct lstp_gpio_priv *priv, unsigned int pin, u8 direction)
+{
+ u8 cur_direction;
+
+ int ret = lstp_gpio_read_direction(priv, pin, &cur_direction);
+
+ if (ret)
+ return ret;
+
+ if (cur_direction == direction)
+ return 0;
+
+ return -EOPNOTSUPP;
+}
+
+static int lstp_gpio_get_direction(struct gpio_chip *gc, unsigned int pin)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ u8 direction;
+
+ int ret = lstp_gpio_read_direction(priv, pin, &direction);
+
+ if (ret)
+ return ret;
+
+ if (direction == LSTP_GPIO_INPUT)
+ return GPIO_LINE_DIRECTION_IN;
+
+ return GPIO_LINE_DIRECTION_OUT;
+}
+
+static int lstp_gpio_direction_input(struct gpio_chip *gc, unsigned int pin)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+
+ return lstp_gpio_require_direction(priv, pin, LSTP_GPIO_INPUT);
+}
+
+static int lstp_gpio_direction_output(struct gpio_chip *gc, unsigned int pin, int value)
+{
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ int ret = lstp_gpio_require_direction(priv, pin, LSTP_GPIO_OUTPUT);
+
+ if (ret)
+ return ret;
+
+ return lstp_gpio_set_value(gc, pin, value);
+}
+
+static int lstp_gpio_linux_irq_to_lstp(unsigned int type, u8 *irq_type)
+{
+ switch (type & IRQ_TYPE_SENSE_MASK) {
+ case IRQ_TYPE_NONE:
+ *irq_type = LSTP_GPIO_IRQ_NONE;
+ break;
+ case IRQ_TYPE_EDGE_RISING:
+ *irq_type = LSTP_GPIO_IRQ_RISING;
+ break;
+ case IRQ_TYPE_EDGE_FALLING:
+ *irq_type = LSTP_GPIO_IRQ_FALLING;
+ break;
+ case IRQ_TYPE_EDGE_BOTH:
+ *irq_type = LSTP_GPIO_IRQ_BOTH;
+ break;
+ case IRQ_TYPE_LEVEL_HIGH:
+ *irq_type = LSTP_GPIO_IRQ_HIGH;
+ break;
+ case IRQ_TYPE_LEVEL_LOW:
+ *irq_type = LSTP_GPIO_IRQ_LOW;
+ break;
+ default:
+ return -EINVAL;
+ }
+ return 0;
+}
+
+/* Host-side filter against stale batches or firmware that skips filtering. */
+static bool lstp_gpio_irq_event_matches(u8 irq_type, u8 value)
+{
+ switch (irq_type) {
+ case LSTP_GPIO_IRQ_NONE:
+ return false;
+ case LSTP_GPIO_IRQ_RISING:
+ return value == LSTP_GPIO_HIGH;
+ case LSTP_GPIO_IRQ_FALLING:
+ return value == LSTP_GPIO_LOW;
+ case LSTP_GPIO_IRQ_BOTH:
+ return true;
+ case LSTP_GPIO_IRQ_HIGH:
+ return value == LSTP_GPIO_HIGH;
+ case LSTP_GPIO_IRQ_LOW:
+ return value == LSTP_GPIO_LOW;
+ default:
+ return false;
+ }
+}
+
+/*
+ * Read every GPIO pin's IRQ type into @types, in descending pin order if
+ * @reverse. With @send_by, return -ETIME instead of sending a request after it.
+ */
+static int lstp_gpio_read_irq_types(struct lstp_gpio_priv *priv, u8 *types, bool reverse,
+ const unsigned long *send_by)
+{
+ for (unsigned int i = 0; i < priv->npins; i++) {
+ unsigned int pin = reverse ? priv->npins - 1 - i : i;
+
+ if (test_bit(pin, priv->led_pins))
+ continue;
+ if (send_by && time_after(jiffies, *send_by))
+ return -ETIME;
+
+ int ret = lstp_gpio_get_irq_config(priv, pin);
+
+ if (ret < 0)
+ return ret;
+ types[pin] = ret;
+ }
+
+ return 0;
+}
+
+#define LSTP_GPIO_IRQ_SYNC_PASSES 5
+#define LSTP_GPIO_IRQ_SYNC_BUDGET_MS 10000
+
+/*
+ * Seed hw_irq_type and shadow_irq_type from the device at probe, so the driver
+ * starts in sync even after a module reload with no device reset.
+ *
+ * A reply carries no tag; the first one after a request is its answer. The
+ * reply to a timed-out request can therefore answer a later request, whose
+ * own reply then answers the request after it, and every pin from there on
+ * reads the type of the pin read before it. So once a pass times out, all
+ * pins are read again until two consecutive passes without a timeout agree.
+ * Each pass follows a response timeout with no request waiting, in which an
+ * owed reply is dropped, and goes in the opposite pin order to the one before.
+ * A pass that agrees with an unshifted one is right, so two passes can agree
+ * on a wrong result only if both were shifted, in opposite directions.
+ *
+ * The probe runs in the context that added the device, often the hub's
+ * worker, so the re-reads and the final wait end within
+ * LSTP_GPIO_IRQ_SYNC_BUDGET_MS of the first timeout, or the probe fails.
+ */
+static int lstp_gpio_sync_hw_irq_state(struct lstp_gpio_priv *priv)
+{
+ struct lstp_channel *ch = priv->ch;
+ u8 *types[2] = { priv->hw_irq_type, priv->shadow_irq_type };
+ bool timed_out = false, have_prev = false;
+ unsigned long send_by = 0;
+ unsigned int active = 0;
+ int pass, ret;
+
+ for (pass = 0; pass < LSTP_GPIO_IRQ_SYNC_PASSES; pass++) {
+ if (timed_out)
+ msleep(LSTP_USB_RESPONSE_TIMEOUT_MS);
+
+ ret = lstp_gpio_read_irq_types(priv, types[pass & 1], pass & 1,
+ timed_out ? &send_by : NULL);
+ if (ret == -ETIME) {
+ ret = -ETIMEDOUT;
+ break;
+ }
+ if (ret == -ETIMEDOUT) {
+ if (!timed_out) {
+ dev_warn(ch->dev,
+ "%s: ch_%d: Reading the IRQ config of all pins again\n",
+ __func__, ch->ch_id);
+ /* Leave room for the last request's timeout and the final wait. */
+ send_by = jiffies +
+ msecs_to_jiffies(LSTP_GPIO_IRQ_SYNC_BUDGET_MS -
+ 2 * LSTP_USB_RESPONSE_TIMEOUT_MS);
+ }
+ timed_out = true;
+ have_prev = false;
+ continue;
+ }
+ if (ret)
+ return ret;
+ if (!timed_out || (have_prev && !memcmp(types[0], types[1], priv->npins)))
+ break;
+ have_prev = true;
+ ret = -EIO;
+ }
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: No consistent IRQ config (%pe)\n", __func__, ch->ch_id,
+ ERR_PTR(ret));
+ return ret;
+ }
+ /* A reply a shifted pass left owed must not answer the first request after probe. */
+ if (timed_out)
+ msleep(LSTP_USB_RESPONSE_TIMEOUT_MS);
+
+ if (pass & 1)
+ memcpy(priv->hw_irq_type, priv->shadow_irq_type, priv->npins);
+ else
+ memcpy(priv->shadow_irq_type, priv->hw_irq_type, priv->npins);
+ for (unsigned int pin = 0; pin < priv->npins; pin++) {
+ if (test_bit(pin, priv->led_pins))
+ continue;
+ if (priv->hw_irq_type[pin] > LSTP_GPIO_IRQ_MAX)
+ dev_warn(ch->dev, "%s: ch_%d: pin %u has unknown IRQ type %u\n", __func__,
+ ch->ch_id, pin, priv->hw_irq_type[pin]);
+ if (priv->hw_irq_type[pin] != LSTP_GPIO_IRQ_NONE)
+ active++;
+ }
+
+ if (active)
+ dev_info(ch->dev,
+ "%s: ch_%d: Synced IRQ state, %u/%u pins with active IRQ config\n",
+ __func__, ch->ch_id, active, priv->ngpio);
+
+ return 0;
+}
+
+/* Shadow only; SET_IRQ_CONFIG is sent from irq_bus_sync_unlock(). */
+static void lstp_gpio_irq_mask(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ unsigned int pin = irqd_to_hwirq(d);
+
+ priv->shadow_irq_type[pin] = LSTP_GPIO_IRQ_NONE;
+ gpiochip_disable_irq(gc, pin);
+}
+
+static void lstp_gpio_irq_unmask(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ unsigned int pin = irqd_to_hwirq(d);
+ unsigned int type = irqd_get_trigger_type(d);
+ u8 irq_type;
+
+ if (lstp_gpio_linux_irq_to_lstp(type, &irq_type)) {
+ dev_err_ratelimited(priv->ch->dev,
+ "%s: ch_%d: Invalid trigger type %u for gpio %u\n", __func__,
+ priv->ch->ch_id, type, pin);
+ return;
+ }
+
+ gpiochip_enable_irq(gc, pin);
+ priv->shadow_irq_type[pin] = irq_type;
+}
+
+/*
+ * Validates the trigger type and nothing else. The callback still has to
+ * exist: with no .irq_set_type, __irq_set_trigger() accepts whatever it was
+ * given without asking the driver. IRQCHIP_SET_TYPE_MASKED makes the core
+ * mask around this call and unmask after, and irq_unmask() is what puts the
+ * type in the shadow.
+ */
+static int lstp_gpio_irq_set_type(struct irq_data *d, unsigned int type)
+{
+ u8 irq_type;
+
+ return lstp_gpio_linux_irq_to_lstp(type, &irq_type);
+}
+
+static void lstp_gpio_irq_bus_lock(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+
+ mutex_lock(&priv->irq_lock);
+}
+
+/* Commit the shadow if it differs from hardware; revert the shadow on failure. */
+static void lstp_gpio_irq_bus_sync_unlock(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+ struct lstp_gpio_priv *priv = gpiochip_get_data(gc);
+ u16 pin = irqd_to_hwirq(d);
+
+ if (priv->shadow_irq_type[pin] != priv->hw_irq_type[pin]) {
+ if (lstp_gpio_set_irq_config(priv, pin, priv->shadow_irq_type[pin]))
+ priv->shadow_irq_type[pin] = priv->hw_irq_type[pin];
+ else
+ priv->hw_irq_type[pin] = priv->shadow_irq_type[pin];
+ }
+
+ mutex_unlock(&priv->irq_lock);
+}
+
+static void lstp_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+
+ seq_puts(p, gc->label ? gc->label : d->chip->name);
+}
+
+static const struct irq_chip lstp_gpio_irq_chip = {
+ .name = "lstp-gpio",
+ .irq_mask = lstp_gpio_irq_mask,
+ .irq_unmask = lstp_gpio_irq_unmask,
+ .irq_set_type = lstp_gpio_irq_set_type,
+ .irq_bus_lock = lstp_gpio_irq_bus_lock,
+ .irq_bus_sync_unlock = lstp_gpio_irq_bus_sync_unlock,
+ .irq_print_chip = lstp_gpio_irq_print_chip,
+ .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,
+ GPIOCHIP_IRQ_RESOURCE_HELPERS,
+};
+
+/*
+ * Deferred GPIO IRQ batch handler. handle_nested_irq() runs the line's
+ * threaded handler inline in this context, and the ordered workqueue
+ * serialises batches, so events reach handlers in USB receive order.
+ */
+static void lstp_gpio_irq_event_work(struct work_struct *work)
+{
+ struct lstp_gpio_irq_event_work *batch =
+ container_of(work, struct lstp_gpio_irq_event_work, work);
+ struct lstp_gpio_priv *priv = batch->priv;
+ struct lstp_channel *ch = priv->ch;
+ struct gpio_chip *gc = &priv->gc;
+ const struct lstp_gpio_irq_event_req *event;
+ const struct lstp_gpio_irq_event_req *end;
+
+ /* Probe enforces bulk_rx_size >= LSTP_USB_EP_MIN_SIZE; anchor base here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(*event) > LSTP_USB_EP_MIN_SIZE);
+
+ if (batch->payload_len < sizeof(*event)) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: IRQ event packet too small (got %u, need >=%zu)\n",
+ __func__, ch->ch_id, batch->payload_len, sizeof(*event));
+ goto out;
+ }
+
+ if (batch->payload_len % sizeof(*event)) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Malformed IRQ event payload (len %u, record size %zu)\n",
+ __func__, ch->ch_id, batch->payload_len, sizeof(*event));
+ goto out;
+ }
+
+ end = (void *)(batch->payload + batch->payload_len);
+ for (event = (void *)batch->payload; event < end; event++) {
+ u16 pin = le16_to_cpu(event->pin);
+
+ if (pin >= priv->npins || test_bit(pin, priv->led_pins)) {
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: IRQ on non-GPIO pin %u\n",
+ __func__, ch->ch_id, pin);
+ continue;
+ }
+
+ u8 value = event->value;
+
+ dev_dbg(ch->dev, "%s: ch=%d: IRQ event: pin=%u, value=%u\n", __func__, ch->ch_id,
+ pin, value);
+
+ if (!lstp_gpio_irq_event_matches(priv->hw_irq_type[pin], value)) {
+ dev_dbg(ch->dev, "%s: ch_%d: Skipping pin %u value %u (irq_type %u)\n",
+ __func__, ch->ch_id, pin, value, priv->hw_irq_type[pin]);
+ continue;
+ }
+
+ int irq = irq_find_mapping(gc->irq.domain, pin);
+
+ if (irq) {
+ handle_nested_irq(irq);
+ dev_dbg(ch->dev, "%s: ch_%d: Nested IRQ %d handled for pin %u\n", __func__,
+ ch->ch_id, irq, pin);
+ } else {
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: No IRQ mapping found for pin %u\n",
+ __func__, ch->ch_id, pin);
+ }
+ }
+
+out:
+ kfree(batch);
+}
+
+/*
+ * ops->irq_packet: copy the payload out and queue it. IRQ_EVENT is never
+ * answered, so a batch dropped here is a lost edge, not a deferred one.
+ */
+static void lstp_gpio_irq_event(struct lstp_channel *ch, struct lstp_packet *pkt)
+{
+ struct lstp_gpio_priv *priv = ch->priv;
+
+ /* No GPIO lines: no irqchip and no workqueue, so nothing to deliver. */
+ if (!priv->ngpio) {
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Dropping IRQ event on a channel without GPIO lines\n",
+ __func__, ch->ch_id);
+ return;
+ }
+
+ u16 payload_len = le16_to_cpu(pkt->hdr.length);
+
+ if (!payload_len)
+ return;
+
+ if (payload_len > ch->max_rx_payload) {
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Dropping IRQ payload too large (%u > %zu bytes)\n",
+ __func__, ch->ch_id, payload_len, ch->max_rx_payload);
+ return;
+ }
+
+ struct lstp_gpio_irq_event_work *batch =
+ kzalloc_flex(*batch, payload, payload_len, GFP_ATOMIC);
+ if (!batch)
+ return;
+
+ batch->priv = priv;
+ batch->payload_len = payload_len;
+ memcpy(batch->payload, pkt->payload, payload_len);
+
+ INIT_WORK(&batch->work, lstp_gpio_irq_event_work);
+ if (!queue_work(priv->wq, &batch->work)) {
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Failed to queue IRQ event work (%u bytes)\n",
+ __func__, ch->ch_id, payload_len);
+ kfree(batch);
+ }
+}
+
+/*
+ * HOLD and INTERPOLATE differ only in device-side rendering; the host treats
+ * both as LED pins, which are excluded from the gpiochip.
+ */
+static bool lstp_gpio_pin_is_led(u8 led_support)
+{
+ return led_support == LSTP_GPIO_LED_MODE_HOLD ||
+ led_support == LSTP_GPIO_LED_MODE_INTERPOLATE;
+}
+
+static void lstp_gpio_clear_led_valid_mask(struct lstp_gpio_priv *priv, unsigned long *valid_mask,
+ unsigned int ngpios)
+{
+ bitmap_andnot(valid_mask, valid_mask, priv->led_pins, ngpios);
+}
+
+/* gpio_chip and gpio_irq_chip valid_mask callbacks: LED pins are not lines. */
+static int lstp_gpio_init_valid_mask(struct gpio_chip *gc, unsigned long *valid_mask,
+ unsigned int ngpios)
+{
+ lstp_gpio_clear_led_valid_mask(gpiochip_get_data(gc), valid_mask, ngpios);
+ return 0;
+}
+
+static void lstp_gpio_irq_init_valid_mask(struct gpio_chip *gc, unsigned long *valid_mask,
+ unsigned int ngpios)
+{
+ lstp_gpio_clear_led_valid_mask(gpiochip_get_data(gc), valid_mask, ngpios);
+}
+
+static void lstp_gpio_destroy_wq(void *wq)
+{
+ destroy_workqueue(wq);
+}
+
+static int lstp_gpio_create_gpiochip(struct lstp_gpio_priv *priv)
+{
+ struct lstp_channel *ch = priv->ch;
+ struct device *dev = ch->dev;
+ struct gpio_chip *gc = &priv->gc;
+
+ gc->label = ch->display_name;
+ gc->owner = THIS_MODULE;
+ gc->names = priv->pin_names;
+ gc->base = -1;
+ gc->ngpio = priv->npins;
+ gc->get = lstp_gpio_get_value;
+ gc->set = lstp_gpio_set_value;
+ gc->can_sleep = true;
+ gc->get_multiple = lstp_gpio_get_multiple;
+ gc->set_multiple = lstp_gpio_set_multiple;
+ gc->get_direction = lstp_gpio_get_direction;
+ gc->direction_input = lstp_gpio_direction_input;
+ gc->direction_output = lstp_gpio_direction_output;
+ gc->init_valid_mask = lstp_gpio_init_valid_mask;
+ gc->parent = dev;
+ gc->fwnode = ch->fwnode;
+
+ return 0;
+}
+
+static int lstp_gpio_create_irq_chip(struct lstp_gpio_priv *priv)
+{
+ struct lstp_channel *ch = priv->ch;
+ struct device *dev = ch->dev;
+ struct gpio_chip *gc = &priv->gc;
+ struct gpio_irq_chip *girq = &gc->irq;
+
+ if (!priv->ngpio)
+ return 0;
+
+ priv->shadow_irq_type =
+ devm_kcalloc(dev, priv->npins, sizeof(*priv->shadow_irq_type), GFP_KERNEL);
+ if (!priv->shadow_irq_type)
+ return -ENOMEM;
+
+ priv->hw_irq_type = devm_kcalloc(dev, priv->npins, sizeof(*priv->hw_irq_type), GFP_KERNEL);
+ if (!priv->hw_irq_type)
+ return -ENOMEM;
+
+ gpio_irq_chip_set_chip(girq, &lstp_gpio_irq_chip);
+ girq->init_valid_mask = lstp_gpio_irq_init_valid_mask;
+ girq->parent_handler = NULL;
+ girq->num_parents = 0;
+ girq->parents = NULL;
+ girq->default_type = IRQ_TYPE_NONE;
+ girq->handler = handle_simple_irq;
+ girq->threaded = true;
+
+ mutex_init(&priv->irq_lock);
+
+ priv->wq = alloc_ordered_workqueue("lstp_gpio_wq", 0);
+ if (!priv->wq) {
+ dev_err(dev, "%s: ch_%d: Failed to create ordered IRQ workqueue\n", __func__,
+ ch->ch_id);
+ return -ENOMEM;
+ }
+
+ int ret = devm_add_action_or_reset(dev, lstp_gpio_destroy_wq, priv->wq);
+
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+/*
+ * Claim @pin for the LED driver if it is an output whose firmware config
+ * reports HOLD or INTERPOLATE; otherwise -EINVAL, and the pin stays a GPIO.
+ */
+static int lstp_gpio_claim_led(struct lstp_gpio_priv *priv, u16 pin, u8 direction, u8 led_support)
+{
+ struct lstp_channel *ch = priv->ch;
+
+ if (!lstp_gpio_pin_is_led(led_support))
+ return -EINVAL;
+
+ if (direction != LSTP_GPIO_OUTPUT) {
+ dev_warn(ch->dev,
+ "%s: ch_%d: led_support=0x%02x for pin %u but direction is input, treating as GPIO\n",
+ __func__, ch->ch_id, led_support, pin);
+ return -EINVAL;
+ }
+
+ set_bit(pin, priv->led_pins);
+ return 0;
+}
+
+/*
+ * LED children not yet released. Their release runs this module's code and
+ * can come after the GPIO driver's unbind, so module exit, and an init that
+ * fails, wait until none remain.
+ */
+static atomic_t lstp_gpio_live_leds = ATOMIC_INIT(0);
+
+/*
+ * Deletion drops the child's parent reference, so the child pins the channel
+ * itself: this release then runs before the channel's, which the core's
+ * module exit waits for.
+ */
+static void lstp_gpio_leds_release(struct device *dev)
+{
+ struct lstp_leds *leds = container_of(to_auxiliary_dev(dev), struct lstp_leds, auxdev);
+ struct device *parent = leds->ch->dev;
+
+ kfree(leds);
+ put_device(parent);
+ if (atomic_dec_and_test(&lstp_gpio_live_leds))
+ wake_up_var(&lstp_gpio_live_leds);
+}
+
+static void lstp_gpio_leds_remove(void *data)
+{
+ struct auxiliary_device *auxdev = data;
+
+ auxiliary_device_delete(auxdev);
+ auxiliary_device_uninit(auxdev);
+}
+
+/*
+ * Hand the LED pins to the LED driver on an auxiliary child named after the
+ * channel's instance @id. Best-effort: on failure the GPIOs stay up. The child
+ * goes with this driver's devres, while the channel can still carry the LED
+ * driver's last requests.
+ */
+static void lstp_gpio_add_leds(struct lstp_gpio_priv *priv, u32 id)
+{
+ struct lstp_channel *ch = priv->ch;
+ struct lstp_leds *leds;
+ unsigned int pin;
+ u16 i = 0;
+ int ret;
+
+ if (!priv->nleds)
+ return;
+
+ leds = kzalloc_flex(*leds, pins, priv->nleds);
+ if (!leds) {
+ ret = -ENOMEM;
+ goto err;
+ }
+ leds->npins = priv->nleds;
+ leds->ch = ch;
+ for_each_set_bit(pin, priv->led_pins, priv->npins) {
+ leds->pins[i].pin = pin;
+ strscpy(leds->pins[i].name, priv->pin_names[pin], sizeof(leds->pins[i].name));
+ i++;
+ }
+
+ leds->auxdev.name = "led";
+ leds->auxdev.id = id;
+ leds->auxdev.dev.parent = ch->dev;
+ leds->auxdev.dev.release = lstp_gpio_leds_release;
+
+ ret = auxiliary_device_init(&leds->auxdev);
+ if (ret) {
+ kfree(leds);
+ goto err;
+ }
+ atomic_inc(&lstp_gpio_live_leds);
+ get_device(ch->dev);
+ ret = __auxiliary_device_add(&leds->auxdev, LSTP_LEDS_AUXDEV_MODNAME);
+ if (ret) {
+ auxiliary_device_uninit(&leds->auxdev);
+ goto err;
+ }
+ ret = devm_add_action_or_reset(ch->dev, lstp_gpio_leds_remove, &leds->auxdev);
+ if (ret)
+ goto err;
+ return;
+
+err:
+ dev_warn(ch->dev, "%s: ch_%d: Could not add the device for %u LEDs (%pe)\n", __func__,
+ ch->ch_id, priv->nleds, ERR_PTR(ret));
+}
+
+/* lstp_read_config_table() callback: classify one pin entry as GPIO or LED. */
+static int lstp_gpio_pin_setup_on_entry(struct lstp_channel *ch, unsigned int pin,
+ const void *entry, void *ctx)
+{
+ struct lstp_gpio_priv *priv = ctx;
+ const struct lstp_gpio_pin *pin_cfg = entry;
+ u8 led_support = pin_cfg->config.led_support;
+ char *name = devm_kzalloc(ch->dev, GPIO_MAX_NAME_SIZE, GFP_KERNEL);
+
+ if (!name)
+ return -ENOMEM;
+ snprintf(name, GPIO_MAX_NAME_SIZE, "%.*s", (int)LSTP_GPIO_PIN_NAME_LEN, pin_cfg->pin_name);
+ priv->pin_names[pin] = name;
+
+ if (lstp_gpio_pin_is_led(led_support)) {
+ if (!lstp_gpio_claim_led(priv, pin, pin_cfg->config.direction, led_support)) {
+ priv->nleds++;
+ return 0;
+ }
+ /* LED config rejected (claim_led logged why); fall back to GPIO. */
+ } else if (led_support != LSTP_GPIO_NOT_LED) {
+ dev_warn(ch->dev,
+ "%s: ch_%d: Unknown led_support=0x%02x for pin %u, treating as GPIO\n",
+ __func__, ch->ch_id, led_support, pin);
+ }
+
+ priv->ngpio++;
+ return 0;
+}
+
+static void lstp_gpio_flush_irq_work(void *wq)
+{
+ flush_workqueue(wq);
+}
+
+/* Classifies each configured pin as GPIO or LED, then registers both. */
+static int lstp_gpio_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
+ int ret;
+
+ if (!info)
+ return -ENODEV;
+
+ const struct lstp_gpio_config *config = info->config;
+
+ if (info->config_len < sizeof(*config)) {
+ dev_err(ch->dev, "%s: ch_%d: GPIO config too short: %zu < %zu\n", __func__,
+ ch->ch_id, info->config_len, sizeof(*config));
+ return -EINVAL;
+ }
+ if (config->npins == 0) {
+ dev_err(ch->dev, "%s: ch_%d: Invalid npins of 0\n", __func__, ch->ch_id);
+ return -EINVAL;
+ }
+
+ struct lstp_gpio_priv *priv = devm_kzalloc(ch->dev, sizeof(*priv), GFP_KERNEL);
+
+ if (!priv)
+ return -ENOMEM;
+
+ priv->pin_names =
+ devm_kcalloc(ch->dev, config->npins, sizeof(*priv->pin_names), GFP_KERNEL);
+ if (!priv->pin_names)
+ return -ENOMEM;
+
+ priv->led_pins = devm_bitmap_zalloc(ch->dev, config->npins, GFP_KERNEL);
+ if (!priv->led_pins)
+ return -ENOMEM;
+
+ priv->ch = ch;
+ priv->npins = config->npins;
+
+ /* gpiolib bounds chip and line names by GPIO_MAX_NAME_SIZE. */
+ if (strlen(ch->display_name) >= GPIO_MAX_NAME_SIZE) {
+ dev_warn(ch->dev, "%s: ch_%d: display_name truncated to '%.*s' (max %d chars)\n",
+ __func__, ch->ch_id, GPIO_MAX_NAME_SIZE - 1, ch->display_name,
+ GPIO_MAX_NAME_SIZE - 1);
+ ch->display_name[GPIO_MAX_NAME_SIZE - 1] = '\0';
+ }
+
+ ret = lstp_gpio_create_gpiochip(priv);
+ if (ret)
+ return ret;
+
+ ret = lstp_read_config_table(ch, sizeof(struct lstp_gpio_config),
+ sizeof(struct lstp_gpio_pin), priv->npins,
+ lstp_gpio_pin_setup_on_entry, priv);
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: Could not setup pins (%pe)\n", __func__, ch->ch_id,
+ ERR_PTR(ret));
+ return ret;
+ }
+ if (priv->ngpio == 0 && priv->nleds == 0) {
+ dev_err(ch->dev, "%s: ch_%d: No GPIO or LED pins discovered\n", __func__,
+ ch->ch_id);
+ return -EINVAL;
+ }
+
+ ret = lstp_gpio_create_irq_chip(priv);
+ if (ret)
+ return ret;
+
+ ch->priv = priv;
+
+ if (priv->ngpio) {
+ ret = lstp_gpio_sync_hw_irq_state(priv);
+ if (ret)
+ return ret;
+
+ ret = devm_gpiochip_add_data(ch->dev, &priv->gc, priv);
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: Could not register GPIO chip (%pe)\n",
+ __func__, ch->ch_id, ERR_PTR(ret));
+ return ret;
+ }
+
+ /*
+ * Booked after the chip so it runs before the chip goes: removal
+ * frees gc->irq.domain without clearing it, and
+ * lstp_gpio_irq_event_work() reads it. Dispatch is retracted
+ * before the auxdev's devres runs, so no batch is queued behind
+ * the flush.
+ */
+ ret = devm_add_action_or_reset(ch->dev, lstp_gpio_flush_irq_work, priv->wq);
+ if (ret)
+ return ret;
+ }
+
+ lstp_gpio_add_leds(priv, auxdev->id);
+
+ dev_info(ch->dev, "%s: ch_%d: Started as %s with %u GPIOs and %u LEDs\n", __func__,
+ ch->ch_id, priv->gc.label, priv->ngpio, priv->nleds);
+ return 0;
+}
+
+static const struct lstp_ops lstp_gpio_ops = {
+ .irq_packet = lstp_gpio_irq_event,
+};
+
+static const struct auxiliary_device_id lstp_gpio_id_table[] = { { .name = "lstp.gpio" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_gpio_id_table);
+
+static struct lstp_auxiliary_driver lstp_gpio_drv = {
+ .adrv = {
+ .name = "gpio",
+ .probe = lstp_gpio_probe,
+ .id_table = lstp_gpio_id_table,
+ },
+ .ops = &lstp_gpio_ops,
+};
+
+static int __init lstp_gpio_module_init(void)
+{
+ int ret = lstp_auxiliary_driver_register(&lstp_gpio_drv);
+
+ /* A registration that fails after binding has deleted LED children. */
+ if (ret)
+ wait_var_event(&lstp_gpio_live_leds, !atomic_read(&lstp_gpio_live_leds));
+ return ret;
+}
+module_init(lstp_gpio_module_init);
+
+/* The unregister unbinds every channel, which deletes its LED child. */
+static void __exit lstp_gpio_module_exit(void)
+{
+ lstp_auxiliary_driver_unregister(&lstp_gpio_drv);
+ wait_var_event(&lstp_gpio_live_leds, !atomic_read(&lstp_gpio_live_leds));
+}
+module_exit(lstp_gpio_module_exit);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP GPIO driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 07/11] leds: Add NVIDIA LSTP LED driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (5 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 06/11] gpio: Add NVIDIA LSTP GPIO driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 08/11] i2c: Add NVIDIA LSTP I2C driver Adrian Ambrozewicz
` (3 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Lee Jones, Pavel Machek
Cc: Donald Shannon, Linus Walleij, Bartosz Golaszewski, linux-kernel,
linux-leds, linux-usb, linux-gpio, Greg Kroah-Hartman
Add a driver for the LEDs of NVIDIA LSTP USB adapters: the pins of a
GPIO channel that the firmware reports as LEDs, which the GPIO driver
offers as an auxiliary device. Each is registered with the LED class;
blink and pattern requests are handed to the adapter, which plays them
on its own. A leds child node of the channel can name the LEDs and set
their default state, trigger and pattern.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/leds/Kconfig | 14 ++
drivers/leds/Makefile | 1 +
drivers/leds/leds-lstp.c | 404 +++++++++++++++++++++++++++++++++++++++
4 files changed, 420 insertions(+)
create mode 100644 drivers/leds/leds-lstp.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 639cd7b6b146..c8ed59cd4b11 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19578,6 +19578,7 @@ F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
F: Documentation/driver-api/usb/lstp.rst
F: Documentation/firmware-guide/acpi/lstp.rst
F: drivers/gpio/gpio-lstp.c
+F: drivers/leds/leds-lstp.c
F: drivers/usb/misc/lstp.c
F: include/linux/usb/lstp.h
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index d0d3182236be..aa843e72a28d 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -1050,6 +1050,20 @@ source "drivers/leds/flash/Kconfig"
comment "RGB LED drivers"
source "drivers/leds/rgb/Kconfig"
+config LEDS_LSTP
+ tristate "LED support for NVIDIA LSTP adapters"
+ depends on LEDS_CLASS
+ depends on GPIO_LSTP
+ default GPIO_LSTP
+ help
+ Say Y or M here to support the LEDs of NVIDIA LSTP USB adapters,
+ the pins of the adapter's GPIO channels that the firmware reports
+ as LEDs. They are registered with the LED class, with blink and
+ pattern requests handed to the adapter.
+
+ This driver can also be built as a module. If so, the module
+ will be called leds-lstp.
+
comment "LED Triggers"
source "drivers/leds/trigger/Kconfig"
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index a68244bd50fb..115b88c6b61a 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -60,6 +60,7 @@ obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o
obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o
obj-$(CONFIG_LEDS_LP8860) += leds-lp8860.o
obj-$(CONFIG_LEDS_LP8864) += leds-lp8864.o
+obj-$(CONFIG_LEDS_LSTP) += leds-lstp.o
obj-$(CONFIG_LEDS_LT3593) += leds-lt3593.o
obj-$(CONFIG_LEDS_LTC3220) += leds-ltc3220.o
obj-$(CONFIG_LEDS_MAX5970) += leds-max5970.o
diff --git a/drivers/leds/leds-lstp.c b/drivers/leds/leds-lstp.c
new file mode 100644
index 000000000000..352e484eb919
--- /dev/null
+++ b/drivers/leds/leds-lstp.c
@@ -0,0 +1,404 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * LED driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/auxiliary_bus.h>
+#include <linux/build_bug.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/kernel.h>
+#include <linux/leds.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/property.h>
+#include <linux/slab.h>
+
+#include <linux/usb/lstp.h>
+
+#define LSTP_LED_REPEAT_FOREVER 0 /* wire: repeats == 0 plays forever */
+#define LSTP_LED_LINUX_REPEAT_FOREVER (-1) /* LED-class pattern_set: repeat == -1 plays forever */
+#define LSTP_LED_DEFAULT_HOLD_TIME_MS 1 /* delta_t for single-step holds */
+#define LSTP_LED_DEFAULT_BLINK_MS 500 /* LED-class default when delay_on/off are both 0 */
+
+/* A GPIO channel command; the others are in gpio-lstp.c. */
+#define LSTP_GPIO_CMD_SET_LED_PATTERN 0x05
+
+struct lstp_led_pattern {
+ u8 brightness;
+ __le32 time_ms;
+} __packed;
+
+struct lstp_gpio_set_led_pattern_req {
+ __le16 pin;
+ __le32 repeats;
+ u8 num_steps;
+ struct lstp_led_pattern pattern[];
+} __packed;
+
+struct lstp_led {
+ struct led_classdev cdev;
+ struct lstp_channel *ch;
+ u16 pin;
+};
+
+/* Send SET_LED_PATTERN. @num_steps 0 clears the pattern, 1 holds forever. */
+static int lstp_led_set_pattern(struct lstp_led *led, u32 repeats,
+ const struct led_pattern *pattern, u8 num_steps)
+{
+ struct lstp_channel *ch = led->ch;
+ struct lstp_gpio_set_led_pattern_req *req;
+ size_t req_len = struct_size(req, pattern, num_steps);
+ /* The LED core applies a firmware-node max-brightness; the wire is 8-bit */
+ unsigned int max_brightness = min_t(unsigned int, led->cdev.max_brightness, U8_MAX);
+
+ /* Probe enforces bulk_tx_size >= LSTP_USB_EP_MIN_SIZE; anchor base here. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) + sizeof(*req) > LSTP_USB_EP_MIN_SIZE);
+
+ for (u8 i = 0; i < num_steps; i++) {
+ if (pattern[i].brightness > max_brightness)
+ return -EINVAL;
+ }
+
+ if (req_len > ch->max_tx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: SET_LED_PATTERN too long for led '%s' (%zu bytes, max %zu)\n",
+ __func__, ch->ch_id, led->cdev.name, req_len,
+ ch->max_tx_payload);
+ return -EMSGSIZE;
+ }
+
+ req = kmalloc(req_len, GFP_KERNEL);
+ if (!req)
+ return -ENOMEM;
+
+ req->pin = cpu_to_le16(led->pin);
+ req->repeats = cpu_to_le32(repeats);
+ req->num_steps = num_steps;
+ for (u8 i = 0; i < num_steps; i++) {
+ req->pattern[i].brightness = (u8)pattern[i].brightness;
+ req->pattern[i].time_ms = cpu_to_le32(pattern[i].delta_t);
+ }
+
+ int ret =
+ lstp_request(ch, LSTP_GPIO_CMD_SET_LED_PATTERN, req, req_len, NULL, 0, NULL, NULL);
+ if (ret && ret != -ENODEV)
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: SET_LED_PATTERN failed for led '%s' (repeats=%u, num_steps=%u) (%pe)\n",
+ __func__, ch->ch_id, led->cdev.name, repeats, num_steps,
+ ERR_PTR(ret));
+
+ kfree(req);
+ return ret;
+}
+
+/*
+ * blink_set: @delay_on 0 holds OFF, @delay_off 0 holds ON, both 0 selects the
+ * LED-class 500 ms default. On-brightness is cdev->brightness, falling back to
+ * max_brightness when the LED is currently off.
+ */
+static int lstp_led_blink_set(struct led_classdev *cdev, unsigned long *delay_on,
+ unsigned long *delay_off)
+{
+ struct lstp_led *led = container_of(cdev, struct lstp_led, cdev);
+ u8 on_value = cdev->brightness ? (u8)cdev->brightness : (u8)cdev->max_brightness;
+ struct led_pattern steps[2];
+ u8 len;
+
+ if (*delay_on == 0 && *delay_off == 0) {
+ *delay_on = LSTP_LED_DEFAULT_BLINK_MS;
+ *delay_off = LSTP_LED_DEFAULT_BLINK_MS;
+ }
+
+ if (*delay_on == 0) {
+ steps[0].delta_t = LSTP_LED_DEFAULT_HOLD_TIME_MS;
+ steps[0].brightness = LED_OFF;
+ len = 1;
+ } else if (*delay_off == 0) {
+ steps[0].delta_t = LSTP_LED_DEFAULT_HOLD_TIME_MS;
+ steps[0].brightness = on_value;
+ len = 1;
+ } else {
+ steps[0].delta_t = *delay_on;
+ steps[0].brightness = on_value;
+ steps[1].delta_t = *delay_off;
+ steps[1].brightness = LED_OFF;
+ len = 2;
+ }
+ return lstp_led_set_pattern(led, LSTP_LED_REPEAT_FOREVER, steps, len);
+}
+
+/*
+ * pattern_set: LED-class repeat -1 maps to the wire's repeats == 0 ("forever").
+ * repeat == 0 and anything below -1 are invalid.
+ */
+static int lstp_led_pattern_set(struct led_classdev *cdev, struct led_pattern *pattern, u32 len,
+ int repeat)
+{
+ struct lstp_led *led = container_of(cdev, struct lstp_led, cdev);
+
+ if (len > U8_MAX)
+ return -EMSGSIZE;
+ if (repeat == 0 || repeat < LSTP_LED_LINUX_REPEAT_FOREVER)
+ return -EINVAL;
+
+ u32 mapped_repeat = (repeat == LSTP_LED_LINUX_REPEAT_FOREVER) ? LSTP_LED_REPEAT_FOREVER :
+ (u32)repeat;
+ return lstp_led_set_pattern(led, mapped_repeat, pattern, (u8)len);
+}
+
+static int lstp_led_pattern_clear(struct led_classdev *cdev)
+{
+ struct lstp_led *led = container_of(cdev, struct lstp_led, cdev);
+
+ return lstp_led_set_pattern(led, LSTP_LED_REPEAT_FOREVER, NULL, 0);
+}
+
+/* brightness_set_blocking: a one-step pattern; @brightness is core-clamped. */
+static int lstp_led_brightness_set_blocking(struct led_classdev *cdev,
+ enum led_brightness brightness)
+{
+ struct lstp_led *led = container_of(cdev, struct lstp_led, cdev);
+ struct led_pattern step = { .delta_t = LSTP_LED_DEFAULT_HOLD_TIME_MS,
+ .brightness = brightness };
+
+ return lstp_led_set_pattern(led, LSTP_LED_REPEAT_FOREVER, &step, 1);
+}
+
+/*
+ * Send @fwnode's led-pattern once, repeating forever; the device then plays it
+ * without host involvement. A pattern that does not fit in one request is not
+ * sent at all.
+ */
+static void lstp_led_send_fwnode_pattern(struct lstp_led *led, struct fwnode_handle *fwnode)
+{
+ struct lstp_channel *ch = led->ch;
+ struct lstp_gpio_set_led_pattern_req *req;
+ size_t max_steps = min_t(size_t, U8_MAX,
+ (ch->max_tx_payload - sizeof(*req)) / sizeof(req->pattern[0]));
+ int count = fwnode_property_count_u32(fwnode, "led-pattern");
+ struct led_pattern *steps = NULL;
+ unsigned int num_steps;
+ u32 *raw = NULL;
+
+ if (count <= 0 || count % 2) {
+ dev_err(ch->dev,
+ "%s: ch_%d: led-pattern of LED '%s' is not a list of <brightness duration> pairs\n",
+ __func__, ch->ch_id, led->cdev.name);
+ return;
+ }
+
+ num_steps = count / 2;
+ if (num_steps > max_steps) {
+ dev_err(ch->dev,
+ "%s: ch_%d: led-pattern of LED '%s' has %u steps, the device takes at most %zu\n",
+ __func__, ch->ch_id, led->cdev.name, num_steps, max_steps);
+ return;
+ }
+
+ raw = kcalloc(count, sizeof(*raw), GFP_KERNEL);
+ steps = kzalloc_objs(*steps, num_steps);
+ if (!raw || !steps || fwnode_property_read_u32_array(fwnode, "led-pattern", raw, count))
+ goto out;
+
+ for (unsigned int i = 0; i < num_steps; i++) {
+ if (raw[2 * i] > led->cdev.max_brightness) {
+ dev_err(ch->dev,
+ "%s: ch_%d: led-pattern of LED '%s': step %u brightness %u exceeds %u\n",
+ __func__, ch->ch_id, led->cdev.name, i, raw[2 * i],
+ led->cdev.max_brightness);
+ goto out;
+ }
+ steps[i].brightness = raw[2 * i];
+ steps[i].delta_t = raw[2 * i + 1];
+ }
+
+ lstp_led_set_pattern(led, LSTP_LED_REPEAT_FOREVER, steps, num_steps);
+out:
+ kfree(steps);
+ kfree(raw);
+}
+
+/*
+ * default-state is written once, and a missing one means "off". "keep" leaves
+ * the LED as the device firmware set it: the device cannot report its current
+ * state, so there is nothing to read back.
+ */
+static void lstp_led_apply_default_state(struct lstp_led *led, struct fwnode_handle *fwnode)
+{
+ switch (led_init_default_state_get(fwnode)) {
+ case LEDS_DEFSTATE_KEEP:
+ return;
+ case LEDS_DEFSTATE_ON:
+ led->cdev.brightness = led->cdev.max_brightness;
+ break;
+ default:
+ led->cdev.brightness = LED_OFF;
+ break;
+ }
+
+ lstp_led_brightness_set_blocking(&led->cdev, led->cdev.brightness);
+}
+
+static void lstp_led_put_fwnode(void *fwnode)
+{
+ fwnode_handle_put(fwnode);
+}
+
+/*
+ * led_classdev_unregister() flushes set_brightness_work before it removes the
+ * sysfs files, and the LED core does not refuse brightness or trigger writes in
+ * between: such a write would queue work or attach a trigger that outlives
+ * @data. Disable sysfs first, under led_access, so they fail with -EBUSY.
+ */
+static void lstp_led_unregister(void *data)
+{
+ struct led_classdev *cdev = data;
+
+ mutex_lock(&cdev->led_access);
+ led_sysfs_disable(cdev);
+ mutex_unlock(&cdev->led_access);
+ led_classdev_unregister(cdev);
+}
+
+static int lstp_led_classdev_register(struct device *dev, struct led_classdev *cdev,
+ struct led_init_data *init_data)
+{
+ int ret = led_classdev_register_ext(dev, cdev, init_data);
+
+ if (ret)
+ return ret;
+ return devm_add_action_or_reset(dev, lstp_led_unregister, cdev);
+}
+
+/* Register @led, initialised from @fwnode if any. A failure leaves the other LEDs up. */
+static int lstp_led_register(struct device *dev, struct lstp_led *led, struct fwnode_handle *fwnode)
+{
+ int ret;
+
+ if (!fwnode) {
+ ret = lstp_led_classdev_register(dev, &led->cdev, NULL);
+ } else {
+ struct led_init_data init_data = { .fwnode = fwnode };
+
+ /*
+ * The class device keeps @fwnode as its node, and default_trigger
+ * points into it. Queued first, the put runs after unregistration.
+ */
+ ret = devm_add_action_or_reset(dev, lstp_led_put_fwnode, fwnode_handle_get(fwnode));
+ if (!ret) {
+ bool pattern = fwnode_property_present(fwnode, "led-pattern");
+ bool trigger = fwnode_property_present(fwnode, "linux,default-trigger");
+
+ /* A trigger takes precedence; the LED core applies it from @fwnode. */
+ if (pattern && trigger)
+ dev_err(dev,
+ "%s: ch_%d: Ignoring led-pattern of LED '%s': %pfw also sets linux,default-trigger\n",
+ __func__, led->ch->ch_id, led->cdev.name, fwnode);
+ if (pattern && !trigger)
+ lstp_led_send_fwnode_pattern(led, fwnode);
+ else
+ lstp_led_apply_default_state(led, fwnode);
+ ret = lstp_led_classdev_register(dev, &led->cdev, &init_data);
+ }
+ }
+
+ if (ret)
+ dev_warn(dev, "%s: ch_%d: Could not register LED '%s', pin %u (%pe)\n", __func__,
+ led->ch->ch_id, led->cdev.name, led->pin, ERR_PTR(ret));
+ return ret;
+}
+
+static struct lstp_led *lstp_led_by_pin(struct lstp_led *leds, u16 nleds, u32 pin)
+{
+ for (u16 i = 0; i < nleds; i++) {
+ if (leds[i].pin == pin)
+ return &leds[i];
+ }
+ return NULL;
+}
+
+/*
+ * Register the LEDs described under the channel's "leds" node, then every other
+ * LED pin under its firmware pin name. A node that does not describe a
+ * firmware-reported LED pin, or that names no LED, is ignored.
+ */
+static int lstp_leds_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_leds *pins = container_of(auxdev, struct lstp_leds, auxdev);
+ struct lstp_channel *ch = pins->ch;
+ struct device *dev = &auxdev->dev;
+ struct fwnode_handle *node;
+ struct fwnode_handle *child;
+ struct lstp_led *leds;
+
+ leds = devm_kcalloc(dev, pins->npins, sizeof(*leds), GFP_KERNEL);
+ if (!leds)
+ return -ENOMEM;
+
+ for (u16 i = 0; i < pins->npins; i++) {
+ leds[i].ch = ch;
+ leds[i].pin = pins->pins[i].pin;
+ leds[i].cdev.name = pins->pins[i].name;
+ leds[i].cdev.max_brightness = U8_MAX;
+ leds[i].cdev.flags = LED_HW_PLUGGABLE;
+ leds[i].cdev.brightness_set_blocking = lstp_led_brightness_set_blocking;
+ leds[i].cdev.blink_set = lstp_led_blink_set;
+ leds[i].cdev.pattern_set = lstp_led_pattern_set;
+ leds[i].cdev.pattern_clear = lstp_led_pattern_clear;
+ }
+
+ node = fwnode_get_named_child_node(ch->fwnode, "leds");
+ /*
+ * Not the available-child iterator; see Documentation/driver-api/usb/lstp.rst.
+ * On OF, fwnode_for_each_child_node() already skips disabled nodes.
+ */
+ fwnode_for_each_child_node(node, child) {
+ struct lstp_led *led = NULL;
+ u32 pin;
+
+ if (!fwnode_property_read_u32(child, "reg", &pin))
+ led = lstp_led_by_pin(leds, pins->npins, pin);
+ if (!led) {
+ dev_warn(dev, "%s: ch_%d: Ignoring %pfw: not an LED pin\n", __func__,
+ ch->ch_id, child);
+ continue;
+ }
+ if (led->cdev.dev) {
+ dev_warn(dev, "%s: ch_%d: Ignoring %pfw: pin %u is already described\n",
+ __func__, ch->ch_id, child, pin);
+ continue;
+ }
+ if (!fwnode_property_present(child, "label") &&
+ !fwnode_property_present(child, "function")) {
+ dev_warn(dev, "%s: ch_%d: Ignoring %pfw: neither label nor function\n",
+ __func__, ch->ch_id, child);
+ continue;
+ }
+ lstp_led_register(dev, led, child);
+ }
+ fwnode_handle_put(node);
+
+ for (u16 i = 0; i < pins->npins; i++) {
+ if (!leds[i].cdev.dev)
+ lstp_led_register(dev, &leds[i], NULL);
+ }
+
+ return 0;
+}
+
+static const struct auxiliary_device_id lstp_leds_id_table[] = { { .name = "lstp.led" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_leds_id_table);
+
+static struct auxiliary_driver lstp_leds_drv = {
+ .name = "led",
+ .probe = lstp_leds_probe,
+ .id_table = lstp_leds_id_table,
+};
+module_auxiliary_driver(lstp_leds_drv);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP LED driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 08/11] i2c: Add NVIDIA LSTP I2C driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (6 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 07/11] leds: Add NVIDIA LSTP LED driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 09/11] spi: Add NVIDIA LSTP SPI driver Adrian Ambrozewicz
` (2 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Andi Shyti
Cc: Donald Shannon, linux-kernel, linux-i2c, linux-usb, Greg Kroah-Hartman
Add a driver for the I2C controller channels of NVIDIA LSTP USB
adapters. Each channel is registered as an I2C adapter; devices behind
it can be described by device tree or ACPI, or instantiated from
userspace. The device sets the bus speed. A transfer that fails on
arbitration loss or a busy bus is re-issued up to nvidia,retries times
(default 3), unless the device reports that it retries itself.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/i2c/busses/Kconfig | 13 +
drivers/i2c/busses/Makefile | 1 +
drivers/i2c/busses/i2c-lstp.c | 573 ++++++++++++++++++++++++++++++++++
4 files changed, 588 insertions(+)
create mode 100644 drivers/i2c/busses/i2c-lstp.c
diff --git a/MAINTAINERS b/MAINTAINERS
index c8ed59cd4b11..082c4b3a0eb6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19578,6 +19578,7 @@ F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
F: Documentation/driver-api/usb/lstp.rst
F: Documentation/firmware-guide/acpi/lstp.rst
F: drivers/gpio/gpio-lstp.c
+F: drivers/i2c/busses/i2c-lstp.c
F: drivers/leds/leds-lstp.c
F: drivers/usb/misc/lstp.c
F: include/linux/usb/lstp.h
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index d7b89508311f..9e3b21f18159 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1387,6 +1387,19 @@ config I2C_USBIO
This driver can also be built as a module. If so, the module
will be called i2c_usbio.
+config I2C_LSTP
+ tristate "NVIDIA LSTP I2C support"
+ depends on USB_LSTP
+ default USB_LSTP
+ help
+ Say Y or M here to support the I2C channels of NVIDIA LSTP USB
+ adapters. Each channel is registered as an I2C adapter, and the
+ devices behind it can be described by device tree, ACPI or
+ instantiated from userspace.
+
+ This driver can also be built as a module. If so, the module
+ will be called i2c-lstp.
+
config I2C_CP2615
tristate "Silicon Labs CP2615 USB sound card and I2C adapter"
depends on USB
diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile
index 3755c54b3d82..5970b0bb1926 100644
--- a/drivers/i2c/busses/Makefile
+++ b/drivers/i2c/busses/Makefile
@@ -138,6 +138,7 @@ obj-$(CONFIG_I2C_DLN2) += i2c-dln2.o
obj-$(CONFIG_I2C_LJCA) += i2c-ljca.o
obj-$(CONFIG_I2C_NCT6694) += i2c-nct6694.o
obj-$(CONFIG_I2C_USBIO) += i2c-usbio.o
+obj-$(CONFIG_I2C_LSTP) += i2c-lstp.o
obj-$(CONFIG_I2C_CP2615) += i2c-cp2615.o
obj-$(CONFIG_I2C_PARPORT) += i2c-parport.o
obj-$(CONFIG_I2C_PCI1XXXX) += i2c-mchp-pci1xxxx.o
diff --git a/drivers/i2c/busses/i2c-lstp.c b/drivers/i2c/busses/i2c-lstp.c
new file mode 100644
index 000000000000..f1af36a709dd
--- /dev/null
+++ b/drivers/i2c/busses/i2c-lstp.c
@@ -0,0 +1,573 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * I2C driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/bits.h>
+#include <linux/build_bug.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/overflow.h>
+#include <linux/property.h>
+#include <linux/string.h>
+#include <linux/uio.h>
+
+#include <linux/usb/lstp.h>
+
+enum lstp_i2c_cmd {
+ LSTP_I2C_CMD_BUS_RECOVERY = 0x00,
+ LSTP_I2C_CMD_READ = 0x01,
+ LSTP_I2C_CMD_WRITE = 0x02,
+ LSTP_I2C_CMD_WRITE_READ = 0x04,
+ LSTP_I2C_CMD_SMBUS_BLOCK_READ = 0x05
+} __packed;
+
+enum lstp_i2c_cmd_flags { LSTP_I2C_CMD_FLAG_NO_STOP = 0x40 };
+
+enum lstp_i2c_smbus_block_read_flags {
+ LSTP_I2C_SMBUS_BLOCK_READ_FLAG_PEC = BIT(0),
+} __packed;
+
+struct lstp_i2c_read_req {
+ u8 addr;
+ __le16 rd_len;
+} __packed;
+
+struct lstp_i2c_write_req {
+ u8 addr;
+ u8 wr_data[];
+} __packed;
+
+struct lstp_i2c_wr_rd_req {
+ u8 addr;
+ __le16 rd_len;
+ u8 wr_data[]; /* Write length inferred from length in header */
+} __packed;
+
+struct lstp_i2c_smbus_block_read_req {
+ u8 addr;
+ __le16 flags; /* lstp_i2c_smbus_block_read_flags */
+ u8 wr_data[]; /* Write length inferred from length in header */
+} __packed;
+
+/* Largest block-read write phase: SMBus command byte, block count, maximum-size block. */
+#define LSTP_I2C_SMBUS_BLOCK_READ_WR_MAX (2 + I2C_SMBUS_BLOCK_MAX)
+
+enum lstp_i2c_speed {
+ LSTP_I2C_SPEED_100KHZ = 0x00,
+ LSTP_I2C_SPEED_400KHZ = 0x01,
+ LSTP_I2C_SPEED_1000KHZ = 0x02,
+ LSTP_I2C_SPEED_3400KHZ = 0x03,
+};
+
+struct lstp_i2c_config {
+ u8 speed;
+ __le16 output_drive_strength; /* in mA */
+ __le16 slew_rate; /* in 100 ps (0.1 ns) increments */
+ __le16 input_debounce_time; /* in us */
+ __le16 glitch_filter_width; /* in ns */
+ u8 bus_low_timeout; /* in ms */
+ u8 bus_arbitration_retries;
+} __packed;
+
+/* Wire offsets: inserting or resizing a field silently shifts every field after it. */
+static_assert(sizeof(struct lstp_i2c_config) == 11,
+ "I2C channel config must match the LSTP specification");
+
+/* Shortest blob the channel accepts; every field after speed is optional. */
+#define LSTP_I2C_CONFIG_MIN_LEN offsetofend(struct lstp_i2c_config, speed)
+
+static bool lstp_i2c_can_retry(int lstp_status)
+{
+ return lstp_status == LSTP_BUSY || lstp_status == LSTP_ARB_LOST;
+}
+
+static bool lstp_i2c_suppress_error_logs(int ret, int lstp_status)
+{
+ return ret == -ENODEV || lstp_status == LSTP_NACK || lstp_i2c_can_retry(lstp_status);
+}
+
+/* i2c_bus_recovery_info.recover_bus: ask the device to run its own bus recovery. */
+static int lstp_i2c_bus_recovery(struct i2c_adapter *adap)
+{
+ struct lstp_channel *ch = adap->algo_data;
+ int lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ int ret = lstp_request(ch, LSTP_I2C_CMD_BUS_RECOVERY, NULL, 0, NULL, 0, NULL, &lstp_status);
+
+ if (ret && !lstp_i2c_suppress_error_logs(ret, lstp_status))
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Bus recovery failed (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(ret));
+ if (ret && lstp_i2c_can_retry(lstp_status))
+ return -EAGAIN;
+ return ret;
+}
+
+static int lstp_i2c_validate_msg(struct i2c_msg *msg)
+{
+ if (!msg->buf && msg->len > 0)
+ return -EINVAL;
+
+ if (msg->flags & I2C_M_TEN)
+ return -EAFNOSUPPORT; /* 10-bit address not supported */
+
+ if (msg->addr > 0x7F)
+ return -EINVAL; /* Only 7-bit address supported */
+
+ if ((msg->flags & I2C_M_RECV_LEN) && (!(msg->flags & I2C_M_RD) || msg->len < 1))
+ return -EINVAL;
+
+ return 0;
+}
+
+/* One READ transaction; @no_stop omits STOP so a further message can follow. */
+static int lstp_i2c_read(struct i2c_adapter *adap, struct i2c_msg *msg, bool no_stop)
+{
+ u8 cmd = LSTP_I2C_CMD_READ;
+ struct lstp_channel *ch = adap->algo_data;
+ struct lstp_i2c_read_req req = {
+ .addr = msg->addr,
+ .rd_len = cpu_to_le16(msg->len),
+ };
+ int lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ int ret = lstp_i2c_validate_msg(msg);
+
+ if (ret) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Invalid message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ if (msg->len > ch->max_rx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Read request message to addr=0x%02x too long (%u bytes, max %zu)\n",
+ __func__, ch->ch_id, msg->addr, msg->len, ch->max_rx_payload);
+ return -EINVAL;
+ }
+
+ dev_dbg(ch->dev, "%s: ch_%d: addr=0x%02x, len=%d\n", __func__, ch->ch_id, msg->addr,
+ msg->len);
+
+ if (no_stop)
+ cmd |= LSTP_I2C_CMD_FLAG_NO_STOP;
+
+ ret = lstp_request(ch, cmd, &req, sizeof(req), msg->buf, msg->len, NULL, &lstp_status);
+ if (ret && !lstp_i2c_suppress_error_logs(ret, lstp_status))
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: READ to addr=0x%02x failed (%pe)\n",
+ __func__, ch->ch_id, msg->addr, ERR_PTR(ret));
+ if (ret && lstp_i2c_can_retry(lstp_status))
+ return -EAGAIN;
+ return ret;
+}
+
+/* One WRITE transaction; @no_stop omits STOP so a further message can follow. */
+static int lstp_i2c_write(struct i2c_adapter *adap, struct i2c_msg *msg, bool no_stop)
+{
+ u8 cmd = LSTP_I2C_CMD_WRITE;
+ struct lstp_channel *ch = adap->algo_data;
+ struct lstp_i2c_write_req req_head = { .addr = msg->addr };
+ struct kvec vecs[2] = {
+ { .iov_base = &req_head, .iov_len = sizeof(req_head) },
+ { .iov_base = msg->buf, .iov_len = msg->len },
+ };
+ int lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ int ret = lstp_i2c_validate_msg(msg);
+
+ if (ret) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Invalid message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ if (sizeof(req_head) + msg->len > ch->max_tx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Write message to addr=0x%02x too long (%u bytes, max %zu)\n",
+ __func__, ch->ch_id, msg->addr, msg->len,
+ ch->max_tx_payload - sizeof(req_head));
+ return -EINVAL;
+ }
+
+ if (msg->len > 0)
+ dev_dbg(ch->dev, "%s: ch_%d: addr=0x%02x, len=%d, data=0x%*ph\n", __func__,
+ ch->ch_id, msg->addr, msg->len, msg->len, msg->buf);
+ else
+ dev_dbg(ch->dev, "%s: ch_%d: addr=0x%02x, len=%d\n", __func__, ch->ch_id, msg->addr,
+ msg->len);
+
+ if (no_stop)
+ cmd |= LSTP_I2C_CMD_FLAG_NO_STOP;
+
+ ret = lstp_requestv(ch, cmd, vecs, ARRAY_SIZE(vecs), NULL, 0, NULL, &lstp_status);
+ if (ret && !lstp_i2c_suppress_error_logs(ret, lstp_status))
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: WRITE to addr=0x%02x failed (%pe)\n",
+ __func__, ch->ch_id, msg->addr, ERR_PTR(ret));
+ if (ret && lstp_i2c_can_retry(lstp_status))
+ return -EAGAIN;
+ return ret;
+}
+
+/* Write then read at one address, separated by a repeated START, as a single request. */
+static int lstp_i2c_write_read(struct i2c_adapter *adap, struct i2c_msg *wr_msg,
+ struct i2c_msg *rd_msg, bool no_stop)
+{
+ u8 cmd = LSTP_I2C_CMD_WRITE_READ;
+ struct lstp_channel *ch = adap->algo_data;
+ struct lstp_i2c_wr_rd_req req_head = {
+ .addr = wr_msg->addr,
+ .rd_len = cpu_to_le16(rd_msg->len),
+ };
+ struct kvec vecs[2] = {
+ { .iov_base = &req_head, .iov_len = sizeof(req_head) },
+ { .iov_base = wr_msg->buf, .iov_len = wr_msg->len },
+ };
+ int lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ int ret = lstp_i2c_validate_msg(wr_msg);
+
+ if (ret) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Invalid write message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, wr_msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ if (sizeof(req_head) + wr_msg->len > ch->max_tx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Write message to addr=0x%02x too long (%u bytes, max %zu)\n",
+ __func__, ch->ch_id, wr_msg->addr, wr_msg->len,
+ ch->max_tx_payload - sizeof(req_head));
+ return -EINVAL;
+ }
+
+ ret = lstp_i2c_validate_msg(rd_msg);
+ if (ret) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Invalid read message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, rd_msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ if (rd_msg->len > ch->max_rx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Read message to addr=0x%02x too long (%u bytes, max %zu)\n",
+ __func__, ch->ch_id, rd_msg->addr, rd_msg->len,
+ ch->max_rx_payload);
+ return -EINVAL;
+ }
+
+ if (wr_msg->addr != rd_msg->addr) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Write/read addr mismatch (wr=0x%02x, rd=0x%02x)\n",
+ __func__, ch->ch_id, wr_msg->addr, rd_msg->addr);
+ return -EINVAL;
+ }
+
+ if (no_stop)
+ cmd |= LSTP_I2C_CMD_FLAG_NO_STOP;
+
+ ret = lstp_requestv(ch, cmd, vecs, ARRAY_SIZE(vecs), rd_msg->buf, rd_msg->len, NULL,
+ &lstp_status);
+ if (ret && !lstp_i2c_suppress_error_logs(ret, lstp_status))
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: WRITE_READ to addr=0x%02x failed (%pe)\n",
+ __func__, ch->ch_id, wr_msg->addr, ERR_PTR(ret));
+ if (ret && lstp_i2c_can_retry(lstp_status))
+ return -EAGAIN;
+ return ret;
+}
+
+/*
+ * SMBus block read with an optional write phase, which must address the same target.
+ * @rd_msg->len is updated to the bytes received.
+ */
+static int lstp_i2c_smbus_block_read(struct i2c_adapter *adap, struct i2c_msg *wr_msg,
+ struct i2c_msg *rd_msg, bool no_stop)
+{
+ u8 cmd = LSTP_I2C_CMD_SMBUS_BLOCK_READ;
+ struct lstp_channel *ch = adap->algo_data;
+ DEFINE_RAW_FLEX(struct lstp_i2c_smbus_block_read_req, req, wr_data,
+ LSTP_I2C_SMBUS_BLOCK_READ_WR_MAX);
+ u16 wr_len = wr_msg ? wr_msg->len : 0;
+ u8 *wr_buf = wr_msg ? wr_msg->buf : NULL;
+ bool pec = rd_msg->flags & I2C_CLIENT_PEC;
+ /* The target frames the block with a count byte, plus a trailing PEC byte if asked for. */
+ u8 framing = pec ? 2 : 1;
+ u16 rx_buf_len = I2C_SMBUS_BLOCK_MAX + framing;
+ size_t pkt_len = 0;
+ int lstp_status = LSTP_NO_RESPONSE_STATUS;
+
+ /* Probe enforces bulk_tx_size >= LSTP_USB_EP_MIN_SIZE; anchor the largest write phase. */
+ BUILD_BUG_ON(sizeof(struct lstp_header) +
+ struct_size(req, wr_data, LSTP_I2C_SMBUS_BLOCK_READ_WR_MAX) >
+ LSTP_USB_EP_MIN_SIZE);
+
+ int ret = lstp_i2c_validate_msg(rd_msg);
+
+ if (ret) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Invalid read message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, rd_msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ /*
+ * An I2C_M_RECV_LEN read reserves rd_msg->len bytes on top of I2C_SMBUS_BLOCK_MAX, so the
+ * framing has to fit in there for a maximum-size block to still land inside the buffer.
+ */
+ if (rd_msg->len < framing) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Read from addr=0x%02x reserves %u bytes, needs %u for framing\n",
+ __func__, ch->ch_id, rd_msg->addr, rd_msg->len, framing);
+ return -EINVAL;
+ }
+
+ if (wr_msg) {
+ ret = lstp_i2c_validate_msg(wr_msg);
+ if (ret) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Invalid write message to addr=0x%02x (%pe)\n",
+ __func__, ch->ch_id, wr_msg->addr, ERR_PTR(ret));
+ return ret;
+ }
+
+ if (wr_msg->addr != rd_msg->addr) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Write/read addr mismatch (wr=0x%02x, rd=0x%02x)\n",
+ __func__, ch->ch_id, wr_msg->addr, rd_msg->addr);
+ return -EINVAL;
+ }
+ }
+
+ if (wr_len > LSTP_I2C_SMBUS_BLOCK_READ_WR_MAX) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: SMBus write phase to addr=0x%02x too long (%u bytes, max %u)\n",
+ __func__, ch->ch_id, rd_msg->addr, wr_len,
+ LSTP_I2C_SMBUS_BLOCK_READ_WR_MAX);
+ return -EINVAL;
+ }
+
+ if (rx_buf_len > ch->max_rx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: Read message to addr=0x%02x too long (%u bytes, max %zu)\n",
+ __func__, ch->ch_id, rd_msg->addr, rx_buf_len,
+ ch->max_rx_payload);
+ return -EINVAL;
+ }
+
+ *req = (struct lstp_i2c_smbus_block_read_req){
+ .addr = rd_msg->addr,
+ .flags = cpu_to_le16(pec ? LSTP_I2C_SMBUS_BLOCK_READ_FLAG_PEC : 0),
+ };
+ if (wr_len)
+ memcpy(req->wr_data, wr_buf, wr_len);
+
+ if (no_stop)
+ cmd |= LSTP_I2C_CMD_FLAG_NO_STOP;
+
+ ret = lstp_request(ch, cmd, req, struct_size(req, wr_data, wr_len), rd_msg->buf, rx_buf_len,
+ &pkt_len, &lstp_status);
+ if (ret) {
+ if (!lstp_i2c_suppress_error_logs(ret, lstp_status))
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: SMBUS_BLOCK_READ to addr=0x%02x failed (%pe)\n",
+ __func__, ch->ch_id, rd_msg->addr, ERR_PTR(ret));
+ if (lstp_i2c_can_retry(lstp_status))
+ return -EAGAIN;
+ return ret;
+ }
+
+ if (pkt_len == 0) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Empty response packet\n", __func__,
+ ch->ch_id);
+ return -EIO;
+ }
+
+ u8 block_len = rd_msg->buf[0];
+
+ if (block_len > I2C_SMBUS_BLOCK_MAX) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Invalid block length %u\n", __func__,
+ ch->ch_id, block_len);
+ return -EPROTO;
+ }
+
+ u16 rx_len = block_len + framing;
+
+ if (pkt_len < rx_len) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Invalid response length (%zu)\n", __func__,
+ ch->ch_id, pkt_len);
+ return -EIO;
+ }
+
+ rd_msg->len = rx_len;
+ return 0;
+}
+
+static bool lstp_i2c_is_combined_pair(const struct i2c_msg *wr_msg, const struct i2c_msg *rd_msg)
+{
+ return !(wr_msg->flags & I2C_M_RD) && (rd_msg->flags & I2C_M_RD) &&
+ wr_msg->addr == rd_msg->addr;
+}
+
+/*
+ * i2c_algorithm.xfer: one device request per message, except a write/read pair to the same
+ * target, which folds into one combined request. Every request but the last omits STOP, so
+ * the whole message array stays a single bus transaction.
+ */
+static int lstp_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
+{
+ struct lstp_channel *ch = adap->algo_data;
+
+ if (!msgs || num <= 0)
+ return -EINVAL;
+
+ dev_dbg(ch->dev, "%s: ch_%d: I2C transfer with %d message(s)\n", __func__, ch->ch_id, num);
+
+ for (int i = 0; i < num; i++) {
+ struct i2c_msg *wr_msg = NULL;
+ struct i2c_msg *msg = &msgs[i];
+
+ if (i + 1 < num && lstp_i2c_is_combined_pair(msg, &msgs[i + 1])) {
+ wr_msg = msg;
+ msg = &msgs[++i];
+ }
+
+ bool recv_len = msg->flags & I2C_M_RECV_LEN;
+ bool read = msg->flags & I2C_M_RD;
+ bool no_stop = i != num - 1;
+ int ret;
+
+ if (!read)
+ ret = lstp_i2c_write(adap, msg, no_stop);
+ else if (read && recv_len)
+ ret = lstp_i2c_smbus_block_read(adap, wr_msg, msg, no_stop);
+ else if (read && !recv_len && wr_msg)
+ ret = lstp_i2c_write_read(adap, wr_msg, msg, no_stop);
+ else
+ ret = lstp_i2c_read(adap, msg, no_stop);
+
+ if (ret)
+ return ret;
+ }
+
+ return num;
+}
+
+static u32 lstp_i2c_functionality(struct i2c_adapter *adap)
+{
+ /* TODO: This needs to be discoverable, also need separate commands for 10-bit address */
+ return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL_ALL;
+}
+
+static struct i2c_bus_recovery_info lstp_i2c_recovery_info = {
+ .recover_bus = lstp_i2c_bus_recovery,
+};
+
+static const struct i2c_algorithm lstp_i2c_algorithm = {
+ .xfer = lstp_i2c_xfer,
+ .functionality = lstp_i2c_functionality,
+};
+
+#define LSTP_I2C_DEFAULT_RETRIES 3
+
+/*
+ * The I2C core re-issues only an -EAGAIN transfer and bounds the whole retry loop, not each
+ * attempt, by adap->timeout, so the timeout spans every attempt. A device reporting
+ * bus_arbitration_retries retries LSTP_BUSY and LSTP_ARB_LOST itself, so the host does not
+ * and ignores "nvidia,retries". @adap's firmware node must already be set.
+ */
+static void lstp_i2c_configure_retry_policy(struct lstp_channel *ch, struct i2c_adapter *adap,
+ const struct lstp_i2c_config *cfg)
+{
+ u32 retries = LSTP_I2C_DEFAULT_RETRIES;
+ u32 configured_retries;
+ bool have_configured;
+
+ have_configured =
+ !device_property_read_u32(&adap->dev, "nvidia,retries", &configured_retries);
+
+ if (cfg->bus_arbitration_retries) {
+ if (have_configured && configured_retries)
+ dev_warn(ch->dev,
+ "%s: ch_%d: Ignoring retries=%u; device retries the bus %u time(s) itself\n",
+ __func__, ch->ch_id, configured_retries,
+ cfg->bus_arbitration_retries);
+ retries = 0;
+ } else if (have_configured) {
+ if (configured_retries <= U8_MAX)
+ retries = configured_retries;
+ else
+ dev_warn(ch->dev, "%s: ch_%d: Ignoring retries value %u; maximum is %u\n",
+ __func__, ch->ch_id, configured_retries, U8_MAX);
+ }
+
+ adap->retries = retries;
+ adap->timeout = msecs_to_jiffies((retries + 1) * LSTP_USB_RESPONSE_TIMEOUT_MS);
+}
+
+/* The I2C core takes the bus number from an "i2c" alias on adap->dev's firmware node. */
+static int lstp_i2c_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
+
+ if (!info)
+ return -ENODEV;
+
+ if (info->config_len < LSTP_I2C_CONFIG_MIN_LEN) {
+ dev_err(ch->dev, "%s: ch_%d: I2C config too short: %zu < %zu\n", __func__,
+ ch->ch_id, info->config_len, LSTP_I2C_CONFIG_MIN_LEN);
+ return -EINVAL;
+ }
+
+ /* Full-size copy, so field reads need no length checks: unreported fields read as zero. */
+ struct lstp_i2c_config cfg;
+
+ memcpy_and_pad(&cfg, sizeof(cfg), info->config, info->config_len, 0);
+
+ struct i2c_adapter *adap = devm_kzalloc(ch->dev, sizeof(*adap), GFP_KERNEL);
+
+ if (!adap)
+ return -ENOMEM;
+
+ adap->owner = THIS_MODULE;
+ adap->class = I2C_CLASS_HWMON;
+ adap->algo = &lstp_i2c_algorithm;
+ adap->algo_data = ch;
+ adap->dev.parent = ch->dev;
+ adap->bus_recovery_info = &lstp_i2c_recovery_info;
+ device_set_node(&adap->dev, ch->fwnode);
+ lstp_i2c_configure_retry_policy(ch, adap, &cfg);
+ strscpy(adap->name, ch->display_name, sizeof(adap->name));
+ /* TODO: save i2c speed from config */
+
+ int ret = devm_i2c_add_adapter(ch->dev, adap);
+
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: Could not register I2C adapter (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(ret));
+ return ret;
+ }
+
+ dev_info(ch->dev, "%s: ch_%d: Started as %s\n", __func__, ch->ch_id, adap->name);
+ return 0;
+}
+
+static const struct auxiliary_device_id lstp_i2c_id_table[] = { { .name = "lstp.i2c" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_i2c_id_table);
+
+static struct lstp_auxiliary_driver lstp_i2c_drv = {
+ .adrv = {
+ .name = "i2c",
+ .probe = lstp_i2c_probe,
+ .id_table = lstp_i2c_id_table,
+ },
+};
+module_lstp_auxiliary_driver(lstp_i2c_drv);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP I2C driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 09/11] spi: Add NVIDIA LSTP SPI driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (7 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 08/11] i2c: Add NVIDIA LSTP I2C driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 10/11] tty: Add NVIDIA LSTP UART driver Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver Adrian Ambrozewicz
10 siblings, 0 replies; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Mark Brown
Cc: Donald Shannon, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-kernel, linux-spi, linux-usb,
llvm, Greg Kroah-Hartman
Add a driver for the SPI controller channels of NVIDIA LSTP USB
adapters. Each channel is registered as an SPI host controller; devices
behind it can be described by device tree or ACPI, or created from
userspace through the controller's new_device attribute. The firmware
reports the chip selects and the bus speed.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/spi/Kconfig | 13 ++
drivers/spi/Makefile | 1 +
drivers/spi/spi-lstp.c | 316 +++++++++++++++++++++++++++++++++++++++++
4 files changed, 331 insertions(+)
create mode 100644 drivers/spi/spi-lstp.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 082c4b3a0eb6..081e3f32c840 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19580,6 +19580,7 @@ F: Documentation/firmware-guide/acpi/lstp.rst
F: drivers/gpio/gpio-lstp.c
F: drivers/i2c/busses/i2c-lstp.c
F: drivers/leds/leds-lstp.c
+F: drivers/spi/spi-lstp.c
F: drivers/usb/misc/lstp.c
F: include/linux/usb/lstp.h
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index a0f37e2df716..e76abaac825c 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -694,6 +694,19 @@ config SPI_LJCA
This driver can also be built as a module. If so, the module
will be called spi-ljca.
+config SPI_LSTP
+ tristate "NVIDIA LSTP SPI support"
+ depends on USB_LSTP
+ default USB_LSTP
+ help
+ Say Y or M here to support the SPI channels of NVIDIA LSTP USB
+ adapters. Each channel is registered as an SPI host controller,
+ and the devices behind it can be described by device tree, ACPI
+ or created through spidev.
+
+ This driver can also be built as a module. If so, the module
+ will be called spi-lstp.
+
config SPI_MA35D1_QSPI
tristate "Nuvoton MA35D1 QSPI controller"
depends on ARCH_MA35 || COMPILE_TEST
diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
index a18814fbde93..c0b1ea6491dd 100644
--- a/drivers/spi/Makefile
+++ b/drivers/spi/Makefile
@@ -86,6 +86,7 @@ obj-$(CONFIG_SPI_LOONGSON_CORE) += spi-loongson-core.o
obj-$(CONFIG_SPI_LOONGSON_PCI) += spi-loongson-pci.o
obj-$(CONFIG_SPI_LOONGSON_PLATFORM) += spi-loongson-plat.o
obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o
+obj-$(CONFIG_SPI_LSTP) += spi-lstp.o
obj-$(CONFIG_SPI_MA35D1_QSPI) += spi-ma35d1-qspi.o
obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o
obj-$(CONFIG_SPI_MESON_SPIFC) += spi-meson-spifc.o
diff --git a/drivers/spi/spi-lstp.c b/drivers/spi/spi-lstp.c
new file mode 100644
index 000000000000..7aa908e6c398
--- /dev/null
+++ b/drivers/spi/spi-lstp.c
@@ -0,0 +1,316 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * SPI driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/spi/spi.h>
+#include <linux/acpi.h>
+#include <linux/err.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/property.h>
+
+#include <linux/usb/lstp.h>
+
+enum lstp_spi_cmd {
+ LSTP_SPI_CMD_READ = 0x01,
+ LSTP_SPI_CMD_WRITE = 0x02,
+ LSTP_SPI_CMD_WRITE_READ = 0x03,
+ LSTP_SPI_CMD_POSTED_WRITE = 0x04
+};
+
+/* clang-format off */
+enum lstp_spi_cmd_cs_toggle {
+ LSTP_SPI_CMD_CS_ASSERT = 0x20,
+ LSTP_SPI_CMD_CS_DEASSERT = 0x10
+};
+
+enum lstp_spi_cmd_cs_sel {
+ LSTP_SPI_CMD_CS0 = 0x00,
+ LSTP_SPI_CMD_CS1 = 0x40
+};
+
+static const u8 lstp_spi_cs_map[] = {
+ LSTP_SPI_CMD_CS0,
+ LSTP_SPI_CMD_CS1
+}; /* clang-format on */
+
+struct lstp_spi_read_req {
+ __le32 len;
+} __packed;
+
+struct lstp_spi_config {
+ u8 num_devices;
+ __le32 speed_hz;
+} __packed;
+
+struct lstp_spi_priv {
+ struct spi_controller *ctrl;
+ u32 current_speed_hz;
+};
+
+/* A transfer without data still sends a zero-length WRITE when @cs_flags moves CS. */
+static int lstp_spi_do_transfer(struct lstp_channel *ch, struct spi_transfer *xfer, u8 cs_bits,
+ u8 cs_flags)
+{
+ struct lstp_spi_priv *priv = ch->priv;
+
+ if (xfer->word_delay.value)
+ dev_warn_once(ch->dev, "%s: ch_%d: word_delay not supported, ignoring\n", __func__,
+ ch->ch_id);
+
+ xfer->error = SPI_TRANS_FAIL_NO_START;
+ xfer->effective_speed_hz = priv->current_speed_hz;
+
+ if (xfer->len && !xfer->tx_buf && !xfer->rx_buf) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Transfer of %u bytes has no buffer\n",
+ __func__, ch->ch_id, xfer->len);
+ return -EINVAL;
+ }
+ if (xfer->tx_buf && xfer->len > ch->max_tx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: TX transfer length %u exceeds capacity %zu\n",
+ __func__, ch->ch_id, xfer->len, ch->max_tx_payload);
+ return -EINVAL;
+ }
+ if (xfer->rx_buf && xfer->len > ch->max_rx_payload) {
+ dev_err_ratelimited(ch->dev,
+ "%s: ch_%d: RX transfer length %u exceeds capacity %zu\n",
+ __func__, ch->ch_id, xfer->len, ch->max_rx_payload);
+ return -EINVAL;
+ }
+
+ int ret;
+
+ if (xfer->tx_buf && xfer->rx_buf) {
+ u8 cmd = LSTP_SPI_CMD_WRITE_READ | cs_bits | cs_flags;
+
+ ret = lstp_request(ch, cmd, xfer->tx_buf, xfer->len, xfer->rx_buf, xfer->len, NULL,
+ NULL);
+ } else if (xfer->tx_buf) {
+ u8 cmd = LSTP_SPI_CMD_WRITE | cs_bits | cs_flags;
+
+ ret = lstp_request(ch, cmd, xfer->tx_buf, xfer->len, NULL, 0, NULL, NULL);
+ } else if (xfer->rx_buf) {
+ struct lstp_spi_read_req req = { .len = cpu_to_le32(xfer->len) };
+ u8 cmd = LSTP_SPI_CMD_READ | cs_bits | cs_flags;
+
+ ret = lstp_request(ch, cmd, &req, sizeof(req), xfer->rx_buf, xfer->len, NULL, NULL);
+ } else if (cs_flags) {
+ u8 cmd = LSTP_SPI_CMD_WRITE | cs_bits | cs_flags;
+
+ ret = lstp_request(ch, cmd, NULL, 0, NULL, 0, NULL, NULL);
+ } else {
+ /* No data and no CS change; only the caller's delay is left to do. */
+ ret = 0;
+ }
+
+ if (ret) {
+ if (ret != -ENODEV)
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Transfer failed (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(ret));
+ xfer->error = SPI_TRANS_FAIL_IO;
+ return ret;
+ }
+
+ xfer->error = 0;
+ return 0;
+}
+
+/*
+ * CS edges ride in each transfer's command byte rather than in a set_cs callback, which would
+ * cost a USB round trip per edge.
+ */
+static int lstp_spi_transfer_one_message(struct spi_controller *ctrl, struct spi_message *mesg)
+{
+ struct lstp_channel *ch = spi_controller_get_devdata(ctrl);
+ struct spi_transfer *xfer;
+ u8 chip_select = spi_get_chipselect(mesg->spi, 0);
+ int ret = 0;
+ bool cs_active = false;
+
+ if (chip_select >= ctrl->num_chipselect) {
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Invalid chip select %u (max %u)\n",
+ __func__, ch->ch_id, chip_select, ctrl->num_chipselect - 1);
+ ret = -EINVAL;
+ goto finalize;
+ }
+
+ u8 cs_bits = lstp_spi_cs_map[chip_select];
+
+ list_for_each_entry(xfer, &mesg->transfers, transfer_list) {
+ u8 cs_flags = 0;
+ bool is_last = list_is_last(&xfer->transfer_list, &mesg->transfers);
+ bool no_data = !xfer->tx_buf && !xfer->rx_buf;
+
+ if (!cs_active) {
+ cs_flags |= LSTP_SPI_CMD_CS_ASSERT;
+ cs_active = true;
+ }
+
+ if ((is_last && !xfer->cs_change) || (!is_last && xfer->cs_change)) {
+ cs_flags |= LSTP_SPI_CMD_CS_DEASSERT;
+ cs_active = false;
+ }
+
+ /* A data transfer fuses delay and CS edge into one command; CS-only waits first. */
+ if (no_data)
+ spi_transfer_delay_exec(xfer);
+
+ ret = lstp_spi_do_transfer(ch, xfer, cs_bits, cs_flags);
+ if (ret)
+ break;
+
+ mesg->actual_length += xfer->len;
+
+ if (!is_last && xfer->cs_change)
+ spi_transfer_cs_change_delay_exec(mesg, xfer);
+
+ if (!no_data)
+ spi_transfer_delay_exec(xfer);
+ }
+
+finalize:
+ mesg->status = ret;
+ spi_finalize_current_message(ctrl);
+ return ret;
+}
+
+/* spi_setup() path: firmware owns CS, so cs_setup/cs_hold/cs_inactive are only warned about. */
+static int lstp_spi_set_cs_timing(struct spi_device *spi)
+{
+ struct lstp_channel *ch = spi_controller_get_devdata(spi->controller);
+
+ if (spi->cs_setup.value || spi->cs_hold.value || spi->cs_inactive.value)
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: CS timing delays not supported, ignoring\n",
+ __func__, ch->ch_id);
+ return 0;
+}
+
+static size_t lstp_spi_max_xfer_size(struct spi_device *spi)
+{
+ struct lstp_channel *ch = spi_controller_get_devdata(spi->controller);
+
+ return min(ch->max_tx_payload, ch->max_rx_payload);
+}
+
+/*
+ * Device tree lists peripherals as children of the channel node, so an empty node is an
+ * incomplete description. ACPI resolves SpiSerialBus() resources from anywhere in the namespace,
+ * and the SPI core enumerates nothing from a software node.
+ */
+static void lstp_spi_enumerate(struct lstp_channel *ch, struct spi_controller *ctrl)
+{
+ if (is_of_node(ch->fwnode)) {
+ unsigned int child_count = 0;
+ struct fwnode_handle *child;
+
+ fwnode_for_each_available_child_node(ch->fwnode, child)
+ child_count++;
+
+ if (child_count == 0) {
+ dev_warn(ch->dev,
+ "%s: ch_%d: Firmware node present but defines no SPI devices\n",
+ __func__, ch->ch_id);
+ } else {
+ dev_info(ch->dev, "%s: ch_%d: Firmware node present with %u SPI devices\n",
+ __func__, ch->ch_id, child_count);
+ }
+ } else if (is_acpi_node(ch->fwnode)) {
+ dev_info(ch->dev,
+ "%s: ch_%d: ACPI describes this channel; its peripherals resolve from the namespace\n",
+ __func__, ch->ch_id);
+ } else if (ch->fwnode) {
+ dev_warn(ch->dev,
+ "%s: ch_%d: Software node describes this channel, so no SPI devices are enumerated for it\n",
+ __func__, ch->ch_id);
+ }
+}
+
+static int lstp_spi_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
+
+ if (!info)
+ return -ENODEV;
+
+ if (info->config_len < sizeof(struct lstp_spi_config)) {
+ dev_err(ch->dev, "%s: ch_%d: SPI config too short: %zu < %zu\n", __func__,
+ ch->ch_id, info->config_len, sizeof(struct lstp_spi_config));
+ return -EINVAL;
+ }
+
+ const struct lstp_spi_config *config = info->config;
+ struct lstp_spi_priv *priv = devm_kzalloc(ch->dev, sizeof(*priv), GFP_KERNEL);
+
+ if (!priv)
+ return -ENOMEM;
+
+ struct spi_controller *ctrl = devm_spi_alloc_host(ch->dev, 0);
+
+ if (!ctrl)
+ return -ENOMEM;
+
+ u8 num_devices = config->num_devices;
+ u32 speed_hz = le32_to_cpu(config->speed_hz);
+
+ if (num_devices == 0 || num_devices > ARRAY_SIZE(lstp_spi_cs_map)) {
+ dev_err(ch->dev, "%s: ch_%d: Invalid num_devices %u (max %zu)\n", __func__,
+ ch->ch_id, num_devices, ARRAY_SIZE(lstp_spi_cs_map));
+ return -EINVAL;
+ }
+
+ if (speed_hz == 0) {
+ dev_err(ch->dev, "%s: ch_%d: Device returned SPI speed of %u Hz\n", __func__,
+ ch->ch_id, speed_hz);
+ return -EINVAL;
+ }
+
+ spi_controller_set_devdata(ctrl, ch);
+ ctrl->bus_num = -1;
+ ctrl->num_chipselect = num_devices;
+ ctrl->transfer_one_message = lstp_spi_transfer_one_message;
+ ctrl->max_transfer_size = lstp_spi_max_xfer_size;
+ ctrl->set_cs_timing = lstp_spi_set_cs_timing;
+
+ device_set_node(&ctrl->dev, ch->fwnode);
+
+ priv->ctrl = ctrl;
+ priv->current_speed_hz = speed_hz;
+ /* Registration probes peripherals, which may transfer at once; transfers read @ch->priv. */
+ ch->priv = priv;
+
+ int ret = devm_spi_register_controller(ch->dev, ctrl);
+
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: Could not register SPI controller (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(ret));
+ return ret;
+ }
+
+ lstp_spi_enumerate(ch, ctrl);
+
+ dev_info(ch->dev, "%s: ch_%d: Started as %s (devices=%u, speed=%u Hz)\n", __func__,
+ ch->ch_id, ch->display_name, ctrl->num_chipselect, priv->current_speed_hz);
+ return 0;
+}
+
+static const struct auxiliary_device_id lstp_spi_id_table[] = { { .name = "lstp.spi" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_spi_id_table);
+
+static struct lstp_auxiliary_driver lstp_spi_drv = {
+ .adrv = {
+ .name = "spi",
+ .probe = lstp_spi_probe,
+ .id_table = lstp_spi_id_table,
+ },
+};
+module_lstp_auxiliary_driver(lstp_spi_drv);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP SPI driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 10/11] tty: Add NVIDIA LSTP UART driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (8 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 09/11] spi: Add NVIDIA LSTP SPI driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-13 5:49 ` Jiri Slaby
2026-10-12 17:36 ` [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver Adrian Ambrozewicz
10 siblings, 1 reply; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Donald Shannon, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-kernel, linux-serial,
linux-usb, llvm, Ilpo Järvinen, Johan Hovold, Oliver Neukum
Add a driver for the UART channels of NVIDIA LSTP USB adapters. Each
channel is registered as a tty device, ttyLSTP<n>, whose parent is the
channel's auxiliary device.
The device firmware owns the line: baud rate, framing, parity and flow
control are provisioned on the device and only read at probe. The host
cannot read or set modem control lines; it can send a fixed-length
break, and a carrier loss reported by the device hangs the tty up unless
CLOCAL is set. Most of serial_core's uart_ops would be stubs, so the
driver registers a plain tty_driver with one tty_port per channel, as
cdc-acm, the greybus UART and sdio_uart do for UARTs reached through
another bus. set_termios keeps the hardware fields at the firmware's
values, so stty reports the real line settings.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/tty/Kconfig | 13 +
drivers/tty/Makefile | 1 +
drivers/tty/lstp_tty.c | 829 +++++++++++++++++++++++++++++++++++++++++
4 files changed, 844 insertions(+)
create mode 100644 drivers/tty/lstp_tty.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 081e3f32c840..8e58895b7d5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19581,6 +19581,7 @@ F: drivers/gpio/gpio-lstp.c
F: drivers/i2c/busses/i2c-lstp.c
F: drivers/leds/leds-lstp.c
F: drivers/spi/spi-lstp.c
+F: drivers/tty/lstp_tty.c
F: drivers/usb/misc/lstp.c
F: include/linux/usb/lstp.h
diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
index 5d6b0dd4d423..34a86259b537 100644
--- a/drivers/tty/Kconfig
+++ b/drivers/tty/Kconfig
@@ -406,6 +406,19 @@ config RPMSG_TTY
To compile this driver as a module, choose M here: the module will be
called rpmsg_tty.
+config LSTP_TTY
+ tristate "NVIDIA LSTP UART support"
+ depends on USB_LSTP
+ default USB_LSTP
+ help
+ Say Y or M here to support the UART channels of NVIDIA LSTP USB
+ adapters. Each channel is registered as a tty device named
+ ttyLSTP<n>, so the usual serial tools and line disciplines work
+ on top of it.
+
+ This driver can also be built as a module. If so, the module
+ will be called lstp_tty.
+
endif # TTY
source "drivers/tty/serdev/Kconfig"
diff --git a/drivers/tty/Makefile b/drivers/tty/Makefile
index c6a063a541fd..c352adda5cfc 100644
--- a/drivers/tty/Makefile
+++ b/drivers/tty/Makefile
@@ -26,3 +26,4 @@ obj-$(CONFIG_GOLDFISH_TTY) += goldfish.o
obj-$(CONFIG_MIPS_EJTAG_FDC_TTY) += mips_ejtag_fdc.o
obj-$(CONFIG_VCC) += vcc.o
obj-$(CONFIG_RPMSG_TTY) += rpmsg_tty.o
+obj-$(CONFIG_LSTP_TTY) += lstp_tty.o
diff --git a/drivers/tty/lstp_tty.c b/drivers/tty/lstp_tty.c
new file mode 100644
index 000000000000..64894eca16ee
--- /dev/null
+++ b/drivers/tty/lstp_tty.c
@@ -0,0 +1,829 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * UART driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/bits.h>
+#include <linux/cleanup.h>
+#include <linux/delay.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/serial.h>
+#include <linux/termios.h>
+#include <linux/tty.h>
+#include <linux/tty_buffer.h>
+#include <linux/tty_driver.h>
+#include <linux/tty_flip.h>
+#include <linux/workqueue.h>
+#include <linux/xarray.h>
+
+#include <linux/usb/lstp.h>
+
+enum lstp_uart_cmd {
+ LSTP_UART_CMD_WRITE = 0x00,
+};
+
+struct lstp_uart_config {
+ __le32 speed;
+ u8 data_bits;
+ u8 stop_bits;
+ u8 parity_flow; /* [3:0] parity, [7:4] flow control */
+} __packed;
+
+#define LSTP_UART_CFG_PARITY(pf) ((pf) & 0x0F)
+#define LSTP_UART_CFG_FLOW(pf) (((pf) >> 4) & 0x0F)
+
+enum lstp_uart_parity {
+ LSTP_UART_PARITY_NONE = 0,
+ LSTP_UART_PARITY_ODD = 1,
+ LSTP_UART_PARITY_EVEN = 2,
+ LSTP_UART_PARITY_MARK = 3,
+ LSTP_UART_PARITY_SPACE = 4,
+};
+
+enum lstp_uart_flow {
+ LSTP_UART_FLOW_NONE = 0,
+ LSTP_UART_FLOW_XONXOFF = 1,
+ LSTP_UART_FLOW_RTSCTS = 2,
+ LSTP_UART_FLOW_DTRDSR = 3,
+};
+
+/* clang-format off */
+
+/* Tag bits OR'd into the WRITE command byte. */
+#define LSTP_UART_TAG_CARRIER_DOWN BIT(6) /* dev→host: carrier lost */
+#define LSTP_UART_TAG_TX_OVERRUN BIT(5) /* dev→host: TX data dropped */
+#define LSTP_UART_TAG_BREAK_DET BIT(4) /* dev→host: break detected */
+#define LSTP_UART_TAG_GEN_BREAK BIT(3) /* host→dev: send break */
+
+/* clang-format on */
+
+/* Bits [1:0] = command; [6:2] = tags; [7] = req/resp flag. */
+#define LSTP_UART_CMD_MASK GENMASK(1, 0)
+
+/* Firmware NACKs WRITE on a full TX FIFO; 5 x 10 ms covers a 500-byte drain at 115200. */
+#define LSTP_UART_NAK_MAX_RETRIES 5
+#define LSTP_UART_NAK_RETRY_DELAY_MS 10
+
+#define LSTP_UART_MINORS 256
+
+/* TX coalesces: lstp_tty_write() appends to @coal_buf, write_work drains @tx_snapshot. */
+struct lstp_uart_ctx {
+ struct tty_port port;
+ struct lstp_channel *ch;
+ int minor;
+ bool registered; /* tty device live for @minor; under lstp_minors_lock */
+ size_t max_payload;
+ tcflag_t hw_cflag;
+ tcflag_t hw_iflag;
+
+ spinlock_t write_lock; /* protects the TX fields below and @iocount.tx */
+ u8 *coal_buf;
+ u8 *tx_snapshot; /* stable copy handed to lstp_request() */
+ size_t coal_len;
+ size_t tx_inflight_len;
+ bool tx_in_flight;
+ struct work_struct write_work;
+
+ /*
+ * Each field is written under one lock -- @write_lock for tx, the
+ * channel's irq_cb_lock for the rest -- and read under neither by
+ * lstp_tty_get_icount(), so writes use WRITE_ONCE() and reads READ_ONCE().
+ */
+ struct serial_icounter_struct iocount;
+};
+
+static struct tty_driver *lstp_tty_driver;
+
+static DEFINE_XARRAY_ALLOC(lstp_minors);
+/* Nests inside tty_lock; never hold it across tty_vhangup(), which takes tty_lock. */
+static DEFINE_MUTEX(lstp_minors_lock);
+
+static int lstp_alloc_minor(struct lstp_uart_ctx *ctx)
+{
+ u32 minor;
+ int ret;
+
+ guard(mutex)(&lstp_minors_lock);
+ ret = xa_alloc(&lstp_minors, &minor, ctx, XA_LIMIT(0, LSTP_UART_MINORS - 1), GFP_KERNEL);
+ return ret ? ret : minor;
+}
+
+/*
+ * Called only from lstp_port_destruct(), so the minor stays reserved for the
+ * life of the port: recycling it earlier would let an open of the reused
+ * index resolve through driver->ttys[] to the previous port's tty.
+ */
+static void lstp_free_minor(struct lstp_uart_ctx *ctx)
+{
+ guard(mutex)(&lstp_minors_lock);
+
+ if (ctx->minor < 0)
+ return;
+
+ xa_erase(&lstp_minors, ctx->minor);
+ ctx->minor = -1;
+}
+
+/*
+ * Resolve a live port by minor, taking a tty_port reference under the lock
+ * lstp_port_destruct() erases the entry under. The context pins its channel,
+ * so @ctx->ch is valid while the reference is held. The entry outlives
+ * @registered: a minor between unbind and destruction is found and refused.
+ */
+static struct lstp_uart_ctx *lstp_get_by_minor(unsigned int minor)
+{
+ guard(mutex)(&lstp_minors_lock);
+ struct lstp_uart_ctx *ctx = xa_load(&lstp_minors, minor);
+
+ if (!ctx || !ctx->registered || lstp_channel_disconnected(ctx->ch))
+ return NULL;
+
+ /* Fails once the last put is in, ahead of the destructor's erase. */
+ if (!tty_port_get(&ctx->port))
+ return NULL;
+ return ctx;
+}
+
+/* clang-format off */
+static speed_t lstp_baud_to_speed(u32 baud)
+{
+ static const struct {
+ u32 baud;
+ speed_t speed;
+ } map[] = {
+ { 50, B50 }, { 75, B75 }, { 110, B110 },
+ { 134, B134 }, { 150, B150 }, { 200, B200 },
+ { 300, B300 }, { 600, B600 }, { 1200, B1200 },
+ { 1800, B1800 }, { 2400, B2400 }, { 4800, B4800 },
+ { 9600, B9600 }, { 19200, B19200 }, { 38400, B38400 },
+ { 57600, B57600 }, { 115200, B115200 }, { 230400, B230400 },
+ { 460800, B460800 }, { 500000, B500000 }, { 576000, B576000 },
+ { 921600, B921600 }, { 1000000, B1000000 }, { 1152000, B1152000 },
+ { 1500000, B1500000 }, { 2000000, B2000000 }, { 2500000, B2500000 },
+ { 3000000, B3000000 }, { 3500000, B3500000 }, { 4000000, B4000000 },
+ };
+
+ for (size_t i = 0; i < ARRAY_SIZE(map); i++)
+ if (map[i].baud == baud)
+ return map[i].speed;
+
+ return B0;
+}
+
+/* clang-format on */
+
+static tcflag_t lstp_build_cflag(const struct lstp_uart_config *cfg)
+{
+ tcflag_t cflag = CREAD | HUPCL | CLOCAL;
+ u8 parity = LSTP_UART_CFG_PARITY(cfg->parity_flow);
+ u8 flow = LSTP_UART_CFG_FLOW(cfg->parity_flow);
+
+ cflag |= lstp_baud_to_speed(le32_to_cpu(cfg->speed));
+
+ switch (cfg->data_bits) {
+ case 5:
+ cflag |= CS5;
+ break;
+ case 6:
+ cflag |= CS6;
+ break;
+ case 7:
+ cflag |= CS7;
+ break;
+ default:
+ cflag |= CS8;
+ break;
+ }
+
+ if (cfg->stop_bits == 2)
+ cflag |= CSTOPB;
+
+ switch (parity) {
+ case LSTP_UART_PARITY_ODD:
+ cflag |= PARENB | PARODD;
+ break;
+ case LSTP_UART_PARITY_EVEN:
+ cflag |= PARENB;
+ break;
+ case LSTP_UART_PARITY_MARK:
+ cflag |= PARENB | PARODD | CMSPAR;
+ break;
+ case LSTP_UART_PARITY_SPACE:
+ cflag |= PARENB | CMSPAR;
+ break;
+ }
+
+ if (flow == LSTP_UART_FLOW_RTSCTS)
+ cflag |= CRTSCTS;
+
+ return cflag;
+}
+
+static tcflag_t lstp_build_iflag(const struct lstp_uart_config *cfg)
+{
+ if (LSTP_UART_CFG_FLOW(cfg->parity_flow) == LSTP_UART_FLOW_XONXOFF)
+ return IXON | IXOFF;
+ return 0;
+}
+
+static int lstp_uart_parse_config(struct lstp_uart_ctx *ctx, struct lstp_channel *ch,
+ const struct lstp_uart_config *cfg)
+{
+ static const char parity_chars[] = "NOEMS";
+ u8 parity = LSTP_UART_CFG_PARITY(cfg->parity_flow);
+
+ ctx->hw_cflag = lstp_build_cflag(cfg);
+ ctx->hw_iflag = lstp_build_iflag(cfg);
+
+ dev_dbg(ch->dev, "%s: ch_%d: %u baud, %u%c%c, parity %u, flow %u\n", __func__, ch->ch_id,
+ le32_to_cpu(cfg->speed), cfg->data_bits, cfg->stop_bits == 2 ? '2' : '1',
+ parity < sizeof(parity_chars) - 1 ? parity_chars[parity] : '?', parity,
+ LSTP_UART_CFG_FLOW(cfg->parity_flow));
+
+ return 0;
+}
+
+static int lstp_uart_send_with_retry(struct lstp_uart_ctx *ctx, u8 cmd, const void *payload,
+ size_t len)
+{
+ struct lstp_channel *ch = ctx->ch;
+ int lstp_status = LSTP_NACK;
+ int ret = 0;
+ int attempt;
+
+ for (attempt = 0; lstp_status == LSTP_NACK && attempt < LSTP_UART_NAK_MAX_RETRIES;
+ attempt++) {
+ if (attempt)
+ fsleep(LSTP_UART_NAK_RETRY_DELAY_MS * USEC_PER_MSEC);
+
+ ret = lstp_request(ch, cmd, payload, len, NULL, 0, NULL, &lstp_status);
+ }
+
+ if (ret && ret != -ENODEV)
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: Failed to write after %d attempt(s) (%pe)\n",
+ __func__, ch->ch_id, attempt, ERR_PTR(ret));
+
+ return ret;
+}
+
+/* @tx_snapshot is written only here, so it stays stable across the retry loop. */
+static void lstp_uart_write_work(struct work_struct *work)
+{
+ struct lstp_uart_ctx *ctx = container_of(work, struct lstp_uart_ctx, write_work);
+ size_t len;
+
+ scoped_guard(spinlock_irqsave, &ctx->write_lock) {
+ len = ctx->coal_len;
+ if (len == 0)
+ return;
+ memcpy(ctx->tx_snapshot, ctx->coal_buf, len);
+ ctx->coal_len = 0;
+ ctx->tx_in_flight = true;
+ ctx->tx_inflight_len = len;
+ }
+
+ tty_port_tty_wakeup(&ctx->port);
+
+ int ret = lstp_uart_send_with_retry(ctx, LSTP_UART_CMD_WRITE, ctx->tx_snapshot, len);
+
+ scoped_guard(spinlock_irqsave, &ctx->write_lock) {
+ ctx->tx_in_flight = false;
+ if (!ret)
+ WRITE_ONCE(ctx->iocount.tx, ctx->iocount.tx + len);
+ if (ctx->coal_len > 0)
+ schedule_work(&ctx->write_work);
+ }
+
+ tty_port_tty_wakeup(&ctx->port);
+}
+
+/* ops->irq_packet: push RX into the flip buffer, NACKing when full so firmware retries. */
+static void lstp_uart_irq_callback(struct lstp_channel *ch, struct lstp_packet *pkt)
+{
+ struct lstp_uart_ctx *ctx = ch->priv;
+ u16 rx_len = le16_to_cpu(pkt->hdr.length);
+ u8 cmd = pkt->hdr.cmd;
+ bool have_break = cmd & LSTP_UART_TAG_BREAK_DET;
+ bool carrier_down = cmd & LSTP_UART_TAG_CARRIER_DOWN;
+ bool tx_overrun = cmd & LSTP_UART_TAG_TX_OVERRUN;
+ size_t need_room = rx_len + (have_break ? 1 : 0);
+ u8 status = LSTP_SUCCESS;
+
+ if ((cmd & LSTP_UART_CMD_MASK) != LSTP_UART_CMD_WRITE) {
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: unexpected UART command 0x%02x\n",
+ __func__, ch->ch_id, cmd);
+ lstp_send_irq_resp(ch, LSTP_NOT_SUPP);
+ return;
+ }
+
+ size_t room = tty_buffer_request_room(&ctx->port, need_room);
+
+ if (room < need_room) {
+ WRITE_ONCE(ctx->iocount.buf_overrun, ctx->iocount.buf_overrun + 1);
+ status = LSTP_NACK;
+ } else {
+ if (have_break) {
+ WRITE_ONCE(ctx->iocount.brk, ctx->iocount.brk + 1);
+ tty_insert_flip_char(&ctx->port, 0, TTY_BREAK);
+ }
+ if (rx_len) {
+ tty_insert_flip_string(&ctx->port, pkt->payload, rx_len);
+ WRITE_ONCE(ctx->iocount.rx, ctx->iocount.rx + rx_len);
+ }
+ tty_flip_buffer_push(&ctx->port);
+ }
+
+ if (tx_overrun) {
+ WRITE_ONCE(ctx->iocount.overrun, ctx->iocount.overrun + 1);
+ dev_warn_ratelimited(ch->dev,
+ "%s: ch_%d: RX overrun on link (firmware dropped bytes)\n",
+ __func__, ch->ch_id);
+ }
+
+ if (carrier_down) {
+ WRITE_ONCE(ctx->iocount.dcd, ctx->iocount.dcd + 1);
+ /* Honors CLOCAL: no-op when userspace asked to ignore carrier. */
+ tty_port_tty_hangup(&ctx->port, true);
+ }
+
+ lstp_send_irq_resp(ch, status);
+}
+
+static int lstp_port_activate(struct tty_port *port, struct tty_struct *tty)
+{
+ struct lstp_uart_ctx *ctx = container_of(port, struct lstp_uart_ctx, port);
+
+ /*
+ * Re-test @registered: .install() resolved it under tty_mutex, which
+ * the core drops before .open. lstp_uart_stop() clears the flag before
+ * it samples @port->tty, so an open that gets past here has already
+ * published its tty and stop() will hang it up.
+ */
+ scoped_guard(mutex, &lstp_minors_lock)
+ if (!ctx->registered)
+ return -ENODEV;
+
+ tty->termios.c_cflag = ctx->hw_cflag;
+ tty->termios.c_iflag = ctx->hw_iflag;
+
+ /* TTY_NO_WRITE_SPLIT: let N_TTY pass a whole write down, not byte at a time. */
+ set_bit(TTY_NO_WRITE_SPLIT, &tty->flags);
+ return 0;
+}
+
+static void lstp_port_shutdown(struct tty_port *port)
+{
+ struct lstp_uart_ctx *ctx = container_of(port, struct lstp_uart_ctx, port);
+
+ cancel_work_sync(&ctx->write_work);
+
+ /*
+ * Normally already empty. What survives the close drain and the hangup
+ * flush is a drain still stalled when closing_wait expires: bytes queued
+ * with no worker after the cancel above, so write_room() would stay
+ * short by that much for the life of the port.
+ */
+ scoped_guard(spinlock_irqsave, &ctx->write_lock) {
+ ctx->coal_len = 0;
+ ctx->tx_inflight_len = 0;
+ }
+}
+
+static void lstp_port_destruct(struct tty_port *port)
+{
+ struct lstp_uart_ctx *ctx = container_of(port, struct lstp_uart_ctx, port);
+ struct lstp_channel *ch = ctx->ch;
+
+ lstp_free_minor(ctx);
+ kfree(ctx->tx_snapshot);
+ kfree(ctx->coal_buf);
+ kfree(ctx);
+ lstp_channel_put(ch);
+}
+
+static const struct tty_port_operations lstp_port_ops = {
+ .activate = lstp_port_activate,
+ .shutdown = lstp_port_shutdown,
+ .destruct = lstp_port_destruct,
+};
+
+static int lstp_tty_install(struct tty_driver *driver, struct tty_struct *tty)
+{
+ struct lstp_uart_ctx *ctx = lstp_get_by_minor(tty->index);
+
+ if (!ctx)
+ return -ENODEV;
+
+ /*
+ * tty_port_install(), as it sets tty->port: tty_init_dev() would use
+ * driver->ports[], which tty_unregister_device() leaves naming the
+ * minor's last context.
+ */
+ int ret = tty_port_install(&ctx->port, driver, tty);
+
+ if (ret) {
+ tty_port_put(&ctx->port);
+ return ret;
+ }
+
+ /*
+ * The tty now owns the lookup's reference; lstp_tty_cleanup() drops it.
+ * @driver_data is the context, not the channel, so this tty never
+ * reaches a later bind's context.
+ */
+ tty->driver_data = ctx;
+ return 0;
+}
+
+static int lstp_tty_open(struct tty_struct *tty, struct file *filp)
+{
+ return tty_port_open(tty->port, tty, filp);
+}
+
+static void lstp_tty_close(struct tty_struct *tty, struct file *filp)
+{
+ tty_port_close(tty->port, tty, filp);
+}
+
+static void lstp_tty_hangup(struct tty_struct *tty)
+{
+ tty_port_hangup(tty->port);
+}
+
+static void lstp_tty_cleanup(struct tty_struct *tty)
+{
+ /* Drops what .install was handed. Runs for every installed tty. */
+ tty_port_put(tty->port);
+}
+
+static ssize_t lstp_tty_write(struct tty_struct *tty, const unsigned char *buf, size_t count)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+ struct lstp_channel *ch = ctx->ch;
+
+ if (!count)
+ return 0;
+
+ guard(spinlock_irqsave)(&ctx->write_lock);
+
+ if (lstp_channel_disconnected(ch))
+ return -EIO;
+
+ size_t room = ctx->max_payload - ctx->coal_len;
+
+ if (!room)
+ return 0;
+
+ count = min(count, room);
+ memcpy(ctx->coal_buf + ctx->coal_len, buf, count);
+ ctx->coal_len += count;
+
+ schedule_work(&ctx->write_work);
+
+ return count;
+}
+
+static unsigned int lstp_tty_write_room(struct tty_struct *tty)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+ struct lstp_channel *ch = ctx->ch;
+
+ guard(spinlock_irqsave)(&ctx->write_lock);
+
+ if (lstp_channel_disconnected(ch))
+ return 0;
+ return ctx->max_payload - ctx->coal_len;
+}
+
+static unsigned int lstp_tty_chars_in_buffer(struct tty_struct *tty)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+ struct lstp_channel *ch = ctx->ch;
+
+ guard(spinlock_irqsave)(&ctx->write_lock);
+
+ if (lstp_channel_disconnected(ch))
+ return 0;
+
+ unsigned int count = ctx->coal_len;
+
+ if (ctx->tx_in_flight)
+ count += ctx->tx_inflight_len;
+ return count;
+}
+
+static void lstp_tty_flush_buffer(struct tty_struct *tty)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+
+ scoped_guard(spinlock_irqsave, &ctx->write_lock)
+ ctx->coal_len = 0;
+ /* Does not cancel an already in-flight TX. */
+ cancel_work(&ctx->write_work);
+}
+
+/*
+ * Firmware config is fixed. tty_termios_copy_hw() restores the speeds and all
+ * of c_cflag but CREAD, HUPCL and CLOCAL; it leaves c_iflag alone, so the
+ * flow-control bits are restored by hand below.
+ */
+static void lstp_tty_set_termios(struct tty_struct *tty, const struct ktermios *old_termios)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+
+ tty_termios_copy_hw(&tty->termios, old_termios);
+
+ /* XON/XOFF is a property of the link, not something stty may change. */
+ tty->termios.c_iflag &= ~(IXON | IXOFF | IXANY);
+ tty->termios.c_iflag |= ctx->hw_iflag & (IXON | IXOFF | IXANY);
+}
+
+/* Firmware fires a fixed-duration break; any non-zero state fires it, as cdc-acm does. */
+static int lstp_tty_break_ctl(struct tty_struct *tty, int state)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+
+ if (!state)
+ return 0;
+
+ /* Hangup clears initialized under port->mutex, so it waits out a break in flight. */
+ guard(mutex)(&ctx->port.mutex);
+ if (!tty_port_initialized(&ctx->port))
+ return -EIO;
+
+ return lstp_uart_send_with_retry(ctx, LSTP_UART_CMD_WRITE | LSTP_UART_TAG_GEN_BREAK, NULL,
+ 0);
+}
+
+static int lstp_tty_get_icount(struct tty_struct *tty, struct serial_icounter_struct *icount)
+{
+ struct lstp_uart_ctx *ctx = tty->driver_data;
+
+ /* tty_get_icount() has zeroed *icount; these are the fields the driver counts. */
+ icount->dcd = READ_ONCE(ctx->iocount.dcd);
+ icount->rx = READ_ONCE(ctx->iocount.rx);
+ icount->tx = READ_ONCE(ctx->iocount.tx);
+ icount->overrun = READ_ONCE(ctx->iocount.overrun);
+ icount->brk = READ_ONCE(ctx->iocount.brk);
+ icount->buf_overrun = READ_ONCE(ctx->iocount.buf_overrun);
+ return 0;
+}
+
+static const struct tty_operations lstp_ops = {
+ .install = lstp_tty_install,
+ .open = lstp_tty_open,
+ .close = lstp_tty_close,
+ .cleanup = lstp_tty_cleanup,
+ .hangup = lstp_tty_hangup,
+ .write = lstp_tty_write,
+ .write_room = lstp_tty_write_room,
+ .chars_in_buffer = lstp_tty_chars_in_buffer,
+ .flush_buffer = lstp_tty_flush_buffer,
+ .set_termios = lstp_tty_set_termios,
+ .break_ctl = lstp_tty_break_ctl,
+ .get_icount = lstp_tty_get_icount,
+};
+
+/*
+ * Set up the tty_port, coalescing buffers and minor for one bind. The bind
+ * holds the port's initial reference, dropped by lstp_uart_remove(), and each
+ * installed tty another, so the context and its minor last until the later of
+ * the unbind and the last close.
+ */
+static int lstp_uart_init(struct lstp_channel *ch, const struct lstp_channel_init_info *info)
+{
+ if (info->config_len < sizeof(struct lstp_uart_config)) {
+ dev_err(ch->dev, "%s: ch_%d: UART config too short: %zu < %zu\n", __func__,
+ ch->ch_id, info->config_len, sizeof(struct lstp_uart_config));
+ return -EINVAL;
+ }
+
+ struct lstp_uart_ctx *ctx = kzalloc_obj(*ctx);
+
+ if (!ctx)
+ return -ENOMEM;
+
+ /* From here the only unwind is tty_port_put(); lstp_port_destruct() frees the rest. */
+ tty_port_init(&ctx->port);
+ ctx->port.ops = &lstp_port_ops;
+ ctx->minor = -1;
+ ctx->max_payload = ch->max_tx_payload;
+ ctx->ch = lstp_channel_get(ch);
+ spin_lock_init(&ctx->write_lock);
+
+ int ret = lstp_uart_parse_config(ctx, ch, info->config);
+
+ if (ret)
+ goto err_put_port;
+
+ ctx->coal_buf = kzalloc(ctx->max_payload, GFP_KERNEL);
+ if (!ctx->coal_buf) {
+ ret = -ENOMEM;
+ goto err_put_port;
+ }
+
+ ctx->tx_snapshot = kzalloc(ctx->max_payload, GFP_KERNEL);
+ if (!ctx->tx_snapshot) {
+ ret = -ENOMEM;
+ goto err_put_port;
+ }
+
+ ret = lstp_alloc_minor(ctx);
+ if (ret < 0) {
+ dev_err(ch->dev, "%s: ch_%d: Failed to allocate minor (%pe)\n", __func__, ch->ch_id,
+ ERR_PTR(ret));
+ goto err_put_port;
+ }
+ ctx->minor = ret;
+
+ INIT_WORK(&ctx->write_work, lstp_uart_write_work);
+ ch->priv = ctx;
+
+ dev_dbg(ch->dev, "%s: ch_%d: Initialized as %s\n", __func__, ch->ch_id, ch->display_name);
+ return 0;
+
+err_put_port:
+ tty_port_put(&ctx->port);
+ return ret;
+}
+
+static int lstp_uart_start(struct lstp_channel *ch)
+{
+ struct lstp_uart_ctx *ctx = ch->priv;
+
+ /*
+ * Mark registered before publishing: tty_port_register_device() adds
+ * the cdev and emits the uevent that sends udev straight to open(),
+ * and lstp_tty_install() refuses a minor that is not marked. No node
+ * exists at this index yet, so nothing can reach the map early.
+ */
+ scoped_guard(mutex, &lstp_minors_lock)
+ ctx->registered = true;
+
+ struct device *tty_dev =
+ tty_port_register_device(&ctx->port, lstp_tty_driver, ctx->minor, ch->dev);
+
+ if (IS_ERR(tty_dev)) {
+ dev_err(ch->dev, "%s: ch_%d: Could not register TTY (%pe)\n", __func__, ch->ch_id,
+ tty_dev);
+ scoped_guard(mutex, &lstp_minors_lock)
+ ctx->registered = false;
+ return PTR_ERR(tty_dev);
+ }
+
+ /* Nothing below may fail: really_probe() skips .remove() when .probe() errors. */
+ dev_info(ch->dev, "%s: ch_%d: Started as %s\n", __func__, ch->ch_id, ch->display_name);
+ return 0;
+}
+
+/*
+ * Hang up the tty and unregister its device node, from the aux_driver
+ * .remove(). The minor and its map entry stay with the context until its last
+ * reference goes; clearing @registered is what refuses opens in between.
+ */
+static void lstp_uart_stop(struct lstp_channel *ch)
+{
+ struct lstp_uart_ctx *ctx = ch->priv;
+
+ /*
+ * Clear @registered before sampling @port->tty, not after:
+ * tty_port_open() publishes the tty before it calls .activate(), so an
+ * open can go live between a sample and a later clear and never be
+ * hung up here.
+ */
+ scoped_guard(mutex, &lstp_minors_lock)
+ ctx->registered = false;
+
+ struct tty_struct *tty = tty_port_tty_get(&ctx->port);
+
+ if (tty) {
+ /*
+ * Synchronous: fds move to hung_up_tty_fops and lstp_port_shutdown()
+ * cancels write_work, so no write is submitted after this returns.
+ */
+ tty_vhangup(tty);
+ tty_kref_put(tty);
+ }
+
+ tty_unregister_device(lstp_tty_driver, ctx->minor);
+}
+
+/*
+ * Nodes come and go with channel binds. The core drops a minor's saved termios
+ * when it is re-registered, so termios does not survive an unbind/bind cycle.
+ */
+static int __init lstp_uart_module_setup(void)
+{
+ lstp_tty_driver =
+ tty_alloc_driver(LSTP_UART_MINORS, TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+ if (IS_ERR(lstp_tty_driver))
+ return PTR_ERR(lstp_tty_driver);
+
+ lstp_tty_driver->driver_name = "lstp";
+ lstp_tty_driver->name = "ttyLSTP";
+ lstp_tty_driver->major = 0;
+ lstp_tty_driver->minor_start = 0;
+ lstp_tty_driver->type = TTY_DRIVER_TYPE_SERIAL;
+ lstp_tty_driver->subtype = SERIAL_TYPE_NORMAL;
+ lstp_tty_driver->init_termios = tty_std_termios;
+ /* Overridden per-device in port_activate; this is the visible default. */
+ lstp_tty_driver->init_termios.c_cflag = B115200 | CS8 | CREAD | HUPCL | CLOCAL;
+ tty_set_operations(lstp_tty_driver, &lstp_ops);
+
+ int ret = tty_register_driver(lstp_tty_driver);
+
+ if (ret) {
+ tty_driver_kref_put(lstp_tty_driver);
+ return ret;
+ }
+
+ return 0;
+}
+
+static void lstp_uart_module_teardown(void)
+{
+ tty_unregister_driver(lstp_tty_driver);
+ tty_driver_kref_put(lstp_tty_driver);
+ xa_destroy(&lstp_minors);
+}
+
+static int lstp_uart_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
+
+ if (!info)
+ return -ENODEV;
+
+ int ret = lstp_uart_init(ch, info);
+
+ if (ret)
+ return ret;
+
+ struct lstp_uart_ctx *ctx = ch->priv;
+
+ ret = lstp_uart_start(ch);
+ if (ret)
+ tty_port_put(&ctx->port);
+ return ret;
+}
+
+/* A tty still installed keeps the context until its cleanup. */
+static void lstp_uart_remove(struct auxiliary_device *auxdev)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ struct lstp_uart_ctx *ctx = ch->priv;
+
+ lstp_uart_stop(ch);
+ tty_port_put(&ctx->port);
+}
+
+static const struct lstp_ops lstp_uart_ops = {
+ .irq_packet = lstp_uart_irq_callback,
+};
+
+static const struct auxiliary_device_id lstp_uart_id_table[] = { { .name = "lstp.uart" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_uart_id_table);
+
+static struct lstp_auxiliary_driver lstp_uart_drv = {
+ .adrv = {
+ .name = "uart",
+ .probe = lstp_uart_probe,
+ .remove = lstp_uart_remove,
+ .id_table = lstp_uart_id_table,
+ },
+ .ops = &lstp_uart_ops,
+};
+
+/* The tty_driver goes first: a probe registers its channel's tty device on it. */
+static int __init lstp_uart_module_init(void)
+{
+ int ret = lstp_uart_module_setup();
+
+ if (ret)
+ return ret;
+
+ ret = lstp_auxiliary_driver_register(&lstp_uart_drv);
+ if (ret)
+ lstp_uart_module_teardown();
+
+ return ret;
+}
+module_init(lstp_uart_module_init);
+
+static void __exit lstp_uart_module_exit(void)
+{
+ lstp_auxiliary_driver_unregister(&lstp_uart_drv);
+ lstp_uart_module_teardown();
+}
+module_exit(lstp_uart_module_exit);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP UART driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 10/11] tty: Add NVIDIA LSTP UART driver
2026-10-12 17:36 ` [PATCH 10/11] tty: Add NVIDIA LSTP UART driver Adrian Ambrozewicz
@ 2026-10-13 5:49 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2026-10-13 5:49 UTC (permalink / raw)
To: Adrian Ambrozewicz, Greg Kroah-Hartman
Cc: Donald Shannon, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-kernel, linux-serial,
linux-usb, llvm, Ilpo Järvinen, Johan Hovold, Oliver Neukum
Hi,
On 12. 10. 26, 19:36, Adrian Ambrozewicz wrote:
> --- /dev/null
> +++ b/drivers/tty/lstp_tty.c
> @@ -0,0 +1,829 @@
...
> +/* clang-format off */
> +static speed_t lstp_baud_to_speed(u32 baud)
Maybe implement this in drivers/tty/tty_baudrate.c on the top of
baud_table + baud_bits?
> +{
> + static const struct {
> + u32 baud;
> + speed_t speed;
> + } map[] = {
> + { 50, B50 }, { 75, B75 }, { 110, B110 },
> + { 134, B134 }, { 150, B150 }, { 200, B200 },
> + { 300, B300 }, { 600, B600 }, { 1200, B1200 },
> + { 1800, B1800 }, { 2400, B2400 }, { 4800, B4800 },
> + { 9600, B9600 }, { 19200, B19200 }, { 38400, B38400 },
> + { 57600, B57600 }, { 115200, B115200 }, { 230400, B230400 },
> + { 460800, B460800 }, { 500000, B500000 }, { 576000, B576000 },
> + { 921600, B921600 }, { 1000000, B1000000 }, { 1152000, B1152000 },
> + { 1500000, B1500000 }, { 2000000, B2000000 }, { 2500000, B2500000 },
> + { 3000000, B3000000 }, { 3500000, B3500000 }, { 4000000, B4000000 },
> + };
> +
> + for (size_t i = 0; i < ARRAY_SIZE(map); i++)
> + if (map[i].baud == baud)
> + return map[i].speed;
> +
> + return B0;
> +}
...
> +static int lstp_uart_start(struct lstp_channel *ch)
> +{
> + struct lstp_uart_ctx *ctx = ch->priv;
> +
> + /*
> + * Mark registered before publishing: tty_port_register_device() adds
> + * the cdev and emits the uevent that sends udev straight to open(),
> + * and lstp_tty_install() refuses a minor that is not marked. No node
> + * exists at this index yet, so nothing can reach the map early.
> + */
> + scoped_guard(mutex, &lstp_minors_lock)
> + ctx->registered = true;
> +
> + struct device *tty_dev =
> + tty_port_register_device(&ctx->port, lstp_tty_driver, ctx->minor, ch->dev);
> +
> + if (IS_ERR(tty_dev)) {
> + dev_err(ch->dev, "%s: ch_%d: Could not register TTY (%pe)\n", __func__, ch->ch_id,
> + tty_dev);
> + scoped_guard(mutex, &lstp_minors_lock)
> + ctx->registered = false;
> + return PTR_ERR(tty_dev);
> + }
> +
> + /* Nothing below may fail: really_probe() skips .remove() when .probe() errors. */
> + dev_info(ch->dev, "%s: ch_%d: Started as %s\n", __func__, ch->ch_id, ch->display_name);
We usually print nothing in case everything went well.
> + return 0;
> +}
...
> +static void lstp_uart_stop(struct lstp_channel *ch)
> +{
> + struct lstp_uart_ctx *ctx = ch->priv;
> +
> + /*
> + * Clear @registered before sampling @port->tty, not after:
> + * tty_port_open() publishes the tty before it calls .activate(), so an
> + * open can go live between a sample and a later clear and never be
> + * hung up here.
> + */
> + scoped_guard(mutex, &lstp_minors_lock)
> + ctx->registered = false;
> +
> + struct tty_struct *tty = tty_port_tty_get(&ctx->port);
> +
> + if (tty) {
> + /*
> + * Synchronous: fds move to hung_up_tty_fops and lstp_port_shutdown()
> + * cancels write_work, so no write is submitted after this returns.
> + */
> + tty_vhangup(tty);
> + tty_kref_put(tty);
tty_port_tty_vhangup()?
> + }
> +
> + tty_unregister_device(lstp_tty_driver, ctx->minor);
> +}
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver
2026-10-12 17:35 [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Adrian Ambrozewicz
` (9 preceding siblings ...)
2026-10-12 17:36 ` [PATCH 10/11] tty: Add NVIDIA LSTP UART driver Adrian Ambrozewicz
@ 2026-10-12 17:36 ` Adrian Ambrozewicz
2026-10-12 21:10 ` Corey Minyard
10 siblings, 1 reply; 19+ messages in thread
From: Adrian Ambrozewicz @ 2026-10-12 17:36 UTC (permalink / raw)
To: Corey Minyard
Cc: Donald Shannon, linux-kernel, openipmi-developer, linux-usb,
Greg Kroah-Hartman, Quan Nguyen, Andrew Jeffery
Add a BMC-side driver for the IPMI channels of NVIDIA LSTP USB adapters.
The adapter carries IPMI messages between the host and the BMC; each
channel is exposed to BMC userspace as an ipmi-lstp<n> character device
that reads requests from the host and writes the responses back.
By default each message on the node carries a one-byte message number
between the length and the payload, and a response echoes the number
of the request it answers. The number exists only on the node, not in
the LSTP protocol. With USB_LSTP_IPMI_MSG_NUM disabled the
node uses the ssif_bmc layout (struct ipmi_ssif_msg) instead, so
userspace written for ssif_bmc works unchanged.
Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
---
MAINTAINERS | 1 +
drivers/char/ipmi/Kconfig | 32 +++
drivers/char/ipmi/Makefile | 1 +
drivers/char/ipmi/ipmi-lstp.c | 464 ++++++++++++++++++++++++++++++++++
4 files changed, 498 insertions(+)
create mode 100644 drivers/char/ipmi/ipmi-lstp.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 8e58895b7d5a..96667b3baa7a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19577,6 +19577,7 @@ F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
F: Documentation/driver-api/usb/lstp.rst
F: Documentation/firmware-guide/acpi/lstp.rst
+F: drivers/char/ipmi/ipmi-lstp.c
F: drivers/gpio/gpio-lstp.c
F: drivers/i2c/busses/i2c-lstp.c
F: drivers/leds/leds-lstp.c
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 538a7d3c65bf..eb51a2d56fc9 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -119,6 +119,38 @@ config IPMI_POWEROFF
endif # IPMI_HANDLER
+config LSTP_IPMI_BMC
+ tristate "NVIDIA LSTP IPMI BMC support"
+ depends on USB_LSTP
+ default USB_LSTP
+ help
+ Say Y or M here to support the IPMI channels of NVIDIA LSTP USB
+ adapters on a BMC. Each channel is exposed as an ipmi-lstp<n>
+ character device through which BMC userspace receives requests
+ from the host and sends the responses back.
+
+ This driver can also be built as a module. If so, the module
+ will be called ipmi-lstp.
+
+config USB_LSTP_IPMI_MSG_NUM
+ bool "Message-number header on LSTP IPMI nodes"
+ depends on LSTP_IPMI_BMC
+ default y
+ help
+ Messages read from and written to an LSTP IPMI device node carry a
+ one-byte message number between the length and the payload, and a
+ response must echo the number of the request it answers. The number
+ exists only on the device node, not in the LSTP protocol, and no
+ other BMC-side IPMI driver has it.
+
+ Disable this option to drop it. The node then uses the layout of
+ struct ipmi_ssif_msg from the ssif_bmc driver, a length followed by
+ the payload, so that userspace written for ssif_bmc works unchanged.
+ A response answers the request read last, and is dropped once a newer
+ request has arrived.
+
+ Say Y if userspace parses the message number.
+
config IPMI_KCS_BMC
tristate
diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
index 4ea450a82242..2e320ce2c901 100644
--- a/drivers/char/ipmi/Makefile
+++ b/drivers/char/ipmi/Makefile
@@ -29,3 +29,4 @@ obj-$(CONFIG_ASPEED_KCS_IPMI_BMC) += kcs_bmc_aspeed.o
obj-$(CONFIG_NPCM7XX_KCS_IPMI_BMC) += kcs_bmc_npcm7xx.o
obj-$(CONFIG_IPMB_DEVICE_INTERFACE) += ipmb_dev_int.o
obj-$(CONFIG_SSIF_IPMI_BMC) += ssif_bmc.o
+obj-$(CONFIG_LSTP_IPMI_BMC) += ipmi-lstp.o
diff --git a/drivers/char/ipmi/ipmi-lstp.c b/drivers/char/ipmi/ipmi-lstp.c
new file mode 100644
index 000000000000..787d633d4ada
--- /dev/null
+++ b/drivers/char/ipmi/ipmi-lstp.c
@@ -0,0 +1,464 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * IPMI driver for LSTP USB interface.
+ *
+ * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ */
+
+#include <linux/build_bug.h>
+#include <linux/err.h>
+#include <linux/idr.h>
+#include <linux/ipmi_ssif_bmc.h>
+#include <linux/kfifo.h>
+#include <linux/kref.h>
+#include <linux/miscdevice.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/poll.h>
+#include <linux/property.h>
+#include <linux/slab.h>
+
+#include <linux/usb/lstp.h>
+
+/* ~1 s of queued requests at OpenBMC rates; past that the host has retried. */
+#define BUFFER_SIZE 4096
+
+static DEFINE_IDA(lstp_ipmi_ida);
+
+#define IPMI_LSTP_PAYLOAD_MAX 254
+#define IPMI_MIN_MSG_LEN 2 /* netfn/lun + cmd */
+
+/*
+ * read(2) and write(2) layout with CONFIG_USB_LSTP_IPMI_MSG_NUM. Deployed
+ * userspace parses these bytes, so the field widths and offsets are fixed;
+ * native byte order, as both ends are the same host. @msg_num exists only on
+ * this interface, never on the wire.
+ */
+struct ipmi_lstp_msg_header {
+ __u32 len;
+ __u8 msg_num;
+} __packed;
+
+struct ipmi_lstp_msg {
+ struct ipmi_lstp_msg_header header;
+ __u8 payload[IPMI_LSTP_PAYLOAD_MAX];
+};
+
+static_assert(sizeof(struct ipmi_lstp_msg_header) == 5, "IPMI read(2) header layout is ABI");
+static_assert(offsetof(struct ipmi_lstp_msg_header, msg_num) == 4,
+ "IPMI read(2) header layout is ABI");
+
+/*
+ * The layout without CONFIG_USB_LSTP_IPMI_MSG_NUM is the ssif_bmc driver's:
+ * the same len and payload, no @msg_num.
+ */
+static_assert(offsetof(struct ipmi_ssif_msg, payload) ==
+ sizeof_field(struct ipmi_lstp_msg_header, len),
+ "Untagged layout must be the LSTP header without msg_num");
+static_assert(IPMI_SSIF_PAYLOAD_MAX == IPMI_LSTP_PAYLOAD_MAX,
+ "Untagged layout must carry the LSTP payload");
+
+#define LSTP_IPMI_MSG_NUM IS_ENABLED(CONFIG_USB_LSTP_IPMI_MSG_NUM)
+
+/* The leading bytes of struct ipmi_lstp_msg_header that userspace sees. */
+#define LSTP_IPMI_UAPI_HDR_LEN \
+ (LSTP_IPMI_MSG_NUM ? sizeof(struct ipmi_lstp_msg_header) : \
+ sizeof_field(struct ipmi_lstp_msg_header, len))
+#define LSTP_IPMI_UAPI_MSG_MAX \
+ (LSTP_IPMI_MSG_NUM ? sizeof(struct ipmi_lstp_msg) : sizeof(struct ipmi_ssif_msg))
+
+/* One per bind; the bind and each open fd hold @ref. */
+struct lstp_ipmi_ctx {
+ struct kref ref;
+ struct lstp_channel *ch; /* pinned for the life of @ctx */
+ struct miscdevice miscdev;
+ int ida_id; /* -1 until allocated */
+ bool running; /* exclusive-open flag */
+ spinlock_t lock; /* protects @running, @msg_count, @read_tag, @fifo */
+ struct mutex tx_lock; /* held across write()'s gone test and send; teardown waits on it */
+ wait_queue_head_t req_wq;
+ struct kfifo_rec_ptr_2 fifo; /* pending requests, oldest dropped to fit */
+ u8 msg_count; /* tag of the outstanding request; write() echoes it */
+ u8 read_tag; /* untagged ABI: tag of the request read() handed out last, 0 for none */
+ bool stopped; /* node torn down; see lstp_ipmi_gone() */
+};
+
+enum lstp_ipmi_cmd {
+ LSTP_IPMI_CMD_MESSAGE = 0x00,
+};
+
+/* @stopped is per bind and never cleared; see Documentation/driver-api/usb/lstp.rst. */
+static inline bool lstp_ipmi_gone(struct lstp_ipmi_ctx *ctx)
+{
+ return READ_ONCE(ctx->stopped) || lstp_channel_disconnected(ctx->ch);
+}
+
+static inline bool lstp_ipmi_readable(struct lstp_ipmi_ctx *ctx)
+{
+ return !kfifo_is_empty(&ctx->fifo) || lstp_ipmi_gone(ctx);
+}
+
+/* Partial-init safe: a failed lstp_ipmi_init() unwinds through it as well. */
+static void lstp_ipmi_ctx_release(struct kref *ref)
+{
+ struct lstp_ipmi_ctx *ctx = container_of(ref, struct lstp_ipmi_ctx, ref);
+ struct lstp_channel *ch = ctx->ch;
+
+ kfifo_free(&ctx->fifo);
+ if (ctx->ida_id >= 0)
+ ida_free(&lstp_ipmi_ida, ctx->ida_id);
+ kfree(ctx->miscdev.name);
+ mutex_destroy(&ctx->tx_lock);
+ kfree(ctx);
+ lstp_channel_put(ch);
+}
+
+/* Devres action for the bind's reference, booked ahead of the node's own. */
+static void lstp_ipmi_ctx_put(void *data)
+{
+ struct lstp_ipmi_ctx *ctx = data;
+
+ kref_put(&ctx->ref, lstp_ipmi_ctx_release);
+}
+
+static inline struct lstp_ipmi_ctx *to_ctx(struct file *file)
+{
+ return container_of(file->private_data, struct lstp_ipmi_ctx, miscdev);
+}
+
+static int lstp_ipmi_open(struct inode *inode, struct file *file)
+{
+ struct lstp_ipmi_ctx *ctx = to_ctx(file);
+ int ret = 0;
+
+ spin_lock_irq(&ctx->lock);
+ if (lstp_ipmi_gone(ctx))
+ ret = -ENODEV;
+ else if (ctx->running)
+ ret = -EBUSY;
+ else
+ ctx->running = true;
+ spin_unlock_irq(&ctx->lock);
+
+ if (ret)
+ return ret;
+
+ /*
+ * misc_mtx spans this ->open and misc_deregister(), which the bind's
+ * @ref outlasts, so @ctx is live here and this cannot race the final put.
+ */
+ kref_get(&ctx->ref);
+ return 0;
+}
+
+/* Read one queued request: the userspace header, then the payload. */
+static ssize_t lstp_ipmi_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
+{
+ struct lstp_ipmi_ctx *ctx = to_ctx(file);
+ struct ipmi_lstp_msg msg;
+ unsigned long flags;
+ unsigned int len = 0;
+ size_t ulen = 0;
+
+ /*
+ * copy_to_user() may sleep, so drain to @msg under @ctx->lock first.
+ * Loop: two readers on one fd can both wake, only one wins the record.
+ */
+ while (!len) {
+ /* Before the queue: a request queued when the bind went cannot be answered. */
+ if (lstp_ipmi_gone(ctx))
+ return -ENODEV;
+ if (kfifo_is_empty(&ctx->fifo)) {
+ if (file->f_flags & O_NONBLOCK)
+ return -EAGAIN;
+ int ret = wait_event_interruptible(ctx->req_wq, lstp_ipmi_readable(ctx));
+
+ if (ret)
+ return ret;
+ }
+
+ spin_lock_irqsave(&ctx->lock, flags);
+ /*
+ * Peek before consuming: kfifo_out() drops whatever of the
+ * record does not fit, so a short @count would retire a
+ * request the caller never saw. Leave it queued and let the
+ * caller come back with room for it.
+ */
+ len = kfifo_out_peek(&ctx->fifo, &msg, sizeof(msg));
+ ulen = len ? LSTP_IPMI_UAPI_HDR_LEN + msg.header.len : 0;
+ if (len && ulen <= count) {
+ kfifo_skip(&ctx->fifo);
+ WRITE_ONCE(ctx->read_tag, msg.header.msg_num);
+ }
+ spin_unlock_irqrestore(&ctx->lock, flags);
+
+ if (ulen > count)
+ return -EINVAL;
+ }
+
+ if (copy_to_user(buf, &msg.header, LSTP_IPMI_UAPI_HDR_LEN) ||
+ copy_to_user(buf + LSTP_IPMI_UAPI_HDR_LEN, msg.payload, msg.header.len))
+ return -EFAULT;
+ return ulen;
+}
+
+/*
+ * Forward a response. A write whose @msg_num misses the outstanding tag is
+ * dropped and reported as consumed, so userspace need not track the race
+ * against a request that arrived meanwhile. Without the tag in the ABI, a
+ * response answers the request read() handed out last.
+ */
+static ssize_t lstp_ipmi_write(struct file *file, const char __user *buf, size_t count,
+ loff_t *ppos)
+{
+ struct lstp_ipmi_ctx *ctx = to_ctx(file);
+ struct lstp_channel *ch = ctx->ch;
+ struct ipmi_lstp_msg msg;
+ ssize_t ret;
+
+ if (count < LSTP_IPMI_UAPI_HDR_LEN || count > LSTP_IPMI_UAPI_MSG_MAX)
+ return -EINVAL;
+
+ /* The untagged bound admits struct padding past the payload; drop it. */
+ if (copy_from_user(&msg.header, buf, LSTP_IPMI_UAPI_HDR_LEN) ||
+ copy_from_user(msg.payload, buf + LSTP_IPMI_UAPI_HDR_LEN,
+ min(count - LSTP_IPMI_UAPI_HDR_LEN, sizeof(msg.payload))))
+ return -EFAULT;
+
+ /* Held through the send; see lstp_ipmi_stop_and_deregister(). */
+ guard(mutex)(&ctx->tx_lock);
+ if (lstp_ipmi_gone(ctx))
+ return -ENODEV;
+
+ if (!LSTP_IPMI_MSG_NUM)
+ msg.header.msg_num = READ_ONCE(ctx->read_tag);
+
+ /*
+ * 0 tags no request; it is only @msg_count's value before the first.
+ * Stale tag read is fine; pairs with WRITE_ONCE in the IRQ producer.
+ */
+ if (!msg.header.msg_num || msg.header.msg_num != READ_ONCE(ctx->msg_count))
+ return count;
+
+ if (!msg.header.len || msg.header.len > IPMI_LSTP_PAYLOAD_MAX ||
+ count < LSTP_IPMI_UAPI_HDR_LEN + msg.header.len)
+ return -EINVAL;
+
+ ret = lstp_send(ch, LSTP_IPMI_CMD_MESSAGE, msg.payload, msg.header.len);
+ if (ret && ret != -ENODEV)
+ dev_err_ratelimited(ch->dev, "%s: ch_%d: Could not forward response (%pe)\n",
+ __func__, ch->ch_id, ERR_PTR(ret));
+
+ return (ret < 0) ? ret : count;
+}
+
+static int lstp_ipmi_release(struct inode *inode, struct file *file)
+{
+ struct lstp_ipmi_ctx *ctx = to_ctx(file);
+
+ spin_lock_irq(&ctx->lock);
+ ctx->running = false;
+ spin_unlock_irq(&ctx->lock);
+
+ kref_put(&ctx->ref, lstp_ipmi_ctx_release);
+
+ return 0;
+}
+
+static __poll_t lstp_ipmi_poll(struct file *file, poll_table *wait)
+{
+ struct lstp_ipmi_ctx *ctx = to_ctx(file);
+
+ poll_wait(file, &ctx->req_wq, wait);
+ if (lstp_ipmi_gone(ctx))
+ return EPOLLHUP;
+ if (!kfifo_is_empty(&ctx->fifo))
+ return EPOLLIN | EPOLLRDNORM;
+
+ return 0;
+}
+
+static const struct file_operations lstp_ipmi_fops = {
+ .owner = THIS_MODULE,
+ .open = lstp_ipmi_open,
+ .read = lstp_ipmi_read,
+ .write = lstp_ipmi_write,
+ .release = lstp_ipmi_release,
+ .poll = lstp_ipmi_poll,
+};
+
+/*
+ * @stopped before the wake: this runs ahead of the framework's fence action, so
+ * a reader woken without it would find nothing changed and sleep again. The
+ * empty @tx_lock section then waits out a write() that tested @stopped before
+ * it went up, so no response is sent once the unwind moves on; a send is
+ * bounded by the USB timeout.
+ */
+static void lstp_ipmi_stop_and_deregister(void *data)
+{
+ struct lstp_ipmi_ctx *ctx = data;
+
+ misc_deregister(&ctx->miscdev);
+ WRITE_ONCE(ctx->stopped, true);
+ wake_up_all(&ctx->req_wq);
+ scoped_guard(mutex, &ctx->tx_lock) {
+ }
+}
+
+/*
+ * ops->irq_packet. Requests are never NACKed, so drop-oldest is the whole
+ * flow-control policy.
+ */
+static void lstp_ipmi_irq_callback(struct lstp_channel *ch, struct lstp_packet *pkt)
+{
+ struct lstp_ipmi_ctx *ctx = ch->priv;
+ u16 rx_len = le16_to_cpu(pkt->hdr.length);
+ struct ipmi_lstp_msg msg;
+ unsigned long flags;
+ unsigned int dropped = 0;
+
+ if (rx_len < IPMI_MIN_MSG_LEN || rx_len > IPMI_LSTP_PAYLOAD_MAX) {
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: Invalid IPMI request length %u\n",
+ __func__, ch->ch_id, rx_len);
+ return;
+ }
+
+ unsigned int msg_size = sizeof(msg.header) + rx_len;
+
+ msg.header.len = rx_len;
+ memcpy(msg.payload, pkt->payload, rx_len);
+
+ spin_lock_irqsave(&ctx->lock, flags);
+ /*
+ * Skip 0 on wrap: it is the initial value, meaning nothing outstanding,
+ * so no request may carry it. Pairs with the READ_ONCE in write().
+ */
+ u8 tag = ctx->msg_count + 1;
+
+ msg.header.msg_num = tag ?: 1;
+ WRITE_ONCE(ctx->msg_count, msg.header.msg_num);
+ while (kfifo_avail(&ctx->fifo) < msg_size) {
+ kfifo_skip(&ctx->fifo);
+ dropped++;
+ }
+ kfifo_in(&ctx->fifo, &msg, msg_size);
+ spin_unlock_irqrestore(&ctx->lock, flags);
+
+ if (dropped)
+ dev_warn_ratelimited(ch->dev, "%s: ch_%d: FIFO full, dropped %u stale request(s)\n",
+ __func__, ch->ch_id, dropped);
+
+ wake_up_all(&ctx->req_wq);
+}
+
+/*
+ * Build this bind's context and its "ipmi-lstpN" node name. An fd held across
+ * the unbind keeps the context, and with it the number, until it closes; the
+ * next bind takes the lowest number free.
+ */
+static int lstp_ipmi_init(struct lstp_channel *ch, const struct lstp_channel_init_info *info)
+{
+ struct lstp_ipmi_ctx *ctx = kzalloc_obj(*ctx);
+
+ if (!ctx)
+ return -ENOMEM;
+
+ kref_init(&ctx->ref);
+ ctx->ida_id = -1;
+ ctx->ch = lstp_channel_get(ch);
+ spin_lock_init(&ctx->lock);
+ mutex_init(&ctx->tx_lock);
+ init_waitqueue_head(&ctx->req_wq);
+
+ int ret = kfifo_alloc(&ctx->fifo, BUFFER_SIZE, GFP_KERNEL);
+
+ if (ret)
+ goto err_put;
+
+ ret = ida_alloc(&lstp_ipmi_ida, GFP_KERNEL);
+ if (ret < 0)
+ goto err_put;
+ ctx->ida_id = ret;
+ ctx->miscdev.name = kasprintf(GFP_KERNEL, "ipmi-lstp%d", ctx->ida_id);
+ if (!ctx->miscdev.name) {
+ ret = -ENOMEM;
+ goto err_put;
+ }
+
+ if (fwnode_property_present(ch->fwnode, "label"))
+ dev_notice_once(ch->dev,
+ "%s: ch_%d: Firmware \"label\" no longer names the node, which is %s; use a udev symlink for a stable name\n",
+ __func__, ch->ch_id, ctx->miscdev.name);
+
+ ctx->miscdev.minor = MISC_DYNAMIC_MINOR;
+ ctx->miscdev.fops = &lstp_ipmi_fops;
+ ctx->miscdev.parent = ch->dev;
+
+ ch->priv = ctx;
+ dev_dbg(ch->dev, "%s: ch_%d: Initialized as %s\n", __func__, ch->ch_id, ch->display_name);
+ return 0;
+
+err_put:
+ kref_put(&ctx->ref, lstp_ipmi_ctx_release);
+ return ret;
+}
+
+static int lstp_ipmi_start(struct lstp_channel *ch, struct lstp_ipmi_ctx *ctx)
+{
+ int ret = misc_register(&ctx->miscdev);
+
+ if (ret) {
+ dev_err(ch->dev, "%s: ch_%d: Could not register miscdevice (%pe)\n", __func__,
+ ch->ch_id, ERR_PTR(ret));
+ return ret;
+ }
+
+ ret = devm_add_action_or_reset(ch->dev, lstp_ipmi_stop_and_deregister, ctx);
+ if (ret)
+ return ret;
+
+ dev_info(ch->dev, "%s: ch_%d: Started as %s\n", __func__, ch->ch_id, ch->display_name);
+ return 0;
+}
+
+static int lstp_ipmi_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
+{
+ struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
+ const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
+
+ if (!info)
+ return -ENODEV;
+
+ int ret = lstp_ipmi_init(ch, info);
+
+ if (ret)
+ return ret;
+
+ /* Booked first, so it unwinds after the node's deregister action. */
+ ret = devm_add_action_or_reset(ch->dev, lstp_ipmi_ctx_put, ch->priv);
+ if (ret)
+ return ret;
+
+ return lstp_ipmi_start(ch, ch->priv);
+}
+
+static const struct lstp_ops lstp_ipmi_ops = {
+ .irq_packet = lstp_ipmi_irq_callback,
+};
+
+static const struct auxiliary_device_id lstp_ipmi_id_table[] = { { .name = "lstp.ipmi" }, {} };
+MODULE_DEVICE_TABLE(auxiliary, lstp_ipmi_id_table);
+
+static struct lstp_auxiliary_driver lstp_ipmi_drv = {
+ .adrv = {
+ .name = "ipmi",
+ .probe = lstp_ipmi_probe,
+ .id_table = lstp_ipmi_id_table,
+ },
+ .ops = &lstp_ipmi_ops,
+};
+module_lstp_auxiliary_driver(lstp_ipmi_drv);
+
+MODULE_IMPORT_NS("LSTP");
+MODULE_DESCRIPTION("LSTP BMC-side IPMI driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver
2026-10-12 17:36 ` [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver Adrian Ambrozewicz
@ 2026-10-12 21:10 ` Corey Minyard
0 siblings, 0 replies; 19+ messages in thread
From: Corey Minyard @ 2026-10-12 21:10 UTC (permalink / raw)
To: Adrian Ambrozewicz
Cc: Donald Shannon, linux-kernel, openipmi-developer, linux-usb,
Greg Kroah-Hartman, Quan Nguyen, Andrew Jeffery
On Mon, Oct 12, 2026 at 08:36:09PM +0300, Adrian Ambrozewicz wrote:
> Add a BMC-side driver for the IPMI channels of NVIDIA LSTP USB adapters.
> The adapter carries IPMI messages between the host and the BMC; each
> channel is exposed to BMC userspace as an ipmi-lstp<n> character device
> that reads requests from the host and writes the responses back.
>
> By default each message on the node carries a one-byte message number
> between the length and the payload, and a response echoes the number
> of the request it answers. The number exists only on the node, not in
> the LSTP protocol. With USB_LSTP_IPMI_MSG_NUM disabled the
> node uses the ssif_bmc layout (struct ipmi_ssif_msg) instead, so
> userspace written for ssif_bmc works unchanged.
Can you name the file usb_lstp.c, or something like that, to match
the other BMC side devices?
>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> MAINTAINERS | 1 +
> drivers/char/ipmi/Kconfig | 32 +++
> drivers/char/ipmi/Makefile | 1 +
> drivers/char/ipmi/ipmi-lstp.c | 464 ++++++++++++++++++++++++++++++++++
> 4 files changed, 498 insertions(+)
> create mode 100644 drivers/char/ipmi/ipmi-lstp.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e58895b7d5a..96667b3baa7a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19577,6 +19577,7 @@ F: Documentation/devicetree/bindings/spi/nvidia,lstp-spi.yaml
> F: Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
> F: Documentation/driver-api/usb/lstp.rst
> F: Documentation/firmware-guide/acpi/lstp.rst
> +F: drivers/char/ipmi/ipmi-lstp.c
> F: drivers/gpio/gpio-lstp.c
> F: drivers/i2c/busses/i2c-lstp.c
> F: drivers/leds/leds-lstp.c
> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
> index 538a7d3c65bf..eb51a2d56fc9 100644
> --- a/drivers/char/ipmi/Kconfig
> +++ b/drivers/char/ipmi/Kconfig
> @@ -119,6 +119,38 @@ config IPMI_POWEROFF
>
> endif # IPMI_HANDLER
>
> +config LSTP_IPMI_BMC
> + tristate "NVIDIA LSTP IPMI BMC support"
> + depends on USB_LSTP
> + default USB_LSTP
> + help
> + Say Y or M here to support the IPMI channels of NVIDIA LSTP USB
> + adapters on a BMC. Each channel is exposed as an ipmi-lstp<n>
> + character device through which BMC userspace receives requests
> + from the host and sends the responses back.
> +
> + This driver can also be built as a module. If so, the module
> + will be called ipmi-lstp.
> +
> +config USB_LSTP_IPMI_MSG_NUM
> + bool "Message-number header on LSTP IPMI nodes"
> + depends on LSTP_IPMI_BMC
> + default y
> + help
> + Messages read from and written to an LSTP IPMI device node carry a
> + one-byte message number between the length and the payload, and a
> + response must echo the number of the request it answers. The number
> + exists only on the device node, not in the LSTP protocol, and no
> + other BMC-side IPMI driver has it.
> +
> + Disable this option to drop it. The node then uses the layout of
> + struct ipmi_ssif_msg from the ssif_bmc driver, a length followed by
> + the payload, so that userspace written for ssif_bmc works unchanged.
> + A response answers the request read last, and is dropped once a newer
> + request has arrived.
> +
> + Say Y if userspace parses the message number.
> +
> config IPMI_KCS_BMC
> tristate
>
> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
> index 4ea450a82242..2e320ce2c901 100644
> --- a/drivers/char/ipmi/Makefile
> +++ b/drivers/char/ipmi/Makefile
> @@ -29,3 +29,4 @@ obj-$(CONFIG_ASPEED_KCS_IPMI_BMC) += kcs_bmc_aspeed.o
> obj-$(CONFIG_NPCM7XX_KCS_IPMI_BMC) += kcs_bmc_npcm7xx.o
> obj-$(CONFIG_IPMB_DEVICE_INTERFACE) += ipmb_dev_int.o
> obj-$(CONFIG_SSIF_IPMI_BMC) += ssif_bmc.o
> +obj-$(CONFIG_LSTP_IPMI_BMC) += ipmi-lstp.o
> diff --git a/drivers/char/ipmi/ipmi-lstp.c b/drivers/char/ipmi/ipmi-lstp.c
> new file mode 100644
> index 000000000000..787d633d4ada
> --- /dev/null
> +++ b/drivers/char/ipmi/ipmi-lstp.c
> @@ -0,0 +1,464 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * IPMI driver for LSTP USB interface.
> + *
> + * Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + */
> +
> +#include <linux/build_bug.h>
> +#include <linux/err.h>
> +#include <linux/idr.h>
> +#include <linux/ipmi_ssif_bmc.h>
> +#include <linux/kfifo.h>
> +#include <linux/kref.h>
> +#include <linux/miscdevice.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/poll.h>
> +#include <linux/property.h>
> +#include <linux/slab.h>
> +
> +#include <linux/usb/lstp.h>
> +
> +/* ~1 s of queued requests at OpenBMC rates; past that the host has retried. */
> +#define BUFFER_SIZE 4096
> +
> +static DEFINE_IDA(lstp_ipmi_ida);
Wouldn't you want to assign the numbers in the device tree so they
always have the same number?
> +
> +#define IPMI_LSTP_PAYLOAD_MAX 254
> +#define IPMI_MIN_MSG_LEN 2 /* netfn/lun + cmd */
> +
> +/*
> + * read(2) and write(2) layout with CONFIG_USB_LSTP_IPMI_MSG_NUM. Deployed
> + * userspace parses these bytes, so the field widths and offsets are fixed;
> + * native byte order, as both ends are the same host. @msg_num exists only on
> + * this interface, never on the wire.
> + */
> +struct ipmi_lstp_msg_header {
> + __u32 len;
> + __u8 msg_num;
> +} __packed;
> +
> +struct ipmi_lstp_msg {
> + struct ipmi_lstp_msg_header header;
> + __u8 payload[IPMI_LSTP_PAYLOAD_MAX];
> +};
> +
> +static_assert(sizeof(struct ipmi_lstp_msg_header) == 5, "IPMI read(2) header layout is ABI");
> +static_assert(offsetof(struct ipmi_lstp_msg_header, msg_num) == 4,
> + "IPMI read(2) header layout is ABI");
> +
> +/*
> + * The layout without CONFIG_USB_LSTP_IPMI_MSG_NUM is the ssif_bmc driver's:
> + * the same len and payload, no @msg_num.
> + */
> +static_assert(offsetof(struct ipmi_ssif_msg, payload) ==
> + sizeof_field(struct ipmi_lstp_msg_header, len),
> + "Untagged layout must be the LSTP header without msg_num");
> +static_assert(IPMI_SSIF_PAYLOAD_MAX == IPMI_LSTP_PAYLOAD_MAX,
> + "Untagged layout must carry the LSTP payload");
> +
> +#define LSTP_IPMI_MSG_NUM IS_ENABLED(CONFIG_USB_LSTP_IPMI_MSG_NUM)
> +
> +/* The leading bytes of struct ipmi_lstp_msg_header that userspace sees. */
> +#define LSTP_IPMI_UAPI_HDR_LEN \
> + (LSTP_IPMI_MSG_NUM ? sizeof(struct ipmi_lstp_msg_header) : \
> + sizeof_field(struct ipmi_lstp_msg_header, len))
> +#define LSTP_IPMI_UAPI_MSG_MAX \
> + (LSTP_IPMI_MSG_NUM ? sizeof(struct ipmi_lstp_msg) : sizeof(struct ipmi_ssif_msg))
> +
> +/* One per bind; the bind and each open fd hold @ref. */
> +struct lstp_ipmi_ctx {
> + struct kref ref;
> + struct lstp_channel *ch; /* pinned for the life of @ctx */
> + struct miscdevice miscdev;
> + int ida_id; /* -1 until allocated */
> + bool running; /* exclusive-open flag */
> + spinlock_t lock; /* protects @running, @msg_count, @read_tag, @fifo */
> + struct mutex tx_lock; /* held across write()'s gone test and send; teardown waits on it */
> + wait_queue_head_t req_wq;
> + struct kfifo_rec_ptr_2 fifo; /* pending requests, oldest dropped to fit */
> + u8 msg_count; /* tag of the outstanding request; write() echoes it */
> + u8 read_tag; /* untagged ABI: tag of the request read() handed out last, 0 for none */
> + bool stopped; /* node torn down; see lstp_ipmi_gone() */
> +};
> +
> +enum lstp_ipmi_cmd {
> + LSTP_IPMI_CMD_MESSAGE = 0x00,
> +};
> +
> +/* @stopped is per bind and never cleared; see Documentation/driver-api/usb/lstp.rst. */
> +static inline bool lstp_ipmi_gone(struct lstp_ipmi_ctx *ctx)
> +{
> + return READ_ONCE(ctx->stopped) || lstp_channel_disconnected(ctx->ch);
> +}
> +
> +static inline bool lstp_ipmi_readable(struct lstp_ipmi_ctx *ctx)
> +{
> + return !kfifo_is_empty(&ctx->fifo) || lstp_ipmi_gone(ctx);
> +}
> +
> +/* Partial-init safe: a failed lstp_ipmi_init() unwinds through it as well. */
> +static void lstp_ipmi_ctx_release(struct kref *ref)
> +{
> + struct lstp_ipmi_ctx *ctx = container_of(ref, struct lstp_ipmi_ctx, ref);
> + struct lstp_channel *ch = ctx->ch;
> +
> + kfifo_free(&ctx->fifo);
> + if (ctx->ida_id >= 0)
> + ida_free(&lstp_ipmi_ida, ctx->ida_id);
> + kfree(ctx->miscdev.name);
> + mutex_destroy(&ctx->tx_lock);
> + kfree(ctx);
> + lstp_channel_put(ch);
> +}
> +
> +/* Devres action for the bind's reference, booked ahead of the node's own. */
> +static void lstp_ipmi_ctx_put(void *data)
> +{
> + struct lstp_ipmi_ctx *ctx = data;
> +
> + kref_put(&ctx->ref, lstp_ipmi_ctx_release);
> +}
> +
> +static inline struct lstp_ipmi_ctx *to_ctx(struct file *file)
> +{
> + return container_of(file->private_data, struct lstp_ipmi_ctx, miscdev);
> +}
> +
> +static int lstp_ipmi_open(struct inode *inode, struct file *file)
> +{
> + struct lstp_ipmi_ctx *ctx = to_ctx(file);
> + int ret = 0;
> +
> + spin_lock_irq(&ctx->lock);
> + if (lstp_ipmi_gone(ctx))
> + ret = -ENODEV;
> + else if (ctx->running)
> + ret = -EBUSY;
> + else
> + ctx->running = true;
> + spin_unlock_irq(&ctx->lock);
> +
> + if (ret)
> + return ret;
> +
> + /*
> + * misc_mtx spans this ->open and misc_deregister(), which the bind's
> + * @ref outlasts, so @ctx is live here and this cannot race the final put.
> + */
> + kref_get(&ctx->ref);
> + return 0;
> +}
> +
> +/* Read one queued request: the userspace header, then the payload. */
> +static ssize_t lstp_ipmi_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
> +{
> + struct lstp_ipmi_ctx *ctx = to_ctx(file);
> + struct ipmi_lstp_msg msg;
> + unsigned long flags;
> + unsigned int len = 0;
> + size_t ulen = 0;
> +
> + /*
> + * copy_to_user() may sleep, so drain to @msg under @ctx->lock first.
> + * Loop: two readers on one fd can both wake, only one wins the record.
> + */
> + while (!len) {
> + /* Before the queue: a request queued when the bind went cannot be answered. */
> + if (lstp_ipmi_gone(ctx))
> + return -ENODEV;
> + if (kfifo_is_empty(&ctx->fifo)) {
> + if (file->f_flags & O_NONBLOCK)
> + return -EAGAIN;
> + int ret = wait_event_interruptible(ctx->req_wq, lstp_ipmi_readable(ctx));
> +
> + if (ret)
> + return ret;
> + }
> +
> + spin_lock_irqsave(&ctx->lock, flags);
> + /*
> + * Peek before consuming: kfifo_out() drops whatever of the
> + * record does not fit, so a short @count would retire a
> + * request the caller never saw. Leave it queued and let the
> + * caller come back with room for it.
> + */
> + len = kfifo_out_peek(&ctx->fifo, &msg, sizeof(msg));
> + ulen = len ? LSTP_IPMI_UAPI_HDR_LEN + msg.header.len : 0;
> + if (len && ulen <= count) {
> + kfifo_skip(&ctx->fifo);
> + WRITE_ONCE(ctx->read_tag, msg.header.msg_num);
> + }
> + spin_unlock_irqrestore(&ctx->lock, flags);
> +
> + if (ulen > count)
> + return -EINVAL;
> + }
> +
> + if (copy_to_user(buf, &msg.header, LSTP_IPMI_UAPI_HDR_LEN) ||
> + copy_to_user(buf + LSTP_IPMI_UAPI_HDR_LEN, msg.payload, msg.header.len))
> + return -EFAULT;
> + return ulen;
> +}
> +
> +/*
> + * Forward a response. A write whose @msg_num misses the outstanding tag is
> + * dropped and reported as consumed, so userspace need not track the race
> + * against a request that arrived meanwhile. Without the tag in the ABI, a
> + * response answers the request read() handed out last.
> + */
> +static ssize_t lstp_ipmi_write(struct file *file, const char __user *buf, size_t count,
> + loff_t *ppos)
> +{
> + struct lstp_ipmi_ctx *ctx = to_ctx(file);
> + struct lstp_channel *ch = ctx->ch;
> + struct ipmi_lstp_msg msg;
> + ssize_t ret;
> +
> + if (count < LSTP_IPMI_UAPI_HDR_LEN || count > LSTP_IPMI_UAPI_MSG_MAX)
> + return -EINVAL;
> +
> + /* The untagged bound admits struct padding past the payload; drop it. */
> + if (copy_from_user(&msg.header, buf, LSTP_IPMI_UAPI_HDR_LEN) ||
> + copy_from_user(msg.payload, buf + LSTP_IPMI_UAPI_HDR_LEN,
> + min(count - LSTP_IPMI_UAPI_HDR_LEN, sizeof(msg.payload))))
> + return -EFAULT;
> +
> + /* Held through the send; see lstp_ipmi_stop_and_deregister(). */
> + guard(mutex)(&ctx->tx_lock);
> + if (lstp_ipmi_gone(ctx))
> + return -ENODEV;
> +
> + if (!LSTP_IPMI_MSG_NUM)
> + msg.header.msg_num = READ_ONCE(ctx->read_tag);
> +
> + /*
> + * 0 tags no request; it is only @msg_count's value before the first.
> + * Stale tag read is fine; pairs with WRITE_ONCE in the IRQ producer.
> + */
> + if (!msg.header.msg_num || msg.header.msg_num != READ_ONCE(ctx->msg_count))
> + return count;
> +
> + if (!msg.header.len || msg.header.len > IPMI_LSTP_PAYLOAD_MAX ||
> + count < LSTP_IPMI_UAPI_HDR_LEN + msg.header.len)
> + return -EINVAL;
> +
> + ret = lstp_send(ch, LSTP_IPMI_CMD_MESSAGE, msg.payload, msg.header.len);
> + if (ret && ret != -ENODEV)
> + dev_err_ratelimited(ch->dev, "%s: ch_%d: Could not forward response (%pe)\n",
> + __func__, ch->ch_id, ERR_PTR(ret));
> +
> + return (ret < 0) ? ret : count;
> +}
> +
> +static int lstp_ipmi_release(struct inode *inode, struct file *file)
> +{
> + struct lstp_ipmi_ctx *ctx = to_ctx(file);
> +
> + spin_lock_irq(&ctx->lock);
> + ctx->running = false;
> + spin_unlock_irq(&ctx->lock);
> +
> + kref_put(&ctx->ref, lstp_ipmi_ctx_release);
> +
> + return 0;
> +}
> +
> +static __poll_t lstp_ipmi_poll(struct file *file, poll_table *wait)
> +{
> + struct lstp_ipmi_ctx *ctx = to_ctx(file);
> +
> + poll_wait(file, &ctx->req_wq, wait);
> + if (lstp_ipmi_gone(ctx))
> + return EPOLLHUP;
> + if (!kfifo_is_empty(&ctx->fifo))
> + return EPOLLIN | EPOLLRDNORM;
> +
> + return 0;
> +}
> +
> +static const struct file_operations lstp_ipmi_fops = {
> + .owner = THIS_MODULE,
> + .open = lstp_ipmi_open,
> + .read = lstp_ipmi_read,
> + .write = lstp_ipmi_write,
> + .release = lstp_ipmi_release,
> + .poll = lstp_ipmi_poll,
> +};
> +
> +/*
> + * @stopped before the wake: this runs ahead of the framework's fence action, so
> + * a reader woken without it would find nothing changed and sleep again. The
> + * empty @tx_lock section then waits out a write() that tested @stopped before
> + * it went up, so no response is sent once the unwind moves on; a send is
> + * bounded by the USB timeout.
> + */
> +static void lstp_ipmi_stop_and_deregister(void *data)
> +{
> + struct lstp_ipmi_ctx *ctx = data;
> +
> + misc_deregister(&ctx->miscdev);
> + WRITE_ONCE(ctx->stopped, true);
> + wake_up_all(&ctx->req_wq);
> + scoped_guard(mutex, &ctx->tx_lock) {
> + }
> +}
> +
> +/*
> + * ops->irq_packet. Requests are never NACKed, so drop-oldest is the whole
> + * flow-control policy.
> + */
> +static void lstp_ipmi_irq_callback(struct lstp_channel *ch, struct lstp_packet *pkt)
> +{
> + struct lstp_ipmi_ctx *ctx = ch->priv;
> + u16 rx_len = le16_to_cpu(pkt->hdr.length);
> + struct ipmi_lstp_msg msg;
> + unsigned long flags;
> + unsigned int dropped = 0;
> +
> + if (rx_len < IPMI_MIN_MSG_LEN || rx_len > IPMI_LSTP_PAYLOAD_MAX) {
> + dev_warn_ratelimited(ch->dev, "%s: ch_%d: Invalid IPMI request length %u\n",
> + __func__, ch->ch_id, rx_len);
> + return;
> + }
> +
> + unsigned int msg_size = sizeof(msg.header) + rx_len;
> +
> + msg.header.len = rx_len;
> + memcpy(msg.payload, pkt->payload, rx_len);
> +
> + spin_lock_irqsave(&ctx->lock, flags);
> + /*
> + * Skip 0 on wrap: it is the initial value, meaning nothing outstanding,
> + * so no request may carry it. Pairs with the READ_ONCE in write().
> + */
> + u8 tag = ctx->msg_count + 1;
> +
> + msg.header.msg_num = tag ?: 1;
> + WRITE_ONCE(ctx->msg_count, msg.header.msg_num);
> + while (kfifo_avail(&ctx->fifo) < msg_size) {
> + kfifo_skip(&ctx->fifo);
> + dropped++;
> + }
> + kfifo_in(&ctx->fifo, &msg, msg_size);
> + spin_unlock_irqrestore(&ctx->lock, flags);
> +
> + if (dropped)
> + dev_warn_ratelimited(ch->dev, "%s: ch_%d: FIFO full, dropped %u stale request(s)\n",
> + __func__, ch->ch_id, dropped);
> +
> + wake_up_all(&ctx->req_wq);
> +}
> +
> +/*
> + * Build this bind's context and its "ipmi-lstpN" node name. An fd held across
> + * the unbind keeps the context, and with it the number, until it closes; the
> + * next bind takes the lowest number free.
> + */
> +static int lstp_ipmi_init(struct lstp_channel *ch, const struct lstp_channel_init_info *info)
> +{
> + struct lstp_ipmi_ctx *ctx = kzalloc_obj(*ctx);
> +
> + if (!ctx)
> + return -ENOMEM;
> +
> + kref_init(&ctx->ref);
> + ctx->ida_id = -1;
> + ctx->ch = lstp_channel_get(ch);
> + spin_lock_init(&ctx->lock);
> + mutex_init(&ctx->tx_lock);
> + init_waitqueue_head(&ctx->req_wq);
> +
> + int ret = kfifo_alloc(&ctx->fifo, BUFFER_SIZE, GFP_KERNEL);
> +
> + if (ret)
> + goto err_put;
> +
> + ret = ida_alloc(&lstp_ipmi_ida, GFP_KERNEL);
> + if (ret < 0)
> + goto err_put;
> + ctx->ida_id = ret;
> + ctx->miscdev.name = kasprintf(GFP_KERNEL, "ipmi-lstp%d", ctx->ida_id);
> + if (!ctx->miscdev.name) {
> + ret = -ENOMEM;
> + goto err_put;
> + }
> +
> + if (fwnode_property_present(ch->fwnode, "label"))
> + dev_notice_once(ch->dev,
> + "%s: ch_%d: Firmware \"label\" no longer names the node, which is %s; use a udev symlink for a stable name\n",
> + __func__, ch->ch_id, ctx->miscdev.name);
> +
> + ctx->miscdev.minor = MISC_DYNAMIC_MINOR;
> + ctx->miscdev.fops = &lstp_ipmi_fops;
> + ctx->miscdev.parent = ch->dev;
It seems a little strange to set this up here and then register it in
the next section. Why not set it up right before the register?
The breakup of the probe function seems a little unnatural. Not a
bit deal, but it makes the code a little harder to follow.
I didn't see anything else in a first review here.
-corey
> +
> + ch->priv = ctx;
> + dev_dbg(ch->dev, "%s: ch_%d: Initialized as %s\n", __func__, ch->ch_id, ch->display_name);
> + return 0;
> +
> +err_put:
> + kref_put(&ctx->ref, lstp_ipmi_ctx_release);
> + return ret;
> +}
> +
> +static int lstp_ipmi_start(struct lstp_channel *ch, struct lstp_ipmi_ctx *ctx)
> +{
> + int ret = misc_register(&ctx->miscdev);
> +
> + if (ret) {
> + dev_err(ch->dev, "%s: ch_%d: Could not register miscdevice (%pe)\n", __func__,
> + ch->ch_id, ERR_PTR(ret));
> + return ret;
> + }
> +
> + ret = devm_add_action_or_reset(ch->dev, lstp_ipmi_stop_and_deregister, ctx);
> + if (ret)
> + return ret;
> +
> + dev_info(ch->dev, "%s: ch_%d: Started as %s\n", __func__, ch->ch_id, ch->display_name);
> + return 0;
> +}
> +
> +static int lstp_ipmi_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
> +{
> + struct lstp_channel *ch = lstp_channel_from_auxdev(auxdev);
> + const struct lstp_channel_init_info *info = dev_get_platdata(&auxdev->dev);
> +
> + if (!info)
> + return -ENODEV;
> +
> + int ret = lstp_ipmi_init(ch, info);
> +
> + if (ret)
> + return ret;
> +
> + /* Booked first, so it unwinds after the node's deregister action. */
> + ret = devm_add_action_or_reset(ch->dev, lstp_ipmi_ctx_put, ch->priv);
> + if (ret)
> + return ret;
> +
> + return lstp_ipmi_start(ch, ch->priv);
> +}
> +
> +static const struct lstp_ops lstp_ipmi_ops = {
> + .irq_packet = lstp_ipmi_irq_callback,
> +};
> +
> +static const struct auxiliary_device_id lstp_ipmi_id_table[] = { { .name = "lstp.ipmi" }, {} };
> +MODULE_DEVICE_TABLE(auxiliary, lstp_ipmi_id_table);
> +
> +static struct lstp_auxiliary_driver lstp_ipmi_drv = {
> + .adrv = {
> + .name = "ipmi",
> + .probe = lstp_ipmi_probe,
> + .id_table = lstp_ipmi_id_table,
> + },
> + .ops = &lstp_ipmi_ops,
> +};
> +module_lstp_auxiliary_driver(lstp_ipmi_drv);
> +
> +MODULE_IMPORT_NS("LSTP");
> +MODULE_DESCRIPTION("LSTP BMC-side IPMI driver");
> +MODULE_LICENSE("GPL");
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 19+ messages in thread