* [PATCH] watchdog: use assign_bit() where applicable
@ 2026-09-18 14:19 Peng Fan (OSS)
2026-09-18 15:13 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2026-09-18 14:19 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck; +Cc: linux-kernel, Peng Fan, linux-watchdog
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit and their
non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
API.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/watchdog/watchdog_core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
index 38c1e63a8e2c..2948fe52e093 100644
--- a/drivers/watchdog/watchdog_core.c
+++ b/drivers/watchdog/watchdog_core.c
@@ -314,10 +314,7 @@ static int ___watchdog_register_device(struct watchdog_device *wdd)
/* Module parameter to force watchdog policy on reboot. */
if (stop_on_reboot != -1) {
- if (stop_on_reboot)
- set_bit(WDOG_STOP_ON_REBOOT, &wdd->status);
- else
- clear_bit(WDOG_STOP_ON_REBOOT, &wdd->status);
+ assign_bit(WDOG_STOP_ON_REBOOT, &wdd->status, stop_on_reboot);
}
if (test_bit(WDOG_STOP_ON_REBOOT, &wdd->status)) {
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: use assign_bit() where applicable
2026-09-18 14:19 [PATCH] watchdog: use assign_bit() where applicable Peng Fan (OSS)
@ 2026-09-18 15:13 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2026-09-18 15:13 UTC (permalink / raw)
To: Peng Fan (OSS); +Cc: Wim Van Sebroeck, linux-kernel, Peng Fan, linux-watchdog
On Fri, Sep 18, 2026 at 10:19:14PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit and their
> non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
> API.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-18 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 14:19 [PATCH] watchdog: use assign_bit() where applicable Peng Fan (OSS)
2026-09-18 15:13 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®