mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
	Yves-Alexis Perez <corsac@debian.org>,
	David Woodhouse <dwmw@amazon.co.uk>,
	tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org,
	linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com,
	bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com,
	ak@linux.intel.com, torvalds@linux-foundation.org,
	gregkh@linux-foundation.org, gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v3 5/6] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown
Date: Fri, 26 Jan 2018 07:30:15 -0800	[thread overview]
Message-ID: <a48513ed-eba8-daa1-d79f-9a023ae1fc0b@linux.intel.com> (raw)
In-Reply-To: <bb85a9bb-4c00-f8f7-13f6-3f1bed997e9c@intel.com>

On 1/26/2018 7:27 AM, Dave Hansen wrote:
> On 01/26/2018 04:14 AM, Yves-Alexis Perez wrote:
>> I know we'll still be able to manually enable PTI with a command line option,
>> but it's also a hardening feature which has the nice side effect of emulating
>> SMEP on CPU which don't support it (e.g the Atom boxes above).
> 
> For Meltdown-vulnerable systems, it's a no brainer: pti=on.  The
> vulnerability there is just too much.
> 
> But, if we are going to change the default, IMNHO, we need a clear list
> of what SMEP emulation mitigates and where.  RSB-related Variant 2 stuff
> on Atom where the kernel speculatively 'ret's back to userspace is
> certainly a concern.  But, there's a lot of other RSB stuffing that's
> going on that will mitigate that too.
> 
> Were you thinking of anything concrete?

not Atom though. Atom has has SMEP for a very long time, at least the ones
that do speculation do afaict.

SMEP is for other bugs (dud kernel function pointer) and for that,
emulating SMEP is an interesting opt-in for sure.

  reply	other threads:[~2018-01-26 15:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 16:56 [PATCH v3 0/6] Basic Speculation Control feature support David Woodhouse
2018-01-24 16:57 ` [PATCH v3 1/6] x86/cpufeatures: Add CPUID_7_EDX CPUID leaf David Woodhouse
2018-01-24 17:18   ` Greg KH
2018-01-24 16:57 ` [PATCH v3 2/6] x86/cpufeatures: Add Intel feature bits for Speculation Control David Woodhouse
2018-01-24 17:18   ` Greg KH
2018-01-24 16:57 ` [PATCH v3 3/6] x86/cpufeatures: Add AMD " David Woodhouse
2018-01-24 17:20   ` Greg KH
2018-01-24 17:57     ` David Woodhouse
2018-01-24 22:52       ` Tom Lendacky
2018-02-20 15:22         ` Tom Lendacky
2018-01-24 16:57 ` [PATCH v3 4/6] x86/msr: Add definitions for new speculation control MSRs David Woodhouse
2018-01-24 17:16   ` Greg KH
2018-01-24 16:57 ` [PATCH v3 5/6] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown David Woodhouse
2018-01-24 17:26   ` Greg KH
2018-01-26 12:14   ` Yves-Alexis Perez
2018-01-26 12:27     ` David Woodhouse
2018-01-26 15:27     ` Dave Hansen
2018-01-26 15:30       ` Arjan van de Ven [this message]
2018-01-26 16:47     ` Alan Cox
2018-01-24 16:57 ` [PATCH v3 6/6] x86/cpufeature: Blacklist SPEC_CTRL on early Spectre v2 microcodes David Woodhouse
2018-01-24 17:29   ` Greg KH
2018-01-24 17:58     ` David Woodhouse
2018-01-24 21:29     ` Ingo Molnar
2018-01-26 12:16   ` Yves-Alexis Perez
2018-01-26 12:27     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a48513ed-eba8-daa1-d79f-9a023ae1fc0b@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=corsac@debian.org \
    --cc=dave.hansen@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=karahmed@amazon.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome