From: Ingo Molnar <mingo@kernel.org>
To: Greg KH <gregkh@linux-foundation.org>
Cc: David Woodhouse <dwmw@amazon.co.uk>,
arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de,
x86@kernel.org, linux-kernel@vger.kernel.org,
tim.c.chen@linux.intel.com, bp@alien8.de, peterz@infradead.org,
pbonzini@redhat.com, ak@linux.intel.com,
torvalds@linux-foundation.org, dave.hansen@intel.com,
gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v3 6/6] x86/cpufeature: Blacklist SPEC_CTRL on early Spectre v2 microcodes
Date: Wed, 24 Jan 2018 22:29:45 +0100 [thread overview]
Message-ID: <20180124212945.ikfzxdxah2shqiis@gmail.com> (raw)
In-Reply-To: <20180124172931.GG16646@kroah.com>
> On Wed, Jan 24, 2018 at 04:57:05PM +0000, David Woodhouse wrote:
> > +static const struct sku_microcode spectre_bad_microcodes[] = {
> > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x0B, 0x80 },
> > + /* Corrected typo in Intel doc */
> > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x0A, 0x80 },
> > + { INTEL_FAM6_KABYLAKE_MOBILE, 0x0A, 0x80 },
> > + { INTEL_FAM6_KABYLAKE_MOBILE, 0x09, 0x80 },
> > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x09, 0x80 },
> > + { INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003C },
> > + { INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0x000000C2 },
> > + { INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0x000000C2 },
> > + { INTEL_FAM6_BROADWELL_CORE, 0x04, 0x28 },
> > + { INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B },
> > + { INTEL_FAM6_HASWELL_ULT, 0x01, 0x21 },
> > + { INTEL_FAM6_HASWELL_GT3E, 0x01, 0x18 },
> > + { INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 },
> > + { INTEL_FAM6_IVYBRIDGE_X, 0x04, 0x42a },
> > + { INTEL_FAM6_HASWELL_X, 0x02, 0x3b },
> > + { INTEL_FAM6_HASWELL_X, 0x04, 0x10 },
> > + { INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 },
> > + { INTEL_FAM6_BROADWELL_XEON_D, 0x02, 0x14 },
> > + { INTEL_FAM6_BROADWELL_XEON_D, 0x03, 0x7000011 },
> > + { INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B },
> > + { INTEL_FAM6_BROADWELL_X, 0x01, 0x0b000025 },
> > + /* Dropped repeat of KBL Desktop 906E9, 0x80 */
> > + { INTEL_FAM6_SKYLAKE_X, 0x03, 0x0100013e },
> > + /* Dropped repeat of SKX 50654, 0x200003c */
Could we please also get better tabulation of this array, so that the general
layout of the values is easier to see? It's also prettier:
{ INTEL_FAM6_KABYLAKE_DESKTOP, 0x09, 0x00000080 },
{ INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003C },
{ INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0x000000C2 },
{ INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0x000000C2 },
Note the vertical spacing and the fixed length of each column.
(We can ignore the col80 for things like this.)
Thanks,
Ingo
next prev parent reply other threads:[~2018-01-24 21:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:56 [PATCH v3 0/6] Basic Speculation Control feature support David Woodhouse
2018-01-24 16:57 ` [PATCH v3 1/6] x86/cpufeatures: Add CPUID_7_EDX CPUID leaf David Woodhouse
2018-01-24 17:18 ` Greg KH
2018-01-24 16:57 ` [PATCH v3 2/6] x86/cpufeatures: Add Intel feature bits for Speculation Control David Woodhouse
2018-01-24 17:18 ` Greg KH
2018-01-24 16:57 ` [PATCH v3 3/6] x86/cpufeatures: Add AMD " David Woodhouse
2018-01-24 17:20 ` Greg KH
2018-01-24 17:57 ` David Woodhouse
2018-01-24 22:52 ` Tom Lendacky
2018-02-20 15:22 ` Tom Lendacky
2018-01-24 16:57 ` [PATCH v3 4/6] x86/msr: Add definitions for new speculation control MSRs David Woodhouse
2018-01-24 17:16 ` Greg KH
2018-01-24 16:57 ` [PATCH v3 5/6] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown David Woodhouse
2018-01-24 17:26 ` Greg KH
2018-01-26 12:14 ` Yves-Alexis Perez
2018-01-26 12:27 ` David Woodhouse
2018-01-26 15:27 ` Dave Hansen
2018-01-26 15:30 ` Arjan van de Ven
2018-01-26 16:47 ` Alan Cox
2018-01-24 16:57 ` [PATCH v3 6/6] x86/cpufeature: Blacklist SPEC_CTRL on early Spectre v2 microcodes David Woodhouse
2018-01-24 17:29 ` Greg KH
2018-01-24 17:58 ` David Woodhouse
2018-01-24 21:29 ` Ingo Molnar [this message]
2018-01-26 12:16 ` Yves-Alexis Perez
2018-01-26 12:27 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124212945.ikfzxdxah2shqiis@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=karahmed@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome