mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Johnston <matt@codeconstruct.com.au>
To: corey@minyard.net
Cc: Andrew Manley <andrew.manley@sealingtech.com>,
	Corey Minyard <minyard@acm.org>,
	openipmi-developer@lists.sourceforge.net,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: ipmb: initialise event handler read bytes
Date: Wed, 14 Jan 2026 10:10:34 +0800	[thread overview]
Message-ID: <a4cf18d7842c27ea2b570962775d982c0dbc54f0.camel@codeconstruct.com.au> (raw)
In-Reply-To: <aWZsAt8unYL6khJj@mail.minyard.net>

Hi Corey,

On Tue, 2026-01-13 at 10:00 -0600, Corey Minyard wrote:
> On Tue, Jan 13, 2026 at 05:41:34PM +0800, Matt Johnston wrote:
> > IPMB doesn't use i2c reads, but the handler needs to set a value.
> > Otherwise an i2c read will return an uninitialised value from the bus
> > driver.
> 
> This is fine, I suppose.  It's probably better to do this.
> 
> Are you actually using this code?  How was it found?

I'm not using IPMB, so haven't tested the patch on hardware.
We received a patch for mctp-i2c read handling, that made me notice 
the uninitialised value problem there. I had a look over other 
i2c_slave_register() kernel users to see if the problem was common
(mctp-i2c used ipmi-ipmb as a bit of a reference during development too).

https://lore.kernel.org/netdev/20260108101829.1140448-1-
zhangjian.3032@bytedance.com/
https://lore.kernel.org/netdev/20260113-mctp-read-fix-v1-1-
70c4b59c741c@codeconstruct.com.au/

Cheers,
Matt


  reply	other threads:[~2026-01-14  2:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  9:41 Matt Johnston
2026-01-13 12:13 ` Markus Elfring
2026-01-13 16:00 ` Corey Minyard
2026-01-14  2:10   ` Matt Johnston [this message]
2026-01-14 15:18     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4cf18d7842c27ea2b570962775d982c0dbc54f0.camel@codeconstruct.com.au \
    --to=matt@codeconstruct.com.au \
    --cc=andrew.manley@sealingtech.com \
    --cc=corey@minyard.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®