* [PATCH] coccinelle: platform_no_drv_owner: Handle also built-in drivers
@ 2025-01-04 14:14 Krzysztof Kozlowski
2025-01-13 12:18 ` [cocci] " Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-04 14:14 UTC (permalink / raw)
To: Julia Lawall, Nicolas Palix, cocci, linux-kernel; +Cc: Krzysztof Kozlowski
builtin_platform_driver() and others also use macro
platform_driver_register() which sets the .owner=THIS_MODULE, so extend
the cocci script to detect these as well.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
scripts/coccinelle/api/platform_no_drv_owner.cocci | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
index 8fa050eeb7e5..5e869858bda8 100644
--- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
+++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
@@ -10,12 +10,21 @@ virtual org
virtual report
@match1@
+declarer name builtin_i2c_driver;
+declarer name builtin_platform_driver;
+declarer name builtin_platform_driver_probe;
declarer name module_i2c_driver;
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
identifier __driver;
@@
(
+ builtin_i2c_driver(__driver);
+|
+ builtin_platform_driver(__driver);
+|
+ builtin_platform_driver_probe(__driver, ...);
+|
module_i2c_driver(__driver);
|
module_platform_driver(__driver);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [cocci] [PATCH] coccinelle: platform_no_drv_owner: Handle also built-in drivers
2025-01-04 14:14 [PATCH] coccinelle: platform_no_drv_owner: Handle also built-in drivers Krzysztof Kozlowski
@ 2025-01-13 12:18 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-01-13 12:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, cocci; +Cc: LKML, Julia Lawall, Nicolas Palix
…
> +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> @@ -10,12 +10,21 @@ virtual org
> virtual report
>
> @match1@
…
> @@
> (
> + builtin_i2c_driver(__driver);
> +|
> + builtin_platform_driver(__driver);
> +|
> + builtin_platform_driver_probe(__driver, ...);
> +|
> module_i2c_driver(__driver);
> |
> module_platform_driver(__driver);
How do you think about to avoid a bit for duplicate SmPL code
(by using nested disjunctions)?
Development idea:
(
(builtin_platform_driver
|builtin_i2c_driver
|module_i2c_driver
|module_platform_driver
)(__driver);
|builtin_platform_driver_probe(__driver, ...);)
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-13 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-04 14:14 [PATCH] coccinelle: platform_no_drv_owner: Handle also built-in drivers Krzysztof Kozlowski
2025-01-13 12:18 ` [cocci] " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®