From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
Subject: Re: [PATCH v3 11/14] KVM: SVM: Introduce hybrid-AVIC mode
Date: Thu, 5 May 2022 10:57:36 +0700 [thread overview]
Message-ID: <a5f0b098-234b-7044-c6d5-ec50cff74676@amd.com> (raw)
In-Reply-To: <fe7cd5012445a941cf55ea82871ea51157490aaa.camel@redhat.com>
Maxim
On 5/4/22 7:32 PM, Maxim Levitsky wrote:
> Well strictly speaking, another thing that has to be done, other that removing the inhibit,
> is to 'hide' the AVIC's private memslot if one of vCPUs is in x2apic mode,
> although not doing this doesn't cause any harm as the guest is not supposed to poke at xAPIC
> mmio even when uses x2apic, and if it does it will get the normal AVIC acceleration,
> so probably it is better to not add any more complexity and leave it like that.
Agree, I'll note this detail in the comment above.
> ...
> BTW, hardware wise, does 'X2APIC_MODE' keeps the emulation of the AVIC mmio, or
> not?
According to the AVIC documentation, when the AVIC is configured to use x2 APIC mode
the MMIO access method will be disabled. This is consistent with the Intel x2APIC specification,
where it states "accessing the MMIO interface when in x2APIC mode, the behavior is identical
to xAPIC in globally disabled state".
Regards,
Suravee
next prev parent reply other threads:[~2022-05-05 3:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 7:31 [PATCH v3 00/14] Introducing AMD x2AVIC and hybrid-AVIC modes Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 01/14] x86/cpufeatures: Introduce x2AVIC CPUID bit Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 02/14] KVM: x86: lapic: Rename [GET/SET]_APIC_DEST_FIELD to [GET/SET]_XAPIC_DEST_FIELD Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 03/14] KVM: SVM: Detect X2APIC virtualization (x2AVIC) support Suravee Suthikulpanit
2022-05-04 12:12 ` Maxim Levitsky
2022-05-05 4:07 ` Suravee Suthikulpanit
2022-05-05 7:38 ` Maxim Levitsky
2022-05-04 7:31 ` [PATCH v3 04/14] KVM: SVM: Update max number of vCPUs supported for x2AVIC mode Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 05/14] KVM: SVM: Update avic_kick_target_vcpus to support 32-bit APIC ID Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 06/14] KVM: SVM: Do not support updating APIC ID when in x2APIC mode Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 07/14] KVM: SVM: Adding support for configuring x2APIC MSRs interception Suravee Suthikulpanit
2022-05-04 12:14 ` Maxim Levitsky
2022-05-04 7:31 ` [PATCH v3 08/14] KVM: SVM: Update AVIC settings when changing APIC mode Suravee Suthikulpanit
2022-05-04 12:19 ` Maxim Levitsky
2022-05-05 1:38 ` Suravee Suthikulpanit
2022-05-05 7:34 ` Maxim Levitsky
2022-05-04 7:31 ` [PATCH v3 09/14] KVM: SVM: Introduce helper functions to (de)activate AVIC and x2AVIC Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 10/14] KVM: SVM: Do not throw warning when calling avic_vcpu_load on a running vcpu Suravee Suthikulpanit
2022-05-04 7:31 ` [PATCH v3 11/14] KVM: SVM: Introduce hybrid-AVIC mode Suravee Suthikulpanit
2022-05-04 12:32 ` Maxim Levitsky
2022-05-05 3:57 ` Suravee Suthikulpanit [this message]
2022-05-04 7:31 ` [PATCH v3 12/14] kvm/x86: Warning APICv inconsistency only when vcpu APIC mode is valid Suravee Suthikulpanit
2022-05-04 12:33 ` Maxim Levitsky
2022-05-04 7:31 ` [PATCH v3 13/14] KVM: SVM: Use target APIC ID to complete x2AVIC IRQs when possible Suravee Suthikulpanit
2022-05-04 12:34 ` Maxim Levitsky
2022-05-04 7:31 ` [PATCH v3 14/14] KVM: SVM: Add AVIC doorbell tracepoint Suravee Suthikulpanit
2022-05-04 12:36 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f0b098-234b-7044-c6d5-ec50cff74676@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=terry.bowman@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®