* [PATCH v2 0/3] SHIFT 6MQ SD-card support, improved responsivness of touchscreen, and codec
@ 2026-04-01 16:51 David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard David Heidelberg via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-04-01 16:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, Konrad Dybcio, devicetree, linux-kernel,
phone-devel, David Heidelberg
I've tested that SD card and touchscreen works well, the codec does too,
but for complete enablement needs soundcard support which isn't fully
finished.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
- Changed bias-pull-up to bias-disable for SD card detection, since the
mechanism doesn't work, we can just save few uA. (Casey)
- Link to v1: https://lore.kernel.org/r/20260320-axolotl-misc-p1-v1-0-89c9b5ecb26e@ixit.cz
---
Alexander Martinz (1):
arm64: dts: qcom: sdm845-shift-axolotl: Enable TFA9890 codec
Casey Connolly (2):
arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard
arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 59 +++++++++++++++++++++++
1 file changed, 59 insertions(+)
---
base-commit: bd0f139e5fc11182777b81cefc3893ea508544ec
change-id: 20260320-axolotl-misc-p1-601d480c25df
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard
2026-04-01 16:51 [PATCH v2 0/3] SHIFT 6MQ SD-card support, improved responsivness of touchscreen, and codec David Heidelberg via B4 Relay
@ 2026-04-01 16:51 ` David Heidelberg via B4 Relay
2026-04-02 9:23 ` Konrad Dybcio
2026-04-01 16:51 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable TFA9890 codec David Heidelberg via B4 Relay
2 siblings, 1 reply; 6+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-04-01 16:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, Konrad Dybcio, devicetree, linux-kernel,
phone-devel, David Heidelberg
From: Casey Connolly <casey.connolly@linaro.org>
The SHIFT6mq features an sdcard slot, add it.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 740eb22550724..c394350998c26 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -600,6 +600,24 @@ &qupv3_id_1 {
status = "okay";
};
+&sdhc_2 {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
+
+ vmmc-supply = <&vreg_l21a_2p95>;
+ vqmmc-supply = <&vreg_l13a_2p95>;
+
+ bus-width = <4>;
+ /*
+ * Card detection is broken, but because the battery must be removed
+ * to insert the card, we use this rather than the broken-cd property
+ * which would just waste CPU cycles polling.
+ */
+ non-removable;
+};
+
&slpi_pas {
firmware-name = "qcom/sdm845/SHIFT/axolotl/slpi.mbn";
@@ -609,6 +627,32 @@ &slpi_pas {
&tlmm {
gpio-reserved-ranges = <0 4>, <81 4>;
+ sdc2_default_state: sdc2-default-state {
+ clk-pins {
+ pins = "sdc2_clk";
+ bias-disable;
+ drive-strength = <16>;
+ };
+
+ cmd-pins {
+ pins = "sdc2_cmd";
+ bias-pull-up;
+ drive-strength = <10>;
+ };
+
+ data-pins {
+ pins = "sdc2_data";
+ bias-pull-up;
+ drive-strength = <10>;
+ };
+ };
+
+ sdc2_card_det_n: sd-card-det-n-state {
+ pins = "gpio126";
+ function = "gpio";
+ bias-disable;
+ };
+
sde_dsi_active: sde-dsi-active-state {
pins = "gpio6", "gpio11";
function = "gpio";
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
2026-04-01 16:51 [PATCH v2 0/3] SHIFT 6MQ SD-card support, improved responsivness of touchscreen, and codec David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard David Heidelberg via B4 Relay
@ 2026-04-01 16:51 ` David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable TFA9890 codec David Heidelberg via B4 Relay
2 siblings, 0 replies; 6+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-04-01 16:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, Konrad Dybcio, devicetree, linux-kernel,
phone-devel, David Heidelberg
From: Casey Connolly <casey.connolly@linaro.org>
Sets a higher rate than the default for good responsiveness of
touchscreen.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index c394350998c26..181c61e8ed748 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -432,6 +432,8 @@ &gpu_zap_shader {
};
&i2c5 {
+ clock-frequency = <400000>;
+
status = "okay";
touchscreen@38 {
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable TFA9890 codec
2026-04-01 16:51 [PATCH v2 0/3] SHIFT 6MQ SD-card support, improved responsivness of touchscreen, and codec David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock David Heidelberg via B4 Relay
@ 2026-04-01 16:51 ` David Heidelberg via B4 Relay
2 siblings, 0 replies; 6+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-04-01 16:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, Konrad Dybcio, devicetree, linux-kernel,
phone-devel, David Heidelberg
From: Alexander Martinz <amartinz@shiftphones.com>
Audio amplifier TFA9890 is present on the board.
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 181c61e8ed748..393eb865a71d3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -459,6 +459,19 @@ &i2c10 {
/* SMB1355@0x0C */
};
+&i2c11 {
+ clock-frequency = <400000>;
+
+ status = "okay";
+
+ audio-codec@34 {
+ compatible = "nxp,tfa9890";
+ reg = <0x34>;
+ vddd-supply = <&vreg_s4a_1p8>;
+ #sound-dai-cells = <0>;
+ };
+};
+
&ipa {
qcom,gsi-loader = "self";
memory-region = <&ipa_fw_mem>;
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard
2026-04-01 16:51 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard David Heidelberg via B4 Relay
@ 2026-04-02 9:23 ` Konrad Dybcio
2026-04-02 9:56 ` David Heidelberg
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2026-04-02 9:23 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, devicetree, linux-kernel, phone-devel
On 4/1/26 6:51 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> The SHIFT6mq features an sdcard slot, add it.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 740eb22550724..c394350998c26 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -600,6 +600,24 @@ &qupv3_id_1 {
> status = "okay";
> };
>
> +&sdhc_2 {
> + status = "okay";
couple nits:
Status should be last, although the file is all over the place
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
preferably in this order
xxx
xxx-names
[...]
> + sdc2_default_state: sdc2-default-state {
> + clk-pins {
> + pins = "sdc2_clk";
> + bias-disable;
> + drive-strength = <16>;
All other pin definitions in this file have the bias property below
drive-strength (like the card_det_n node you're adding)
other than that
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard
2026-04-02 9:23 ` Konrad Dybcio
@ 2026-04-02 9:56 ` David Heidelberg
0 siblings, 0 replies; 6+ messages in thread
From: David Heidelberg @ 2026-04-02 9:56 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dylan Van Assche
Cc: linux-arm-msm, Petr Hodina, Casey Connolly, Dmitry Baryshkov,
Alexander Martinz, devicetree, linux-kernel, phone-devel
On 02/04/2026 11:23, Konrad Dybcio wrote:
> On 4/1/26 6:51 PM, David Heidelberg via B4 Relay wrote:
>> From: Casey Connolly <casey.connolly@linaro.org>
>>
>> The SHIFT6mq features an sdcard slot, add it.
>>
>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
>> index 740eb22550724..c394350998c26 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
>> @@ -600,6 +600,24 @@ &qupv3_id_1 {
>> status = "okay";
>> };
>>
>> +&sdhc_2 {
>> + status = "okay";
>
> couple nits:
>
> Status should be last, although the file is all over the place
>
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
>
> preferably in this order
>
> xxx
> xxx-names
>
> [...]
>
>> + sdc2_default_state: sdc2-default-state {
>> + clk-pins {
>> + pins = "sdc2_clk";
>> + bias-disable;
>> + drive-strength = <16>;
>
> All other pin definitions in this file have the bias property below
> drive-strength (like the card_det_n node you're adding)
>
> other than that
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
Thanks for catching these, I completly missed that sorting is non-compliant. New
revision sent w/ ur R-b :)
David
> Konrad
--
David Heidelberg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-02 9:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-01 16:51 [PATCH v2 0/3] SHIFT 6MQ SD-card support, improved responsivness of touchscreen, and codec David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard David Heidelberg via B4 Relay
2026-04-02 9:23 ` Konrad Dybcio
2026-04-02 9:56 ` David Heidelberg
2026-04-01 16:51 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock David Heidelberg via B4 Relay
2026-04-01 16:51 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable TFA9890 codec David Heidelberg via B4 Relay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®