From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: sram: qcom,imem: Document Qualcomm IPQ SoC's IMEM compatibles
Date: Wed, 2 Jul 2025 12:19:33 +0200 [thread overview]
Message-ID: <a68f46f0-8053-4d9f-96f7-55de33bb301f@kernel.org> (raw)
In-Reply-To: <20250702-imem-v1-1-12d49b1ceff0@oss.qualcomm.com>
On 02/07/2025 12:17, Kathiravan Thirumoorthy wrote:
> IMEM is present in the Qualcomm's IPQ SoCs as well. Document the same.
>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/sram/qcom,imem.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
Where is the changelog? This is not a v1.
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index 72d35e30c439ccf4901d937f838fe7c7a81f33b1..48e2f332e0e9fc9fa4147fa12d9c6c70a77fafda 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -18,6 +18,12 @@ properties:
> items:
> - enum:
> - qcom,apq8064-imem
> + - qcom,ipq8074-imem
> + - qcom,ipq6018-imem
> + - qcom,ipq5018-imem
> + - qcom,ipq9574-imem
> + - qcom,ipq5332-imem
> + - qcom,ipq5424-imem
Random order, no, follow existing style. This applies for every qcom
binding and you received such feedbacks in the past.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-02 10:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 10:17 [PATCH 0/7] Describe the IMEM present in Qualcomm IPQ SoC's Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 1/7] dt-bindings: sram: qcom,imem: Document Qualcomm IPQ SoC's IMEM compatibles Kathiravan Thirumoorthy
2025-07-02 10:19 ` Krzysztof Kozlowski [this message]
2025-07-02 10:46 ` Kathiravan Thirumoorthy
2025-07-02 10:48 ` Krzysztof Kozlowski
2025-07-02 10:59 ` Kathiravan Thirumoorthy
2025-07-04 8:51 ` Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 2/7] arm64: dts: qcom: ipq8074: Add the IMEM node Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 3/7] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2025-07-02 10:50 ` Krzysztof Kozlowski
2025-07-02 13:00 ` Konrad Dybcio
2025-07-02 12:59 ` Konrad Dybcio
2025-07-04 8:54 ` Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 4/7] arm64: dts: qcom: ipq5018: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 5/7] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 6/7] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 7/7] arm64: dts: qcom: ipq5424: " Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a68f46f0-8053-4d9f-96f7-55de33bb301f@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®