mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] arm64: dts: qcom: ipq6018: Add the IMEM node
Date: Fri, 4 Jul 2025 14:24:35 +0530	[thread overview]
Message-ID: <d4e7dcb1-5a6e-458b-9b1f-28298fefcbd7@oss.qualcomm.com> (raw)
In-Reply-To: <96073931-644c-4d77-9c61-45ec65adf928@oss.qualcomm.com>


On 7/2/2025 6:29 PM, Konrad Dybcio wrote:
> On 7/2/25 12:17 PM, Kathiravan Thirumoorthy wrote:
>> Add the IMEM node to the device tree to extract debugging information
>> like system restart reason, which is populated via IMEM. Define the
>> IMEM region to enable this functionality.
>>
>> As described, overall IMEM region is approximately 32KB but only initial
>> 4KB is accessible by all masters in the SoC.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index bfe59b0208415902c69fd0c0c7565d97997d4207..7eca5ba416c2ef5ef1c4e0eb4f58f1ca94fc92f0 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -659,6 +659,15 @@ qpic_nand: nand-controller@79b0000 {
>>   			status = "disabled";
>>   		};
>>   
>> +		sram@8600000 {
>> +			compatible = "qcom,ipq6018-imem", "syscon", "simple-mfd";
>> +			reg = <0 0x08600000 0 0x7fff>;
>> +			ranges = <0 0 0x08600000 0x7fff>;
> I firmly believe there's an off-by-one in the docs and there
> isn't an odd number of bytes reserved in the hw
Thanks, I cross checked this in the SoC and I'm able to access the full 
4 byte at the end. Let me fix this up in the V2.
>
> Konrad

  reply	other threads:[~2025-07-04  8:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 10:17 [PATCH 0/7] Describe the IMEM present in Qualcomm IPQ SoC's Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 1/7] dt-bindings: sram: qcom,imem: Document Qualcomm IPQ SoC's IMEM compatibles Kathiravan Thirumoorthy
2025-07-02 10:19   ` Krzysztof Kozlowski
2025-07-02 10:46     ` Kathiravan Thirumoorthy
2025-07-02 10:48       ` Krzysztof Kozlowski
2025-07-02 10:59         ` Kathiravan Thirumoorthy
2025-07-04  8:51           ` Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 2/7] arm64: dts: qcom: ipq8074: Add the IMEM node Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 3/7] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2025-07-02 10:50   ` Krzysztof Kozlowski
2025-07-02 13:00     ` Konrad Dybcio
2025-07-02 12:59   ` Konrad Dybcio
2025-07-04  8:54     ` Kathiravan Thirumoorthy [this message]
2025-07-02 10:17 ` [PATCH 4/7] arm64: dts: qcom: ipq5018: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 5/7] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 6/7] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2025-07-02 10:17 ` [PATCH 7/7] arm64: dts: qcom: ipq5424: " Kathiravan Thirumoorthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4e7dcb1-5a6e-458b-9b1f-28298fefcbd7@oss.qualcomm.com \
    --to=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®