From: Michael Bringmann <mwb@linux.vnet.ibm.com>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask
Date: Thu, 27 Jul 2017 14:12:52 -0500 [thread overview]
Message-ID: <a7215815-66f9-6344-4b8c-c9f0bff4099d@linux.vnet.ibm.com> (raw)
In-Reply-To: <47ac4fb9-a316-0125-7d4e-73cf602d891e@linux.vnet.ibm.com>
>>
>> /* yeap, return possible CPUs in @node that @attrs wants */
>> cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
>> +
>> + if (cpumask_empty(cpumask)) {
>> + pr_warn_once("WARNING: workqueue cpumask: onl intersect > "
> ^^^
> This message doesn't seem right, or I am missing something, "onl"?
Shorthand for 'online' in long message.
>
> -Nathan
>
>> + "possible intersect\n");
>> + return false;
>> + }
>> +
>> return !cpumask_equal(cpumask, attrs->cpumask);
>>
>> use_dfl:
>>
>
--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
mwb@linux.vnet.ibm.com
next prev parent reply other threads:[~2017-07-27 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 18:15 Michael Bringmann
2017-07-27 18:31 ` Tejun Heo
2017-07-27 19:07 ` Michael Bringmann
2017-07-27 19:24 ` Tejun Heo
2017-07-27 20:15 ` Michael Bringmann
2017-07-27 20:46 ` Tejun Heo
2017-07-27 18:42 ` Nathan Fontenot
2017-07-27 19:12 ` Michael Bringmann [this message]
2017-07-27 19:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7215815-66f9-6344-4b8c-c9f0bff4099d@linux.vnet.ibm.com \
--to=mwb@linux.vnet.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®