mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "hui.wang@canonical.com" <hui.wang@canonical.com>,
	"mwalle@kernel.org" <mwalle@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"florent.trinh-thai@cs-soprasteria.com"
	<florent.trinh-thai@cs-soprasteria.com>,
	"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] eeprom: at25: convert to spi-mem API
Date: Tue, 4 Nov 2025 14:24:17 +0100	[thread overview]
Message-ID: <a74bac93-88de-4d45-9961-b5a3aa342c70@csgroup.eu> (raw)
In-Reply-To: <2941b3527113a0b09b9a380e4746bf899948708c.camel@siemens.com>

Hi Alexander,

Le 04/11/2025 à 14:13, Sverdlin, Alexander a écrit :
> Hi Christophe,
> 
> On Mon, 2025-11-03 at 23:36 +0100, Christophe Leroy wrote:
>>>>>>> Replace the RAW SPI accesses with spi-mem API. The latter will fall back to
>>>>>>> RAW SPI accesses if spi-mem callbacks are not implemented by a controller
>>>>>>> driver.
>>>>>>
>>>>>> With this patch (kernel v6.17.1) our powerpc boards are totally
>>>>>> unstable, we get multiple random Oops due to bad memory accesses.
>>>>>>
>>>>>> With this commit reverted the board is stable again.
>>>>>>
>>>>>> The SPI driver is:
>>>>>>
>>>>>> CONFIG_SPI=y
>>>>>> CONFIG_SPI_MASTER=y
>>>>>> CONFIG_SPI_MEM=y
>>>>>> CONFIG_SPI_FSL_LIB=y
>>>>>> CONFIG_SPI_FSL_CPM=y
>>>>>> CONFIG_SPI_FSL_SPI=y
>>>>>>
>>>>>> How can we further investigate the issue ?
>>>>>
>>>>> could you share these "random Oops"?
>>>>
>>>> Sure. At the first place they look unrelated. Something is likely
>>>
>>> indeed, no obvious connection... Do you have a chance to run KASAN?
>>
>> I ran KASAN, it found an overrun in the loop in
>> fsl_spi_cpm_bufs_complete() when t->len is odd, but once fixed the
>> random problem is still there.
> 
> thanks for the quick reply!
> That sounds promising already!
> 
> Do you have a chance to run with CONFIG_DEBUG_STACKOVERFLOW=y ?
> 

Unfortunately I won't be able to do any additionnal test until Monday 
next week as I'm travelling at the moment.

However, our kernel is built with CONFIG_VMAP_STACK, so a stack overflow 
would have been caught by the early stack overflow detection, see commit 
3978eb78517c ("powerpc/32: Add early stack overflow detection with VMAP 
stack.") for details.

Christophe

  reply	other threads:[~2025-11-04 13:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 22:28 A. Sverdlin
2025-07-04 10:09 ` Arnd Bergmann
2025-11-03 16:33 ` Christophe Leroy
2025-11-03 19:12   ` Sverdlin, Alexander
2025-11-03 21:46     ` Christophe Leroy
2025-11-03 22:29       ` Sverdlin, Alexander
2025-11-03 22:36         ` Christophe Leroy
2025-11-04 13:13           ` Sverdlin, Alexander
2025-11-04 13:24             ` Christophe Leroy [this message]
2025-11-04 23:15   ` Greg Kroah-Hartman
2025-11-05  7:20     ` Sverdlin, Alexander
2025-11-07 11:49       ` Sverdlin, Alexander
2025-11-07 13:08         ` Arnd Bergmann
2025-11-07 13:44           ` Sverdlin, Alexander
2025-11-08 10:05         ` Christophe Leroy
2025-11-08 11:14           ` Christophe Leroy
2025-11-08 11:41             ` Sverdlin, Alexander
2025-11-08 16:24               ` Christophe Leroy
2025-11-10 15:09                 ` Sverdlin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a74bac93-88de-4d45-9961-b5a3aa342c70@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=alexander.sverdlin@siemens.com \
    --cc=arnd@arndb.de \
    --cc=florent.trinh-thai@cs-soprasteria.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwalle@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®